Commit Graph

558 Commits

Author SHA1 Message Date
Jonathan Watt
ef39f8ec17 Bug 1931517. Rename confusing IDTracker methods. r=emilio
Some of the Reset* methods are named ResetTo* and some are named ResetWith*.
That seems to imply some sort of difference which simply doesn't exist. This
commit renames them to all use ResetTo* to avoid that.

Furthermore, the inconsistency in naming terminology between
ResetToURIFragmentID and ResetWithLocalRef makes it less than clear that the
latter is exactly the same as the former, but with only the fragment identifier
being specified. This commit better aligns the naming terminology for clarity.

Differential Revision: https://phabricator.services.mozilla.com/D229118
2024-11-15 12:30:03 +00:00
longsonr
941ac724d1 Bug 1930221 - prevent underflow as well as overflow when adding an instance time r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D228495
2024-11-12 13:55:34 +00:00
Brad Werth
9cccb8ffb3 Bug 1928352: Make SMILCompositor fail earlier when adding an incorrectly configured animation. r=longsonr
If multiple animations of the same element is an error (as asserted in
`SMILCompositor::ComposeAttribute`), then this patch will catch that
when the animation is added.

Differential Revision: https://phabricator.services.mozilla.com/D227737
2024-11-05 17:44:45 +00:00
Boris Chiou
9c0a612291 Bug 1922315 - Replace the tuple of PseudoStyleType and nsAtom with PseudoStyleRequest. r=view-transitions-reviewers,emilio
We introduce PseudoStyleRequest, which contains `PseudoStyleType` and
`nsAtom*`, and I tried to replace the tuple of `PseudoStyleType` and
`nsAtom*` in nsComputedDOMStyle.

Also, for the animation part, let's leave them to Bug 1921553.

There is no behavior change to end users. Only do refactoring code.

Differential Revision: https://phabricator.services.mozilla.com/D226710
2024-10-24 22:34:22 +00:00
longsonr
6532204b12 Bug 1925761 - Use nsAString::const_iterator to iterate strings rather than RangedPtr r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D226222
2024-10-21 12:01:01 +00:00
Emilio Cobos Álvarez
2bb32736de Bug 1925324 - Properly regenerate the underlying 'from' value, for SVG/SMIL to-animation of CSS properties r=dholbert
We need to remove the property in that case.

Differential Revision: https://phabricator.services.mozilla.com/D226030
2024-10-18 09:48:32 +00:00
serge-sans-paille
9aab8c45ce Bug 1921276 - Remove global constructor from dom/smil/SMILTimedElement.cpp r=longsonr
Differential Revision: https://phabricator.services.mozilla.com/D223865
2024-10-03 06:55:07 +00:00
Sandor Molnar
6f7a808f76 Backed out 6 changesets (bug 1921341, bug 1921268, bug 1921270, bug 1921269, bug 1921267, bug 1921276) for causing build bustages @ gfxSVGGlyphs.h CLOSED TREE
Backed out changeset 2a5d5e7e863b (bug 1921341)
Backed out changeset 86df2445ee83 (bug 1921276)
Backed out changeset bf1b223af380 (bug 1921270)
Backed out changeset 4cdbd2521712 (bug 1921269)
Backed out changeset 6bb5d64f664a (bug 1921267)
Backed out changeset 7ec43f4b07ff (bug 1921268)
2024-10-03 02:05:13 +03:00
serge-sans-paille
4e9ef35943 Bug 1921276 - Remove global constructor from dom/smil/SMILTimedElement.cpp r=longsonr
Differential Revision: https://phabricator.services.mozilla.com/D223865
2024-10-02 19:41:39 +00:00
Butkovits Atila
c73347890d Backed out 6 changesets (bug 1921267, bug 1921270, bug 1921269, bug 1921276, bug 1921268, bug 1921341) for causing bustages at WheelHandlingHelper.cpp.
Backed out changeset d9054241c1f4 (bug 1921341)
Backed out changeset 5b4ba445b189 (bug 1921276)
Backed out changeset 6497eb64ef2a (bug 1921270)
Backed out changeset 9c39218f7372 (bug 1921269)
Backed out changeset 2d5d640c060d (bug 1921267)
Backed out changeset 7b068aede249 (bug 1921268)
2024-10-01 15:17:46 +03:00
serge-sans-paille
9606cdeb10 Bug 1921276 - Remove global constructor from dom/smil/SMILTimedElement.cpp r=longsonr
Differential Revision: https://phabricator.services.mozilla.com/D223865
2024-10-01 09:09:39 +00:00
Olli Pettay
e1fad67026 Bug 1914513 - Add a pref to disable mutation events, r=masayuki
Differential Revision: https://phabricator.services.mozilla.com/D219934
2024-09-02 13:29:57 +00:00
longsonr
67956a1583 Bug 1904378 - Stop creating runnables to fire SMIL events if we know we can't have listeners r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D214744
2024-06-25 03:31:45 +00:00
longsonr
066a7d4c67 Bug 1903214 - Don't dispatch SMIL events unless there are listeners r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D214010
2024-06-18 13:25:47 +00:00
longsonr
b1cffa0413 Bug 1891005 - Make PreTraverse functions void since we don't use their return value r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D207267
2024-04-13 20:34:00 +00:00
longsonr
d8dd9fc6ae Bug 1354393 - remove flush in SMILAnimationController::DoSample r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D206847
2024-04-09 15:35:30 +00:00
Daniel Holbert
82e657a09b Bug 1881367 part 2: Upgrade a SMILAnimationController assert to a release-assert, to ensure that we unregister from the refresh driver properly. r=hiro
If this assertion fails, then we're losing track of a refresh driver
registration, which means we're likely to crash (with a non-specific
backtrace). So it's better to intentionally check this condition up-front and
crash in a clearer controlled way if it fails.

Differential Revision: https://phabricator.services.mozilla.com/D202359
2024-02-22 00:32:35 +00:00
Gregory Pappas
c056a64e2e Bug 1873137 - Remove dom.animations-api.getAnimations.enabled pref r=webidl,emilio,firefox-animation-reviewers,devtools-reviewers,nchevobbe,boris
Differential Revision: https://phabricator.services.mozilla.com/D201162
2024-02-09 22:00:23 +00:00
Cristian Tuns
73e74628dc Backed out changeset ccc6ced28d4d (bug 1873137) for causing reftest failures in crashtests.list CLOSED TREE 2024-02-09 13:43:10 -05:00
Gregory Pappas
4a8b2cd0aa Bug 1873137 - Remove dom.animations-api.getAnimations.enabled pref r=webidl,emilio,firefox-animation-reviewers,devtools-reviewers,nchevobbe,boris
Differential Revision: https://phabricator.services.mozilla.com/D201162
2024-02-09 17:57:16 +00:00
Mark Banner
e7a36c96d7 Bug 1866589 - Enable ESLint rule consistent-return on all of dom/*. r=dom-core,jgilbert,dom-worker-reviewers,mccr8,smaug
Differential Revision: https://phabricator.services.mozilla.com/D194664
2024-01-16 20:45:42 +00:00
Robert Longson
cad8a108e0 Bug 1871107 - Use do_AddRef more r=TYLin
Differential Revision: https://phabricator.services.mozilla.com/D197001
2023-12-20 23:34:03 +00:00
Robert Longson
a35f582ac1 Bug 1870796 - Inline servo animation methods now that servo is the only option r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D196825
2023-12-20 11:37:00 +00:00
Zach Hoffman
7653a4f1c2 Bug 1846516 - [css-properties-values-api] Use AnimatedPropertyID to communicate between Gecko and Servo. r=emilio,layout-reviewers,firefox-style-system-reviewers
Co-authored-by: Frederic Wang <fred.wang@free.fr>
Co-authored-by: Emilio Cobos Álvarez <emilio@crisal.io>

Depends on D191059

Differential Revision: https://phabricator.services.mozilla.com/D191322
2023-12-18 09:24:08 +00:00
Robert Longson
2e1f916689 Bug 733744 - don't round short durations to zero r=birtles
Differential Revision: https://phabricator.services.mozilla.com/D195971
2023-12-11 13:39:53 +00:00
Robert Longson
d96fe01866 Bug 658189 Part 2 - force compositing if the number of animation functions changes r=birtles
Differential Revision: https://phabricator.services.mozilla.com/D195219
2023-12-07 05:52:59 +00:00
Robert Longson
f49c568eb2 Bug 658189 Part 1 - non-functional cleanup r=emilio
- Use range based loops where we can
- Use IsEmpty() instead of comparing Count() to 0
- Use LastElement() where we can
- Don't flush if we're not going to use an animation function at all

Differential Revision: https://phabricator.services.mozilla.com/D195218
2023-12-07 05:52:58 +00:00
Tooru Fujisawa
8c59289f4f Bug 1864168 - Part 1: Use 1-origin column number in nsIContentSecurityPolicy. r=smaug,devtools-reviewers,ochameau,ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D193369
2023-11-22 12:31:30 +00:00
Natalia Csoregi
705aa81869 Backed out 14 changesets (bug 1865005, bug 1864168, bug 1864155, bug 1862814, bug 1862693) for causing bustage on nsRFPService.cpp. CLOSED TREE
Backed out changeset a4f3e7625abf (bug 1865005)
Backed out changeset ab38141e470b (bug 1862814)
Backed out changeset a679b50dc4a9 (bug 1862814)
Backed out changeset e340886ce62a (bug 1862814)
Backed out changeset 1378502e64b0 (bug 1862814)
Backed out changeset 8ee94e5e79c2 (bug 1862814)
Backed out changeset 6d4ef1cdfabb (bug 1864168)
Backed out changeset 2c30c4d757fc (bug 1864168)
Backed out changeset d4db9576559b (bug 1864168)
Backed out changeset 8ffec0d83028 (bug 1864168)
Backed out changeset fa77d852b494 (bug 1864168)
Backed out changeset f6646771a26a (bug 1864168)
Backed out changeset 7bd0ff6986df (bug 1864155)
Backed out changeset 39867b503289 (bug 1862693)
2023-11-22 14:01:55 +02:00
Tooru Fujisawa
a4a513ad86 Bug 1864168 - Part 1: Use 1-origin column number in nsIContentSecurityPolicy. r=smaug,devtools-reviewers,ochameau,ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D193369
2023-11-22 11:13:54 +00:00
Mark Banner
6119729476 Bug 1860988 - Enable ESLint rule no-useless-return on all of dom/*. r=dom-core,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D191848
2023-10-27 12:43:03 +00:00
Emilio Cobos Álvarez
25c0d10932 Bug 1624819 - Remove TaskCategory and other quantum dom remnants. r=smaug,media-playback-reviewers,credential-management-reviewers,cookie-reviewers,places-reviewers,win-reviewers,valentin,mhowell,sgalich,alwu
Sorry this is not a particularly easy patch to review. But it should be
mostly straight-forward.

I kept Document::Dispatch mostly for convenience, but could be
cleaned-up too / changed by SchedulerGroup::Dispatch. Similarly maybe
that can just be NS_DispatchToMainThread if we add an NS_IsMainThread
check there or something (to preserve shutdown semantics).

Differential Revision: https://phabricator.services.mozilla.com/D190450
2023-10-10 08:51:12 +00:00
Tom Marble
faa34b0552 Bug 1855296 - convert .ini manifests to .toml: batch 9 dom/[m-s]**/mochitest.ini r=jmaher,media-playback-reviewers,alwu
Differential Revision: https://phabricator.services.mozilla.com/D189845
2023-10-03 19:35:22 +00:00
Robert Longson
905dbcc069 Bug 1717312 - clear mapped values if we're not animating any more r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D188712
2023-09-20 19:17:21 +00:00
Peter Van der Beken
3f4ffadbe1 Bug 1846277 - Untangle nsGlobalWindow*.h includes. r=dom-core,media-playback-reviewers,sessionstore-reviewers,padenot,farre
Differential Revision: https://phabricator.services.mozilla.com/D184978
2023-08-02 20:41:49 +00:00
Peter Van der Beken
9fba1d5220 Bug 1846277 - Remove nsGlobalWindow.h. r=dom-core,necko-reviewers,jesup,farre
Differential Revision: https://phabricator.services.mozilla.com/D184973
2023-08-02 20:41:48 +00:00
Zach Hoffman
98ad5a0692 Bug 1844295 - Don't duplicate ParsingMode in rust and C++. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D184409
2023-07-25 10:00:59 +00:00
Robert Longson
088bb7c7ba Bug 1772573 - check both types for relative or absoluteness r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D179872
2023-06-05 19:24:26 +00:00
Robert Longson
ef3b8b5368 Bug 1834892 - permit fractional SMIL timecount values to omit leading 0 r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D178995
2023-05-26 08:25:12 +00:00
Butkovits Atila
73aa7c6961 Backed out changeset fef0d9458939 (bug 1834892) as requested by dev. CLOSED TREE 2023-05-25 16:56:46 +03:00
Robert Longson
fcb8ef3146 Bug 1834892 - permit fractional SMIL timecount values to omit leading 0 r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D178995
2023-05-25 07:38:16 +00:00
Mark Banner
130a655906 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
8219a5c503 Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
nicklas boman
5e31225558 Bug 1724649 - Followup to remove #include plstr.h r=necko-reviewers,xpcom-reviewers,valentin,nika
Differential Revision: https://phabricator.services.mozilla.com/D177690
2023-05-15 14:53:02 +00:00
Emilio Cobos Álvarez
a7526d2a34 Bug 1832173 - Finish removing HasArcFFI. r=boris
Use the actual Locked<T> types around (via a typedef, just for
convenience).

Differential Revision: https://phabricator.services.mozilla.com/D177824
2023-05-12 22:31:38 +00:00
Butkovits Atila
cc740ca292 Backed out changeset f6e3d050b3e7 (bug 1832173) for causing bustages at CanvasRenderingContext2D.cpp. CLOSED TREE 2023-05-13 01:16:03 +03:00
Emilio Cobos Álvarez
7fc0f42cee Bug 1832173 - Finish removing HasArcFFI. r=boris
Use the actual Locked<T> types around (via a typedef, just for
convenience).

Differential Revision: https://phabricator.services.mozilla.com/D177824
2023-05-12 21:37:19 +00:00
Emilio Cobos Álvarez
6f904444e8 Bug 1832173 - Remove HasArcFFI for AnimationValue. r=boris
See previous patches for context.

Differential Revision: https://phabricator.services.mozilla.com/D177622
2023-05-11 08:25:36 +00:00
Robert Longson
c30e3eb265 Bug 1828294 - Simplify SMILSetAnimationFunction r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D175560
2023-04-17 22:27:59 +00:00
Robert Longson
f543d3efcd Bug 616362 - do not set aPreventCachingOfSandwich to false in methods that override SMILAttr::ValueFromString r=emilio
Currently SMILAnimationFunction::ParseAttr only sets its aPreventCachingOfSandwich outparam when it needs to be set to true.  (This lets us pass the same initially-false outparam into ParseAttr multiple times, and then check it for trueness at the end to see if any of the parsed values need us to prevent caching the sandwich.)

Our impls for ISMILAttr::ValueFromString should behave like that, too.  Then, we can pass ParseAttr's outparam directly to ValueFromString.

Differential Revision: https://phabricator.services.mozilla.com/D174353
2023-04-01 12:44:07 +00:00