We no longer need to gate including the sync description on whether sync is supported by the application or not because the string no longer includes the sync brand. This just uses the status of sync to control whether we ever see the sync specific string.
Differential Revision: https://phabricator.services.mozilla.com/D238058
The deletion request needs to be enabled after the usage reporting is enabled, because that will set up the usage reporting id which will identify the deletion request.
There's no reason for the deletion request to ever be disabled, however, so it's just set to true.
Differential Revision: https://phabricator.services.mozilla.com/D238072
The deletion request needs to be enabled after the usage reporting is enabled, because that will set up the usage reporting id which will identify the deletion request.
There's no reason for the deletion request to ever be disabled, however, so it's just set to `true`.
Differential Revision: https://phabricator.services.mozilla.com/D238070
Automatic update from web-platform-tests
script: fix spurious animation checks to correctly invoke rAF callbacks
After running an `rAF` callback, if no new callbacks were registered, we
send a `NoAnimationFramesCallback` to the compositor to stop ticking
animations using video refresh callbacks. This interacts badly with the
mechanism to track spurious animations frames i.e. rAF callbacks that
don't mutate the DOM. Such 'faked' rAF callbacks are triggered by
registering a oneshot timer instead of the compositor callback.
The compositor's refresh callback is never enabled back again once a
non-spurious rAF callback runs and registers a new rAF callback. If the
former callback resets the `spurious_animations_frames` counter, then when
the latter rAF callback runs, it will not schedule a OneShotTimer timer
for any rAF callback that itself registers, since the counter was reset
previously. Hence that third rAF callback that never runs as it relies
on the compsitor's refresh callback, which was disabled previously.
The current logic also doesn't actually recognize spurious animation
frames because the `spurious_animations_frames` counter is updated at
the end of the `run_the_animation_frame_callbacks`, effectively meaning
`was_faking_animation_frames` and `self.is_faking_animation_frames` will
always be the same value but the logic effectively only runs when
`(!was_faking && is_faking)` is true.
This patch fixes the logic to detect spurious animations frames by
moving logic to update the counter to be before the check for spurious
frames. It also ensures that the compositor's refesh callbacks is
re-enabled once we see a non-spurious callback.
Fixes#35386
Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
--
wpt-commits: f7c16d21ea82a52552da6e606e9aa28ef1306334
wpt-pr: 50620
Automatic update from web-platform-tests
Add requestClose() subtests for initially open dialog (#50432)
This tests that requestClose() still closes a dialog that's opened via attribute.
--
wpt-commits: 3bd5b55d329f457da1cac74148ed80011173c344
wpt-pr: 50432
Automatic update from web-platform-tests
Test `overflow-clip-margin` with `border-radius`
Assert that the resulting shape is the same as a spreading `box-shadow`.
Firefox fails this test.
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
--
wpt-commits: 634191c7610eeecd6cdac7f452dcb083760af829
wpt-pr: 50653
Automatic update from web-platform-tests
Fix a DCHECK when a block is started in the @property prelude.
Fixed: 393171829
Change-Id: I10431c8818ce163a9e00f036ca030f4a07088475
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6218377
Reviewed-by: Daniil Sakhapov <sakhapov@chromium.org>
Commit-Queue: Steinar H Gunderson <sesse@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1419175}
--
wpt-commits: cd978ccdde337f7aa46161b1ecfffa2e675b76af
wpt-pr: 50450
Automatic update from web-platform-tests
[carousel] Handle out-of-flow positioned scrollers.
If a scroller is out-of-flow, but its scroll marker group is not, they
will not be laid out in sequence. The out-of-flow scroller will
typically be laid out way after the scroll marker group. Since the
scroll marker group is populated as part of scroller layout, we need to
make sure that we only mark for layout within the subtree established by
the scroll marker group. Marking on the outside would re-mark elements
for layout, after we're done laying them out.
Also remove the early-bail for `after` scroll marker groups in
HandleScrollMarkerGroup(), since we cannot assume that such groups
actually come after in layout.
Bug: 395798192
Change-Id: I4c19afe7b3f217ff83eeebd33e1ec92d88aaee5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6253685
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1419158}
--
wpt-commits: 9ae8b0c560adbd99dd9b1bd5cfa1203f2d5e0123
wpt-pr: 50650
Automatic update from web-platform-tests
WPT for the sandbox `allow-same-site-none-cookies` value
Tentative Web Platform Test to verify the value allows SameSite=None
cookies to be accessed by sandboxed frames. Also validate SameSite=None
cookies are not accessible by frames with cross-site ancestors.
Bug: 372894175
Change-Id: Ie9bcdb15c37675203f0eeb2f0f6732dc81a7885c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6090256
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Anusha Muley <anushamuley@google.com>
Reviewed-by: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/main@{#1418956}
--
wpt-commits: c9f17cccd9aa1cb139fc3e8354c7e819f5fc611b
wpt-pr: 50647
Automatic update from web-platform-tests
Remove broken NoCorsSubresourceCookiesFromFrame helper (#50613)
If a request's mode is no-cors, then the response is opaque to
JavaScript. This helper relies on reading the response via the
`Response.text()` method, so it can't return anything except the empty
string.
Change-Id: I77828ab229d3175f607a4ed62a9e4895fc9f7185
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6243093
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Auto-Submit: Chris Fredrickson <cfredric@chromium.org>
Reviewed-by: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/main@{#1418242}
Co-authored-by: Chris Fredrickson <cfredric@chromium.org>
--
wpt-commits: 33a575c29f4d98c2c9aa2c489ba6db31a09110ae
wpt-pr: 50613
Automatic update from web-platform-tests
Add descriptions to fullscreen asserts (#50625)
This is to make it easier to understand failures.
--
wpt-commits: b8263dc75a63ce8444dc94f72f9a1d1742a12d87
wpt-pr: 50625
Automatic update from web-platform-tests
webnn: Support the dequantizeLinear operator in CoreML
Support basic dequantization. Follow up work to support:
- use `constexpr_affine_dequantize` when input is constant
- use `constexpr_blockwise_shift_scale` for blockwise quantization on
mac15.
Bug: 41481333
Change-Id: I088d41371a0c040670d0ef1a5383d6f39456111b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6226664
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Phillis Tang <phillis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418894}
--
wpt-commits: 2faf7231a91814b27b8548faf49b11f380471635
wpt-pr: 50644
Automatic update from web-platform-tests
Add tests for button type reflection and behaviour with command/commandfor and popovertarget (#50583)
--
wpt-commits: c0c25cb32c16911cadc9ce4a8a6b25d5836bded3
wpt-pr: 50583
Automatic update from web-platform-tests
[flex] Fix justify-content:stretch
Previously the kStretch branch in ContentDistributionSpace was
unreachable.
This changed after:
https://chromium-review.googlesource.com/c/chromium/src/+/6102219
(which coerced stretch to default in flexible_box_algorithm.cc:145).
Make kStretch behave the same as kDefault.
Fixed: 395659796
Change-Id: Id9a787ced5786cbd773d3d1e18cf0d2243ad176d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6253778
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418840}
--
wpt-commits: 7d68e04441548ea305d683763bc3e76d7c7ff540
wpt-pr: 50641
Automatic update from web-platform-tests
[DC] Fix/Improve Digital Credentials permission policy wpt
Web platforms tests for Digital Credentials Permission Policy has the
following issues:
1- The test were very fragile. Tests were passing an incomplete request
to the API, which results in the request being rejected before even
checking the permission policy. The test were relying on the type of
error that is thrown to decide the permission policy behaviour which was
basically masks the real issues.
2- Some tests assumed that the allow="" attribute can override the
header policy which isn't correct. [*]
This CL addresses both issues by always sending a complete request to
the API, and updates the tests to reflect the latest standards.
When sending a complete request to the API, the API is expected to
forward the request to the underlying platform and request user UI. In
order to avoid test hang, one option would be to introduce a command
line flag that's enabled by default in tests, which preempts the call to
the platform APIs and responds immediately with success. This allows
testing sending proper requests to the browser without test hang.
[*]
https://www.w3.org/TR/permissions-policy/#algo-define-inherited-policy-in-container
Bug: 370982995
Change-Id: Ie2f4b94a2788691e0f62458eba41b4b1f6080c74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6239109
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418815}
--
wpt-commits: 916aab962ad0375b4e19dc9ffe58a8d1f2f75983
wpt-pr: 50642
Automatic update from web-platform-tests
Fixed the crash when calling moveBefore on a custom element without implementing disconnectedCallback
When calling `moveBefore` on a custom element, `connectedMoveCallback`
is triggered. If `connectedMoveCallback` is not implemented,
it falls back to `disconnected/connectedCallback`, and it is necessary
to check whether `disconnected/connectedCallback` is implemented.
Bug: 395640957
Change-Id: I026546cf8bed705d35fbfa6cecdc47e7101dadc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6253397
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Peng Zhou <zhoupeng.1996@bytedance.com>
Reviewed-by: Noam Rosenthal <nrosenthal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418718}
--
wpt-commits: 4aaaf207afcc320d6181e7e24f07f2a1fa3f5071
wpt-pr: 50640
Automatic update from web-platform-tests
Fix dialog crashers related to `<dialog open>`
When the `open` attribute is added to a dialog to force-open it, the
close watcher was previously not getting constructed. Several related
cases then could crash, due to the lack of a close watcher. This CL
constructs the close watcher, and adds the dialog to the open dialogs
list, when the `open` attribute is manually added.
Fixed: 393420204, 393883102, 393879748, 393834331
Bug: 376516550
Change-Id: Id80ac36a3b9295b071fc56c251f6f3706573bc27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6245064
Reviewed-by: Traian Captan <tcaptan@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418682}
--
wpt-commits: 84d1cb2c6687439981f1570418c63a85d29de4a6
wpt-pr: 50638
Automatic update from web-platform-tests
Expose Captured Surface Resolution while screensharing for Windows
This change allows the MediaStreamTrack to expose physical and logical
dimensions of the captured track while screensharing. We get width and
height per frame using its metadata.source_size as that is unaffected by
applyConstraints.
For non-chrome window and screen captures, we need the device scale
factor from windows platform API. This work is in a separate WebRTC CL.
A follow-up change would be to add an 'capturedsurfacedimensionschanged'
event or reuse the existing 'configurationchange' event which would be
triggered whenever the dimensions change.
These new properties exposed by MediaTrackSettings are guarded by the
RuntimeEnabled flag 'CapturedSurfaceResolution'.
Design doc: go/expose-captured-surface-resolution
Bug: 383946052
Change-Id: Iedb06a85af13a8abc4dcedc04d971d32c29aa16c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6089100
Reviewed-by: Mark Foltz <mfoltz@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Palak Agarwal <agpalak@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418642}
--
wpt-commits: b841e01b37477fb469f123771cdc2a62d7c89d1e
wpt-pr: 50635
Automatic update from web-platform-tests
Add NS decl in wpt/svg/pservers/reftests/fill-fallback-invalid-uri.svg
Seems to have gotten lost during "export" to WPT.
Fixed: 395214642
Change-Id: I17c2ecb515e607d232e572c455f2b3c8e854db86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6249582
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418595}
--
wpt-commits: 26bac3cc99464cff46dc6135ce6c754c6c1e713f
wpt-pr: 50632
