Commit Graph

18947 Commits

Author SHA1 Message Date
Bogdan Tara
0108d839e9 Backed out 8 changesets (bug 1598516) for run startup hangs CLOSED TREE
Backed out changeset bc0035aa57fe (bug 1598516)
Backed out changeset 33603b723337 (bug 1598516)
Backed out changeset 31c11dd9146d (bug 1598516)
Backed out changeset 4e269a638350 (bug 1598516)
Backed out changeset 76b86080c868 (bug 1598516)
Backed out changeset b6f84b01cbd9 (bug 1598516)
Backed out changeset 74d136798dd3 (bug 1598516)
Backed out changeset bf370938463e (bug 1598516)
2019-12-04 00:48:17 +02:00
Matt Woodrow
9d6d1cef54 Bug 1598516 - Add DocumentChannel MOZ_LOGs. r=jya
Differential Revision: https://phabricator.services.mozilla.com/D54250

--HG--
extra : moz-landing-system : lando
2019-12-03 20:43:43 +00:00
Matt Woodrow
6fd561123e Bug 1598516 - Don't crash if NS_NewChannelInternal fails. r=mayhemer
Looks like this can sometimes fail with moz-extension URIs, so we shouldn't crash

Differential Revision: https://phabricator.services.mozilla.com/D54249

--HG--
extra : moz-landing-system : lando
2019-12-03 20:43:33 +00:00
Matt Woodrow
1f894c8f18 Bug 1598516 - Expose a RemoteWindowContext on ParentChannelListener. r=mayhemer,kmag
Without DocumentChannel, nsExtProtocolChannel::OpenURL calls into nsExternalHelperAppService::LoadURI in the content process.
We then manually forward this to the parent process over PContent, create a RemoteWindowContext around the browser parent, and then call LoadURI again.

With DocumemntChannel, the nsExtProtocolChannel already lives in the parent, so we just need to provide a RemoteWindowContext directly (that the code accesses via GetInterface on the callbacks).

Differential Revision: https://phabricator.services.mozilla.com/D54247

--HG--
extra : moz-landing-system : lando
2019-12-03 20:43:19 +00:00
Michal Novotny
a7fe3954fe Bug 1598321 - InputStreamShim::AsyncWait() and OutputStreamShim::AsyncWait() are not one-shot, r=dragana
InputStreamShim and OutputStreamShim now hold a strong reference to the callback and it's released after calling nsIInputStreamCallback::OnInputStreamReady() and nsIOutputStreamCallback::OnOutputStreamReady()

Differential Revision: https://phabricator.services.mozilla.com/D54147

--HG--
extra : moz-landing-system : lando
2019-11-26 18:31:18 +00:00
Gurzau Raul
2e8639b3b4 Backed out 8 changesets (bug 1598516) for build bustage at ParentChannelListener.cpp on a CLOSED TREE.
Backed out changeset 7ac1b091aa5f (bug 1598516)
Backed out changeset b62c5b49b91c (bug 1598516)
Backed out changeset e48c0ce38498 (bug 1598516)
Backed out changeset cc2599921b5e (bug 1598516)
Backed out changeset 0a0f80b0b278 (bug 1598516)
Backed out changeset 1dc19a039cab (bug 1598516)
Backed out changeset b664c8af6e2d (bug 1598516)
Backed out changeset 943b440179b9 (bug 1598516)
2019-12-03 21:48:14 +02:00
Michal Novotny
b508e7721e Bug 1600811 - network ID: use hardcoded IP for route checking in nsNetworkLinkService on MacOS r=JuniorHsu
The preferences network.netlink.route.check.IPv4 and network.netlink.route.check.IPv6 were removed in bug 1593693 and the values are now hardcoded because they are used by Linux/Android implementation of nsNetworkLinkService for link status detection and they are not supposed to be changed by the user.

Differential Revision: https://phabricator.services.mozilla.com/D55587

--HG--
extra : moz-landing-system : lando
2019-12-03 07:26:07 +00:00
Matt Woodrow
ab7f711e51 Bug 1598516 - Add DocumentChannel MOZ_LOGs. r=jya
Differential Revision: https://phabricator.services.mozilla.com/D54250

--HG--
extra : moz-landing-system : lando
2019-12-03 06:20:23 +00:00
Matt Woodrow
15db260efa Bug 1598516 - Don't crash if NS_NewChannelInternal fails. r=mayhemer
Looks like this can sometimes fail with moz-extension URIs, so we shouldn't crash

Differential Revision: https://phabricator.services.mozilla.com/D54249

--HG--
extra : moz-landing-system : lando
2019-12-03 06:20:11 +00:00
Matt Woodrow
9cc742b690 Bug 1598516 - Expose a RemoteWindowContext on ParentChannelListener. r=mayhemer,kmag
Without DocumentChannel, nsExtProtocolChannel::OpenURL calls into nsExternalHelperAppService::LoadURI in the content process.
We then manually forward this to the parent process over PContent, create a RemoteWindowContext around the browser parent, and then call LoadURI again.

With DocumemntChannel, the nsExtProtocolChannel already lives in the parent, so we just need to provide a RemoteWindowContext directly (that the code accesses via GetInterface on the callbacks).

Differential Revision: https://phabricator.services.mozilla.com/D54247

--HG--
extra : moz-landing-system : lando
2019-12-03 06:19:35 +00:00
Ehsan Akhgari
d94f27a8d6 Bug 1595934 - Make nsICookieManager cookie enumerators return Array<nsICookie> instead of nsISimpleEnumerator; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D52761

--HG--
extra : moz-landing-system : lando
2019-12-03 17:08:25 +00:00
Tom Ritter
4f9313ba4e Bug 1582512 - Register a ScriptValidationCallback to examine script loads in the parent process r=Gijs,ckerschb
Additionally, we disable validation on PAC scripts.

Differential Revision: https://phabricator.services.mozilla.com/D46500

--HG--
extra : moz-landing-system : lando
2019-12-02 17:27:09 +00:00
Kershaw Chang
9c48606bb3 Bug 1596409 - P6: Add a pref for using socket process for network r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D54174

--HG--
extra : moz-landing-system : lando
2019-12-03 13:46:04 +00:00
Kershaw Chang
e686a3ff31 Bug 1596409 - P5: Enable necessary XPCOM components for using nsHttpTransaction in socket process r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D54165

--HG--
extra : moz-landing-system : lando
2019-12-03 13:45:19 +00:00
Kershaw Chang
23e2261f84 Bug 1596409 - P4: Impl PHttpConnectionMgr IPC protocol r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D54164

--HG--
extra : moz-landing-system : lando
2019-12-03 13:44:39 +00:00
Kershaw Chang
1c7dbad1ac Bug 1596409 - P3: Add HttpConnectionMgrShell r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D54162

--HG--
extra : moz-landing-system : lando
2019-12-03 13:44:06 +00:00
Kershaw Chang
cb29d04cfa Bug 1596409 - P2: Seperate nsHttpConnectionMgr and AltSvcCache r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D54161

--HG--
extra : moz-landing-system : lando
2019-12-03 13:43:29 +00:00
Kershaw Chang
750f73dbb2 Bug 1596409 - P1.2: Create PHttpTransaction IPC protocol r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D54290

--HG--
extra : moz-landing-system : lando
2019-12-03 13:42:15 +00:00
Kershaw Chang
f3bddbd52b Bug 1596409 - P1.1: Make socket process support IPCStream r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D54289

--HG--
extra : moz-landing-system : lando
2019-12-03 13:41:58 +00:00
Kershaw Chang
a1a7f14884 Bug 1600678 - Use IPDL refcounted for DNSRequest r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D55475

--HG--
extra : moz-landing-system : lando
2019-12-02 18:28:49 +00:00
Valentin Gosu
2fc5985a45 Bug 1598430 - Make sure that we record the NETWORK_ID_ONLINE telemetry at the right time r=michal
We perform this check in the first OnDataAvailable, instead of doing it in
OnStopRequest in case a network down event occurs after the data has arrived
but before we fire OnStopRequest. That would cause us to report a missing
networkID, even though it was not empty while receiving data.

Differential Revision: https://phabricator.services.mozilla.com/D55574

--HG--
extra : moz-landing-system : lando
2019-12-03 07:35:11 +00:00
Ciure Andrei
e473bd5f57 Backed out 10 changesets (bug 1582512) for causing browser_preferences_usage.js to permafail CLOSED TREE
Backed out changeset a615a2c07523 (bug 1582512)
Backed out changeset 7dd0266da0a1 (bug 1582512)
Backed out changeset dfdefc6ede97 (bug 1582512)
Backed out changeset 59db30e1915f (bug 1582512)
Backed out changeset 1eb6f6b02149 (bug 1582512)
Backed out changeset 391ed11326fb (bug 1582512)
Backed out changeset 02865605c1c3 (bug 1582512)
Backed out changeset 017582048986 (bug 1582512)
Backed out changeset 1374c08302f9 (bug 1582512)
Backed out changeset 40dd63b6910a (bug 1582512)
2019-12-02 19:23:12 +02:00
Tom Ritter
40826aaf6c Bug 1582512 - Register a ScriptValidationCallback to examine script loads in the parent process r=Gijs,ckerschb
Additionally, we disable validation on PAC scripts.

Differential Revision: https://phabricator.services.mozilla.com/D46500

--HG--
extra : moz-landing-system : lando
2019-12-02 15:45:13 +00:00
Emilio Cobos Álvarez
74327c26b4 Bug 1599615 - Make some necko code less nsresult-happy. r=kershaw,valentin
Stuff that's infallible and not virtual has no reason to return an nsresult.

Differential Revision: https://phabricator.services.mozilla.com/D54831

--HG--
extra : moz-landing-system : lando
2019-12-02 13:21:06 +00:00
Valentin Gosu
0848f9ba9a Bug 1590528 - Call CheckAdaptersAddresses at startup r=kershaw
The problem is that the suffix is not always computed when Firefox starts up.
This patch adds a pref `network.notify.initial_call` that controls whether
CheckAdaptersAddresses gets called imediately after.
This call is necessary in order to compute the suffix list, VPN status, etc.

This patch also ensures that OnDnsSuffixListUpdated gets called by
NetlinkService::ComputeDNSSuffixList on Android. This notification is
necessary for the TRRService to pick up the suffix list.

Differential Revision: https://phabricator.services.mozilla.com/D55303

--HG--
extra : moz-landing-system : lando
2019-12-02 09:34:14 +00:00
Jean-Yves Avenard
72d4a6a2a4 Bug 1599968 - Remove nsIChildProcessChannelListerner interface. r=farre
There's just no use for it, it was an unnecessary virtual interface, with a single concreate class and only ever used in C++.

Differential Revision: https://phabricator.services.mozilla.com/D55069

--HG--
extra : moz-landing-system : lando
2019-11-29 15:14:07 +00:00
Jean-Yves Avenard
1bd91d2d68 Bug 1597865 - Fix do_QueryInterface to a RefPtr in DocumentChannel. r=mattwoodrow,mayhemer.
Use QueryObject instead. Some variable renaming to make it clearer we are dealing with a http channel.

Differential Revision: https://phabricator.services.mozilla.com/D55238

--HG--
extra : moz-landing-system : lando
2019-11-29 12:43:44 +00:00
Christian Holler
fcad9f8bf9 Bug 1595692 - Handle missing base64 challenge in NegotiateAuth. r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D53989

--HG--
extra : moz-landing-system : lando
2019-11-22 21:17:10 +00:00
Michal Novotny
f67a1ec522 Bug 1587534 - nsHttpChannel can return invalid content length for alternative data, r=valentin
CacheEntry::GetAltDataSize() can throw an error if the size isn't known yet, i.e. when the output stream wasn't closed yet. nsHttpChannel::OpenCacheInputStream() doesn't check the return value and in case of failure uninitialized altDataSize is stored in mAltDataLength.

Differential Revision: https://phabricator.services.mozilla.com/D55085

--HG--
extra : moz-landing-system : lando
2019-11-28 11:09:09 +00:00
Valentin Gosu
7996f8211b Bug 1582647 - Pref off the "public-suffix-list-updated" event r=Gijs
Updating the PSL while Firefox is running could cause principals to have
a different base domain before/after the update.
See bug 1582647 comment 30

Differential Revision: https://phabricator.services.mozilla.com/D55014

--HG--
extra : moz-landing-system : lando
2019-11-28 12:16:19 +00:00
Sebastian Streich
a79df87bcc Bug 1589690 : Add isOnion API r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D49751

--HG--
extra : moz-landing-system : lando
2019-11-28 09:22:17 +00:00
Jean-Yves Avenard
06d164721b Bug 1599006 - P4. Properly carry history and frecency data when switching process. r=kmag,mayhemer.
This allows test toolkit/components/places/tests/browser/browser_multi_redirect_frecency.js and others to pass when fission is enabled.

The content process expects to know the chain of redirects encountered while opening a URI. The DocumentChannelParent gather that information and sends it to the new ContentChild which can then propagate the information to the new nsDocShell.

The data used to only be passed around during same-origin redirects when fission mode was enabled.

In order to allow for move semantics and preventing unnecessary copy of the DocumentChannelRedirect array, we make the nsIChildProcessChannelListener::onChannelReady property C++ only (noscript).
As we have only one concrete nsIChildProcessChannelListener class (ChildProcessListener) and that the unique OnChannelReady implementation is infallible; we really don't need for the method to return nsresult (so we declare it nostdcall). This helps simplify that call.

Differential Revision: https://phabricator.services.mozilla.com/D54909

--HG--
extra : moz-landing-system : lando
2019-11-28 06:09:54 +00:00
Jean-Yves Avenard
3a1ad99868 Bug 1599006 - P3. Fix move semantics. r=mattwoodrow
A typo prevented for moves to actually occur. Fix other IPDL entry points while at it that could benefit from move semantics.

Depends on D54907

Differential Revision: https://phabricator.services.mozilla.com/D54908

--HG--
extra : moz-landing-system : lando
2019-11-27 23:07:34 +00:00
Jean-Yves Avenard
1922c3d728 Bug 1599006 - P2. Fix namespace comment. r=mattwoodrow
Depends on D54454

Differential Revision: https://phabricator.services.mozilla.com/D54907

--HG--
extra : moz-landing-system : lando
2019-11-27 23:00:57 +00:00
Emilio Cobos Álvarez
0c421267c6 Bug 1599843 - nsBaseChannel::Init does nothing. r=valentin
And is not virtual, so has no point in existing.

Differential Revision: https://phabricator.services.mozilla.com/D54983

--HG--
extra : moz-landing-system : lando
2019-11-27 20:06:41 +00:00
Ehsan Akhgari
6216893099 Bug 1599237 - Add a cookie manager API for deleting cookies by a time range, and use it in the clear data service; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D54646

--HG--
extra : moz-landing-system : lando
2019-11-27 11:01:45 +00:00
Andreea Pavel
c81fb53e77 Bug 1582318 - disable correct browser_sharedWorker.js test case on fission r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D54895

--HG--
extra : moz-landing-system : lando
2019-11-27 10:36:36 +00:00
Kershaw Chang
0e741f1658 Bug 1598676 - P2: Send dns suffix list updated event (Windows/Linux/Android) r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D54901

--HG--
extra : moz-landing-system : lando
2019-11-27 11:14:44 +00:00
Kershaw Chang
4c90c150c6 Bug 1598676 - P1: Send dns suffix list updated event (MacOS) r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D54782

--HG--
extra : moz-landing-system : lando
2019-11-27 11:14:44 +00:00
Matt Woodrow
4e9f06f73c Bug 1584031 - Allow non-http channels into on-may-change-process. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D53893

--HG--
extra : moz-landing-system : lando
2019-11-27 02:19:17 +00:00
Narcis Beleuzu
7d30f98797 Backed out changeset 4c50773d59a2 (bug 1594004) for mochitest failures on test_postMessage_solidus.html . CLOSED TREE 2019-11-27 02:01:58 +02:00
Alex Catarineu
5f0e03d3bf Bug 1598647 - Set Origin to null with network.http.referer.hideOnionSource r=JuniorHsu
Fix comment.

Differential Revision: https://phabricator.services.mozilla.com/D54749

--HG--
extra : moz-landing-system : lando
2019-11-26 17:56:14 +00:00
Sebastian Streich
a3be2f9036 Bug 1594004 - Enable CacheSplit in nightly r=ckerschb,annevk
***
Fix Cache-Split related Tests

Differential Revision: https://phabricator.services.mozilla.com/D51815

--HG--
extra : moz-landing-system : lando
2019-11-26 15:38:53 +00:00
Sylvestre Ledru
8d2f0d1b1f Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D54686

--HG--
extra : moz-landing-system : lando
2019-11-26 14:35:02 +00:00
Michal Novotny
f155107d8c Bug 1528850 - ws-over-h2 receive seems unreliable, r=dragana
The patch changes InputStreamShim::AsyncWait() so it checks the buffer state and if there is some data available the callback is immediately notified. Without this check the callback would be notified only when new data is delivered from the network.

Differential Revision: https://phabricator.services.mozilla.com/D53972

--HG--
extra : moz-landing-system : lando
2019-11-26 08:20:59 +00:00
Brindusan Cristian
6c34625fa0 Backed out 4 changesets (bug 1584031) for crashtest failures at crashtests/914521.html.
Backed out changeset 48a289c7226f (bug 1584031)
Backed out changeset cac72426ac2a (bug 1584031)
Backed out changeset bfb6286d68b6 (bug 1584031)
Backed out changeset c94a216693c5 (bug 1584031)
2019-11-26 06:42:14 +02:00
Matt Woodrow
c5ae95e1b1 Bug 1584031 - Allow non-http channels into on-may-change-process. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D53893

--HG--
extra : moz-landing-system : lando
2019-11-26 03:18:26 +00:00
Jean-Yves Avenard
7198477b2c Bug 1596665 - P5. Pass last site information from the parent and remove DCC's nsHashPropertyBag inheritance. r=mayhemer,kmag
The previous site URI is now only written on the parent and sent back to the child once all redirects have completed.

In a follow up we will also transfer this information when a process switch occur as it's currently broken.

Differential Revision: https://phabricator.services.mozilla.com/D53926

--HG--
extra : moz-landing-system : lando
2019-11-26 01:47:48 +00:00
Jean-Yves Avenard
6f3787fd8c Bug 1596665 - P4. Expose some nsDocShell utility methods. r=kmag
And use the new methods where we can.

Differential Revision: https://phabricator.services.mozilla.com/D53925

--HG--
extra : moz-landing-system : lando
2019-11-26 01:24:42 +00:00
Jean-Yves Avenard
9d62b283ad Bug 1596665 - P3. Copy property bag from parent to child. r=kmag,mayhemer
Rather that setting the property bag on both the child and parent from the docshell; we first set it on the parent instead, and once the redirect (or process switch) has completed we carry that bag across.

Differential Revision: https://phabricator.services.mozilla.com/D53924

--HG--
extra : moz-landing-system : lando
2019-11-26 01:24:34 +00:00