Commit Graph

31 Commits

Author SHA1 Message Date
Gijs Kruitbosch
7a09de96f9 Bug 1539757 - fix trying to initialize XBL bindings while the prompt is still hidden, r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D25390

--HG--
extra : moz-landing-system : lando
2019-04-01 13:37:49 +00:00
Ciure Andrei
73e7b60fc2 Backed out changeset de24b08ddc37 (bug 1539757) for causing browser_hidden_document_autofill.js, browser_httpauth.js, test_bug_627616.html to permafail CLOSED TREE
--HG--
extra : histedit_source : 12f30c6ab7c094c787618b62090e221815ff8439
2019-03-30 03:13:58 +02:00
Gijs Kruitbosch
4ffc2ff028 Bug 1539757 - fix trying to initialize XBL bindings while the prompt is still hidden, r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D25390

--HG--
extra : moz-landing-system : lando
2019-03-29 23:11:37 +00:00
Timothy Guan-tin Chien
bd38b39f8a Bug 1512048 - Convert tabmodalprompt binding to JSM module r=Gijs
This converts the tabmodalprompt binding to a class, to be constructed along side with the element
by TabModalPromptBox.

TabModalPromptBox will keep the instances in a map and pass it to the callers, instead of the element.
The tests and callers can access the class instance by passing the element reference to the map.

Differential Revision: https://phabricator.services.mozilla.com/D15505

--HG--
rename : toolkit/components/prompts/content/tabprompts.xml => toolkit/components/prompts/content/tabprompts.jsm
extra : moz-landing-system : lando
2019-01-04 19:29:34 +00:00
Brendan Dahl
f6923ccc24 Bug 1485426 - Use createXULElement instead of createElement in XUL docs. r=bgrins
Preparing for transitioning to XHTML.

MozReview-Commit-ID: JLlmUxsvhIB

Differential Revision: https://phabricator.services.mozilla.com/D4265

--HG--
extra : moz-landing-system : lando
2018-08-25 00:16:27 +00:00
Joel Maher
50b91c0a14 Bug 1405428 - skip-if = verify on mochitests which do not pass test-verify. r=gbrown 2018-06-10 05:01:47 -04:00
Tooru Fujisawa
1adba8c1fc Bug 1442465 - Part 4.2: Stop unnecessarily awaiting on BrowserTestUtils.removeTab (simple part). r=dao 2018-03-19 11:16:45 +09:00
Bevis Tseng
0108bf8272 Bug 1428253 - Resume the test at next tick after the resolve of openTabSelectedPromise. r=:Gijs.
With the conformant promising scheduling, the promise callback can be performed
eariler at the returning from a event listener if possible instead of the end
of current task.

The resolving of "selected" change of the openedTab becomes part of the process
of RemotePrompt.openTabPrompt() where the 'DOMWillOpenModalDialog' event is fired.

We should resume the test at next tick to ensure that the openTabPrompt() is
done before removing the openedTab.
2018-01-16 14:04:36 +08:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Christoph Kerschbaumer
e4f38c8d7c Bug 1362993 - Rewrite gBrowser.addTab() to use BrowserTestUtils.addTab(). r=florian 2017-05-15 21:49:50 +02:00
Florian Quèze
5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Florian Queze
4c6a68d1c9 Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Florian Queze
37ff4fc7cc Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
159215e6f4 Backed out changeset 18d45aa984d6 (bug 1355161) 2017-04-14 23:39:23 +02:00
Sebastian Hengst
a07223d699 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
95d4d20c17 Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Florian Queze
a363fb8c8b Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Prathiksha
68df0b85af Bug 1224137 - List the 'allow pages from <example.com> to take you to their tab' permission (for alerts/prompts) in the site identity / permission panel. r=johannh
MozReview-Commit-ID: LIsJ8VG0stN

--HG--
extra : rebase_source : 975e6684f0872ea3f0e42bf073f1bceec12d5bc7
2017-04-09 11:45:01 +05:30
Sebastian Hengst
8858633e3a Backed out changeset ce87577c5da8 (bug 1224137) for failing xpcshell test browser/modules/test/unit/test_SitePermissions.js. r=backout 2017-04-03 19:07:39 +02:00
Prathiksha
e9f21d2948 Bug 1224137 - List the 'allow pages from <example.com> to take you to their tab' permission (for alerts/prompts) in the site identity / permission panel. r=johannh
MozReview-Commit-ID: LGDNUbpVEgX

--HG--
extra : rebase_source : f18d8c15ecb2aab0554d2ce8a9c59619a84b2890
2017-03-23 12:30:57 +05:30
Mark Banner
bd625e4e9f Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws
MozReview-Commit-ID: LH0CQOPfoe6

--HG--
extra : rebase_source : 83eaf40c5cbb5e25cfb3f3b5afadf4fbf0422c92
2017-03-20 12:36:37 +01:00
Florian Quèze
85611a7b6d Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws.
--HG--
extra : rebase_source : a22344ee1569f58f1f0a01017bfe0d46a6a14602
2017-01-17 11:50:25 +01:00
Florian Quèze
1e42cad36c Bug 1330464 - script-generated removal of additional parameters that don't exist in the interface, r=jaws. 2017-01-13 20:21:53 +01:00
Dão Gottwald
7b3b6f0ada Bug 1317961 - Remove the browser.tabs.dontfocusfordialogs pref. r=gijs 2016-11-16 14:36:08 +01:00
Mark Banner
709dd68567 Bug 1313626 - Clean up more issues found by eslint no-undef rule. r=mossop
MozReview-Commit-ID: HGiOmpyN5zV

--HG--
extra : rebase_source : f09a308b4c34b3cd3c28e170440bd1012176ef08
2016-10-28 11:40:32 +01:00
Boris Zbarsky
fee88c0518 Bug 1167575. Ensure that we don't exit modal state while we're still waiting on a Gecko runnable in the event-loop-spinning code in nsPrompter.js. r=dolske
If we synchronously shut down the prompt, that will exit modal state while we're
still processing our mouse or key event, which happens _before_ Gecko runnable
processing.  Exiting modal state will generally post a runnable to run timeouts,
so we can end up processing that runnable before we return from processNextEvent
and unwind to whatever code did the alert() call on the web page.  The upshot is
that the webpage will see timeouts fire before the alert() call returns.

If we exit modal state off a Gecko runnable instead, that will ensure that we
return to the nsPrompter code immediately after exiting modal state, see that
the prompt is no longer active, and return to the calling web page code _before_
processing any more runnables.
2016-09-01 21:31:22 -04:00
Jared Wein
a182a61bce Bug 1298559 - Enable eslint for /browser/base/content/test/ r=mattn
MozReview-Commit-ID: BZlkPTcLJMB
2016-08-31 12:53:24 -04:00
Katie Broida[:ktbee]
07f2d654fe Bug 1171746 - Ensure tab-specific panels close when you switch the tab. r=jaws
--HG--
extra : amend_source : 8c8bd60be44132befa37a50422086d9ffdae3cbe
2016-08-19 07:27:00 -04:00
Wes Kocher
7636e9aaaf Backed out changeset 33fcf83eefe4 (bug 1171746) for browser_visibleFindSelection.js failures a=backout 2016-08-12 19:11:21 -07:00
Katie Broida[:ktbee]
b9d80840e4 Bug 1171746 - ensure tab specific panels close when you switch the tab r=jaws
Adds a tabspecific attribute to the edit bookmarks panel and the Pocket subview panel to signal that these popups should close when the user navigates away from the tab. It also specifies that the localized keyboard short cut for closing a  window should close the edit bookmarks panel and the tab by adding a general function to check whether a certain <key> has been pressed. Adds tests for both closing specific tabs and checking keys.

MozReview-Commit-ID: AxW5uQgDQQB

--HG--
extra : rebase_source : 76f649492e719317a9ef71895e9cb1d600ea67b1
2016-08-11 16:51:45 -04:00
Timothy Guan-tin Chien
b7fa00b590 Bug 1266611 - Multiple tab prompts should not overlap, r=gijs
MozReview-Commit-ID: 6wjdoiR38Wb

--HG--
rename : browser/base/content/test/general/openPromptOffTimeout.html => browser/base/content/test/tabPrompts/openPromptOffTimeout.html
extra : rebase_source : dab1ec206a4f511f7bdf2108ed22d73d0df4c4c7
2016-05-21 21:13:10 +08:00