Commit Graph

10474 Commits

Author SHA1 Message Date
Henri Sivonen
ec150294ab Bug 1513799 - Remove windows-1252 as a Japanese detection outcome. r=emk.
If this removal turns out to be OK, we should be able to make the detector
decide more quickly between the remaining options.

Differential Revision: https://phabricator.services.mozilla.com/D26283
2019-04-08 14:43:26 +03:00
Sylvestre Ledru
03c8e8c2dd Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
2019-04-05 21:41:42 +00:00
Csoregi Natalia
ba58e936bd Backed out changeset 4ad80127f89f (bug 1519636) for bustage on MarkupMap.h and nsAccessibilityService.cpp. CLOSED TREE 2019-04-05 09:48:19 +03:00
Sylvestre Ledru
d1c1878603 Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
2019-04-04 21:36:16 +00:00
Narcis Beleuzu
24dbe577a5 Backed out changeset 389b6bbd76db (bug 1519636) for bustages on MarkupMap.h . CLOSED TREE 2019-04-05 00:27:56 +03:00
Sylvestre Ledru
399dbd28fe Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
2019-04-04 20:12:23 +00:00
Erica Wright
fccf274cc5 Bug 1524883 - Clear storageAccessAPI permissions when history is cleared. r=johannh,Ehsan
When history is cleared, clear the flag that indicates a user has visited the domain.

Differential Revision: https://phabricator.services.mozilla.com/D24404

--HG--
extra : moz-landing-system : lando
2019-03-28 18:44:08 +00:00
Boris Zbarsky
92f7b5dd5e Bug 1539716. Remove nsIHashable. r=froydnj
It's dead code.

Differential Revision: https://phabricator.services.mozilla.com/D25190

--HG--
extra : moz-landing-system : lando
2019-03-28 13:07:05 +00:00
Mark Banner
dba6983e75 Bug 1415265 - Remove now unnecessary .eslintrc.js files or entries. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D23850

--HG--
extra : moz-landing-system : lando
2019-03-28 09:38:14 +00:00
Masayuki Nakano
0a753c3aac Bug 1533293 - part 3: Make editor and ContentEventHandler not use Selection::Extend() due to too slow r=m_kato
`Selection::Extend()` is too slow but editor and ContentEventHandler use it in
some places.  We should make them use `Selection::SetStartAndEndInLimiter()` or
`Selection::SetBaseAndExtentInLimiter()`.  The former is usable only when caller
guarantees the start point is prior to the end point in the DOM tree.
Otherwise, we need to use the latter even though it's slower than the former.

Differential Revision: https://phabricator.services.mozilla.com/D23462

--HG--
extra : moz-landing-system : lando
2019-03-26 10:09:47 +00:00
Masayuki Nakano
534fd23ca4 Bug 1533293 - part 2: Rewrite EditorBase::SelectEntireDocument() and its overrides r=m_kato
`EditorBase::SelectEntierDocument()` uses `Selection::Extend()` but it's too
slow.  It should use `Selection::SetStartAndEndInLimiter()` instead.

Additionally, `TextEditor::SelectEntierDocument()` shrink the result of
`EditorBase::SelectEntierDocument()` with `Selection::Extend()` if there is
a `moz-<br>` element.  So, `TextEditor::SelectEntinerDocument()` should set
its expected selection with a call for saving the runtime cost.

Then, we don't need to make `EditorBase::SelectEntierDocument()` as non-pure
virtual method.  So, this patch makes each its callers call
`Selection->SelectAllChildren()` directly.

Differential Revision: https://phabricator.services.mozilla.com/D23461

--HG--
extra : moz-landing-system : lando
2019-03-26 10:06:43 +00:00
Noemi Erli
165f0d8c1c Backed out 3 changesets (bug 1533293) for causing Bug 1536595 a=backout
Backed out changeset d011dfe83683 (bug 1533293)
Backed out changeset e536f6e123d8 (bug 1533293)
Backed out changeset 19cff61f4fed (bug 1533293)
2019-03-20 13:29:17 +02:00
Masayuki Nakano
6dd0ecdd8e Bug 1533293 - part 3: Make editor and ContentEventHandler not use Selection::Extend() due to too slow r=m_kato
`Selection::Extend()` is too slow but editor and ContentEventHandler use it in
some places.  We should make them use `Selection::SetStartAndEndInLimiter()` or
`Selection::SetBaseAndExtentInLimiter()`.  The former is usable only when caller
guarantees the start point is prior to the end point in the DOM tree.
Otherwise, we need to use the latter even though it's slower than the former.

Differential Revision: https://phabricator.services.mozilla.com/D23462

--HG--
extra : moz-landing-system : lando
2019-03-18 01:52:36 +00:00
Masayuki Nakano
448571fd81 Bug 1533293 - part 2: Rewrite EditorBase::SelectEntireDocument() and its overrides r=m_kato
`EditorBase::SelectEntierDocument()` uses `Selection::Extend()` but it's too
slow.  It should use `Selection::SetStartAndEndInLimiter()` instead.

Additionally, `TextEditor::SelectEntierDocument()` shrink the result of
`EditorBase::SelectEntierDocument()` with `Selection::Extend()` if there is
a `moz-<br>` element.  So, `TextEditor::SelectEntinerDocument()` should set
its expected selection with a call for saving the runtime cost.

Then, we don't need to make `EditorBase::SelectEntierDocument()` as non-pure
virtual method.  So, this patch makes each its callers call
`Selection->SelectAllChildren()` directly.

Differential Revision: https://phabricator.services.mozilla.com/D23461

--HG--
extra : moz-landing-system : lando
2019-03-18 01:51:53 +00:00
Sebastian Hengst
cee711baf9 Bug 1535353 - update Core :: DOM: * bugzilla product and component meta data in moz.build files after reorganization in bug 1533440 r=hsinyi
Differential Revision: https://phabricator.services.mozilla.com/D23546

--HG--
extra : moz-landing-system : lando
2019-03-17 23:13:22 +00:00
Sylvestre Ledru
4aa92e3091 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D22514
2019-03-13 10:19:06 +01:00
Nathan Froyd
646507261e Bug 1533750 - pack members of PermissionEntry better on 64-bit platforms; r=jdm
The current ordering leaves a hole after `mExpireType` due to the need
to align a 64-bit `mExpireTime` and another one after
`mNonSessionExpireTime` to pad out the structure.  We can group members
by their type (and initialize them in that order to avoid compiler
warnings) to avoid the holes and save a little bit of space.

Differential Revision: https://phabricator.services.mozilla.com/D22713

--HG--
extra : moz-landing-system : lando
2019-03-11 18:36:44 +00:00
Andrea Marchesini
b27c7a2194 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 14 - Test for cookies policy, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D21697

--HG--
extra : moz-landing-system : lando
2019-03-08 09:04:57 +00:00
Andrea Marchesini
8e20bbbc9a Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 12 - nsICookieSettings for the channel creation, r=ckerschb,asuth,Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D21538

--HG--
extra : moz-landing-system : lando
2019-03-08 09:04:11 +00:00
Andrea Marchesini
6b7df33f3a Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 10 - Fix existing tests, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D18958

--HG--
extra : moz-landing-system : lando
2019-03-08 09:03:15 +00:00
Ciure Andrei
712dd2bb8c Backed out 16 changesets (bug 1525245) for perma failing test_document_cookie.html CLOSED TREE
Backed out changeset 3fd27215698f (bug 1525245)
Backed out changeset d9a9e8e77873 (bug 1525245)
Backed out changeset 0e6f7be92e3f (bug 1525245)
Backed out changeset 6790802e2fa5 (bug 1525245)
Backed out changeset a5a9e01116ed (bug 1525245)
Backed out changeset 66e19a0c38dd (bug 1525245)
Backed out changeset fb90d51ba853 (bug 1525245)
Backed out changeset 4772db3625b3 (bug 1525245)
Backed out changeset 9affaf0cb998 (bug 1525245)
Backed out changeset a91b7ebe8bdd (bug 1525245)
Backed out changeset c2a13a7480e1 (bug 1525245)
Backed out changeset abe4482fa137 (bug 1525245)
Backed out changeset b3920c0bcf84 (bug 1525245)
Backed out changeset 0821b81f2724 (bug 1525245)
Backed out changeset 70bed2ad7899 (bug 1525245)
Backed out changeset 5f72ba232cc8 (bug 1525245)
2019-03-07 17:54:18 +02:00
Andrea Marchesini
f5aaaac0e2 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 14 - Test for cookies policy, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D21697

--HG--
extra : moz-landing-system : lando
2019-03-07 10:22:18 +00:00
Andrea Marchesini
6856f88972 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 12 - nsICookieSettings for the channel creation, r=ckerschb,asuth,Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D21538

--HG--
extra : moz-landing-system : lando
2019-03-07 10:21:15 +00:00
Andrea Marchesini
48b3f2b792 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 10 - Fix existing tests, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D18958

--HG--
extra : moz-landing-system : lando
2019-03-07 10:18:07 +00:00
Dorel Luca
ac34e1d973 Backed out 16 changesets (bug 1525245) for Android failures. CLOSED TREE
Backed out changeset 9f8a1b410320 (bug 1525245)
Backed out changeset 0ef284a9a1d5 (bug 1525245)
Backed out changeset 835e5f642a03 (bug 1525245)
Backed out changeset 362f5a8d033c (bug 1525245)
Backed out changeset 9da3ab33cf67 (bug 1525245)
Backed out changeset 6aacd2d6e835 (bug 1525245)
Backed out changeset 8ff9e8f45e02 (bug 1525245)
Backed out changeset 2020227181cc (bug 1525245)
Backed out changeset fc3c64c330b9 (bug 1525245)
Backed out changeset 2762bf88e050 (bug 1525245)
Backed out changeset ffc10fdc50a6 (bug 1525245)
Backed out changeset bb6ade1207d7 (bug 1525245)
Backed out changeset 1875eb5085e4 (bug 1525245)
Backed out changeset 7e4f67a6d6f1 (bug 1525245)
Backed out changeset e671fc9581eb (bug 1525245)
Backed out changeset b89f5def8d0d (bug 1525245)
2019-03-06 21:07:49 +02:00
Andrea Marchesini
4643d957ad Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 14 - Test for cookies policy, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D21697

--HG--
extra : moz-landing-system : lando
2019-03-06 17:04:55 +00:00
Andrea Marchesini
4fabb4a2a8 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 12 - nsICookieSettings for the channel creation, r=ckerschb,asuth,Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D21538

--HG--
extra : moz-landing-system : lando
2019-03-06 17:04:06 +00:00
Andrea Marchesini
cc69a8960f Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 10 - Fix existing tests, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D18958

--HG--
extra : moz-landing-system : lando
2019-03-06 17:03:08 +00:00
Ryan Hunt
f11762a961 Bug 1523969 part 7 - Move method definition inline comments to new line in 'extensions/'. r=ehsan
Differential Revision: https://phabricator.services.mozilla.com/D21107

--HG--
extra : rebase_source : 464cdd0563865fcfd4f6fc9617f7b235892af2a4
2019-02-25 16:05:47 -06:00
Jonathan Kingston
f6680698bd Bug 1525319 - Removing context from OnDataAvailable r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D20881

--HG--
extra : moz-landing-system : lando
2019-02-27 23:42:27 +00:00
Jonathan Kingston
c4853316e7 Bug 1525319 - Removing context from OnStopRequest r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D20770

--HG--
extra : moz-landing-system : lando
2019-02-27 23:41:31 +00:00
Jonathan Kingston
f7e35ae39e Bug 1525319 - Removing context from OnStartRequest r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D20769

--HG--
extra : moz-landing-system : lando
2019-02-27 23:41:04 +00:00
Ciure Andrei
8d2894e70d Backed out 12 changesets (bug 1525245) for failing worker-interception.https.html CLOSED TREE
Backed out changeset 009e7457b990 (bug 1525245)
Backed out changeset efb2e8fca464 (bug 1525245)
Backed out changeset 6a8401de3237 (bug 1525245)
Backed out changeset 38e802661b14 (bug 1525245)
Backed out changeset d02e3f436390 (bug 1525245)
Backed out changeset 10afd61b7582 (bug 1525245)
Backed out changeset 6b92fb3666d1 (bug 1525245)
Backed out changeset 476af2d7efe5 (bug 1525245)
Backed out changeset 43ad14e323a1 (bug 1525245)
Backed out changeset 94295e3fb027 (bug 1525245)
Backed out changeset d01ead2270e9 (bug 1525245)
Backed out changeset 6bdda622a04a (bug 1525245)
2019-02-28 00:55:39 +02:00
Andrea Marchesini
eaa983a53f Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 10 - Fix existing tests, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D18958

--HG--
extra : moz-landing-system : lando
2019-02-27 19:57:47 +00:00
Dorel Luca
4a4dcd57fa Backed out 4 changesets (bug 1525319) for Android failures in dom/base/test/test_progress_events_for_gzip_data.html
Backed out changeset b73f033efb41 (bug 1525319)
Backed out changeset 1d318d5c6b98 (bug 1525319)
Backed out changeset 6d73418988d4 (bug 1525319)
Backed out changeset 84ca79bd2dc3 (bug 1525319)
2019-02-25 04:06:11 +02:00
Jonathan Kingston
63ab2bd8aa Bug 1525319 - Removing context from OnDataAvailable r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D20881

--HG--
extra : moz-landing-system : lando
2019-02-24 20:27:55 +00:00
Jonathan Kingston
332531fa9c Bug 1525319 - Removing context from OnStopRequest r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D20770

--HG--
extra : moz-landing-system : lando
2019-02-24 20:26:59 +00:00
Jonathan Kingston
2441197975 Bug 1525319 - Removing context from OnStartRequest r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D20769

--HG--
extra : moz-landing-system : lando
2019-02-24 20:26:16 +00:00
Ehsan Akhgari
3219a47956 Bug 1527505 - Part 11: Avoid looking up the effective TLD service repeatedly inside the permission manager; r=nika
Depends on D20238

Differential Revision: https://phabricator.services.mozilla.com/D20239

--HG--
extra : moz-landing-system : lando
2019-02-21 22:54:34 +00:00
Ehsan Akhgari
21eac68e65 Bug 1527505 - Part 10: Add a variation of TestPermissionFromPrincipal() that knows to not check for the presence of a default pref if the caller knows the permission type doesn't support default prefs, and use it in the anti-tracking backend; r=nika
This gives us the additional benefit that it will provide a clean inlined path
for the common case of testing for permissions from the anti-tracking backend.

Depends on D20237

Differential Revision: https://phabricator.services.mozilla.com/D20238

--HG--
extra : moz-landing-system : lando
2019-02-21 22:54:30 +00:00
Ehsan Akhgari
b5a2bda7ee Bug 1527505 - Part 9: Make nsIPermissionManager accept ACString arguments for permission types instead of raw C strings; r=nika
This will mean that in places like the tight loop in GetTypeIndex()
we would no longer require calling strlen() on the input type argument
once per loop iteration.

Depends on D20236

Differential Revision: https://phabricator.services.mozilla.com/D20237

--HG--
extra : moz-landing-system : lando
2019-02-21 22:54:28 +00:00
Ehsan Akhgari
b7a58af3de Bug 1527505 - Part 8: Lift the handling of expanded principals out of CommonTestPermissionInternal() into CommonPrepareToTestPermission(); r=nika
This patch in the series ensures that the order of operations in
recursive invocations of CommonTestPermission() remains consistent
compared to before the patch series, even though it is not strictly
needed for the performance improvements that the series focuses on.

The core idea behind CommonPrepareToTestPermission() now is to do the checks
that do not depend on the host name being tested, and for
CommonTestPermissionInternal() itself to focus on the rest of the checks,
that is looking up our hashtable entry based on the host name being tested,
and everything else that's needed from that point on.

Depends on D20235

Differential Revision: https://phabricator.services.mozilla.com/D20236

--HG--
extra : moz-landing-system : lando
2019-02-21 22:54:26 +00:00
Ehsan Akhgari
b0243117bd Bug 1527505 - Part 7: Compute the default permission in the recursive loop only once; r=nika
Depends on D20234

Differential Revision: https://phabricator.services.mozilla.com/D20235

--HG--
extra : moz-landing-system : lando
2019-02-21 22:54:24 +00:00
Ehsan Akhgari
d29bd70ee2 Bug 1527505 - Part 6: Use inline storage for storing the type array in order to speed up searching though it in the common case; r=nika
Depends on D20233

Differential Revision: https://phabricator.services.mozilla.com/D20234

--HG--
extra : moz-landing-system : lando
2019-02-21 22:54:16 +00:00
Ehsan Akhgari
0083cbb875 Bug 1527505 - Part 5: Inline nsPermissionManager::GetTypeIndex(); r=nika
Depends on D20232

Differential Revision: https://phabricator.services.mozilla.com/D20233

--HG--
extra : moz-landing-system : lando
2019-02-21 22:54:14 +00:00
Ehsan Akhgari
ef76693c35 Bug 1527505 - Part 4: Compute the type index in the recursive loop only once; r=nika
This patch alone decreases the runtime of the loop on my machine from about
1700 to 200-400ms ranges.  It turns out that computing the type index is
the most expensive part.  So perhaps we should look into improving that as
well.

The first thing that comes to mind is whether we can inline the loop in
GetTypeIndex().  The next part takes care of that, and it does help a bit.
But we need to do more still.

The next obvious thing is to optimize the memory access patterns.  Right
now we iterate over an array of dynamically allocated strings to compare
them, which amounts to pointer chasing to read a bit of memory, kind of
the worst possible way to access memory.  Then we look at replacing that
with fully sequential memory reads in the common cases.

Depends on D20231

Differential Revision: https://phabricator.services.mozilla.com/D20232

--HG--
extra : moz-landing-system : lando
2019-02-21 22:54:12 +00:00
Ehsan Akhgari
4268da8938 Bug 1527505 - Part 3: Compute the origin hash once when storing permissions; r=nika
Depends on D20230

Differential Revision: https://phabricator.services.mozilla.com/D20231

--HG--
extra : moz-landing-system : lando
2019-02-21 22:54:10 +00:00
Ehsan Akhgari
f017471b08 Bug 1527505 - Part 2: Inline the IsSystemPrincipal check; r=nika
Depends on D20229

Differential Revision: https://phabricator.services.mozilla.com/D20230

--HG--
extra : moz-landing-system : lando
2019-02-21 22:54:08 +00:00
Ehsan Akhgari
354461335a Bug 1527505 - Part 1: Add a platform-bench test for measuring the performance of TestPermissionFromPrincipal() in the common case that the anti-tracking backend uses it; r=nika
We choose 100,000 iterations so that on a fast processor the test takes
times in the order of seconds.

Differential Revision: https://phabricator.services.mozilla.com/D20229

--HG--
rename : extensions/cookie/test/moz.build => extensions/cookie/test/gtest/moz.build
extra : moz-landing-system : lando
2019-02-21 22:54:06 +00:00
Junior Hsu
b7e28eddd2 Bug 1507110 - Allow hijacking localhost only if network.proxy.allow_hijacking_localhost is set r=Gijs,mayhemer,mkaply,jmaher
Differential Revision: https://phabricator.services.mozilla.com/D19325

--HG--
extra : moz-landing-system : lando
2019-02-19 21:53:22 +00:00