Commit Graph

507 Commits

Author SHA1 Message Date
Mike Hommey
61bc19ae44 Bug 1836883. Avoid passing ref function arguments to Rc::from_raw. r=eemeli, a=dmeehan
It is unfortunately undefined behavior and leads to problems with LLVM
16.

Differential Revision: https://phabricator.services.mozilla.com/D180061
2023-06-06 08:55:21 +00:00
Mike Hommey
96c67f7c0b Bug 1836419 - Remove the serial_test dependency. r=nordzilla,supply-chain-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D179754
2023-06-02 21:49:16 +00:00
Kris Maglione
fbc33fd683 Bug 1648545: Part 2 - Load SpecialPowers in XPCShellContentUtils. r=ahal,application-update-reviewers,nalexander,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D119449
2023-05-27 03:46:44 +00:00
Noemi Erli
06b68d0d45 Backed out 4 changesets (bug 1648545) for causing mass failures
Backed out changeset ac3d639547fa (bug 1648545)
Backed out changeset f63760c845f3 (bug 1648545)
Backed out changeset 652b48b10d37 (bug 1648545)
Backed out changeset 1ca7abd873d1 (bug 1648545)
2023-05-26 02:12:58 +03:00
Kris Maglione
1abe5de918 Bug 1648545: Part 2 - Load SpecialPowers in XPCShellContentUtils. r=ahal,application-update-reviewers,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D119449
2023-05-25 22:04:31 +00:00
Greg Tatum
a5ebe9f40b Bug 1830989 - Add a document.l10n.setArgs method; r=webidl,smaug,eemeli
Differential Revision: https://phabricator.services.mozilla.com/D176958
2023-05-08 14:24:54 +00:00
Dana Keeler
f0596227b1 Bug 1811645 - avoid an American English colloquialism meaning "nonsense" r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D175802
2023-04-20 22:24:00 +00:00
serge-sans-paille
95a3a332df Bug 1824509 - Make intl/l10n buildable outside of a unified build environment r=andi
Differential Revision: https://phabricator.services.mozilla.com/D173609
2023-03-30 13:48:31 +00:00
Emilio Cobos Álvarez
f3f4f3270c Bug 1819664 - Notify chrome docs when async translation work is done. r=smaug,Gijs
This prototypes the proposal in bug 1738056 comment 22.

Depends on D171359

Differential Revision: https://phabricator.services.mozilla.com/D171360
2023-03-04 00:04:21 +00:00
Emilio Cobos Álvarez
3d49ec4825 Bug 1819664 - Fix unsettled promise handling in Localization. r=smaug
Otherwise we have some promises that may never resolve. This causes
issues in
toolkit/content/tests/widgets/test_videocontrols_jsdisabled.html with
the previous patch, for example.

Differential Revision: https://phabricator.services.mozilla.com/D171564
2023-03-03 22:18:11 +00:00
Eemeli Aro
47c30f3625 Bug 1815410 - Add documentation for fluent.migrate TransformPattern. r=flod DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D169058
2023-02-07 17:44:10 +00:00
Sylvestre Ledru
e2b52a1324 Bug 1807899 - Remove the trailing whitespace and Windows CR on md files r=linter-reviewers,necko-reviewers,marco,jesup
Differential Revision: https://phabricator.services.mozilla.com/D165662
2022-12-30 15:23:21 +00:00
Jonathan Kew
859eb99179 Bug 1806042 - Update tests to expect normal spaces rather than U+202F/2009 in formatted date/time strings. r=gregtatum
We'll need to revert this when we're ready to disable the workaround.

Depends on D165408

Differential Revision: https://phabricator.services.mozilla.com/D165409
2022-12-24 10:35:10 +00:00
Andrew McCreight
ce28c41da0 Bug 1805931, part 2 - Automated removal of uses of ROOT and UNROOT CC macros. r=smaug
As of the prior patch, these are no longer needed. I removed
these with a script, then ran clang-format on the files, then
manually reverted a few unrelated changed from the formatter.

Differential Revision: https://phabricator.services.mozilla.com/D164829
2022-12-15 19:45:01 +00:00
Sylvestre Ledru
baca9eb94e Bug 1802689 - cargo.toml: more consistency in the author names
Differential Revision: https://phabricator.services.mozilla.com/D163769
2022-12-13 09:14:44 +00:00
Sylvestre Ledru
04363d3827 Bug 1802689 - Add missing licenses info in Cargo.toml r=mhoye,necko-reviewers,kershaw,valentin
Differential Revision: https://phabricator.services.mozilla.com/D163157
2022-12-13 09:14:44 +00:00
Eemeli Aro
f08c01b802 Bug 1804404 - Update l10n documentation due to DTD & .inc removal. r=flod
Differential Revision: https://phabricator.services.mozilla.com/D164047
2022-12-07 11:50:39 +00:00
Greg Tatum
d3921e547e Bug 1685180 - Debug assert Fluent strings where replaced variables are not provided; r=nordzilla
Differential Revision: https://phabricator.services.mozilla.com/D161996
2022-12-01 21:40:56 +00:00
André Bargull
86a29191ae Bug 1792775 - Part 11.1: Update expected test results in non-SpiderMonkey files. r=platform-i18n-reviewers,gregtatum
Differential Revision: https://phabricator.services.mozilla.com/D162707
2022-11-23 17:56:18 +00:00
Noemi Erli
57fbfda9e8 Backed out 16 changesets (bug 1792775) for causing build bustage in TestDateIntervalFormat.cpp CLOSED TREE
Backed out changeset 240681aef215 (bug 1792775)
Backed out changeset e15aea6bb46b (bug 1792775)
Backed out changeset ee9cd4c8d5cd (bug 1792775)
Backed out changeset 0be61a39756f (bug 1792775)
Backed out changeset 7db4fb376f48 (bug 1792775)
Backed out changeset 7009b35a05a0 (bug 1792775)
Backed out changeset 5abc2704004e (bug 1792775)
Backed out changeset 6d76fe50cf35 (bug 1792775)
Backed out changeset d6300cbbf628 (bug 1792775)
Backed out changeset 8f5e0e60d195 (bug 1792775)
Backed out changeset 0b9cf0354dc0 (bug 1792775)
Backed out changeset 7136c85641b7 (bug 1792775)
Backed out changeset 486778427d64 (bug 1792775)
Backed out changeset 7acee89c2699 (bug 1792775)
Backed out changeset 654c5f659fed (bug 1792775)
Backed out changeset a60b1bc33f91 (bug 1792775)
2022-11-23 17:18:45 +02:00
André Bargull
0fedffe9f5 Bug 1792775 - Part 11.1: Update expected test results in non-SpiderMonkey files. r=platform-i18n-reviewers,gregtatum
Differential Revision: https://phabricator.services.mozilla.com/D162707
2022-11-23 10:42:45 +00:00
Noemi Erli
d26dc9e9e0 Backed out 13 changesets (bug 1792775) for causing bustages
Backed out changeset f2c8e2200194 (bug 1792775)
Backed out changeset 3392ce042fb6 (bug 1792775)
Backed out changeset f5461baa7c5a (bug 1792775)
Backed out changeset d810c2b2d0bd (bug 1792775)
Backed out changeset af6164024ade (bug 1792775)
Backed out changeset 8c97026ef2b5 (bug 1792775)
Backed out changeset d396bec29ac2 (bug 1792775)
Backed out changeset a9aaa2387313 (bug 1792775)
Backed out changeset a4461db138b7 (bug 1792775)
Backed out changeset a7b39a5105a9 (bug 1792775)
Backed out changeset 5e746d85926a (bug 1792775)
Backed out changeset 3ea531c10813 (bug 1792775)
Backed out changeset 78811cdadd63 (bug 1792775)
2022-11-23 11:48:28 +02:00
André Bargull
995289f140 Bug 1792775 - Part 11.1: Update expected test results in non-SpiderMonkey files. r=platform-i18n-reviewers,gregtatum
Differential Revision: https://phabricator.services.mozilla.com/D162707
2022-11-23 08:43:23 +00:00
Butkovits Atila
6ded0f39e9 Backed out 2 changesets (bug 1685180) for causing Xpcshell failures at test_l10nCache.js. CLOSED TREE
Backed out changeset c05d7c567c19 (bug 1685180)
Backed out changeset be4603eff17c (bug 1685180)
2022-11-21 19:51:30 +02:00
Greg Tatum
be1aa4d51d Bug 1685180 - Debug assert Fluent strings where replaced variables are not provided; r=nordzilla
Differential Revision: https://phabricator.services.mozilla.com/D161996
2022-11-21 16:14:06 +00:00
Sylvestre Ledru
97f4c646c8 Bug 1801196 - remove unused crates r=xpcom-reviewers,nika,gregtatum
Differential Revision: https://phabricator.services.mozilla.com/D162334
2022-11-18 16:31:05 +00:00
Greg Tatum
24751e2521 Bug 1755216 - Vendor in fluent-fallback@0.7.0; r=nordzilla
Depends on D161733

Differential Revision: https://phabricator.services.mozilla.com/D161734
2022-11-17 16:00:17 +00:00
Csoregi Natalia
9550c6467f Bug 1800902 - Fix trailing whitespace. r=fix CLOSED TREE 2022-11-17 15:28:47 +02:00
Francesco Lodolo (:flod)
3c01cd430a Bug 1800902 - Remove comm-central from cross-channel generation, r=eemeli DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D162201
2022-11-17 12:11:40 +00:00
Greg Tatum
0f321c2172 Bug 1773733 - Remove some commented out code in l10n-registry; r=nordzilla
Depends on D159715

Differential Revision: https://phabricator.services.mozilla.com/D159716
2022-10-19 21:17:33 +00:00
Greg Tatum
4299b58786 Bug 1773733 - Add a README.md for l10nregistry-rs; r=nordzilla
Depends on D159714

Differential Revision: https://phabricator.services.mozilla.com/D159715
2022-10-19 21:17:32 +00:00
Greg Tatum
caa67f36e3 Bug 1773733 - Add a fuzzing test for the l10nregistry; r=nordzilla
Depends on D159446

Differential Revision: https://phabricator.services.mozilla.com/D159714
2022-10-19 21:17:32 +00:00
Greg Tatum
f0ed9daad0 Bug 1773733 - Remove locking and add a MetaSources struct; r=nordzilla
I believe the crashes are due to the metasources list being mutated
while the async iterators are running. This changes should fix this
issue if it is in fact the root cause. The scope of this patch is a bit
larger since it changes the implementation to use a proper MetaSources
struct.

This struct centralizes access and mutation to the MetaSources,
providing an ergonomic API that should be fairly idiomatic and similar
to other Rust APIs.

The Mutex is not needed as this code is not multi-threaded. The RefCell
should provide proper access controls for handling the mutation of the
MetaSources.

The MetaSources struct also favors a Vec<Vec<Rc<T>>> rather than
Vec<Vec<T>> so that it can be copied very cheaply for the async
iterators.

Differential Revision: https://phabricator.services.mozilla.com/D159446
2022-10-19 21:17:32 +00:00
Greg Tatum
e055b8e94a Bug 1773733 - Add a bit more documentation to various pieces of the L10nRegistry; r=nordzilla
Differential Revision: https://phabricator.services.mozilla.com/D159445
2022-10-19 21:17:31 +00:00
Greg Tatum
1a8e733b51 Bug 1773733 - Rename L10nRegistry methods to be consistent and idiomatic; r=nordzilla
Differential Revision: https://phabricator.services.mozilla.com/D159444
2022-10-19 21:17:31 +00:00
Greg Tatum
79cc2c219c Bug 1773733 - Re-work and document the L10nRegistry bundle algorithm; r=nordzilla
This is probably the riskiest patch in the group, as it's touching the
core async iterator algorithm. The previous implementation relied on
pure match branches for handling things, but it made it awkward to share
some of the logic with a macro. I kept on running into issues with
refactoring tools not being able to work on the macro.

The changes here makes the code a bit more imperative, but I added
documentation of the current state that thing are in, so that it's
clearer where we were in the process of the algorithm.

This is a pure refactor and should not have any behavior changes.

Differential Revision: https://phabricator.services.mozilla.com/D159443
2022-10-19 21:17:30 +00:00
Greg Tatum
6c32be54a6 Bug 1773733 - Remove the bundle_adapter from the L10nRegistryLocked; r=nordzilla
This is a bit of chore work, as the upcoming MetaSources struct will not
need access to this member, and it's simpler without it.

Differential Revision: https://phabricator.services.mozilla.com/D159442
2022-10-19 21:17:30 +00:00
Greg Tatum
8dc7797215 Bug 1773733 - Fill in reasons for unreachable panics; r=nordzilla
Differential Revision: https://phabricator.services.mozilla.com/D159441
2022-10-19 21:17:29 +00:00
Greg Tatum
6b697478cc Bug 1773733 - Rename generate_sources_for_file to get_sources_for_resource; r=nordzilla
Differential Revision: https://phabricator.services.mozilla.com/D159440
2022-10-19 21:17:29 +00:00
Greg Tatum
22a6e7c007 Bug 1773733 - Mark test-only methods as cfg(test); r=nordzilla
Differential Revision: https://phabricator.services.mozilla.com/D159439
2022-10-19 21:17:29 +00:00
Greg Tatum
75cddf17e6 Bug 1773733 - Rename get_source to file_source_by_name; r=nordzilla
Depends on D159437

Differential Revision: https://phabricator.services.mozilla.com/D159438
2022-10-19 21:17:28 +00:00
Greg Tatum
f5418b7733 Bug 1773733 - Rename set_adapt_bundle to set_bundle_adapter; r=nordzilla
Differential Revision: https://phabricator.services.mozilla.com/D159437
2022-10-19 21:17:28 +00:00
Mark Banner
2ffde1e92f Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Andrew McCreight
566e2d6cec Bug 1792920, part 1 - Remove the unused return values for various Rust AddRef and Release methods. r=necko-reviewers,platform-i18n-reviewers,gregtatum,valentin
Rust's definition of nsrefcnt is incorrect, so I'm eliminating uses of it
where possible. Nobody actually uses these return values, so remove them.

Differential Revision: https://phabricator.services.mozilla.com/D159320
2022-10-17 16:09:20 +00:00
Nika Layzell
3d9a6d0374 Bug 1789902 - Part 2: Use XPCOM static components instead of Services in Rust, r=xpcom-reviewers,necko-reviewers,barret,valentin
Differential Revision: https://phabricator.services.mozilla.com/D156891
2022-09-13 13:47:13 +00:00
justchen1369
4743055749 Bug 1789765 - Fix broken links to 'Fluent for Firefox Developers' page. r=firefox-source-docs-reviewers,marco DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D156761
2022-09-08 19:03:25 +00:00
Mike Hommey
0e59ca6e3c Bug 1789524 - Use drop(Box::from_raw). r=platform-i18n-reviewers,dminor
As of rustc 1.64, Box::from_raw is #[must_use].

Differential Revision: https://phabricator.services.mozilla.com/D156617
2022-09-07 20:48:02 +00:00
Olli Pettay
93acdfad59 Bug 1777574, automate CC zone handling, r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D155084
2022-09-07 11:22:51 +00:00
Bobby Holley
f7234adda2 Bug 1787306 - Upgrade serial_test to 0.6 to leverage Embark's audit. r=supply-chain-reviewers,nika
This unfortunately pulls in rustversion but it was easy enough to audit.

Differential Revision: https://phabricator.services.mozilla.com/D155641
2022-08-26 04:06:55 +00:00
criss
055a8632de Backed out 6 changesets (bug 1787306) for causing Toolchains bustages. CLOSED TREE
Backed out changeset bcee96aa7df1 (bug 1787306)
Backed out changeset b5be37b86b21 (bug 1787306)
Backed out changeset 7e518de15dbb (bug 1787306)
Backed out changeset 07d938340e27 (bug 1787306)
Backed out changeset 9b8971442df5 (bug 1787306)
Backed out changeset 4d719c2b2711 (bug 1787306)
2022-08-26 02:25:46 +03:00