Commit Graph

1162 Commits

Author SHA1 Message Date
Sylvestre Ledru
038bd866b5 Bug 1601612 - Fix some py2/py3 lints with a newer version of Python r=marco
Differential Revision: https://phabricator.services.mozilla.com/D57509

--HG--
extra : moz-landing-system : lando
2019-12-17 19:17:43 +00:00
Sylvestre Ledru
08e2e04f2a Bug 1604079 - Add a unit test for mozlint yamllint r=ahal
+ some python 3 changes

Differential Revision: https://phabricator.services.mozilla.com/D57263

--HG--
extra : moz-landing-system : lando
2019-12-17 16:57:25 +00:00
Emily McMinn
9271624bf9 Bug 1575658 - Moved firefox-wordmark.svg to browser/branding r=MattN,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D44235

--HG--
rename : browser/components/newtab/data/content/assets/firefox-wordmark.svg => browser/branding/aurora/content/firefox-wordmark.svg
rename : browser/components/newtab/data/content/assets/firefox-wordmark.svg => browser/branding/nightly/content/firefox-wordmark.svg
rename : browser/components/newtab/data/content/assets/firefox-wordmark.svg => browser/branding/official/content/firefox-wordmark.svg
extra : moz-landing-system : lando
2019-12-10 21:08:57 +00:00
Thomas Nguyen
9fa06727dd Bug 1600883 - Enable Feature Policy allow attribute and permission delegation by default r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D55627

--HG--
extra : moz-landing-system : lando
2019-12-13 07:00:28 +00:00
Tom Prince
0973afdc03 Bug 1596775: Update license headers; r=glandium
parse_pbzx.py appears to be from
https://gist.github.com/pudquick/ac29c8c19432f2d200d4 which does not have a
license.

Differential Revision: https://phabricator.services.mozilla.com/D55327

--HG--
extra : moz-landing-system : lando
2019-12-13 04:03:18 +00:00
Megha
08ae52fe49 Bug 1556380 - Enable more ESLint rules for extensions/. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D43355

--HG--
extra : moz-landing-system : lando
2019-12-06 21:05:20 +00:00
Mark Banner
8365798b9c Bug 1601681 - Re-enable unix-line endings on ESLint controlled files. r=mossop
This was accidentally regressed to match existing line endings in the switch to prettier.

Differential Revision: https://phabricator.services.mozilla.com/D55991

--HG--
extra : moz-landing-system : lando
2019-12-11 08:12:57 +00:00
Andrew Halberstadt
4e51876f56 Bug 1600904 - [lint.yaml] Fix Python 3 related error and the issues that snuck in because of it, r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D55798

--HG--
extra : moz-landing-system : lando
2019-12-10 19:18:31 +00:00
Gregory Mierzwinski
ef26668a1c Bug 1587080 - Part 2: Integrate perfdocs into mozlint. r=ahal
This patch integrates the performance documentation (perfdocs) verification into mozlint. It can be used with `./mach lint -l perfdocs`.

Depends on D53647

Differential Revision: https://phabricator.services.mozilla.com/D53648

--HG--
extra : moz-landing-system : lando
2019-12-10 17:04:33 +00:00
alexandru.ionescu
9f6b4ddb80 Bug 1587080 - Part 1: Add performance documentation verification code. r=ahal,perftest-reviewers,alexandru.irimovici,octavian_negru
This patch adds the performance documentation (perfdocs) verification code under `tools/lint/perfdocs`. This tool currently validates `perfdocs` folders found within the `testing` folder to ensure all performance tests have documentation (it only does this for raptor at the moment). See `tools/lint/docs/perfdocs.rst` for more details.

Differential Revision: https://phabricator.services.mozilla.com/D53647

--HG--
extra : moz-landing-system : lando
2019-12-10 17:04:35 +00:00
Noemi Erli
72d7d8ff5e Backed out 4 changesets (bug 1587080) for causing perfdocs Lint failure CLOSED TREE
Backed out changeset 254fd0c3af4a (bug 1587080)
Backed out changeset 34efe80bfd61 (bug 1587080)
Backed out changeset 4a552742b1cd (bug 1587080)
Backed out changeset 22afcb56e8ea (bug 1587080)
2019-12-10 19:01:07 +02:00
Gregory Mierzwinski
24aaeb8461 Bug 1587080 - Part 2: Integrate perfdocs into mozlint. r=ahal
This patch integrates the performance documentation (perfdocs) verification into mozlint. It can be used with `./mach lint -l perfdocs`.

Depends on D53647

Differential Revision: https://phabricator.services.mozilla.com/D53648

--HG--
extra : moz-landing-system : lando
2019-12-10 15:29:06 +00:00
alexandru.ionescu
bb9728552a Bug 1587080 - Part 1: Add performance documentation verification code. r=ahal,perftest-reviewers,alexandru.irimovici,octavian_negru
This patch adds the performance documentation (perfdocs) verification code under `tools/lint/perfdocs`. This tool currently validates `perfdocs` folders found within the `testing` folder to ensure all performance tests have documentation (it only does this for raptor at the moment). See `tools/lint/docs/perfdocs.rst` for more details.

Differential Revision: https://phabricator.services.mozilla.com/D53647

--HG--
extra : moz-landing-system : lando
2019-12-10 15:29:03 +00:00
Mark Banner
426ca4b45f Bug 1602066 - For ESLint, treat all xhtml files as xml files for parsing when we're looking for script tags. r=bgrins
This helps finding globals for files as we can find out more information about the scripts they include.

Differential Revision: https://phabricator.services.mozilla.com/D56325

--HG--
extra : moz-landing-system : lando
2019-12-09 17:43:42 +00:00
Kris Maglione
64dd29e2b8 Bug 1596918: Part 2 - Add ESLint support for SpecialPowers.spawn globals. r=Standard8
This patch updates the existing ContentTask.spawn rule to do similar things
for SpecialPowers.spawn calls, only with a slightly different set of globals.

Differential Revision: https://phabricator.services.mozilla.com/D53739

--HG--
extra : moz-landing-system : lando
2019-12-07 18:44:33 +00:00
Sylvestre Ledru
7a6b62a3bf No bug - In the coding style, explain how to auto-add missing braces r=sg
Differential Revision: https://phabricator.services.mozilla.com/D56293

--HG--
extra : moz-landing-system : lando
2019-12-07 11:41:21 +00:00
Daniel Varga
84a601a6d4 Backed out 17 changesets (bug 1596918) for multiple browser-chrome and dev-tools failures. On a CLOSED TREE
Backed out changeset ab87d2c1afae (bug 1596918)
Backed out changeset 775f3b06a687 (bug 1596918)
Backed out changeset 67cc63ef5d7f (bug 1596918)
Backed out changeset 7d290bcd2067 (bug 1596918)
Backed out changeset 048db9f4db7c (bug 1596918)
Backed out changeset 96a79d2ba614 (bug 1596918)
Backed out changeset be770d112dd8 (bug 1596918)
Backed out changeset 302c8ab8391c (bug 1596918)
Backed out changeset 44ef8f20732e (bug 1596918)
Backed out changeset 38c11ebfb8ff (bug 1596918)
Backed out changeset b586fc081374 (bug 1596918)
Backed out changeset 12283166716f (bug 1596918)
Backed out changeset 99b0421015d8 (bug 1596918)
Backed out changeset 97ec49dbbbf3 (bug 1596918)
Backed out changeset ec79478f58f1 (bug 1596918)
Backed out changeset c6d356833bb8 (bug 1596918)
Backed out changeset 5ef6026806c8 (bug 1596918)
2019-12-07 03:12:07 +02:00
Kris Maglione
37df64fb9f Bug 1596918: Part 2 - Add ESLint support for SpecialPowers.spawn globals. r=Standard8
This patch updates the existing ContentTask.spawn rule to do similar things
for SpecialPowers.spawn calls, only with a slightly different set of globals.

Differential Revision: https://phabricator.services.mozilla.com/D53739

--HG--
extra : moz-landing-system : lando
2019-12-06 22:13:59 +00:00
Sean Feng
93f9021bb1 Bug 1589700 - Record the number of unique site origins across all tabs r=smaug,agi,Dexter
Differential Revision: https://phabricator.services.mozilla.com/D54027

--HG--
extra : moz-landing-system : lando
2019-12-05 23:13:24 +00:00
Razvan Maries
ef51899325 Backed out changeset 52af8765cb21 (bug 1589700) for perma fails on browser_Telemetry_numberOfSiteOrigins.js. CLOSED TREE 2019-12-04 23:48:27 +02:00
Sean Feng
0dea348f20 Bug 1589700 - Record the number of unique site origins across all tabs r=smaug,agi,Dexter
Differential Revision: https://phabricator.services.mozilla.com/D54027

--HG--
extra : moz-landing-system : lando
2019-12-04 19:39:18 +00:00
Nicolas Chevobbe
bb864342f1 Bug 1529917 - Remove VariablesViewController.jsm. r=miker.
It isn't used anywhere, so we can safely remove it.

Differential Revision: https://phabricator.services.mozilla.com/D54733

--HG--
extra : moz-landing-system : lando
2019-12-04 07:30:08 +00:00
Brindusan Cristian
eaecab785f Backed out 2 changesets (bug 1529917, bug 1591874) for ESlint failure on VariablesView.jsm. CLOSED TREE
Backed out changeset a7f97f586d04 (bug 1591874)
Backed out changeset acbd48303fb3 (bug 1529917)

--HG--
rename : devtools/client/storage/VariablesView.jsm => devtools/client/shared/widgets/VariablesView.jsm
2019-12-03 19:20:19 +02:00
Nicolas Chevobbe
84cd17ec36 Bug 1529917 - Remove VariablesViewController.jsm. r=miker.
It isn't used anywhere, so we can safely remove it.

Differential Revision: https://phabricator.services.mozilla.com/D54733

--HG--
extra : rebase_source : 328156c04a78f6be3cba7cd390b2ab4aa17ebc2f
2019-12-03 16:12:16 +01:00
Mihai Alexandru Michis
26c821546b Backed out 2 changesets (bug 1529917, bug 1591874) for causing build bustages in VariablesView.jsm CLOSED TREE
Backed out changeset faeca320475a (bug 1591874)
Backed out changeset 9fbb57c24aa0 (bug 1529917)
2019-12-03 17:16:53 +02:00
Nicolas Chevobbe
49f07f54d8 Bug 1529917 - Remove VariablesViewController.jsm. r=miker.
It isn't used anywhere, so we can safely remove it.

Differential Revision: https://phabricator.services.mozilla.com/D54733

--HG--
extra : moz-landing-system : lando
2019-12-03 15:12:16 +00:00
Sylvestre Ledru
0371facbd6 Bug 1600555 - excludes => exclude r=marco
Differential Revision: https://phabricator.services.mozilla.com/D55658

--HG--
extra : moz-landing-system : lando
2019-12-03 14:12:10 +00:00
Sylvestre Ledru
7272d60c44 Bug 1579845 - Add a test to the mozlint check: codespell r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D45446

--HG--
extra : moz-landing-system : lando
2019-12-03 14:00:49 +00:00
Mihai Alexandru Michis
b518e576cf Backed out 2 changesets (bug 1529917, bug 1591874) for causing bustages in VariablesView.jsm CLOSED TREE
Backed out changeset 0b5282256e00 (bug 1591874)
Backed out changeset 5f8829083bfc (bug 1529917)
2019-12-03 15:16:14 +02:00
Nicolas Chevobbe
0681dfe765 Bug 1529917 - Remove VariablesViewController.jsm. r=miker.
It isn't used anywhere, so we can safely remove it.

Differential Revision: https://phabricator.services.mozilla.com/D54733

--HG--
extra : moz-landing-system : lando
2019-12-03 11:11:56 +00:00
Simon Giesecke
7cee812af2 Bug 1600885 - Remove redundant formatting instructions from C++ coding style. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D55619

--HG--
extra : moz-landing-system : lando
2019-12-03 10:39:45 +00:00
Narcis Beleuzu
db6b5c1e00 Backed out 2 changesets (bug 1529917, bug 1591874) for build bustages on storage/moz.build . CLOSED TREE
Backed out changeset 6dc649a6a711 (bug 1591874)
Backed out changeset 9301bdb66fb4 (bug 1529917)
2019-12-03 12:24:07 +02:00
Nicolas Chevobbe
c632d39c32 Bug 1529917 - Remove VariablesViewController.jsm. r=miker.
It isn't used anywhere, so we can safely remove it.

Differential Revision: https://phabricator.services.mozilla.com/D54733

--HG--
extra : moz-landing-system : lando
2019-12-03 10:10:13 +00:00
Sylvestre Ledru
4f4f4cc897 no bug - Reduce the maxdepth on the linting doc r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D55426

--HG--
extra : moz-landing-system : lando
2019-12-02 17:30:07 +00:00
Gabriele Svelto
d0e4d2c6c2 Bug 1420363 - Write crash annotations as JSON r=froydnj,agi
This patch rolls up all the required changes for this purpose. Since the
whole crash reporting flow must understand the new format it's not possible
to land this as separate patches as individually they would be broken. This
patch includes the following changes:

* Changes to the crash reporting machinery to write out annotations as JSON,
  these includes changes to the DLL blocklist code that must be run at crash
  time.
* Modifications to the crash reporter client so that it can read and
  submit the new format; this includes platform-specific changes to the
  Breakpad libraries it uses for submitting crashes.
* Modifications to the minidump-analyzer to understand and process the new
  format correctly.
* Modifications to the crash manager to understand and process the new format
  correctly.
* Modifications to GeckoView's crash handler to understand and submit the
  new format correctly.
* Added new tests to cover the new format and modified existing ones to
  accomodate the new one.

Differential Revision: https://phabricator.services.mozilla.com/D46848

--HG--
extra : moz-landing-system : lando
2019-12-02 13:18:35 +00:00
championshuttler
df392eec65 Bug 1569472 - Remove toolkit/components/telemetry/docs from exclude list of RST linter. r=sylvestre
Depends on D55418

Differential Revision: https://phabricator.services.mozilla.com/D55419

--HG--
extra : moz-landing-system : lando
2019-12-02 10:12:27 +00:00
Emilio Cobos Álvarez
0ff42b5218 Bug 1600155 - Remove StyleSheet{Added,Removed} and StyleRule{Added,Removed,Changed} events. r=heycam,smaug
They're only used by tests, and are not exposed.

Differential Revision: https://phabricator.services.mozilla.com/D55185

--HG--
extra : moz-landing-system : lando
2019-11-30 12:24:32 +00:00
Sylvestre Ledru
09ed42e0fd Bug 1600361 - Move the static analysis doc in tree r=andi
+ add a thing about coding style

Differential Revision: https://phabricator.services.mozilla.com/D55345

--HG--
extra : moz-landing-system : lando
2019-11-30 10:18:37 +00:00
Sylvestre Ledru
8f7a2f7386 Bug 1599749 - Reference prettier from the JS coding style page r=vporof
Depends on D54933

Differential Revision: https://phabricator.services.mozilla.com/D54934

--HG--
extra : moz-landing-system : lando
2019-11-30 04:39:16 +00:00
Sylvestre Ledru
a9ea8049fd Bug 1599749 - Reference black&flake8 from the Python coding style page r=ahal
Depends on D54934

Differential Revision: https://phabricator.services.mozilla.com/D54935

--HG--
extra : moz-landing-system : lando
2019-11-29 18:43:40 +00:00
Sylvestre Ledru
fbac4969b4 Bug 1599749 - Rename coding_style.rst to coding_style_cpp.rst r=sg
Differential Revision: https://phabricator.services.mozilla.com/D55104

--HG--
rename : tools/lint/docs/coding-style/coding_style.rst => tools/lint/docs/coding-style/coding_style_cpp.rst
extra : moz-landing-system : lando
2019-11-28 12:58:40 +00:00
Sylvestre Ledru
a52c67fc4b Bug 1599749 - Improve the display of the C++ coding style page r=sg
Depends on D54932

Differential Revision: https://phabricator.services.mozilla.com/D54933

--HG--
extra : moz-landing-system : lando
2019-11-28 12:58:40 +00:00
Sylvestre Ledru
a5f1bb6a23 Bug 1599749 - Split the coding style documentation into different files r=sg
Differential Revision: https://phabricator.services.mozilla.com/D54931

--HG--
extra : moz-landing-system : lando
2019-11-28 12:58:25 +00:00
Olli Pettay
c6003cd98a Bug 1596763 - Remove unused ParentSHistory, r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D53190

--HG--
extra : moz-landing-system : lando
2019-11-27 10:36:32 +00:00
Julian Descottes
3c6458633a Bug 1598557 - Move all BrowserToolbox files to a dedicated folder r=ochameau
Depends on D54119

Differential Revision: https://phabricator.services.mozilla.com/D54265

--HG--
rename : devtools/client/framework/ToolboxProcess.jsm => devtools/client/framework/browser-toolbox/Launcher.jsm
rename : devtools/client/framework/test/browser_browser_toolbox.js => devtools/client/framework/browser-toolbox/test/browser_browser_toolbox.js
rename : devtools/client/framework/test/browser_browser_toolbox_debugger.js => devtools/client/framework/browser-toolbox/test/browser_browser_toolbox_debugger.js
rename : devtools/client/framework/test/browser_browser_toolbox_fission_inspector.js => devtools/client/framework/browser-toolbox/test/browser_browser_toolbox_fission_inspector.js
rename : devtools/client/framework/test/browser_browser_toolbox_rtl.js => devtools/client/framework/browser-toolbox/test/browser_browser_toolbox_rtl.js
rename : devtools/client/framework/test/helpers.js => devtools/client/framework/browser-toolbox/test/helpers-browser-toolbox.js
rename : devtools/client/framework/toolbox-process-window.css => devtools/client/framework/browser-toolbox/window.css
rename : devtools/client/framework/toolbox-process-window.html => devtools/client/framework/browser-toolbox/window.html
rename : devtools/client/framework/toolbox-process-window.js => devtools/client/framework/browser-toolbox/window.js
extra : moz-landing-system : lando
2019-11-27 11:08:11 +00:00
championshuttler
a45acd4a52 Bug 1569472 - Remove toolkit/components/extensions from exclude list of rst linter. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D54062

--HG--
extra : moz-landing-system : lando
2019-11-26 19:28:49 +00:00
Sylvestre Ledru
948d330640 Bug 1596911 - refresh the ignore list with the new exts r=Gijs
Depends on D53266

Differential Revision: https://phabricator.services.mozilla.com/D54171

--HG--
extra : moz-landing-system : lando
2019-11-26 15:02:02 +00:00
Sylvestre Ledru
4056ec2363 Bug 1596911 - Activate the license lint on more extensions r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D53266

--HG--
extra : moz-landing-system : lando
2019-11-26 14:59:31 +00:00
Sylvestre Ledru
df4066dd02 Bug 1598971 - Enable codespell on more directories r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D54430

--HG--
extra : moz-landing-system : lando
2019-11-25 20:08:17 +00:00
Sylvestre Ledru
5417332694 Bug 1598615 - Ride along: explain how to run the mozlint tests r=ahal
Depends on D54499

Differential Revision: https://phabricator.services.mozilla.com/D54517

--HG--
extra : moz-landing-system : lando
2019-11-25 20:09:33 +00:00