Commit Graph

645777 Commits

Author SHA1 Message Date
Brindusan Cristian
c298fe167e Backed out changeset 1ea4b3582033 (bug 760345) for build bustages at ia2AccessibleComponent.cpp. 2019-04-05 07:49:09 +03:00
Botond Ballo
67196d833b Bug 1531962 - Add a unit test harness for MobileViewportManager. r=kats
The harness contains an initial test case for bug 1536755.

Differential Revision: https://phabricator.services.mozilla.com/D26247

--HG--
extra : moz-landing-system : lando
2019-04-04 22:10:27 +00:00
Botond Ballo
fbb1036cee Bug 1531962 - Extract an MVMContext interface used by MobileViewportManager to interact with its surroundings. r=kats
Differential Revision: https://phabricator.services.mozilla.com/D26246

--HG--
extra : moz-landing-system : lando
2019-04-04 22:11:40 +00:00
Botond Ballo
2cb0da3cd1 Bug 1531962 - Avoid including MobileViewportManager.h from nsIPresShell.h. r=kats
nsIPresShell.h is widely included, so this avoids excessively long rebuilds
when MobileViewportManager.h is modified.

Differential Revision: https://phabricator.services.mozilla.com/D26245

--HG--
extra : moz-landing-system : lando
2019-04-04 22:09:55 +00:00
Samuel Thibault
81cc6f4467 Bug 1541457: atk: When watching for toplevel windows to manage as native root accessibles, Also look for refined roles of dialog boxes. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D26181

--HG--
extra : moz-landing-system : lando
2019-04-04 22:50:21 +00:00
James Teh
8810a3c233 Bug 1540918: When a panel is opened from the toolbar via the keyboard, restore focus to the toolbar button when the panel is closed. r=Gijs
Toolbar buttons are only made focusable when accessed via the keyboard.
As soon as they lose focus, their focusability is removed.
This is done so that clicking them doesn't focus them.
Previously, this meant that if a panel opened, focus couldn't be restored to the button like it should be when the panel was closed, as the button was no longer focusable.
To work around this, use the open="true" attribute set on the button when the panel opens.
If this is detected when the button loses focus, focusability is not removed.
Once focus is restored after the panel closes, things continue as normal.
That is, when the button loses focus for some other reason, its focusability is removed.

Differential Revision: https://phabricator.services.mozilla.com/D26073

--HG--
extra : moz-landing-system : lando
2019-04-04 17:04:18 +00:00
Emilio Cobos Álvarez
993731e44b Bug 760345 - Remove the last usage of lossy currentcolor. r=heycam
We don't have lossy currentcolor in the style system anymore, except for a
single property -moz-font-smoothing-background-color.

I could've converted it into a proper StyleColor and thread down all the
necessary information to the font metrics code.

But it doesn't really seem worth it given it's not exposed to the web, so I just
did the simplest thing, which is making currentcolor compute to transparent to
that specific property.

This patch also removes the stores_complex_colors_lossily code and related,
since now we always can cache computed colors.

Differential Revision: https://phabricator.services.mozilla.com/D26187

--HG--
extra : moz-landing-system : lando
2019-04-04 22:06:03 +00:00
Gijs Kruitbosch
0e774ff83f Bug 1541958 - remove nsIUserInfo which is unused, r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D26212

--HG--
extra : moz-landing-system : lando
2019-04-04 20:09:34 +00:00
Gijs Kruitbosch
abcec64af8 Bug 1541377 - add contentPane class to allow the site data settings dialog to scroll when the window height is constrained, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D26195

--HG--
extra : moz-landing-system : lando
2019-04-04 19:05:10 +00:00
Makoto Kato
20f0f47eda Bug 1539827 - Use cmd_selectAll instead of nsISelectionController.selectAll on action bar r=geckoview-reviewers,esawin
After bug 676268 is landed, Gecko/Android supports `text/html` mime type on
clipboard. But copy command is sometimes failed after select all is executed.

`nsISelectionContoller.selectAll` is different of `cmd_selectAll`.
Since `cmd_selectAll` that is used on Firefox desktop doesn't select root
element, copy command always works well. So we should use it like desktop
browser on Fennec.

Also, GV already uses cmd_selectAll on action bar, so this is Fennec only.

Differential Revision: https://phabricator.services.mozilla.com/D25924

--HG--
extra : moz-landing-system : lando
2019-04-03 15:15:03 +00:00
David Walsh
742034f638 Bug 1542008 - Update flow config so flow runs locally r=loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D26220

--HG--
extra : moz-landing-system : lando
2019-04-04 23:45:07 +00:00
Ting-Yu Lin
a331856c45 Bug 1516963 - Make grid, flex, etc. be a selection target themselves if they contain no selectable children. r=emilio
Exclude replaced frame likes image frames otherwise
editor/libeditor/tests/test_abs_positioner_positioning_elements.html
will break.

Differential Revision: https://phabricator.services.mozilla.com/D26049

--HG--
extra : moz-landing-system : lando
2019-04-05 00:04:32 +00:00
Brindusan Cristian
655cd99db5 Backed out 2 changesets (bug 1540170) for xpcshell failures at test_sanitizer.js. CLOSED TREE
Backed out changeset a13bf582f195 (bug 1540170)
Backed out changeset b5ed3294a9d7 (bug 1540170)
2019-04-05 06:23:23 +03:00
Narcis Beleuzu
ed1878b2ce Backed out 4 changesets (bug 1541684) for bustages on xpcprivate.h . CLOSED TREE
Backed out changeset b021ea89cf04 (bug 1541684)
Backed out changeset 16d5f0b792d4 (bug 1541684)
Backed out changeset a37029984f13 (bug 1541684)
Backed out changeset 900f639d72a3 (bug 1541684)
2019-04-05 03:57:09 +03:00
Daosheng Mu
4be669f520 Bug 1540590 - Moving VRManager::Shutdown() task to Compositor thread to avoid race conditions. r=kip
Differential Revision: https://phabricator.services.mozilla.com/D25829

--HG--
extra : moz-landing-system : lando
2019-04-04 18:35:02 +00:00
Nathan Froyd
0273818ea0 Bug 1542048 - mark aarch64 unix's PrepareAndDispatch as used; r=mccr8
Otherwise, LTO will eliminate it because the compiler can't see the
calls to PrepareAndDispatch from the relevant assembly file.

Differential Revision: https://phabricator.services.mozilla.com/D26244

--HG--
extra : moz-landing-system : lando
2019-04-04 21:13:47 +00:00
Nathan Froyd
3cb7a40d1f Bug 1538236 - fix LTO issues with arm xptcstubs; r=mccr8
ARM's xptcstubs use a slightly different setup for PrepareAndDispatch
than...well, all of our other stubs.  This difference appears to be
causing problems with LTO builds.  Change the setup to be more like our
other stubs, which additionally gets rid of some of the `asm` nonsense.

Differential Revision: https://phabricator.services.mozilla.com/D26243

--HG--
extra : moz-landing-system : lando
2019-04-04 21:14:18 +00:00
Liang-Heng Chen
b56c857b8e Bug 1533363 - Part 2: Add HTTP Traffic category Telemetry; r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D25135

--HG--
extra : moz-landing-system : lando
2019-04-04 21:36:39 +00:00
Liang-Heng Chen
87aef68061 Bug 1533363 - Part 1: Add HttpTrafficAnalyzer service; r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D24517

--HG--
extra : moz-landing-system : lando
2019-04-04 21:38:28 +00:00
Gijs Kruitbosch
8833331cd2 Bug 1540170 - release assert if something tries to start the history service before profile startup, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D24910

--HG--
extra : moz-landing-system : lando
2019-04-04 23:05:23 +00:00
Gijs Kruitbosch
13ff7ba935 Bug 1540170 - don't use history for windowless browsers, r=farre
Differential Revision: https://phabricator.services.mozilla.com/D25587

--HG--
extra : moz-landing-system : lando
2019-04-04 23:05:25 +00:00
Dave Townsend
332067407d Bug 1539820: Fix test_claim_locked.js to work with dev-edition. r=Gijs
The original name of the profile is irrelevant here since we aren't testing
a migration to profiles-per-install. On dev-edition DEDICATED_NAME is the same
as PROFILE_DEFAULT so we correctly make a new profile with a unique name.

Differential Revision: https://phabricator.services.mozilla.com/D26230

--HG--
extra : moz-landing-system : lando
2019-04-04 21:56:42 +00:00
Dave Townsend
00de7dca50 Bug 1541804: Make profile refresh for non-ascii named profiles work correctly. r=Gijs
This fixes two bugs. The first is that when the firefox profile migrator doesn't
know which profile to migrate it attempts to fall back to another profile. I
think this was intended to be the default but in bug 1322797 I ended up making
it the current profile, which is the profile we're restoring into now. I think
at this stage the profile directory doesn't even exist so things go wrong.
Changing to use the actual default works but....

When the profile migrator UI doesn't know what profile to migrate from it uses
the default profile. So if the profile you're actually trying to restore is not
the default we'll effectively throw its data into the archive and replace it
with data from the default profile. I'm inclined to say that if the migrator
does not know what profile to migrate from it should error at that point for
safety.

Why would the profile migrator not know what profile to migrate from? Because of
a long-standing text encoding problem. In C++ profile names are encoded in UTF8.
But we try to pass them to JS through an IDL parameter of type ACString. This
does no UTF8 decoding and so JS recieves an incorrect name if the name includes
non-ascii characters and so can't find the profile.

This patch fixes the IDL parameter to AUTF8String which does the decoding
correctly and so JS gets the name correctly.

We should probably think about whether just passing the nsIToolkitProfile object
to the migrator is a better choice here.

Differential Revision: https://phabricator.services.mozilla.com/D26250

--HG--
extra : moz-landing-system : lando
2019-04-04 21:53:01 +00:00
Emilio Cobos Álvarez
84eaf99704 Bug 1541925 - Avoid accounting for @font-face rules the style set when there's no pres shell. r=heycam
This preserves the behavior of not having FontFace objects for @font-face rules
in display: none iframes.

Note, however that we may want to always track stylesheets to both not have this
limitation and to fix bug 1471231 & co. But that's a separate bug in any case.

The assertion that is failing ultimately in this bug is not really relevant
anymore, so remove it while at it.

Differential Revision: https://phabricator.services.mozilla.com/D26196

--HG--
extra : moz-landing-system : lando
2019-04-04 21:40:55 +00:00
Carolina Jimenez Gomez
8093499470 Bug 1512505 - Log a message in web console when a site is only supporting TLS 1.0 or 1.1. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D25660

--HG--
extra : moz-landing-system : lando
2019-04-04 23:37:20 +00:00
Emilio Cobos Álvarez
2c6ec66a70 Bug 1540732 - Validate input in InspectorUtils.removeContentState as well. r=smaug
Same as bug 1538732, but I didn't know this api existed at all.

Differential Revision: https://phabricator.services.mozilla.com/D26198

--HG--
extra : moz-landing-system : lando
2019-04-04 21:13:10 +00:00
Andrew McCreight
1a6c8f3740 Bug 1541684, part 4 - Remove nsXPCWrappedJSClass:mDescriptors. r=nika
This field now just caches the IsReflectable() field from the method
info, so get rid of it.

Differential Revision: https://phabricator.services.mozilla.com/D26071

--HG--
extra : moz-landing-system : lando
2019-04-04 21:01:26 +00:00
Andrew McCreight
98dd357c68 Bug 1541684, part 3 - Statically compute if a method is reflectable. r=nika
XPCConvert::IsMethodReflectable() is derived entirely from
nsXPTMethodInfo, so we can compute it at build time and include it in
nsXPTMethodInfo. It is the only use of mNotXPCOM and mHidden, so we
can get rid of those fields at the same time.

This paves the way for getting rid of XPCWrappedJSClass::mDescriptors
in the next patch.

Differential Revision: https://phabricator.services.mozilla.com/D26070

--HG--
extra : moz-landing-system : lando
2019-04-04 21:01:24 +00:00
Andrew McCreight
a838eacb5c Bug 1541684, part 2 - Remove nsXPCWrappedJSClass::mIID. r=nika
This is already stored on mInfo.

Differential Revision: https://phabricator.services.mozilla.com/D26069

--HG--
extra : moz-landing-system : lando
2019-04-04 21:01:22 +00:00
Andrew McCreight
bd9b8350ab Bug 1541684, part 1 - Remove XPCWrappedJSClass::mRuntime. r=bzbarsky
There is only a single XPC JS runtime now, so there's no need to keep a
special pointer around.

Differential Revision: https://phabricator.services.mozilla.com/D26068

--HG--
extra : moz-landing-system : lando
2019-04-04 21:02:15 +00:00
Thomas Wisniewski
3c0b32cd63 Bug 1539916 - Update about:compat to show the proper URL and fix page-refresh glitches; r=kmag
Update about:compat to show the proper URL and fix page-refresh glitches

Differential Revision: https://phabricator.services.mozilla.com/D25487

--HG--
extra : moz-landing-system : lando
2019-04-04 23:47:03 +00:00
Brindusan Cristian
522cfbe7f9 Backed out changeset 5dae6d1b597a (bug 1540150) for [@ libgdk-3.so.0.1800.9 + 0x60a09] crashes in h13 tests. CLOSED TREE
--HG--
extra : histedit_source : 431f554b4dd383748b3f1603b43b8ac5e790e70d
2019-04-05 03:23:12 +03:00
Narcis Beleuzu
24dbe577a5 Backed out changeset 389b6bbd76db (bug 1519636) for bustages on MarkupMap.h . CLOSED TREE 2019-04-05 00:27:56 +03:00
Andrew Halberstadt
2f1869451d Bug 1532747 - Use 'mach python' with repackage.sh script, CLOSED TREE, r=catlee
Differential Revision: https://phabricator.services.mozilla.com/D26239

--HG--
extra : moz-landing-system : lando
2019-04-04 20:35:09 +00:00
Sylvestre Ledru
399dbd28fe Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
2019-04-04 20:12:23 +00:00
Boris Zbarsky
859b7ee389 Bug 1541600 part 3. Stop using AutoJSContext in GetStateObject. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D26225

--HG--
extra : moz-landing-system : lando
2019-04-04 20:01:14 +00:00
Boris Zbarsky
8b2ada715e Bug 1541600 part 2. Stop using AutoJSContext for the slow script dialog. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D26224

--HG--
extra : moz-landing-system : lando
2019-04-04 20:00:36 +00:00
Boris Zbarsky
11f24f599a Bug 1541600 part 1. Stop using AutoJSContext in nsJSEnvironment. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D26222

--HG--
extra : moz-landing-system : lando
2019-04-04 20:00:08 +00:00
Haik Aftandilian
f357396a1e Bug 1541272 - Mac Utility sandbox profile missing crash reporter port allow rule r=Alex_Gaynor
Add the crash reporter port to the utility process sandbox so that crash reports can be saved for processes using the utility sandbox with early sandbox init.

At this time, the RDD process is the only process using the utility sandbox.

Differential Revision: https://phabricator.services.mozilla.com/D26228

--HG--
extra : moz-landing-system : lando
2019-04-04 19:59:25 +00:00
David Walsh
cb2da09956 Bug 1540792 - Show element highlighter when hovering an element in Scopes/Watch Expression/Popup r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D25635

--HG--
extra : moz-landing-system : lando
2019-04-04 15:03:22 +00:00
Zibi Braniecki
54768975b1 Bug 1540085 - Use label.value rather than text content in site data settings UI to use cropping. r=jaws,flod
Differential Revision: https://phabricator.services.mozilla.com/D25692

--HG--
extra : moz-landing-system : lando
2019-04-04 14:14:52 +00:00
Junior Hsu
a7df8024a2 Bug 1524154 - Re-enable flow control for media wpt r=kershaw
Differential Revision: https://phabricator.services.mozilla.com/D25427

--HG--
extra : moz-landing-system : lando
2019-04-01 12:29:27 +00:00
Brian Grinstead
a8732856e7 Bug 1541400 - Reference the scrollButtonDown field from the arrowscrollbox and not tabbrowser-tabs;r=dao
When this handler got changed to an arrow function the reference didn't get
moved onto the scrollbox.

Differential Revision: https://phabricator.services.mozilla.com/D26142

--HG--
extra : moz-landing-system : lando
2019-04-04 14:40:09 +00:00
Matthew Noorenberghe
c79c58538b Bug 1541625 - Don't use an intermediate function for console logging in LoginHelper. r=jaws
This fixes the filename and line number of login manager logs.

This is basically a rebased backout of the LMH portion of changeset b1e3cd7db269.

Differential Revision: https://phabricator.services.mozilla.com/D26023

--HG--
extra : moz-landing-system : lando
2019-04-04 19:05:27 +00:00
meandave
e1d5a28c30 Bug 1532773 - Add player controls for PictureInPicture. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D25435

--HG--
extra : moz-landing-system : lando
2019-04-04 19:04:47 +00:00
Agi Sferro
7409bb591e Bug 1542005 - Fix javadoc error in GeckoSession. r=geckoview-reviewers,rbarker
Differential Revision: https://phabricator.services.mozilla.com/D26219

--HG--
extra : moz-landing-system : lando
2019-04-04 18:56:40 +00:00
Andrew Halberstadt
372e239037 Bug 1195299 - [mozharness] Remove copies of mozbase from testing/mozharness r=catlee
Differential Revision: https://phabricator.services.mozilla.com/D22185

--HG--
extra : moz-landing-system : lando
2019-04-04 12:34:56 +00:00
Andrew Halberstadt
ff9a2ed949 Bug 1195299 - [ci] Use 'mach python' to run mozharness scripts when we have a srcdir r=catlee
This makes sure that the mozharness scripts have access to all the packages in
the build system virtualenv (namely mozbase).

Differential Revision: https://phabricator.services.mozilla.com/D22184

--HG--
extra : moz-landing-system : lando
2019-04-04 18:41:12 +00:00
Emilio Cobos Álvarez
e63fdb7c97 Bug 1541913 - Use rust lengths for outline-offset. r=boris
Depends on D26155

Differential Revision: https://phabricator.services.mozilla.com/D26156

--HG--
extra : moz-landing-system : lando
2019-04-04 18:32:09 +00:00
Emilio Cobos Álvarez
c028706efc Bug 1541913 - Use Servo lengths for column-width. r=boris
Depends on D26154

Differential Revision: https://phabricator.services.mozilla.com/D26155

--HG--
extra : moz-landing-system : lando
2019-04-04 18:29:57 +00:00