759286 Commits

Author SHA1 Message Date
Steve Fink
ef5aead81c Bug 1711413 - Fix marking of nuked weakmap key delegates r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D115750
2021-06-01 17:16:13 +00:00
Yulia Startsev
f288b2e904 Bug 1713615 - Rename WorkerType to WorkerKind; r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D116389
2021-06-01 16:59:50 +00:00
Luca Greco
f7d963b533 Bug 1438663 - Fix browserAction focus test intermittency in browser_ext_popup_focus.js and renable it. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D116019
2021-06-01 16:54:14 +00:00
Yury Delendik
b5ceb69088 Bug 1690492 - Use PBLENDVB for blend operations. r=lth
Differential Revision: https://phabricator.services.mozilla.com/D113582
2021-06-01 16:47:38 +00:00
Alexandre Poirot
653a9b8293 Bug 1713806 - [devtools] Fix lint in browser_aboutdebugging_devtoolstoolbox_splitconsole_key.js. CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D116495
2021-06-01 16:39:09 +00:00
Nicolas Silva
8aa37de340 Bug 1711648 - Move all device rects to the Box2D representations. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D116401
2021-06-01 16:30:36 +00:00
Nicolas Silva
162e431533 Bug 1711648 - Update euclid to 0.22.6. r=gfx-reviewers,jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D116266
2021-06-01 16:30:35 +00:00
Alexandre Poirot
55e05f9618 Bug 1713806 - [devtools] Wait for full loading of the console in browser_aboutdebugging_devtoolstoolbox_splitconsole_key.js. r=jdescottes
Without this, the new pending call to watchResources throws because we close the toolbox while the console still initiates.

Differential Revision: https://phabricator.services.mozilla.com/D116489
2021-06-01 16:09:22 +00:00
Nicolas Chevobbe
c8670bef20 Bug 1713568 - [devtools] Remove testActor#synthesizeKey. r=jdescottes.
Callsites switch to BrowserTestUtils.synthesizeKey.

Differential Revision: https://phabricator.services.mozilla.com/D116394
2021-06-01 14:53:31 +00:00
Nicolas Chevobbe
e52344a990 Bug 1713560 - [devtools] Remove testActor#synthesizeMouse. r=ochameau.
Replace its usage with a helper in shared-head that
scroll to the ndoe matching the selector and then
uses BrowserTestUtils.synthesizeMouse to trigger the
mouse event.

Differential Revision: https://phabricator.services.mozilla.com/D116393
2021-06-01 14:53:30 +00:00
Nicolas Chevobbe
088b36d612 Bug 1713557 - [devtools] Remove testActor#getNumberOfElementMatches. r=jdescottes.
All usage of the methods are replaced with a shared helper
that uses a content task to retrieve the number of elements
on the page.

Differential Revision: https://phabricator.services.mozilla.com/D116341
2021-06-01 14:53:30 +00:00
Luca Greco
665f72549b Bug 1710917 - Introduced internal:svgContextPropertiesAllowed webextension permission. r=dholbert,mixedpuppy
This patch does change the extension-related special case in SVGContextPaint::IsAllowedForImageFromURI
to check the "internal:svgContextPropertiesAllowed" extension permission, and move the existing
criteria in the Extension class (which takes care of adding the internal permission when those
criteria as met).

This patch does not contain yet a new explicit test case for the new internal permission (which is
part of the patch build on top of this one and attached to the same bugzilla issue), but it does
pass the existing mochitest-chrome (test_chrome_ext_svg_context_fill.html).

Differential Revision: https://phabricator.services.mozilla.com/D115835
2021-06-01 14:46:03 +00:00
Lars T Hansen
b2a938a18c Bug 1710024 - Clean up lowering of wasm 'select'. r=yury
This factors out the lowering of wasm select (except for the folded
compare-and-select case which needs more thought) into platform code.
The benefit of doing this is partly to get rid of a platform ifdef in
platform-independent code (this was a hack when Wasm Ion on ARM64 was
being bootstrapped) and partly to loosen up the register constraints
on ARM64, which are overly pessimistic and result in a lot of extra
moves.

This also improves the generated ARM64 code for FP select, using FCSEL
for float/double operations.  There does not seem to be a select
instruction for vector data, but it's likely that vector data would be
selected lane-wise anyway, so here I tie the output register to the
true register and conditionally move the false register into output
using a jump.

Differential Revision: https://phabricator.services.mozilla.com/D116149
2021-06-01 14:28:23 +00:00
Lars T Hansen
6734226373 Bug 1710403 - Lower 0-n and n*-1 as -n for int types. r=nbp
For 0-n with integer n, add specialization in shared lowering code to
lower as LNegI and LNegI64 (a new node type).

For n*-1 with int64 n, add a specialization in shared lowering code to
lower as LNegI64.  The case for int32 was already handled.  (The
specialization for n*-1 that's performed in codegen on some platforms
is now redundant, but that will be cleaned up with bug 1712298.)

These optimizations benefit wasm, as there is no integer negate
operation in the wasm instruction set, one of these cliches will be
used instead.

The lowering for 64-bit is a little easier than for 32-bit since
64-bit subtract/multiply are not fallible.

There's some platform-dependent codegen here because we want to allow
the src and dest registers to differ on arm64 and arm, but to reuse
the input on x86 and x64.  mips64 follows x64, for simplicity.

Drive-by change: The 'reused input index' argument to lowerNegI has no
function and is removed.  (Its value must always be zero because it's
the index of the reused input in the LIR node, not an index in the MIR
node.)

Differential Revision: https://phabricator.services.mozilla.com/D116088
2021-06-01 14:28:22 +00:00
Mark Banner
f8a90a0d94 Bug 1713290 - Update a couple of eBay urls to include www to avoid unnecessary redirects. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D116218
2021-06-01 14:24:35 +00:00
Ben Hearsum
6290622edf No bug: Add helpful suggestion to ./mach taskgraph --diff for some circumstances r=ahal
This helps hint that in some cases, a user may have forgotten to diff
with `-J` if they were changing task bodies/payloads instead of adding
or removing a task.

Differential Revision: https://phabricator.services.mozilla.com/D116384
2021-06-01 14:10:07 +00:00
Sebastian Hengst
12a4669d84 Bug 1713444 - Set test step in RTCRtpSender-replaceTrack.https.html back to passing outside Nightly. r=jgraham DONTBUILD
The test got set to the failing expectation by the expectation update in
bug 1712994.

Differential Revision: https://phabricator.services.mozilla.com/D116409
2021-06-01 14:03:21 +00:00
Jan Varga
f4a3bc258f Bug 1711848 - Add argument separation comments for QM_OR_ELSE(WARN|NOTE|LOG_VERBOSE)(_IF) uses; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D115465
2021-06-01 13:58:27 +00:00
NuriAmari
307c53eb25 Bug 1711878 - Remove unused JSContext arguments from PrintErrorImpl and PrintSingleError. r=mgaudet
Differential Revision: https://phabricator.services.mozilla.com/D115754
2021-06-01 13:56:19 +00:00
Edgar Chen
c80e2f09d3 Bug 1712930 - Part 7: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_BE_OPENED; r=smaug,perftest-reviewers,sparky
Differential Revision: https://phabricator.services.mozilla.com/D116081
2021-06-01 13:10:48 +00:00
Edgar Chen
8effa3808d Bug 1712930 - Part 6: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_SENDING; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D116080
2021-06-01 13:10:48 +00:00
Edgar Chen
b4a690870e Bug 1712930 - Part 5: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_LOADING_OR_DONE_RESPONSE_TYPE; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D116079
2021-06-01 13:10:47 +00:00
Edgar Chen
2f19ad2de5 Bug 1712930 - Part 4: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_LOADING_OR_DONE_OVERRIDE_MIME_TYPE; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D116078
2021-06-01 13:10:47 +00:00
Edgar Chen
79a3f4a3a1 Bug 1712930 - Part 3: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_HAS_WRONG_RESPONSETYPE_FOR_RESPONSEXML; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D116077
2021-06-01 13:10:46 +00:00
Edgar Chen
bededd95ac Bug 1712930 - Part 2: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_HAS_WRONG_RESPONSETYPE_FOR_RESPONSETEXT; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D116076
2021-06-01 13:10:46 +00:00
Edgar Chen
7664189944 Bug 1712930 - Part 1: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_CHUNKED_RESPONSETYPES_UNSUPPORTED_FOR_SYNC; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D116075
2021-06-01 13:10:46 +00:00
Rob Wu
790f81df65 Bug 1697196 - Wait for newtab to have been initialized before proceeding r=rpl
Fix based on the observed error, see https://bugzilla.mozilla.org/show_bug.cgi?id=1697196#c24

Differential Revision: https://phabricator.services.mozilla.com/D116454
2021-06-01 12:55:36 +00:00
Dão Gottwald
0009ec00dd Bug 1712565 - Add amazon.cn to tippytop domains. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D115910
2021-06-01 12:37:50 +00:00
Jan Varga
f7d0092e58 Bug 1711656 - Rename QM_OR_ELSE_LOG to QM_OR_ELSE_LOG_VERBOSE; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D115363
2021-06-01 12:12:27 +00:00
Marco Bonardo
a68324caaf Bug 1713073 - Add new places metadata tables. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D116084
2021-06-01 12:10:00 +00:00
Emilio Cobos Álvarez
2a23f108c0 Bug 1713563 - Fix styling of in-content menulists after bug 1708735. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D116390
2021-06-01 12:09:09 +00:00
Alexandre Poirot
21aafa8249 Bug 1710582 - [devtools] Make refreshTab test helper wait for target switching. r=nchevobbe
navigateTo contains all the logic to wait for panel updates on reload,
as well as wait for the process of the new target.

Differential Revision: https://phabricator.services.mozilla.com/D114828
2021-06-01 11:40:31 +00:00
Emilio Cobos Álvarez
a4b5e6b006 Bug 1713777 - Fix autoscroll background styles after bug 1708735. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D116455
2021-06-01 11:36:53 +00:00
Rob Wu
75c0cde5b5 Bug 1694533 - Fix erroneous bookmarkGuid access in ext-menus.js in library window r=zombie
Differential Revision: https://phabricator.services.mozilla.com/D116421
2021-06-01 10:20:34 +00:00
Jon Coppeard
995da418b0 Bug 1711063 - Part 11: Add telemetry for pretenuring using the existing unused historgram r=sfink
Differential Revision: https://phabricator.services.mozilla.com/D115501
2021-06-01 09:57:03 +00:00
Jon Coppeard
535cf3cf63 Bug 1711063 - Part 10: Add tests for pretenuring behaviour r=jandem
Adds tests for pretenuring, not pretenuring and recovery in both directions,
for plain object and array creation.

Differential Revision: https://phabricator.services.mozilla.com/D115498
2021-06-01 09:57:03 +00:00
Jon Coppeard
367038284d Bug 1711063 - Part 9: Recover when allocation patterns change r=jandem,sfink
This is a bunch of heuristics to detect when sites that were short-lived become
long-lived and vice versa.

For the former we check the promotion rate for the whole nursery and the tenure
count for the optimized site in each zone. For the latter we look at tenured
objects that die in their first GC.

When then happens we discard JIT code and reset the allocation sites using the
list in the JitScript. This happens in one of two ways: if we are already
discarding JIT code then we reset the allocation sites for any remaining JIT
scripts, or if not we check all scripts in the zone and discard scripts
individually. This is so we don't add another script iteration if we're already
doing this for discarding JIT code.

Differential Revision: https://phabricator.services.mozilla.com/D115496
2021-06-01 09:57:02 +00:00
Jon Coppeard
cf7fbecd3b Bug 1711063 - Part 8: Add isNewlyCreated flag to Arenas that is set on creation and cleared on sweep r=sfink
This allows us to detect arenas that have been created since the last major GC.

Differential Revision: https://phabricator.services.mozilla.com/D115495
2021-06-01 09:57:02 +00:00
Jon Coppeard
c36e9df989 Bug 1711063 - Part 7: Refactor the interface to Zone::discardJitCode to use an options struct in preparation for adding more options r=jandem
Differential Revision: https://phabricator.services.mozilla.com/D115494
2021-06-01 09:57:01 +00:00
Jon Coppeard
574c30e061 Bug 1711063 - Part 6: Invalidate any JIT code that has already been compiled when an allocation site is determined to be long-lived r=jandem
Unfortunately we often end up optimizing code before a minor GC happens and we
realize that we should be pretenuring a site. This invalidates JIT code when we
decide to pretenure a site.

Differential Revision: https://phabricator.services.mozilla.com/D115493
2021-06-01 09:57:01 +00:00
Jon Coppeard
1db3e7a1b8 Bug 1711063 - Part 5: Track allocation sites for new plain object and new array optimized stubs r=jandem
This allocates AllocSite instances when stubs are created. There's a limit on
the number created per minor GC to prevent runaway growth of the site list that
must be traversed at the next minor GC.

The fallback by which JIT code calls into the VM has to be different for
baseline/optimzed code because we still track allocations in baseline code. (It
might be possible to use the same one and have the baseline fallback just use
the unknow site. I think this would violate some assertions but they could
perhaps be relaxed)

Differential Revision: https://phabricator.services.mozilla.com/D115242
2021-06-01 09:57:01 +00:00
Jon Coppeard
f86db35f6e Bug 1711063 - Part 4: Add the ability to pass an allocation site when assembling inline allocations r=jandem
For baseline allocations we still want to track the allocations made and update
the AllocSite whereas for optimized code we want to ignore this entirely and
use the catch-all optimzed site for tracked allocation sites. To allow this,
the patch adds AllocSiteInput which can either be a register holding an
AllocSite pointer or an immediate indicating which catch-all allocation site to
use.

Differential Revision: https://phabricator.services.mozilla.com/D115241
2021-06-01 09:57:00 +00:00
Jon Coppeard
f65b467f8f Bug 1711063 - Part 3: Process allocation sites on minor GC r=jandem
This adds logic to process allocation sites used since the last nursery
collection and update their state based on number of allocations made and now
many of those that were tenured.

This also dumps information about allocation sites to stderr if
JS_GC_REPORT_PRETENURING is set.

Differential Revision: https://phabricator.services.mozilla.com/D115240
2021-06-01 09:57:00 +00:00
Jon Coppeard
08d3cd51be Bug 1711063 - Part 2: Add AllocSite parameter to various APIs that will be used to create new objects and arrays r=jandem
This adds an optional AllocSite parameter to the APIs that we will use to
create objects/arrays when JIT code falls back to calling into the VM.

Differential Revision: https://phabricator.services.mozilla.com/D115238
2021-06-01 09:56:59 +00:00
Jon Coppeard
e2532cabd1 Bug 1711063 - Part 1: Add gc::AllocSite class and store a pointer to an instance in the nursery cell header r=jandem
This stores a pointer to a new AllocSite sturcture before every nursery cell.
Previously this was used to store a pointer to the zone, and we now have to get
the zone pointer from the AllocSite when necessary.

Since every cell must have such a pointer and we don't want to track all
allocation sites, there is a catch-call site per zone for unknown sites.
There's a second catch-all site which is used for optimized code generated for
known allocation sites by later patches.

Differential Revision: https://phabricator.services.mozilla.com/D115236
2021-06-01 09:56:59 +00:00
Neil Deakin
999ac32053 Bug 1695527, listen to the wheel event instead of DOMMouseScroll to close tooltips when scrolling, r=masayuki
Differential Revision: https://phabricator.services.mozilla.com/D116137
2021-06-01 09:45:53 +00:00
Jan Varga
0f6f29a66b Bug 1711675 - IDB: Fix linking in non-unified builds; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D115362
2021-06-01 09:42:01 +00:00
Masayuki Nakano
11211e435b Bug 1540037 - part 36: Make EditorBase handle Delete, Backspace and Tab of plaintext editor mode r=m_kato
`Delete` and `Backspace` keys are handled by same code.  So, the code should
be in `EditorBase` instead of `TextEditor`.

If `HTMLEditor` is in the plaintext editing mode of mail composer, `Tab` key
is also handled by the same code as `TextEditor`.  So, the code in `TextEditor`
should be moved to `EditorBase` too and `HTMLEditor` should call `EditorBase`'s
method only when it's in the plaintext mode.

Depends on D116352

Differential Revision: https://phabricator.services.mozilla.com/D116353
2021-06-01 08:51:25 +00:00
Jan Varga
4b29ca0eb3 Bug 1711663 - Extract non-template stuff into base classes; r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D115361
2021-06-01 08:50:32 +00:00
Jan Varga
4d9b952881 Bug 1711663 - Clean up includes related to FileInfo/FileInfoManager/DatabaseFileInfo/DatabaseFileManager; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D115360
2021-06-01 08:50:32 +00:00