Commit Graph

17353 Commits

Author SHA1 Message Date
Alexandre Poirot
1ebb0ed421 Bug 1570696 - Destroy Toolbox on TabClose event for local tab targets. r=jdescottes
Move disconnection message out of Toolbox class in favor of toolbox-init module
as that is specific to Toolbox loaded in a tab.
We do that in order to stop automatically destroying the toolbox when the
attached target is destroyed. This will help support switching to another target
when we navigate between two documents loaded in distinct processes.
We will now destroy the toolboxes for local tabs only when TabClose event
is fired.

Differential Revision: https://phabricator.services.mozilla.com/D40233

--HG--
extra : moz-landing-system : lando
2019-08-28 15:22:26 +00:00
Barret Rennie
c48dcf7d7c Bug 1510569 - Port onSecurityChange from WebProgressChild.jsm to C++; remove WebProgressChild r=Ehsan,ochameau
This is the last message that WebProgressChild was sending to the
RemoteWebProgress in the parent process, so we can remove the module entirely.

Differential Revision: https://phabricator.services.mozilla.com/D35091

--HG--
extra : moz-landing-system : lando
2019-08-28 18:55:45 +00:00
Dorel Luca
06a2578d2d Backed out changeset 3853d8979a55 (bug 1575240) for Devtools on devtools/client/webconsole/test/browser/browser_jsterm_inspect.js
--HG--
extra : rebase_source : a9ffc17ade0874f515e44152d78af257c10df334
2019-08-28 22:08:26 +03:00
Dorel Luca
b09fe526aa Backed out 4 changesets (bug 1510569) for build bustage. CLOSED TREE
Backed out changeset d7db6a1935ce (bug 1510569)
Backed out changeset 03b7cf756a7f (bug 1510569)
Backed out changeset fa318eec0e76 (bug 1510569)
Backed out changeset cecb17bd8c03 (bug 1510569)
2019-08-28 21:46:40 +03:00
Barret Rennie
e0d50ea7ce Bug 1510569 - Port onSecurityChange from WebProgressChild.jsm to C++; remove WebProgressChild r=Ehsan,ochameau
This is the last message that WebProgressChild was sending to the
RemoteWebProgress in the parent process, so we can remove the module entirely.

Differential Revision: https://phabricator.services.mozilla.com/D35091

--HG--
extra : moz-landing-system : lando
2019-08-28 18:00:23 +00:00
Yura Zenevich
346739d4b9 Bug 1564968 - add keyboard audit filter/badge to the accessibility panel. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D43446

--HG--
rename : devtools/client/accessibility/components/TextLabelBadge.js => devtools/client/accessibility/components/KeyboardBadge.js
extra : moz-landing-system : lando
2019-08-28 13:09:17 +00:00
Yura Zenevich
722e0fdc59 Bug 1564968 - add keyboard check section within accessibility panel sidebar checks. r=gl,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D43445

--HG--
extra : moz-landing-system : lando
2019-08-28 13:09:19 +00:00
Yura Zenevich
00c46e63a1 Bug 1564968 - create Check component for a generic check result in the checks section of the accessibility panel sidebar. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D43444

--HG--
extra : moz-landing-system : lando
2019-08-28 13:09:21 +00:00
Yura Zenevich
f025c6403a Bug 1564968 - add highlighting support for keyboard issues. r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D43443

--HG--
rename : devtools/server/tests/browser/browser_accessibility_infobar_audit_text_label.js => devtools/server/tests/browser/browser_accessibility_infobar_audit_keyboard.js
extra : moz-landing-system : lando
2019-08-28 13:09:23 +00:00
Yura Zenevich
511b056b80 Bug 1564968 - adding keyboard audit type serverside support. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D43442

--HG--
extra : moz-landing-system : lando
2019-08-28 13:09:24 +00:00
Gabriel Luong
7e80772a80 Bug 1568157 - Part 5: Move the NodePicker initialization into a getter. r=yulia
Differential Revision: https://phabricator.services.mozilla.com/D43567

--HG--
extra : moz-landing-system : lando
2019-08-28 12:03:30 +00:00
Gabriel Luong
8a3245ac6c Bug 1568157 - Part 4: Replace toolbox.walker with the contextual WalkerFront. r=yulia
Differential Revision: https://phabricator.services.mozilla.com/D40317

--HG--
extra : moz-landing-system : lando
2019-08-28 11:54:42 +00:00
Itiel
d28c64390c Bug 1576092 - Fix the breadcrumbs' arrow border color for white theme r=gl
Differential Revision: https://phabricator.services.mozilla.com/D43769

--HG--
extra : moz-landing-system : lando
2019-08-28 17:45:06 +00:00
Jason Laster
b553db9b43 Bug 1575240 - inspect(x) should show x in the appropriate panel. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D42747

--HG--
extra : moz-landing-system : lando
2019-08-28 12:04:49 +00:00
Nicolas Chevobbe
04f5f42266 Bug 1558417 - Add onboarding UI for Editor. r=Honza.
The onboarding UI is displayed on top of the Editor.
A dismiss button hides it forever (this is handled via
a pref that is set to false when clicking the button).

We take this as an opportunity to polish the Editor UI/wording
a bit.

Differential Revision: https://phabricator.services.mozilla.com/D43621

--HG--
rename : devtools/client/debugger/images/resume.svg => devtools/client/themes/images/webconsole/run.svg
extra : moz-landing-system : lando
2019-08-28 15:42:36 +00:00
Gurzau Raul
32356aa004 Backed out changeset a5bc37462cee (bug 1576835) for codespell failure at writing-perf-tests.md on a CLOSED TREE 2019-08-28 18:21:45 +03:00
Krishnal Ciccolella
70788158ec Bug 1558371 - Improve tooltip readability in dark mode r=pbro
Changed the color in `.devtools-tooltip-inactive-css` to match the color of the meatball menu

Differential Revision: https://phabricator.services.mozilla.com/D43756

--HG--
extra : moz-landing-system : lando
2019-08-28 14:48:22 +00:00
Julian Descottes
faf26174a7 Bug 1576835 - Update DAMP test writing documentation r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D43580

--HG--
extra : moz-landing-system : lando
2019-08-28 14:34:19 +00:00
Gurzau Raul
ad32ef1d9a Backed out changeset 9aa911cc3fcf (bug 1558417) for failing at browser_jsterm_editor_toolbar.js on a CLOSED TREE. 2019-08-28 17:12:00 +03:00
Julian Descottes
2646ae9c6d Bug 1577092 - Remove connectTo* helpers in debugger-server and use connectors directly r=nchevobbe
Depends on D43728

Differential Revision: https://phabricator.services.mozilla.com/D43729

--HG--
extra : moz-landing-system : lando
2019-08-28 13:07:56 +00:00
Julian Descottes
e12432f70d Bug 1577092 - Change devtools server connectors to expose connectTo functions r=nchevobbe
Depends on D43618

Differential Revision: https://phabricator.services.mozilla.com/D43728

--HG--
extra : moz-landing-system : lando
2019-08-28 13:07:40 +00:00
Bogdan Tara
02e806d54a Backed out 6 changesets (bug 1564968) by yzen's request CLOSED TREE
Backed out changeset 4b7516635108 (bug 1564968)
Backed out changeset c3227d4ff4b3 (bug 1564968)
Backed out changeset 868dbd59c79e (bug 1564968)
Backed out changeset db1a396ab58e (bug 1564968)
Backed out changeset e69163dc4683 (bug 1564968)
Backed out changeset c12857bc6980 (bug 1564968)
2019-08-28 16:06:23 +03:00
Yura Zenevich
c094bf25b6 Bug 1564968 - add keyboard audit filter/badge to the accessibility panel. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D43446

--HG--
rename : devtools/client/accessibility/components/TextLabelBadge.js => devtools/client/accessibility/components/KeyboardBadge.js
extra : moz-landing-system : lando
2019-08-27 23:37:54 +00:00
Yura Zenevich
411f447380 Bug 1564968 - add keyboard check section within accessibility panel sidebar checks. r=gl,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D43445

--HG--
extra : moz-landing-system : lando
2019-08-27 18:17:19 +00:00
Yura Zenevich
195b0a1aaf Bug 1564968 - create Check component for a generic check result in the checks section of the accessibility panel sidebar. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D43444

--HG--
extra : moz-landing-system : lando
2019-08-27 23:34:29 +00:00
Yura Zenevich
14f3ce0a9b Bug 1564968 - add highlighting support for keyboard issues. r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D43443

--HG--
rename : devtools/server/tests/browser/browser_accessibility_infobar_audit_text_label.js => devtools/server/tests/browser/browser_accessibility_infobar_audit_keyboard.js
extra : moz-landing-system : lando
2019-08-27 18:06:41 +00:00
Yura Zenevich
07581454e5 Bug 1564968 - adding keyboard audit type serverside support. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D43442

--HG--
extra : moz-landing-system : lando
2019-08-28 12:12:59 +00:00
Belén Albeza
8e89cc0eb6 Bug 1575872 - Part 2: Add Jest tests r=Ola
Differential Revision: https://phabricator.services.mozilla.com/D43638

--HG--
extra : moz-landing-system : lando
2019-08-28 10:49:57 +00:00
Belén Albeza
ef64830e0c Bug 1575872 - Part 1: Render a list of issues (errors and warnings) in the Manifest r=Ola,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D43637

--HG--
rename : devtools/client/application/src/components/manifest/ManifestItemWarning.css => devtools/client/application/src/components/manifest/ManifestIssue.css
rename : devtools/client/application/src/components/manifest/ManifestItemWarning.js => devtools/client/application/src/components/manifest/ManifestIssue.js
extra : moz-landing-system : lando
2019-08-28 12:20:43 +00:00
Nicolas Chevobbe
db62899801 Bug 1558417 - Add onboarding UI for Editor. r=Honza.
The onboarding UI is displayed on top of the Editor.
A dismiss button hides it forever (this is handled via
a pref that is set to false when clicking the button).

We take this as an opportunity to polish the Editor UI/wording
a bit.

Differential Revision: https://phabricator.services.mozilla.com/D43621

--HG--
rename : devtools/client/debugger/images/resume.svg => devtools/client/themes/images/webconsole/run.svg
extra : moz-landing-system : lando
2019-08-28 11:47:49 +00:00
yulia
91d20d2982 Bug 1575557 - rename webExtension to webExtensionDescriptor; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D42867

--HG--
rename : devtools/server/actors/addon/webextension.js => devtools/server/actors/descriptors/webextension.js
rename : devtools/shared/fronts/addon/webextension.js => devtools/shared/fronts/descriptors/webextension.js
rename : devtools/shared/specs/addon/webextension.js => devtools/shared/specs/descriptors/webextension.js
extra : moz-landing-system : lando
2019-08-28 10:02:57 +00:00
yulia
207370a55c Bug 1575557 - merge webextension-proxy with webextension; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D42866

--HG--
extra : moz-landing-system : lando
2019-08-28 10:06:27 +00:00
yulia
e7dd37593b Bug 1522571 - Unify addonTargetFront with webExtensionSpec; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D42833

--HG--
extra : moz-landing-system : lando
2019-08-28 10:01:43 +00:00
Itiel
e6b2d42978 Bug 1576487 - RTL fixes to the network details panel r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D43359

--HG--
extra : moz-landing-system : lando
2019-08-28 08:04:35 +00:00
tanhengyeow
e38a987dd9 Bug 1576884 - TypeError: this.intersectionObserver is null. r=Honza
Fix edge case.

Differential Revision: https://phabricator.services.mozilla.com/D43634

--HG--
extra : moz-landing-system : lando
2019-08-28 07:20:53 +00:00
Julian Descottes
8a65fc4677 Bug 1557170 - Add isParentInterceptEnabled trait to ServiceWorkerRegistration actor r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D43598

--HG--
extra : moz-landing-system : lando
2019-08-28 06:38:47 +00:00
Nicolas Chevobbe
451bc0629c Bug 1572671 - Don't load content process server startup script if it was already loaded. r=ochameau.
Previously, we were simply having a flag on the ContentProcessConnector
that we would flip once we loaded the content process server startup script.
This was working fine until multi-proxy browser console.
Each time we open the Browser Console, we create a new loader in a new
compartment. Which means in the end we'll have a new ContentProcessConnector
instance, and the flag would be resetted, and thus we would load a new
content process server startup script, which finally, would emit some
packet twice, and thus would break how we manage new packet in the client.

This patch fixes that by replacing the flag by checking if the script
was already loaded.

Differential Revision: https://phabricator.services.mozilla.com/D43618

--HG--
extra : moz-landing-system : lando
2019-08-28 06:37:18 +00:00
Nicolas Chevobbe
74b4cd5282 Bug 1576841 - Enable multi-proxy WebConsole in Browser Toolbox when fission pref is true. r=ochameau.
We remove the multiple this.fissionSupport properties to only check
the permission in the couple place we need it.

Differential Revision: https://phabricator.services.mozilla.com/D43585

--HG--
extra : moz-landing-system : lando
2019-08-27 17:41:29 +00:00
Paul Bone
08bc01ab37 Bug 1576814 - Skip tests that timeout r=kmag
Depends on D43572

Differential Revision: https://phabricator.services.mozilla.com/D43573

--HG--
extra : moz-landing-system : lando
2019-08-27 19:07:43 +00:00
Paul Bone
22abd7da9b Bug 1576814 - Remove fail-if tests that are now passing r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D43571

--HG--
extra : moz-landing-system : lando
2019-08-27 19:05:41 +00:00
David Walsh
ef58a63b92 Bug 1576165 - Prevent react warning in inline preview r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D43647

--HG--
extra : moz-landing-system : lando
2019-08-28 01:24:15 +00:00
David Walsh
2bbe6fef7a Bug 1576679 - Turn on inline preview by default r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D43490

--HG--
extra : moz-landing-system : lando
2019-08-27 21:48:49 +00:00
David Walsh
fdbeea9b5f Bug 1555333 - Toggle skipPausing when adding or enabling a breakpoint via reducers r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D43512

--HG--
extra : moz-landing-system : lando
2019-08-27 20:51:10 +00:00
Ehsan Akhgari
4ba1487439 Bug 1540117 - Part 5: Fix browser_webconsole_warning_group_content_blocking.js too by ensuring that the test image does set a cookie. r=fix CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com//D43671

--HG--
extra : histedit_source : c0cb5631e5195fe73d19dc36813efc3bf6284f25
2019-08-27 23:39:59 +03:00
Gabriel Luong
006d44d6b7 Bug 1568157 - Part 3: Replace toolbox.highlighter with the contextual HighlighterFront. r=yulia
Differential Revision: https://phabricator.services.mozilla.com/D40316

--HG--
extra : moz-landing-system : lando
2019-08-27 19:13:45 +00:00
Alexandre Poirot
341d06e6a0 Bug 1576586 - Enable all about:debugging tests with fission. r=jdescottes,kmag
All these tests seem to work fine with Fission.

Differential Revision: https://phabricator.services.mozilla.com/D43401

--HG--
extra : moz-landing-system : lando
2019-08-27 18:14:39 +00:00
Krishnal Ciccolella
933f7160c5 Bug 1573316 - RDM controls are off-center (when in centered mode) r=gl
Added a CSS selector to aid in centering RDM controls

Differential Revision: https://phabricator.services.mozilla.com/D43067

--HG--
extra : moz-landing-system : lando
2019-08-27 18:41:57 +00:00
Ehsan Akhgari
73345dc559 Bug 1540117 - Part 4: Fix browser_webconsole_trackingprotection_errors.js by ensuring that the test page does set a cookie. r=fix CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com//D43652

--HG--
extra : histedit_source : 296fb0ecbd7b1540bba93ea1d8490629a04fa91a
2019-08-27 21:27:50 +03:00
Alex Rosenfeld
e5b0947fe7 Bug 1574053 - allow shift-click to disable column breakpoints.
Allow user to disable column breakpoints with shift-click. Added mochitests to reinforce.   r=jlast.

Differential Revision: https://phabricator.services.mozilla.com/D43326

--HG--
extra : moz-landing-system : lando
2019-08-27 16:29:19 +00:00
Nicolas Chevobbe
d98ef83ed4 Bug 1576844 - Add a tabDetached even in content-process spec. r=yulia.
This event is sent from the content-process-connector in the server,
and not having it declared in the spec was causing unknown packets
error messages.

Differential Revision: https://phabricator.services.mozilla.com/D43587

--HG--
extra : moz-landing-system : lando
2019-08-27 16:36:55 +00:00