Commit Graph

66304 Commits

Author SHA1 Message Date
Boris Chiou
04b273259e Bug 1496619 - part 6: Generate StyleTimingFunction and drop ns_timing_function.rs r=emilio,birtles
First, we generate StyleComputedTimingFunction by cbindgen from Rust, and use
it in nsTimingFunction, so we could copy it directly without handling
the different memory layout. However, we have to rewrite the
nsTimingFunction and mozilla::ComputedTimingFunction for this.

Second, the rust-bindgen seems cannot generate the correct generic members
from complex C++ templates, especially for the nested template struct,
(https://github.com/rust-lang-nursery/rust-bindgen/issues/1429)
So we have to hide StyleTimingFunction to avoid the compilation errors.

Depends on D9312

Differential Revision: https://phabricator.services.mozilla.com/D9313

--HG--
extra : moz-landing-system : lando
2018-10-26 18:03:35 +00:00
Boris Chiou
adff31eff9 Bug 1496619 - Part 1: Drop frames() timing function r=birtles
frames() timing function was removed from the spec, so we drop it.
Besides, some devtool tests are removed because they use frame(). I will
add them back by using new step function later.

Differential Revision: https://phabricator.services.mozilla.com/D9309

--HG--
extra : moz-landing-system : lando
2018-10-26 18:03:24 +00:00
Andrea Marchesini
13bf7aa219 Bug 1432429 - Clean up a few random areas of code to accomodate Fuzzyfox: Performance and RefreshDriver. r=froydnj,baku
1: Correct the Performance API 'NowUnclamped' to obtain a non-Fuzzed Timestamp

2: Do not compare fuzzed and non-fuzzed timestamps in a Refresh Driver assert,
since this happens so early on that we will eventually compare them and
asserting would be bad.
2018-09-18 13:05:48 -05:00
Tom Ritter
b83b9c5b11 Bug 1432429 - Add FuzzyFox class and prefs. r=baku,froydnj
Creates a FuzzyFox class for implementating the core of the step/sleep
algorithm. Starts it in nsLayoutStatics::Initialize()

Adds the fuzzyfox prefs.

Moves the ms2mt macros from TimeStamp_windows.cpp to TimeStamp_windows.h
and creates a new public function GetQueryPerformanceFrequencyPerSec() to
expose a static variable in the .cpp file. This is necessary to support
the macros being usable anywhere.  (And we use the macros in FuzzyFox.)
2018-09-18 13:05:26 -05:00
Daniel Holbert
039305b565 Bug 1488762: Soften an assertion about sign of free space in flex layout, since absurdly large sizes can cause it to fail. r=bradwerth
Differential Revision: https://phabricator.services.mozilla.com/D9876

--HG--
extra : moz-landing-system : lando
2018-10-26 00:58:40 +00:00
Mats Palmgren
0feccf9fd7 Bug 1500530 - Make the anonymous child <label> have display:inline-block so that it applies its min-inline-size. r=jfkthame 2018-10-25 16:51:45 +02:00
Mats Palmgren
66c9ef8188 Bug 1453298 - [css-text] Resolve 'text-indent' percentage against the content-box inline-size of the box itself, not its containing block. r=emilio 2018-10-25 16:51:44 +02:00
Csoregi Natalia
9fbc76ace6 Merge inbound to mozilla-central. a=merge 2018-10-25 07:45:08 +03:00
Nika Layzell
23c990d165 Bug 1500926 - Part 1: Use a statically generated perfect hash in WebIDLGlobalNameHash, r=bzbarsky
This strategy allows us to dodge dynamic allocations in WebIDLGlobalNameHash.
This removes the Init() and Shutdown() methods, as well as Register. The
RegisterBindings.cpp file now only contains static data and one method
declaration for the WebIDLGlobalNameHash class.

This should also be faster by making the hashtable lookup infallible.

Differential Revision: https://phabricator.services.mozilla.com/D9406
2018-10-24 20:11:01 -04:00
Brad Werth
1600580027 Bug 1498273 Part 3: Define and set ComputedFlexItemInfo::mClampState. r=dholbert
Depends on D9727

Differential Revision: https://phabricator.services.mozilla.com/D9728

--HG--
extra : moz-landing-system : lando
2018-10-24 23:47:23 +00:00
Brad Werth
2eb1938e51 Bug 1498273 Part 2: Change mHasMinViolation and mHasMaxViolation to also track clamp state after item freeze. r=dholbert
Depends on D8769

Differential Revision: https://phabricator.services.mozilla.com/D9727

--HG--
extra : moz-landing-system : lando
2018-10-24 23:46:39 +00:00
Botond Ballo
dc9473c8e5 Bug 1493976 - Define OutOfFlowDisplayData::ComputeVisibleRectForFrame() out of line. r=kats
Differential Revision: https://phabricator.services.mozilla.com/D9442

--HG--
extra : moz-landing-system : lando
2018-10-24 19:19:06 +00:00
Andrew McCreight
681cefeb09 Bug 1492584, part 1 - Eagerly initialize nsLayoutModule in the component manager. r=froydnj
nsLayoutModule must be initialized in order to call into JS, but I
don't want to have to rely on calling a service in that
module. Instead, always initialize the module very early in component
manager initialization. This also makes initialization more
consistent, so things like errors in manifests won't affect when it
happens, which can result in different behavior in different builds.

I also made nsLayoutModule initialization infallible, because I can't
imagine that we can do much that is useful without it.

Another change I made is that gInitialized is set to true even in a
GPU process. This simplifies checking whether initialization has
happened already when we start up the layout module.

Differential Revision: https://phabricator.services.mozilla.com/D9583

--HG--
extra : moz-landing-system : lando
2018-10-24 16:10:29 +00:00
Emilio Cobos Álvarez
acda669e27 Bug 1500885 - Remove some unused keywords. r=xidorn
Differential Revision: https://phabricator.services.mozilla.com/D9372
2018-10-24 14:01:39 +02:00
Emilio Cobos Álvarez
a21614c515 Bug 1500885 - Serialize text-align with Servo. r=xidorn
Differential Revision: https://phabricator.services.mozilla.com/D9372
2018-10-24 14:01:39 +02:00
Xidorn Quan
78e208a120 Bug 1501418 - Have scrollbar-color: auto resolved to auto rather than two colors. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D9640

--HG--
extra : moz-landing-system : lando
2018-10-24 11:52:46 +00:00
Emilio Cobos Álvarez
449b22d059 Bug 1500885 - mTextAlignTrue / mTextAlingLastTrue are write-only. r=mats
They were added in bug 929991, but there's no text-align: true anymore.

Differential Revision: https://phabricator.services.mozilla.com/D9371

--HG--
extra : moz-landing-system : lando
2018-10-22 15:14:42 +00:00
longsonr
34f04a3465 Bug 1501057 - Trivial clipPaths should respect visibility=hidden r=dholbert 2018-10-24 06:01:57 +01:00
arthur.iakab
0d669cb499 Merge inbound to mozilla-central a=merge 2018-10-24 07:15:44 +03:00
Noemi Erli
71c13b613f Bug 1434812 - Disable list-1.html for frequent failures on OSX. r=jmaher 2018-10-23 13:34:00 +03:00
Bobby Holley
8ae065a347 Bug 1501073 - Test expectation adjustments. r=kats
Depends on D9610

Differential Revision: https://phabricator.services.mozilla.com/D9611

--HG--
extra : moz-landing-system : lando
2018-10-24 00:49:16 +00:00
Emilio Cobos Álvarez
8e5db71984 Bug 1501125 - Use WR clips instead of a mask as well for circle() and ellipse() shapes. r=kats
Differential Revision: https://phabricator.services.mozilla.com/D9463
2018-10-24 00:43:26 +02:00
Emilio Cobos Álvarez
6c70244466 Bug 1501122 - Handle opacity with WebRender instead of generating a mask if we have a simple clip. r=kats
Differential Revision: https://phabricator.services.mozilla.com/D9458
2018-10-24 00:38:33 +02:00
Ting-Yu Lin
8c481a151b Bug 1501145 Part 2 - Assign default values to ColumnBalanceData fields. r=mats
Depends on D9467

Differential Revision: https://phabricator.services.mozilla.com/D9468

--HG--
extra : moz-landing-system : lando
2018-10-23 13:09:16 +00:00
Ting-Yu Lin
4e6b53ce88 Bug 1501145 Part 1 - Assign default values to ReflowConfig fields, and explicitly initialize them in ChooseColumnStrategy. r=mats
The original statement is neat, but one cannot easily associates the values
computed in ChooseColumnStrategy with the actually field name in ReflowConfig.

Remove the aFeasibleBSize and aInfeasibleBSize for ChooseColumnStrategy()
because they're not used.

Differential Revision: https://phabricator.services.mozilla.com/D9467

--HG--
extra : moz-landing-system : lando
2018-10-23 13:08:59 +00:00
Kartikaya Gupta
bad6bf49d6 Bug 1374790 - Wait until APZ is ready before sending it a wheel event. r=mats
Differential Revision: https://phabricator.services.mozilla.com/D9567

--HG--
extra : moz-landing-system : lando
2018-10-23 18:58:10 +00:00
Brad Werth
29992e3858 Bug 1501109 Part 1: Change Flex API growth state to match layout algorithm, and use enums from webidl. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D9454

--HG--
extra : moz-landing-system : lando
2018-10-23 16:23:37 +00:00
Margareta Eliza Balazs
1a7c7d8823 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-10-23 12:31:53 +03:00
Margareta Eliza Balazs
a7f4d3ba4f Merge inbound to mozilla-central. a=merge 2018-10-23 12:27:03 +03:00
Andrea Marchesini
4439acd683 Bug 1498510 - Move nsICSPEventListener out of CSP object, r=ckerschb 2018-10-23 08:17:13 +02:00
Emilio Cobos Álvarez
42f80b2b77 Bug 1500575 - De-fuzz another webrender test. r=me 2018-10-23 04:20:24 +02:00
Kartikaya Gupta
2c29b10d55 Bug 1469403 - Skip DL dumps when the DL builder is from an inactive docshell. r=mattwoodrow
Depends on D9141

Differential Revision: https://phabricator.services.mozilla.com/D9146

--HG--
extra : moz-landing-system : lando
2018-10-22 23:42:05 +00:00
Kartikaya Gupta
1c01a94201 Bug 1469403 - Set a flag on the DL builder to indicate if the docshell is active. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D9141

--HG--
extra : moz-landing-system : lando
2018-10-22 23:41:47 +00:00
Andrew McCreight
f7cab62df4 Bug 1497707, part 4 - Only support loading JS files in the component manager. r=froydnj
JS is the only file extension actually supported, and there are a few
layers of cruft that can be eliminated if we specialize it.

This eliminates one XPCOM registration of the JS component loader.

Depends on D8170

Differential Revision: https://phabricator.services.mozilla.com/D8171

--HG--
extra : moz-landing-system : lando
2018-10-23 00:47:38 +00:00
Emilio Cobos Álvarez
d62a793992 Bug 1500575 - Map inset clip paths to WR complex clip regions. r=kats
Differential Revision: https://phabricator.services.mozilla.com/D9412

--HG--
extra : moz-landing-system : lando
2018-10-23 00:10:00 +00:00
tb120
e996e1e744 Convert NS_STYLE_ANIMATION_PLAY_STATE_* to scoped enum StyleAnimationPlayState (Bug 1500439) r=emilio
This change removes directives NS_STYLE_ANIMATION_PLAY_STATE_* and replaces the values with those from a scoped enum called StyleAnimationPlayState.

Differential Revision: https://phabricator.services.mozilla.com/D9382

--HG--
extra : moz-landing-system : lando
2018-10-22 21:58:01 +00:00
Masayuki Nakano
871e853d74 Bug 1499996 - Wait to run tests until new window gets focus r=smaug
test_expanding_selection_per_page.html creates another window and requires
focus event on each case which creates editing host because
EditorEventListener::Focus() sets ancestor limit of Selection as the editing
host.  Therefore, if the window itself does not have focus, focus event won't
be fired on editing hosts.  So, the reason why the orange occurs almost all
with opt build is, debug build is enough slow to wait focus of new window
before running test.

Differential Revision: https://phabricator.services.mozilla.com/D9473

--HG--
extra : moz-landing-system : lando
2018-10-23 07:34:55 +00:00
Julian Descottes
73e3a16c0d Bug 1499096 - Use ok() with 2 arguments instead of 3 when possible;r=Standard8
Depends on D8740.
This changeset replaces calls to ok with 3 arguments to calls with 2 arguments
in situations where the switch does not have a significant impact on the assert.

Differential Revision: https://phabricator.services.mozilla.com/D8741

--HG--
extra : moz-landing-system : lando
2018-10-23 07:13:35 +00:00
Julian Descottes
2fcd6cb020 Bug 1499096 - Update tests using ok() to is();r=Standard8
This changeset updates all the test that were wrongly using ok() and wanted to
use is() AND for which the assert is still passing without any modification
required.

Differential Revision: https://phabricator.services.mozilla.com/D8739

--HG--
extra : moz-landing-system : lando
2018-10-23 07:12:23 +00:00
Xidorn Quan
9de832b381 Bug 1448317 - Don't include absolutely-positioned and float children in element outline. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D9349

--HG--
extra : moz-landing-system : lando
2018-10-23 06:37:16 +00:00
Gurzau Raul
fcfb479e6f Merge inbound to mozilla-central. a=merge 2018-10-22 12:48:35 +03:00
Kartikaya Gupta
bec97d607b Bug 1500815 - Drop unnecessary Ahem-font styling. r=jfkthame
This is bogus because there is no ahem.css in this folder.

Differential Revision: https://phabricator.services.mozilla.com/D9357

--HG--
extra : moz-landing-system : lando
2018-10-21 23:33:53 +00:00
Mats Palmgren
822ff9c4d2 Bug 1500609 part 2 - Make the declaration of operator<< for nsReflowStatus unconditional since it's needed to build some COLUMN_SET_LOG expression in nsColumnSetFrame.cpp (idempotent patch). r=me 2018-10-22 00:54:57 +02:00
Mats Palmgren
4b5a264c80 Bug 1500609 part 1 - Add a nsFlexContainerFrame method to remove cached data that depend on flex items' intrinsic isize (idempotent patch). r=dholbert 2018-10-22 00:54:57 +02:00
Mats Palmgren
c33780d631 Bug 1499230 - Make empty <select>s have zero content-box inline-size, like in other UAs. r=emilio 2018-10-22 00:54:56 +02:00
Mats Palmgren
960944e003 Bug 1499578 - Make one line-height the intrinsic block-size for <select> comboboxes. r=emilio
Also, remove the !important on 'line-height' on <select> since other
UAs allows authors to change it.
2018-10-22 00:54:56 +02:00
Cristina Coroiu
0846a53f21 Bug 1432941 - Disable multicol-inherit-003.xht on mac for frequent failures. r=jmaher 2018-10-20 08:07:00 -04:00
Daniel Holbert
a597621867 Bug 1500608: Don't skip the flex-item early-freeze for devtools after all. r=bradwerth
This patch basically reverts the functional part of changeset 52bd865d757c.
I'd optimistically hoped we could skip this early-freeze in order to compute &
report a bit more "potential flexing" information via devtools.  Bbut it turns
out that breaks assertions & produces bogus information for flex items whose
base size vs. min/max-clamped "hypothetical" sizes are very
different. (Specifically: it produces nonsense for flex items whose base sizes,
if unclamped, would reverse the directionality of flexing.)

Differential Revision: https://phabricator.services.mozilla.com/D9304

--HG--
extra : moz-landing-system : lando
2018-10-19 22:05:46 +00:00
Kartikaya Gupta
a971a37e5f Bug 1485834 - Allow recomputing the cumulative resolution in ComputeScrollMetadata. r=botond
We need to correctly populate the cumulative resolution field in the
ScrollMetadata in order to support zooming. Without this, the cumulative
resolution doesn't include the presShell resolution, and that results in
APZ getting into an inconsistent state.

Currently, the cumulative resolution is populated from the
ContainerLayerParameters object's scale, but in the case of WebRender,
we call ComputeScrollMetadata with an empty ContainerLayerParameters
since don't actually do layer building or rasterization in Gecko.
This patch makes this more explicit by changing the argument to a
Maybe<ContainerLayerParameters> and passing Nothing() from the WebRender
call sites.

In this scenario, we just use the cumulative presShell resolution as
the cumulative resolution, which should be correct for WebRender as
we won't have an "extra" CSS-derived resolution applied on the Gecko
side.

Depends on D9120

Differential Revision: https://phabricator.services.mozilla.com/D9121

--HG--
extra : moz-landing-system : lando
2018-10-19 14:24:50 +00:00
Brian Birtles
590a7f2bba Bug 1472917 - Update test_transitions_per_property.html so it continues to work r=hiro
with the new interpolation rules; r?hiro

The updated tests are intended to cover percent translation when using matrix
decomposition but after introducing the new interpolation rules the initial
rotate() functions will match so the result will differ. This patch updates the
test values so that the result will not change even after introducing the new
interpolation rules.

Depends on D9183

Differential Revision: https://phabricator.services.mozilla.com/D9184

--HG--
extra : moz-landing-system : lando
2018-10-19 04:40:56 +00:00