Commit Graph

15325 Commits

Author SHA1 Message Date
Andrea Marchesini
8df66534cf Bug 1554847 - Improve cross-origin checks in canvas API - consider intermediate redirects, r=jya
Differential Revision: https://phabricator.services.mozilla.com/D32792

--HG--
extra : moz-landing-system : lando
2019-06-03 09:54:43 +00:00
Boris Zbarsky
46934887af Bug 1553018 part 1. Add various media preferences bindings use in Pref annotations on interfaces to StaticPrefs. r=jya
The renaming of MediaWebspeechRecognitionEnable to
media_webspeech_recognition_enable is to follow the StaticPrefs convention,
because bindings are going to assume that convention.

Differential Revision: https://phabricator.services.mozilla.com/D32942

--HG--
extra : moz-landing-system : lando
2019-05-30 17:21:39 +00:00
Dan Minor
3edf01f700 Bug 1554174 - Remove media.eme.vp9-in-mp4.enabled pref; r=jya
Differential Revision: https://phabricator.services.mozilla.com/D32808

--HG--
extra : moz-landing-system : lando
2019-05-30 07:17:38 +00:00
Byron Campen [:bwc]
2d6cf50175 Bug 1551589: readyState fixes r=ng
Depends on D31085

Differential Revision: https://phabricator.services.mozilla.com/D31123

--HG--
extra : moz-landing-system : lando
2019-05-29 21:27:18 +00:00
Matthew Gregan
66b75740df Bug 1550695 - Wrap cubeb_init in EnsureMTA to handle being called from threads where COM is uninitialized. r=achronop
Depends on D32654

Differential Revision: https://phabricator.services.mozilla.com/D32655

--HG--
extra : moz-landing-system : lando
2019-05-28 09:53:04 +00:00
Matthew Gregan
eee1406ae2 Bug 1550695 - Avoid duplicating cubeb_init in both arms of MOZ_CUBEB_REMOTING ifdef. r=achronop
Differential Revision: https://phabricator.services.mozilla.com/D32654

--HG--
extra : moz-landing-system : lando
2019-05-28 09:43:08 +00:00
Bryce Van Dyk
0e8b231d45 Bug 1552717 - P3: Set mInitDataType on sample info regardless of if the sample is encrypted. r=cpearce
Unencrypted samples can carry init data and thus we should set the init data
type regardless of if the sample itself is encrypted (otherwise the init data
info is incomplete for unencrypted samples).

Depends on D32751

Differential Revision: https://phabricator.services.mozilla.com/D32752

--HG--
extra : moz-landing-system : lando
2019-05-28 12:40:16 +00:00
Bryce Van Dyk
488430bdb9 Bug 1552717 - P2: Add test media for key rotation with a clear lead. r=cpearce
Add another test case for the mp4 key rotation (pssh in fragments) test. In this
case, the test file has a clear (unencrypted) lead. This test seeks to ensure we
don't regress surfacing of init info even if we encounter it for fragments that
start with unencrypted samples.

Add a further check to the key rotation test to ensure that the initDataType is
being surfaced correctly on the encrypted event.

Media files created with shaka packager via:
```
packager-win.exe
in=bipbop.mp4,stream=audio,out=bipbop-clearkey-keyrotation-clear-lead-audio.mp4
in=bipbop.mp4,stream=video,out=bipbop-clearkey-keyrotation-clear-lead-video.mp4
--enable_raw_key_encryption --keys
label=:key_id=00112233445566778899AABBCCDDEEFF:key=00112233445566778899AABBCCDDEEFF
--crypto_period_duration 5 --fragment_duration 5 --clear_lead 3
```

Note that the way shaka packager handles key rotation in this case is just to
left shift the key id and the key. In this case, where crypto_period_duration ==
fragment_duration, a left shift of 1 will take place each time the keys rotate.
This happens once in the test file leaving us with 2 key ids + keys.

Depends on D32750

Differential Revision: https://phabricator.services.mozilla.com/D32751

--HG--
extra : moz-landing-system : lando
2019-05-28 08:13:13 +00:00
Bryce Van Dyk
8141975d4d Bug 1552717 - P1: Refactor test_eme_pssh_in_moof mochitest so it's easier to add further test media. r=cpearce
test_eme_pssh_in_moof tests if our key rotation works correctly. It currently
does so by using a single video with an audio and video track. This patch
refactors the test so that it does the same thing (all going well), but in a
more extensible way.

The changes in this patch seek to lean more heavily on test harness
functionality in manifest.js and eme.js where possible. This cuts down on some
boilerplate, but means we have to make some concessions in a more verbose
expression of our test media list so the eme.js functions work with it.

Differential Revision: https://phabricator.services.mozilla.com/D32750

--HG--
extra : moz-landing-system : lando
2019-05-28 08:11:38 +00:00
Tarek Ziadé
c48befbb9c Bug 1542674 - Make Media debug info machine parsable r=padenot,smaug,jya
This patch structurizes the media debug information via webidl dictionaries
that are returned by HTMLMediaElement::GetMozRequestDebugInfo() and
MediaSource::GetMozDebugReaderData().

Differential Revision: https://phabricator.services.mozilla.com/D27893

--HG--
extra : moz-landing-system : lando
2019-05-27 16:15:33 +00:00
Andreas Pehrson
38bcf48b1c Bug 1546655 - Modernize test_streams_element_capture.html. r=jib
This async/await-ifies the test to put checks in logical order.
It also, as a drive-by, adds `v.token = token` since this is a cue to the test
framework in manifest.js to mozDumpDebugInfo() on the right element after
timeout of a token.

Differential Revision: https://phabricator.services.mozilla.com/D32114

--HG--
extra : moz-landing-system : lando
2019-05-27 12:32:00 +00:00
Andreas Pehrson
8ec3fef61a Bug 1546655 - Remove racy assert. r=jya
This assert can be racy if the following sequence happens:
SetPlaying() -- watch manager schedules SendData()
Stop() -- unwatches mPlaying, resets mStartTime
SendData() -- fails the assert

SendData handles the case where mStartTime is unset at runtime already through the mData check, further making this assert unnecessary.

Depends on D32112

Differential Revision: https://phabricator.services.mozilla.com/D32113

--HG--
extra : moz-landing-system : lando
2019-05-22 12:43:11 +00:00
Andreas Pehrson
3236dd6fde Bug 1546655 - Call SendData() on SetPlaying(true). r=jya
The following sequence in DecodedStream could lead to a stall for a captured
media element:
- MediaDecoder decodes some data, DecodedStream sends it out
- MediaDecoder pauses for buffering, DecodedStream sees SetPlaying(false)
- MediaDecoder decodes until the end, DecodedStream doesn't send since it's
  not playing
- MediaDecoder starts playing again, DecodedStream sees SetPlaying(true)

At the last step above, SetPlaying(true) doesn't trigger SendData() so no data
is sent out. Since all data has already been decoded, nothing can trigger
SendData() anymore. This patch fixes this by calling SendData() on SetPlaying().

Depends on D32111

Differential Revision: https://phabricator.services.mozilla.com/D32112

--HG--
extra : moz-landing-system : lando
2019-05-22 12:47:01 +00:00
Andreas Pehrson
567ff1cd38 Bug 1546655 - Add AudioQueue info to DecodedStream's debug info. r=jya
Depends on D32110

Differential Revision: https://phabricator.services.mozilla.com/D32111

--HG--
extra : moz-landing-system : lando
2019-05-22 12:46:25 +00:00
Andreas Pehrson
21e37086ec Bug 1546655 - Switch to NullableTimeUnit where applicable in DecodedStream. r=jya
DecodedStream is already using this for mStartTime.

Depends on D32109

Differential Revision: https://phabricator.services.mozilla.com/D32110

--HG--
extra : moz-landing-system : lando
2019-05-22 12:46:17 +00:00
Andreas Pehrson
89a63019db Bug 1546655 - Re-enable tests. r=jya
Depends on D32108

Differential Revision: https://phabricator.services.mozilla.com/D32109

--HG--
extra : moz-landing-system : lando
2019-05-22 12:46:09 +00:00
Jean-Yves Avenard
022c57caf3 Bug 1550422 - P23. Remove now unused gfxPrefs. r=jrmuizel
And with some tidying some comments and removing stray #include "gfxPrefs.h"

Differential Revision: https://phabricator.services.mozilla.com/D31468

--HG--
extra : moz-landing-system : lando
2019-05-26 14:31:53 +00:00
Jean-Yves Avenard
23436e1811 Bug 1550422 - P15. Move Skip and Once gfxPrefs to StaticPrefs. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D31259

--HG--
extra : moz-landing-system : lando
2019-05-26 14:30:14 +00:00
Jean-Yves Avenard
04a34db033 Bug 1550422 - P12. Convert Live gfxPrefs into StaticPrefs. r=jrmuizel
gfxPrefs Live preferences are almost identical to StaticPrefs.

We leave aside for now those that set a custom change callback as this feature isn't yet supported in StaticPrefs.

Differential Revision: https://phabricator.services.mozilla.com/D31256

--HG--
extra : moz-landing-system : lando
2019-05-26 14:29:42 +00:00
Jean-Yves Avenard
0a1e2b53cb Bug 1550422 - P6. Release object early when error. r=mattwoodrow
No need to keep the object alive.

Differential Revision: https://phabricator.services.mozilla.com/D31014

--HG--
extra : moz-landing-system : lando
2019-05-25 10:12:49 +00:00
Jean-Yves Avenard
84eb7085f1 Bug 1550422 - P5. Sync preferences with RDD process when then changed. r=mattwoodrow,mjf
Differential Revision: https://phabricator.services.mozilla.com/D30590

--HG--
extra : moz-landing-system : lando
2019-05-25 10:12:47 +00:00
Sylvestre Ledru
d57d4905f1 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D30883

--HG--
extra : moz-landing-system : lando
2019-05-25 17:46:15 +00:00
Gurzau Raul
967bc2a754 Backed out 31 changesets (bug 1552643, bug 1550422) for xpcshell crash on a CLOSED TREE.
Backed out changeset e30c1aa75529 (bug 1552643)
Backed out changeset caadcd7e02d3 (bug 1552643)
Backed out changeset aa7086ab09be (bug 1552643)
Backed out changeset 0b4029671710 (bug 1550422)
Backed out changeset a16295296035 (bug 1550422)
Backed out changeset 3b70307c0db5 (bug 1550422)
Backed out changeset 69df7818d4a3 (bug 1550422)
Backed out changeset d98dfc565927 (bug 1550422)
Backed out changeset 6f0997976944 (bug 1550422)
Backed out changeset 0edd264464c2 (bug 1550422)
Backed out changeset 9ea6da7a74ec (bug 1550422)
Backed out changeset f855f9309c8b (bug 1550422)
Backed out changeset 1033546224a7 (bug 1550422)
Backed out changeset ade7384c6186 (bug 1550422)
Backed out changeset 75b04de7e99c (bug 1550422)
Backed out changeset 91c3acdb2454 (bug 1550422)
Backed out changeset 77d2f80257d1 (bug 1550422)
Backed out changeset e0cd10d35327 (bug 1550422)
Backed out changeset 097091082423 (bug 1550422)
Backed out changeset 2f328853c1ab (bug 1550422)
Backed out changeset f92f2cc29cb1 (bug 1550422)
Backed out changeset 6dc82f88333d (bug 1550422)
Backed out changeset c20f66494d69 (bug 1550422)
Backed out changeset 2ba22cddeb6f (bug 1550422)
Backed out changeset 3aa72f89e295 (bug 1550422)
Backed out changeset ab4c4e806977 (bug 1550422)
Backed out changeset 72e5de040dda (bug 1550422)
Backed out changeset 7d3c2d486706 (bug 1550422)
Backed out changeset 132e0b8d8468 (bug 1550422)
Backed out changeset 54c85ac75dd0 (bug 1550422)
Backed out changeset d7ba4a18dd54 (bug 1550422)
2019-05-25 09:07:49 +03:00
Jean-Yves Avenard
074aea57fe Bug 1550422 - P23. Remove now unused gfxPrefs. r=jrmuizel
And with some tidying some comments and removing stray #include "gfxPrefs.h"

Differential Revision: https://phabricator.services.mozilla.com/D31468

--HG--
extra : moz-landing-system : lando
2019-05-24 11:37:50 +00:00
Jean-Yves Avenard
8d5f292ab5 Bug 1550422 - P15. Move Skip and Once gfxPrefs to StaticPrefs. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D31259

--HG--
extra : moz-landing-system : lando
2019-05-24 11:32:54 +00:00
Jean-Yves Avenard
af5790cf9b Bug 1550422 - P12. Convert Live gfxPrefs into StaticPrefs. r=jrmuizel
gfxPrefs Live preferences are almost identical to StaticPrefs.

We leave aside for now those that set a custom change callback as this feature isn't yet supported in StaticPrefs.

Differential Revision: https://phabricator.services.mozilla.com/D31256

--HG--
extra : moz-landing-system : lando
2019-05-25 00:03:32 +00:00
Jean-Yves Avenard
0176b72a88 Bug 1550422 - P6. Release object early when error. r=mattwoodrow
No need to keep the object alive.

Differential Revision: https://phabricator.services.mozilla.com/D31014

--HG--
extra : moz-landing-system : lando
2019-05-23 04:13:06 +00:00
Jean-Yves Avenard
ae9b00180b Bug 1550422 - P5. Sync preferences with RDD process when then changed. r=mattwoodrow,mjf
Differential Revision: https://phabricator.services.mozilla.com/D30590

--HG--
extra : moz-landing-system : lando
2019-05-23 04:13:06 +00:00
alwu
71e65af283 Bug 1550633 - part13.6 - refactor tests. r=jya
Refactor those tests' structure in order to make them more readable, and add the comment to show what the test purpose is for each test.

Differential Revision: https://phabricator.services.mozilla.com/D31914

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:02 +00:00
alwu
7e3d903ca9 Bug 1550633 - part13.5 - wait text track element's 'load' event. r=jya
This patch do two things in order to trigger loading for track element and wait for correct event to check track's and cues' status after loading finished.

(1) listen track element's load event
There are some tests listening video's loadedmetadata, but it's wrong. The loading process of media element and track element are completely non-related.
If you would like to check track element's status, you should wait for track element's load event.

(2) enable track explictly
If the text track which has default attribute is added to the media element before the media element starts running automatic track selection [1], then it would be enable by the media element.
Otherwise, you have to enable track explicitly by changing its track mode.

[1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-7

Differential Revision: https://phabricator.services.mozilla.com/D31913

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:04 +00:00
alwu
b045a61b28 Bug 1550633 - part13.4 : don't use anonymous function. r=jya
Use named function for callback to reduce the indentation.

Differential Revision: https://phabricator.services.mozilla.com/D31912

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:06 +00:00
alwu
4b62a057ad Bug 1550633 - part13.3 - create elements in HTML, not in JS. r=jya
Create test elements in HTML beforehand, which can remove unnecessary JS code and make test cleaner.

Differential Revision: https://phabricator.services.mozilla.com/D31911

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:08 +00:00
alwu
75459f89eb Bug 1550633 - part13.2 - no need to set pref "media.webvtt.regions.enabled". r=jya
These tests didn't use region at all, so we have no need to set the pref.

Differential Revision: https://phabricator.services.mozilla.com/D31910

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:10 +00:00
alwu
35f5a82cdc Bug 1550633 - part13.1 - remove unnecessary elements. r=jya
These elemenets are useless and we can run tests without them.

Differential Revision: https://phabricator.services.mozilla.com/D31909

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:12 +00:00
alwu
973b2aec17 Bug 1550633 - part6 : clear track's cues list whenever track element's src attribute set, changed or removed. r=jya,baku
According to the spec [1], we should empty track's cue list whenever a track element has its src attribute set, changed, or removed.

[1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:attr-track-src

Differential Revision: https://phabricator.services.mozilla.com/D31552

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:29 +00:00
alwu
48d979dff3 Bug 1550633 - part3 : add debug log to show track's kind. r=jya
Showing track's kind in debug log is helpful.

Differential Revision: https://phabricator.services.mozilla.com/D31373

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:35 +00:00
alwu
ee122028fb Bug 1550633 - part2 : maybe start loading resource when the track's mode changes. r=jya
According to the spec [1], the user agent must start the track processing model when text track has its text track mode changed.

[1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:start-the-track-processing-model

Differential Revision: https://phabricator.services.mozilla.com/D31372

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:38 +00:00
Joel Maher
edd5fd6be2 Bug 1544460 - fix reftest annotations and enable for osx 10.14. r=jfkthame,kats
fix reftest annotations and enable for osx 10.14.

Differential Revision: https://phabricator.services.mozilla.com/D32463

--HG--
extra : moz-landing-system : lando
2019-05-24 18:01:02 +00:00
Boris Zbarsky
328fedf055 Bug 1121623 part 4. Remove AudioScheduledSourceNode::WrapObject. r=padenot
It's dead code, because AudioScheduledSourceNode is an abstract class and all
subclasses override WrapObject.

Differential Revision: https://phabricator.services.mozilla.com/D32202

--HG--
extra : moz-landing-system : lando
2019-05-23 11:40:14 +00:00
arthur.iakab
af8e458c5f Backed out changeset a296439a25ff (bug 1519636) for frequent Windows cppunit failures CLOSED TREE 2019-05-24 14:26:01 +03:00
Jan Beich
697c499897 Bug 1547193 - Unbreak on platforms without GeckoProfiler after bug 1552530.
Differential Revision: https://phabricator.services.mozilla.com/D32446

--HG--
extra : moz-landing-system : lando
2019-05-24 11:09:59 +00:00
Sylvestre Ledru
c82ea97226 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D30883

--HG--
extra : moz-landing-system : lando
2019-05-24 09:59:17 +00:00
Alastor Wu
771bc43492 Bug 1551385 - part3 : add test 'test_webvtt_overlapping_time.html' and 'vtt_overlapping_time.html'. r=heycam
Adding tests to ensure that when cues with overlapping times, the one with earlier end timestamp should disappear when the media time reaches its end time. In this test, we have two cues with overlapping time, when the video starts, both cues should be displayed. When the time passes 1 seconds, the first cue should disappear and the second cues should be still displayed.

Differential Revision: https://phabricator.services.mozilla.com/D31172

--HG--
extra : moz-landing-system : lando
2019-05-23 22:52:47 +00:00
Alastor Wu
0195200d42 Bug 1551385 - part2 : recompute display state when display cues amount is different from the one we rendered last time. r=heycam
If the amount of cues which are going to be displayed is different from the one we displayed last time, we have to compute cues' display state again because cue's position might be affected by other cues.

Differential Revision: https://phabricator.services.mozilla.com/D31170

--HG--
extra : moz-landing-system : lando
2019-05-23 21:25:13 +00:00
Alastor Wu
102628f8e2 Bug 1551385 - part1 : let 'processCue()' handle cleaning cues div. r=heycam
We can actually let `processCue()` to handle rendering cues or cleaning displayed cues, no need to use another way to clear the cue.

The advantages is to make the code cleaner and easier to read, now we just need to know JS side would handle all rendering stuffs for us. We don't need to have different behavior when there is no showing cue.

The way we clear displayed cues are intuitive, we would remove all child nodes under the overlay, which are used to display cues.

Differential Revision: https://phabricator.services.mozilla.com/D31171

--HG--
extra : moz-landing-system : lando
2019-05-23 21:25:14 +00:00
Andreea Pavel
ed8cf51b98 Backed out 23 changesets (bug 1550633) for causing bug 1548454 to permafail on a CLOSED TREE
Backed out changeset ce4a146da49d (bug 1550633)
Backed out changeset e1a33576d6ad (bug 1550633)
Backed out changeset bbd8f62b9bff (bug 1550633)
Backed out changeset 583d4e0945ad (bug 1550633)
Backed out changeset 29487a59512d (bug 1550633)
Backed out changeset 0f6ddd898e89 (bug 1550633)
Backed out changeset fd1afdd721e3 (bug 1550633)
Backed out changeset d4a6c1337f89 (bug 1550633)
Backed out changeset 2d4773f2dc6c (bug 1550633)
Backed out changeset e9dea69efffe (bug 1550633)
Backed out changeset 4265dd65cec3 (bug 1550633)
Backed out changeset 2aaaa42c409b (bug 1550633)
Backed out changeset d85485f76233 (bug 1550633)
Backed out changeset b6e8370b6efb (bug 1550633)
Backed out changeset afaef937598b (bug 1550633)
Backed out changeset 470d8fae0461 (bug 1550633)
Backed out changeset 8024fcefe8b1 (bug 1550633)
Backed out changeset 224eadc5ef27 (bug 1550633)
Backed out changeset 26c3c521ce27 (bug 1550633)
Backed out changeset def294ad0efb (bug 1550633)
Backed out changeset b15cc6e689e7 (bug 1550633)
Backed out changeset be178934cbbb (bug 1550633)
Backed out changeset 9893ccf1f8ad (bug 1550633)
2019-05-24 03:38:26 +03:00
Andreea Pavel
21ad779f6a Backed out 3 changesets (bug 1551385) for breaking reftests at vtt_overlapping_time.html on a CLOSED TREE
Backed out changeset 4268e661e741 (bug 1551385)
Backed out changeset fb20dcf3c072 (bug 1551385)
Backed out changeset 883151b42d88 (bug 1551385)
2019-05-24 00:23:19 +03:00
alwu
f0b8fff7fc Bug 1550633 - part13.6 - refactor tests. r=jya
Refactor those tests' structure in order to make them more readable, and add the comment to show what the test purpose is for each test.

Differential Revision: https://phabricator.services.mozilla.com/D31914

--HG--
extra : moz-landing-system : lando
2019-05-23 09:03:12 +00:00
alwu
580e319c3d Bug 1550633 - part13.5 - wait text track element's 'load' event. r=jya
This patch do two things in order to trigger loading for track element and wait for correct event to check track's and cues' status after loading finished.

(1) listen track element's load event
There are some tests listening video's loadedmetadata, but it's wrong. The loading process of media element and track element are completely non-related.
If you would like to check track element's status, you should wait for track element's load event.

(2) enable track explictly
If the text track which has default attribute is added to the media element before the media element starts running automatic track selection [1], then it would be enable by the media element.
Otherwise, you have to enable track explicitly by changing its track mode.

[1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-7

Differential Revision: https://phabricator.services.mozilla.com/D31913

--HG--
extra : moz-landing-system : lando
2019-05-23 09:03:14 +00:00
alwu
ca2b2b41e4 Bug 1550633 - part13.4 : don't use anonymous function. r=jya
Use named function for callback to reduce the indentation.

Differential Revision: https://phabricator.services.mozilla.com/D31912

--HG--
extra : moz-landing-system : lando
2019-05-23 09:03:16 +00:00