Commit Graph

19197 Commits

Author SHA1 Message Date
Valentin Gosu
3cf093181f Bug 1610836 - Don't fail TRR_FIRST requests if the TRR service is not ready r=mayhemer
When it's first starting up, when mConfirmationState != CONFIRM_OK
the TRR service is not ready to use.
For TRR_FIRST requests we need to fallback to DNS while the service starts up.

Differential Revision: https://phabricator.services.mozilla.com/D61218

--HG--
extra : moz-landing-system : lando
2020-02-01 04:43:14 +00:00
Arthur Iakab
57110a989d Backed out changeset e051d75e66f7 (bug 1610836) for causing connectivity mass test failures.
CLOSED TREE
2020-02-01 02:09:30 +02:00
Valentin Gosu
8ce544c4ce Bug 1610836 - Don't fail TRR_FIRST requests if the TRR service is not ready r=mayhemer
When it's first starting up, when mConfirmationState != CONFIRM_OK
the TRR service is not ready to use.
For TRR_FIRST requests we need to fallback to DNS while the service starts up.

Differential Revision: https://phabricator.services.mozilla.com/D61218

--HG--
extra : moz-landing-system : lando
2020-01-31 15:09:18 +00:00
Honza Bambas
afc85e4008 Bug 1602313 - Make nsHttpChannel::mCachedContentIsValid an atomic bool, r=kershaw
Differential Revision: https://phabricator.services.mozilla.com/D60877

--HG--
extra : moz-landing-system : lando
2020-01-31 14:11:20 +00:00
Razvan Maries
f783276fb9 Backed out changeset fe27999955a4 (bug 1610836) for multiple perma failures. CLOSED TREE
--HG--
extra : amend_source : 7f648c73ebfbd227abf477d975f033e507cb151b
2020-01-31 17:04:10 +02:00
Valentin Gosu
773c572e19 Bug 1610836 - Don't fail TRR_FIRST requests if the TRR service is not ready r=mayhemer
When it's first starting up, when mConfirmationState != CONFIRM_OK
the TRR service is not ready to use.
For TRR_FIRST requests we need to fallback to DNS while the service starts up.

Differential Revision: https://phabricator.services.mozilla.com/D61218

--HG--
extra : moz-landing-system : lando
2020-01-31 14:03:10 +00:00
Valentin Gosu
74f9a5e3d8 Bug 1608114 - Increase the priority of the TRR main thread events r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D61306

--HG--
extra : moz-landing-system : lando
2020-01-31 08:46:44 +00:00
Kershaw Chang
2f7e31abd6 Bug 1600254 - P9: Avoild accessing http channel from transaction r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D56730

--HG--
extra : moz-landing-system : lando
2020-01-30 13:38:39 +00:00
Kershaw Chang
4bc096f818 Bug 1600254 - P8: Make nsIInputChannelThrottleQueue work with socket process r=dragana
The only information that devtools needs is the amount of how many bytes readed, so this patch introduces PInputChannelThrottleQueue ipdl for carrying on this information.

Differential Revision: https://phabricator.services.mozilla.com/D56710

--HG--
extra : moz-landing-system : lando
2020-01-30 13:32:55 +00:00
Kershaw Chang
98739d4a39 Bug 1600254 - P7: Enable ContentSniffer for socket process r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D56206

--HG--
extra : moz-landing-system : lando
2020-01-30 13:56:57 +00:00
Kershaw Chang
04931f96d9 Bug 1600254 - P6: Make H2 push work r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D56208

--HG--
extra : moz-landing-system : lando
2020-01-30 13:52:22 +00:00
Kershaw Chang
ad3911288e Bug 1600254 - P5: Make TransactionObserver work r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D56040

--HG--
extra : moz-landing-system : lando
2020-01-30 13:07:45 +00:00
Kershaw Chang
41300d6e8a Bug 1600254 - P4: Make HttpActivityObserver work in socket process r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D56039

--HG--
extra : moz-landing-system : lando
2020-01-30 13:00:11 +00:00
Kershaw Chang
a231a369a8 Bug 1600254 - P3: Implement HttpTransactionParent::ResolvedByTRR and HttpTransactionParent::GetProxyConnectResponseCode r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D56038

--HG--
extra : moz-landing-system : lando
2020-01-30 12:56:04 +00:00
Kershaw Chang
278afbaea7 Bug 1600254 - P2: Implement HttpTransactionParent::SetDomainLookupStart/End r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D56037

--HG--
extra : moz-landing-system : lando
2020-01-30 12:54:18 +00:00
Kershaw Chang
cc68e7a697 Bug 1600254 - P1: Send some variables over Init IPC message r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D56036

--HG--
extra : moz-landing-system : lando
2020-01-30 12:56:02 +00:00
Honza Bambas
718c54fd9f Bug 1608224 - Update originalURI of the "new" redirect channel used by a view-source channel to let consumers see it has been actually used for view-source, r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D60740

--HG--
extra : moz-landing-system : lando
2020-01-29 10:30:09 +00:00
Dimi Lee
3f336cb71f Bug 1599046 - P4. Report content blocking log to console while running in the parent process r=Ehsan
Depends on D57630

Differential Revision: https://phabricator.services.mozilla.com/D57807

--HG--
extra : moz-landing-system : lando
2020-01-27 19:23:05 +00:00
Dimi Lee
d58587be36 Bug 1599046 - P3. Remove unused IPC method in nsIParentChannel.idl. r=timhuang,Ehsan
The following methods are removed:
1. notifyChannelClassifierProtectionDisabled
2. notifyCookieAllowed
3. notifyCookieBlocked

Depends on D56875

Differential Revision: https://phabricator.services.mozilla.com/D57630

--HG--
extra : moz-landing-system : lando
2020-01-27 10:39:38 +00:00
Dimi Lee
6b66f4ad81 Bug 1599046 - P2. Remove calling NotifyOnContentBlocking in the child process r=timhuang,Ehsan
This patch does the followings:
1. Remove NotifyOnContentBlocking in WindowOuter and all the call sites.
   This is because all the content blocking event handling is moved to the parent.

2. Replace UrlClassifierCommon::NotifyChannelBlocked with AntiTrackingCommon:::NotifyContentBlockingEventInParent.
   This is because we don't need to pass the request to the child anymore, which was implemented in NotifyChannelBlocked previously.

3. Add NotifyContentBlockingEvent* utility functions to AntiTrackingCommon.cpp.

4. Update AntiTrackingCommon::NotifyBlockingDecision, when it is called in the parent,
   do not send requests to the child, notify the parent directly

Depends on D56874

Differential Revision: https://phabricator.services.mozilla.com/D56875

--HG--
extra : moz-landing-system : lando
2020-01-27 10:39:43 +00:00
Dimi Lee
f9ac16c330 Bug 1599046 - P1. Remove ContentBlockingLog from the child r=timhuang,Ehsan
At this point, there is no consumer that uses ContentBlockingLog stored
in the child. This patch removes the following code:
1. Removing nsGlobalWindowOuter::NotifyContentBlockingEvent
2. Removing nsDocLoader::OnContentBlockingEvent
3. Removing contentBlockingEvent in nsISecureBrowserUI.idl
4. Removing mContentBlockingLog from Document.cpp and APIs related to it.

Differential Revision: https://phabricator.services.mozilla.com/D56874

--HG--
extra : moz-landing-system : lando
2020-01-27 10:39:41 +00:00
Brindusan Cristian
00b2950b8d Backed out 4 changesets (bug 1599046) for xpcshell failures at test_ext_cookieBehaviors. CLOSED TREE
Backed out changeset 721f54870498 (bug 1599046)
Backed out changeset 2e165c119a4f (bug 1599046)
Backed out changeset 2bc0fa3bbe0e (bug 1599046)
Backed out changeset 805fb67be8a3 (bug 1599046)
2020-01-27 12:36:11 +02:00
Dimi Lee
1a9cf4eaa6 Bug 1599046 - P4. Report content blocking log to console while running in the parent process r=Ehsan
Depends on D57630

Differential Revision: https://phabricator.services.mozilla.com/D57807

--HG--
extra : moz-landing-system : lando
2020-01-27 09:13:34 +00:00
Dimi Lee
9b6c954be8 Bug 1599046 - P3. Remove unused IPC method in nsIParentChannel.idl. r=timhuang,Ehsan
The following methods are removed:
1. notifyChannelClassifierProtectionDisabled
2. notifyCookieAllowed
3. notifyCookieBlocked

Depends on D56875

Differential Revision: https://phabricator.services.mozilla.com/D57630

--HG--
extra : moz-landing-system : lando
2020-01-27 09:13:27 +00:00
Dimi Lee
9b9787812e Bug 1599046 - P2. Remove calling NotifyOnContentBlocking in the child process r=timhuang,Ehsan
This patch does the followings:
1. Remove NotifyOnContentBlocking in WindowOuter and all the call sites.
   This is because all the content blocking event handling is moved to the parent.

2. Replace UrlClassifierCommon::NotifyChannelBlocked with AntiTrackingCommon:::NotifyContentBlockingEventInParent.
   This is because we don't need to pass the request to the child anymore, which was implemented in NotifyChannelBlocked previously.

3. Add NotifyContentBlockingEvent* utility functions to AntiTrackingCommon.cpp.

4. Update AntiTrackingCommon::NotifyBlockingDecision, when it is called in the parent,
   do not send requests to the child, notify the parent directly

Depends on D56874

Differential Revision: https://phabricator.services.mozilla.com/D56875

--HG--
extra : moz-landing-system : lando
2020-01-27 09:13:19 +00:00
Dimi Lee
ffdfd5d51a Bug 1599046 - P1. Remove ContentBlockingLog from the child r=timhuang,Ehsan
At this point, there is no consumer that uses ContentBlockingLog stored
in the child. This patch removes the following code:
1. Removing nsGlobalWindowOuter::NotifyContentBlockingEvent
2. Removing nsDocLoader::OnContentBlockingEvent
3. Removing contentBlockingEvent in nsISecureBrowserUI.idl
4. Removing mContentBlockingLog from Document.cpp and APIs related to it.

Differential Revision: https://phabricator.services.mozilla.com/D56874

--HG--
extra : moz-landing-system : lando
2020-01-27 09:13:12 +00:00
Perry Jiang
c2250891d2 Bug 1264175 - remove FetchEvent.isReload r=dom-workers-and-storage-reviewers,valentin,sg,bzbarsky
isReload is no longer a property defined by the FetchEvent specification.

Differential Revision: https://phabricator.services.mozilla.com/D60774

--HG--
extra : moz-landing-system : lando
2020-01-25 00:05:12 +00:00
Ehsan Akhgari
eccae96ef4 Bug 1609176 - Remove the obsolete baseDomain field of the moz_cookies table; r=baku
This change is backwards incompatible with the older cookies.sqlite
files, which means files saved from newer versions of Firefox will
no longer be possible to open in older versions of Firefox.

Differential Revision: https://phabricator.services.mozilla.com/D60464

--HG--
rename : netwerk/test/unit/test_schema_3_migration.js => netwerk/test/unit/test_schema_10_migration.js
extra : moz-landing-system : lando
2020-01-25 00:18:34 +00:00
shindli
78f9c85759 Backed out changeset 86d1da74131f (bug 1264175) for causing mochitest failures in dom/serviceworkers/test/test_fetch_event.html CLOSED TREE 2020-01-24 06:18:04 +02:00
Perry Jiang
64699e71f7 Bug 1264175 - remove FetchEvent.isReload r=dom-workers-and-storage-reviewers,valentin,sg,bzbarsky
isReload is no longer a property defined by the FetchEvent specification.

Differential Revision: https://phabricator.services.mozilla.com/D60774

--HG--
extra : moz-landing-system : lando
2020-01-24 02:38:01 +00:00
Coroiu Cristina
73c0827187 Backed out 2 changesets (bug 1322095) for build bustage at dist/include/mtransport/runnable_utils.h on a CLOSED TREE
Backed out changeset 14e115ba7f12 (bug 1322095)
Backed out changeset 078c0fe497b7 (bug 1322095)
2020-01-23 19:50:51 +02:00
Eric Rahm
e120eee6b8 Bug 1322095 - Part 1b: Update callbacks to support moved args and convert nsAutoPtr usage. r=jya
In order to support the update to move args when invoking callbacks we:
 - Convert anything that was using WrapRunnable with `nsAutoPtr` to `UniquePtr`
 - Convert anything that was using a non-const ref as a param to either a
   const ref or a by-val copy

Addtionally we convert the remaining `nsAutoPtr` usage to `UniquePtr`.

Differential Revision: https://phabricator.services.mozilla.com/D59961

--HG--
extra : moz-landing-system : lando
2020-01-23 17:38:18 +00:00
Gijs Kruitbosch
c229dbc8a1 Bug 1526731 - handle image.http.accept pref inside netwerk instead of forcing all consumers to do the same dance, r=valentin,aosmond
Differential Revision: https://phabricator.services.mozilla.com/D60568

--HG--
extra : moz-landing-system : lando
2020-01-23 08:36:48 +00:00
Bogdan Tara
c9467840cd Backed out changeset 4cf57a5a3143 (bug 1609176) for test_cookies_async_failure.js related failures CLOSED TREE 2020-01-22 22:19:20 +02:00
Ehsan Akhgari
d0561affbf Bug 1609176 - Remove the obsolete baseDomain field of the moz_cookies table; r=baku
This change is backwards incompatible with the older cookies.sqlite
files, which means files saved from newer versions of Firefox will
no longer be possible to open in older versions of Firefox.

Differential Revision: https://phabricator.services.mozilla.com/D60464

--HG--
rename : netwerk/test/unit/test_schema_3_migration.js => netwerk/test/unit/test_schema_10_migration.js
extra : moz-landing-system : lando
2020-01-22 17:01:55 +00:00
Jan-Ivar Bruaroey
85c420c220 Bug 1547106: Throw OperationError in createDataChannel() if id in use. r=bwc
Differential Revision: https://phabricator.services.mozilla.com/D60569

--HG--
extra : moz-landing-system : lando
2020-01-22 14:20:26 +00:00
Andrea Marchesini
d2e146600e Bug 1507055 - Implement Anti-tracking heuristic for redirects, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D56191

--HG--
extra : moz-landing-system : lando
2020-01-21 18:18:32 +00:00
Emilio Cobos Álvarez
8a7906f381 Bug 1610064 - Avoid including StyleSheet.h from Document.h. r=nordzilla,firefox-style-system-reviewers
This in turn requires fixing various other include hell / missing include
issues.

Differential Revision: https://phabricator.services.mozilla.com/D60337

--HG--
extra : moz-landing-system : lando
2020-01-21 20:31:05 +00:00
Noemi Erli
e5fff9caae Backed out 2 changesets (bug 1507055) for causing build bustages in AntiTrackingCommon.cpp CLOSED TREE
Backed out changeset be170480919d (bug 1507055)
Backed out changeset 678dd02cf719 (bug 1507055)
2020-01-21 20:14:36 +02:00
Andrea Marchesini
f97dcc5818 Bug 1507055 - Implement Anti-tracking heuristic for redirects, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D56191

--HG--
extra : moz-landing-system : lando
2020-01-21 17:59:33 +00:00
Dragana Damjanovic
a3834a2925 Bug 1608967 - Adapt necko to new neqo r=michal
- process_timer used to be called by process_output, that is not the case any more, therefore we nee$
- how closing/closed event has change: on idle-timeout only closed even is called which means that neqo connection is completely closed and should not be kept alive.

Differential Revision: https://phabricator.services.mozilla.com/D59801

--HG--
extra : moz-landing-system : lando
2020-01-20 21:06:07 +00:00
shindli
083bbbba1d Merge autoland to mozilla-central. a=merge 2020-01-21 18:13:28 +02:00
Andreea Pavel
bd998e0112 Backed out changeset 4639d83e5871 (bug 1507055) for causing the crash in bug 1610485 a=backout
--HG--
extra : amend_source : 8cf2f5ccf0dc884c0d2ccdc3f1c48b3b5e014e1e
2020-01-21 16:46:22 +02:00
Michal Novotny
7c7d2abfab Bug 1607224 - Data race on CacheFileHandle::mFileSize r=valentin
This patch fixes data race on CacheFileHandle::mFileSize when accessed on main thread by nsHttpChannel::ReportNetVSCacheTelemetry(). All other usages are on cache I/O thread.

Differential Revision: https://phabricator.services.mozilla.com/D60407

--HG--
extra : moz-landing-system : lando
2020-01-21 09:48:11 +00:00
Sylvestre Ledru
187e9bafaf Bug 1519636 - Automatically reformat recent changes using clang-format r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D60354

--HG--
extra : moz-landing-system : lando
2020-01-21 09:51:27 +00:00
Ehsan Akhgari
8b642fb37e Bug 1609491 - Update the comment about differences with RFC2109/2616
This is based on the recent changes in
https://github.com/httpwg/http-extensions/issues/159 and
https://github.com/httpwg/http-extensions/pull/1018.

Differential Revision: https://phabricator.services.mozilla.com/D60465

--HG--
extra : moz-landing-system : lando
2020-01-21 00:13:18 +00:00
Coroiu Cristina
9490b63809 Backed out changeset b634b7b787d5 (bug 1609491) for wpt failures at /cookies/http-state/general-tests.html on a CLOSED TREE 2020-01-20 20:57:54 +02:00
Geoff Brown
95d2b89c71 Bug 1608126 - Enable node for Android xpcshell tests and run node tests on Android; r=valentin
Fetch, configure, and run node for Android on the test host, just like Linux tests do.
Make the node/HTTP/2 environment variables available to the tests on the device, and
use adb port forwarding to connect sockets. Finally, enable tests skipped for node.

Differential Revision: https://phabricator.services.mozilla.com/D60204

--HG--
extra : moz-landing-system : lando
2020-01-20 18:06:37 +00:00
Emilio Cobos Álvarez
256c124f94 Bug 1609996 - Reorder some includes affected by the previous patches. r=froydnj
This was done by:

This was done by applying:

```
diff --git a/python/mozbuild/mozbuild/code-analysis/mach_commands.py b/python/mozbuild/mozbuild/code-analysis/mach_commands.py
index 789affde7bbf..fe33c4c7d4d1 100644
--- a/python/mozbuild/mozbuild/code-analysis/mach_commands.py
+++ b/python/mozbuild/mozbuild/code-analysis/mach_commands.py
@@ -2007,7 +2007,7 @@ class StaticAnalysis(MachCommandBase):
         from subprocess import Popen, PIPE, check_output, CalledProcessError

         diff_process = Popen(self._get_clang_format_diff_command(commit), stdout=PIPE)
-        args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format]
+        args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format, '-sort-includes']

         if not output_file:
             args.append("-i")
```

Then running `./mach clang-format -c <commit-hash>`

Then undoing that patch.

Then running check_spidermonkey_style.py --fixup

Then running `./mach clang-format`

I had to fix four things:

 * I needed to move <utility> back down in GuardObjects.h because I was hitting
   obscure problems with our system include wrappers like this:

0:03.94 /usr/include/stdlib.h:550:14: error: exception specification in declaration does not match previous declaration
0:03.94 extern void *realloc (void *__ptr, size_t __size)
0:03.94              ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/malloc_decls.h:53:1: note: previous declaration is here
0:03.94 MALLOC_DECL(realloc, void*, void*, size_t)
0:03.94 ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozilla/mozalloc.h:22:32: note: expanded from macro 'MALLOC_DECL'
0:03.94     MOZ_MEMORY_API return_type name##_impl(__VA_ARGS__);
0:03.94                                ^
0:03.94 <scratch space>:178:1: note: expanded from here
0:03.94 realloc_impl
0:03.94 ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozmemory_wrap.h:142:41: note: expanded from macro 'realloc_impl'
0:03.94 #define realloc_impl mozmem_malloc_impl(realloc)

   Which I really didn't feel like digging into.

 * I had to restore the order of TrustOverrideUtils.h and related files in nss
   because the .inc files depend on TrustOverrideUtils.h being included earlier.

 * I had to add a missing include to RollingNumber.h

 * Also had to partially restore include order in JsepSessionImpl.cpp to avoid
   some -WError issues due to some static inline functions being defined in a
   header but not used in the rest of the compilation unit.

Differential Revision: https://phabricator.services.mozilla.com/D60327

--HG--
extra : moz-landing-system : lando
2020-01-20 16:19:48 +00:00
Emilio Cobos Álvarez
aa3a695712 Bug 1609996 - Remove mozilla/Move.h. r=froydnj
rg -l 'mozilla/Move.h' | xargs sed -i 's/#include "mozilla\/Move.h"/#include <utility>/g'

Further manual fixups and cleanups to the include order incoming.

Differential Revision: https://phabricator.services.mozilla.com/D60323

--HG--
extra : moz-landing-system : lando
2020-01-20 16:18:20 +00:00