Also remove IsBookmarkedInDatabase(), mItemCount, RecursiveFindRedirectedBookmark(), UpdateKeywordsForRemovedBookmark() from nsNavBookmarks as they aren't used anywhere.
MozReview-Commit-ID: 4cZXAdRuVoF
--HG--
extra : rebase_source : 2c08a09de48cfb06c3e8db261dfe7ea1b1526e10
Optimise adding a folder with child bookmarks for transactions by allowing PlacesTransactions.NewFolder to take children details and use insertTree rather than needing separate NewFolder and then multiple NewBookmark transactions.
MozReview-Commit-ID: 6s9j0pbsiUB
--HG--
extra : rebase_source : 0b4029905dc76a0ca49d16a7e71c85f1f07b8e2d
nsXPIDLStrings are marked as VOIDED upon initialization. Most of these local
nsXPIDLString variables are immediately set via getter_Copies(), which will
either assign a string value (using Adopt()) or do SetIsVoid(). These can be
trivially converted to nsString, which will get the same treatment.
The patch suitably converts the remaining nsXPIDLString local variable as well.
--HG--
extra : rebase_source : 5fff9f2c6844559198f601853f8db08564add7d5
This moves it to the same compartment as the code that it interfaces with the
most often, and allows for much more effective JIT optimizations.
MozReview-Commit-ID: FZcogI4d4rv
--HG--
rename : toolkit/components/extensions/ExtensionTabs.jsm => toolkit/components/extensions/ext-tabs-base.js
extra : rebase_source : 9928f7e36e4d65401ebb420dddfbcfcdbb11226f
Also updated addon listeners in extensions.js to use Set instead of
arrays and added a way to listen to AddonListener events on any addon.
MozReview-Commit-ID: Ev3kJgcr30G
--HG--
extra : rebase_source : 8f6ab458dc4ed82303631c0db1fa57849f149592
This removes about 2/3 of the occurrences of nsXPIDLString in the tree. The
places where nsXPIDLStrings are null-checked are replaced with |rv| checks.
The patch also removes a couple of unused declarations from
nsIStringBundle.idl.
Note that nsStringBundle::GetStringFromNameHelper() was merged into
GetStringFromName(), because they both would have had the same signature.
--HG--
extra : rebase_source : ac40bc31c2a4997f2db0bd5069cc008757a2df6d
The test is based on "test-harmful-simple" so we can add testing entries
in a human-readable way.
MozReview-Commit-ID: IJcYrp04uFs
--HG--
extra : rebase_source : afc4329af4cd5fc31a783a8f0f2e3a4bdcb2a432
extra : source : 55a2e275514d2154a23a656e48f685cc6032e5c3
As our threattype-listname conversion design, "goog-harmful-proto" is allocated
for this new threat type. This threat type is mainly for mobile.
MozReview-Commit-ID: G9GbgmHHHfp
--HG--
extra : rebase_source : 0681fcd9322b94451a86eafe57bf1ccc4b89db30
extra : intermediate-source : 28b0502d9add81beeae58a2c33f9fd5839d4d544
extra : source : 646f02f15131aa98ad37015b0a641304a3271796
_updateScrollButtonsDisabledState doesn't use nsIScrollBoxObject, so this shouldn't be a problem anymore.
MozReview-Commit-ID: DP7RD0lA7dQ
--HG--
extra : rebase_source : b39ae8b8cd05aa454ec5e4f960db7529c3ca455f
Also updated addon listeners in extensions.js to use Set instead of
arrays and added a way to listen to AddonListener events on any addon.
MozReview-Commit-ID: Ev3kJgcr30G
--HG--
extra : rebase_source : 1420093c1b69dccd4ff39cc3b0ede35cf9079efa
This mechanically replaces nsILocalFile with nsIFile in
*.js, *.jsm, *.sjs, *.html, *.xul, *.xml, and *.py.
MozReview-Commit-ID: 4ecl3RZhOwC
--HG--
extra : rebase_source : 412880ea27766118c38498d021331a3df6bccc70
The combination of "match_about_blank": true and "run_at": "document_start"
can potentially cause content scripts to run twice for the same document, once
for the intermediate about:blank document created by the document.open() call,
and again for the same document with its final URL after it's been fully
setup.
This test ensures that that behavior doesn't regress.
MozReview-Commit-ID: 9XSfW3rEL4f
--HG--
extra : rebase_source : e206bccd8fad648ebb152418c8784b0a4739fcab