Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-08 04:27:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
115,210 Commits 615 Branches 98 Tags 5.9 GiB
07d9f284b2
Commit Graph

177 Commits

Author SHA1 Message Date
bbaetz%student.usyd.edu.au
dd519e4374 Bug 151369 - need to trim the entered assignee's email address 
r=mattyt x2
 2002-06-16 05:26:50 +00:00
gerv%gerv.net
c4d9231226 Bug 144728 - Midair collision doubles line feeds. Patch by jouni@heikniemi.net; 2xr=justdave. 2002-05-29 07:21:44 +00:00
gerv%gerv.net
db55935a5f Bug 125066 - remove the need to set a milestone on accept for products with just one milestone. Patch by zeroj; r=justdave, gerv. 2002-04-24 20:07:57 +00:00
gerv%gerv.net
3bc9d4ca2b Bug 138588 - change to use new template structure. Patch by gerv, r=myk, afranke. 2002-04-24 07:24:50 +00:00
gerv%gerv.net
5820179602 Bug 137954 - Empty "move-button-text" field blocks changing bugs. Patch by gerv, 2xr=justdave. 2002-04-17 22:59:07 +00:00
bbaetz%student.usyd.edu.au
b8049151a5 bug 117718 - Mass Change removes a bugs groupset if the bug was in the 
wrong product group
r=justdave x2
 2002-04-16 08:29:01 +00:00
myk%mozilla.org
a26bc29e52 Fix for bug 125660: Templatizes process_bug.cgi. 
Patch by Myk Melez <myk@mozilla.org>
r=gerv,bbaetz
 2002-04-12 21:02:00 +00:00
gerv%gerv.net
20b99d16c6 Bug 124937 - templatise show_activity.cgi. Patch by me, r=myk, bbaetz. 2002-04-03 18:54:18 +00:00
justdave%syndicomm.com
a2f9effc6e Fix for bug 82143 and bug 95594: Attempting to reverse dependencies falsely reported a circular dependency loop, and setting 
both the blocks and depends at the same time allowed a real dependency loop to be created.
Patch by Stephen Lee <slee@wilcoxassoc.com>
r= myk, justdave
 2002-04-03 00:55:56 +00:00
gerv%gerv.net
d391f38ecb Bug 110012 - show_bug templatisation. r=bbaetz, afranke. 2002-03-23 17:58:41 +00:00
myk%mozilla.org
7395f6773d Fix for bug 72184: prevents users from entering too-large comments/descriptions that get rejected by MySQL's MAX_PACKET_SIZE restrictions. 
Patch by Myk Melez <myk@mozilla.org>.
r=bbaetz,gerv
 2002-03-11 07:33:03 +00:00
bbaetz%student.usyd.edu.au
fdfcfb96fd Bug 97471 - The assignee and qa contact should always be able to see their 
bugs
r=justdave, afranke
 2002-02-13 03:05:15 +00:00
bbaetz%student.usyd.edu.au
0c682418d4 Bug 119715 - strictvaluechecks should always be enabled 
r=justdave, gerv
 2002-02-05 00:20:09 +00:00
bbaetz%student.usyd.edu.au
d9d0617952 Bug 121074 - taint error after changing bug 
r=daa@distributed.net,jake
 2002-01-22 15:12:11 +00:00
justdave%syndicomm.com
e24c04e22a Fix for bug 108982: enable taint mode for all user-facing CGI files. 
Patch by Brad Baetz <bbaetz@student.usyd.edu.au>
r= jake, justdave
 2002-01-20 01:44:52 +00:00
jake%acutex.net
6f658a8b68 Bug 113975 - Changing only cc on mass change page incorrectly gives an error that you didn't select anything to change. 
r= myk x2
 2002-01-06 14:36:00 +00:00
justdave%syndicomm.com
840d1c4527 Fix for bug 102487: If you had "comment on product change required" turned on in your installation, Bugzilla would warn you of 
a forgotten comment AFTER allowing you to choose new components, versions, and milestones, forcing you to hit your back button
TWICE to correct your mistake.  This checkin corrects that.
Patch by David Kilzer <ddkilzer@theracingworld.com>
r= caillon, gerv
 2001-12-16 00:05:54 +00:00
justdave%syndicomm.com
d89032c7bf Fix for bug 73502: midair collision wasn't catching other bugs changing dependencies 
Patch by Dave Miller
r= bbaetz, jake
 2001-12-11 02:38:18 +00:00
jake%acutex.net
c7e781a010 Bug 108312 - The mid-air collision page was only showing the most recent changes if two people comitted changes to a bug while you were viewing it. 
r=louie, myk
 2001-11-27 15:04:52 +00:00
justdave%syndicomm.com
5a3a1fe26f Backing out previous checkin, it broke the tree. :( 2001-11-17 21:28:24 +00:00
justdave%syndicomm.com
5828cbd866 Fix for bug 102487: If admin has set preferences to require a comment on a product/component change, prompt the user that they 
forgot to comment first, before prompting for component, milestone, and version for new product.
Patch by Garvase Markham <gerv@mozilla.org>
r= kiko, ddk
 2001-11-17 21:12:53 +00:00
bbaetz%cs.mcgill.ca
91fafca168 Bug 107718 pt 2 - use subtraction instead of the ~ operator, which older 
mysql versions don't support. Remove the checksetup.pl restriction, too.

r=jake x2
 2001-11-14 15:12:23 +00:00
justdave%syndicomm.com
52073d81d4 Fix for bug 99519: timestamps were not being set correctly in the activity table in some situations, and the delta_ts on the 
bug itself was not always being updated if dependencies or CCs changed.
Patch by Dave Miller <justdave@syndicomm.com>
r= bbaetz, jake
 2001-11-08 03:38:12 +00:00
justdave%syndicomm.com
99906b233b SECURITY FIX see bug 108385: Due to trusting of passed form fields that shouldn't have been trusted, it was possible to add a comment to a bug pretending to be someone else if you edited the HTML by hand before submitting. The bug form did not include the field in question, but due to legacy processing code, the field was still trusted if it was present. 
Patch by Dave Miller <justdave@syndicomm.com>
r= jake x2
 2001-11-05 20:47:17 +00:00
bbaetz%cs.mcgill.ca
8d60ac104d Bug 107718 - mass changes give all changed bugs the groupset of the first 
bug in the list.

Do bit fiddling instead of adding groupsets from the first bug.

r=justdave, jake
 2001-11-03 05:49:23 +00:00
jake%acutex.net
57021053de Bug 104065 - Stop uninitilized string warnings from getting into the error log when the login cookie doesn't exist. 
Patch by Dave Miller <justdave@syndicomm.com>
r= gerv@mozilla.org, jake@acutex.net
 2001-10-25 14:46:58 +00:00
bbaetz%cs.mcgill.ca
543d7e522a Bug 97469 - Assignee/QA/Reporter/CC don't get email on restricted bugs. 
Also fixes seeing bugs in the buglist (bug 95024), dependancy lists,
tooltips, duplicates, and everywhere else I could see which checked group
bugs.groupset == 0.

Also fxed bug 101560, by clearing BASH_ENV

r=myk,justdave
 2001-10-23 15:44:53 +00:00
justdave%syndicomm.com
93a2f50358 Fix for bug 104516: No code changes in this patch, all this checkin does is remove all tabs from the bugzilla source and replace it with the appropriate number of spaces (in most cases 8) to line up with existing code. This is part of the effort to bring the existing codebase up to par with our style guidelines. 
Patch by Jake Steehagen <jake@acutex.net>
r= justdave x2
 2001-10-13 01:36:17 +00:00
myk%mozilla.org
792932cb8f Fix for bug 98744: No more software error when the user clicks "remove cc" without specifying users to remove. 
Fix by Jake <jake@acutex.net>.
r=myk@mozilla.org, no second review needed.
 2001-09-28 19:49:53 +00:00
myk%mozilla.org
4e68305b35 Fix for bug 90333: Bugzilla now displays an appropriate error message if a user hits process_bug.cgi without specifying any bugs to change. 
Patch by Myk Melez <myk@mozilla.org>
r=jake@acutex.net
 2001-09-17 18:55:31 +00:00
jake%acutex.net
f1aceec2a8 Fix for bug 30731 - Reassigning closed bugs from the mass change page caused their status to be set to new. 
r= myk@mozilla.org, zach@zachlipton.com
 2001-09-14 21:50:08 +00:00
justdave%syndicomm.com
42a7dcc52c Fix for bug 92266: Prevent dataloss in the bugs_activity table by wrapping 
entries into additional entries if they're too long to fit.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
 2001-08-26 22:58:34 +00:00
jake%acutex.net
7750d44cdd Bug 96085 - bypassing group security checks using duplicate bugs 
Patch by Christopher Aillon <christopher@aillon.com>
r= jake@acutex.net
 2001-08-26 18:51:45 +00:00
justdave%syndicomm.com
6aaa134676 Fix for bug 95235: variables with untrusted content were being echoed back to the user in error messages. Those variables are now run through html_quote() first. 
Patch by Gavin Shelley <gavins@iplbath.com>
r= justdave@syndicomm.com
 2001-08-24 17:32:25 +00:00
jake%acutex.net
ce973b6c4b Refixing bug 95875 - The code that breakes the typed in CC list into individual lists is now slightly more robust and allows perl to handle the splitting more efficiently (by using a space as the delimiter). 
r= myk@mozilla.org
 2001-08-18 03:35:36 +00:00
justdave%syndicomm.com
6264032f3e Fix for bug 95857: process_bugs.cgi sees blank address in cc: line (would show up as __UNKNOWN__) 
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
 2001-08-18 01:49:02 +00:00
jake%acutex.net
af1bd70cd7 Fix for bug 95747 - CC List validation (for additions) wasn't happening until after the bug's changes were in the process of being commited. This caused problems if a typo was made in the e-mail address. 
r= myk@mozilla.org
 2001-08-17 20:18:33 +00:00
justdave%syndicomm.com
67893f32dd Fix for bug 95743: the role-accessible checkboxes were getting cleared if a user with group access had to log in to make changes to a public bug. 
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
 2001-08-17 11:15:04 +00:00
justdave%syndicomm.com
43755341de Fix for bug 39816: Anyone in CC, Reporter, QA Contact, or Asigned To fields can now be given access to view a bug even if the permissions on that bug are set to a group that would normally exclude those people. 
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
 2001-08-13 00:46:20 +00:00
zach%zachlipton.com
1ecf08a901 fix for bug 66235: process_bug.cgi: multiple product change misses the groupset bit. Patch by Myk <myk@mozilla.org> r=Jake, oh, and it's my first checkin, yahoo! 2001-08-11 01:18:24 +00:00
justdave%syndicomm.com
99dccbf9c5 Fix for bug 84714 and bug 88797: You can now change bug groups from the "change several bugs" form even if the bugs aren't all in the same groups. Also, the groups are no longer cleared when you make a change from the "change several bugs" form (unless you tell it to) 
Patch by Joe Robins <jmrobins@tgix.com> and Dave Miller <justdave@syndicomm.com>
r= zach@zachlipton.com
a= justdave@syndicomm.com
 2001-07-22 00:29:45 +00:00
jake%acutex.net
ed69b4acf1 Fix for bugs 55161 and 12819. The activity log now stores only what's changed in multi-value fields. 
r= justdave@syndicomm.com
 2001-07-20 15:18:30 +00:00
justdave%syndicomm.com
8efbae9be1 Fix for bug 80289: Group restrictions are now identified with checkboxes instead of select widgets. Also, product groups are now only offered if they are either already set, or match the current product (i.e. the option to set a product bit for a product other than the one the bug is in is no longer available) This results in much less clutter for the admin folks on sites with lots of products. 
Patch by Joe Robbins <jmrobins@tgix.com>
r= justdave@syndicomm.com
 2001-06-27 01:44:34 +00:00
justdave%syndicomm.com
3b98736d18 Fix for bug 15980: Password is no longer shown in the location bar on the first page you load after logging in. 
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
 2001-06-07 20:26:40 +00:00
justdave%syndicomm.com
336d245aa5 Fix for bug 21253: removing all single-parameter system() calls from Bugzilla 
Patch by Dave Miller <justdave@syndicomm.com>
r= tara@tequilarista.org
 2001-06-06 21:17:42 +00:00
tara%tequilarista.org
eda44f5b9f Landing Myk's patch for bug #71767 2001-06-02 22:02:02 +00:00
jake%acutex.net
d520cdb669 Bugzilla was leaking information about bugs marked secure (using bug groups). This checkin fixes bugs 39524, 39527, 39531, and 39533. 
Patches by Myk Melez <myk@mozilla.org>.
r= jake@acutex.net
 2001-05-31 15:52:25 +00:00
justdave%syndicomm.com
8e2cc80353 Correcting my email address in the comments 2001-04-17 02:26:16 +00:00
dave%intrec.com
09e1aa7370 Fix for bug 71606: Duplicates not getting marked in comments which bug they're a dupe of. 2001-03-11 18:54:05 +00:00
dave%intrec.com
2de2e7e265 Fix for bug 7873: Duplicate marking now happens AFTER privs are checked to make sure a) the user is allowed to dupe it, and b) the change hasn't caused a midair collision. 2001-03-11 00:53:22 +00:00
cyeh%bluemartini.com
53a27cfa44 back out change 2001-03-09 23:59:40 +00:00
cyeh%bluemartini.com
558f46a9ba fix for 70039: Mid-air collision page confusing, users think comments will be lost 2001-03-09 23:41:37 +00:00
cyeh%bluemartini.com
c97581c0fe fix for bug 51670: Dependency loops are possible 
we now search each list (dependson, blocks) to see if a bug number shows
up in each list. a bug can't be dependent upon and block the same bug.
also make it so you can't set a bug blocking or dependent on itself.
 2001-02-26 22:50:58 +00:00
dave%intrec.com
c4d36b7026 Oops, typo in patch. = -> eq 2001-02-23 19:32:13 +00:00
cyeh%bluemartini.com
5a2b170f3f fix for 66876: Using userids (mediumint) for initialowner and initialqacontact 
based on patch submitted by baulig@suse.de (Martin Baulig).
 2001-02-22 18:11:29 +00:00
dave%intrec.com
9bc017041d Fix for bug 49306: Resolution field getting cleared on midair-collision. 2001-02-21 22:13:34 +00:00
cyeh%bluemartini.com
d42d7db47f fix for 28676 : 
When a bug is marked duplicate, the reporter should be added to the bug that it duplicated.
patch submitted by jake@acutex.net (Jake).
 2001-02-15 22:42:13 +00:00
dmose%mozilla.org
6077fdc769 fix for bug found in original 17464 patch, where removal from the CC list was not generating a mail. r=donm@bluemartini.com 2001-02-14 20:41:26 +00:00
tara%tequilarista.org
a65e4dc297 Cleaning up the language for matty for bug #45213 2001-01-18 02:20:04 +00:00
gerv%gerv.net
d6f20616fb Formatting change. Trivial. 2000-12-14 12:17:11 +00:00
tara%tequilarista.org
f4303b44e5 Landing duplicates stuff from gervase markham 2000-10-23 22:01:31 +00:00
cyeh%bluemartini.com
0bee60c556 fix for 49063: no sanity checking when setting duplicate. sanity checking 
is done for the dup id field, but not for the originating bug id.
now checks to see if the original bug id is valid as well, although i don't
understand how this could get corrupted in the first place
 2000-08-29 18:01:07 +00:00
cyeh%bluemartini.com
cba6ea46ad fix for 47790 : A bug to track which bugs Zach's bugzilla patch resolves. 
patches by zach@zachlipton.com. Thanks!
 2000-08-28 17:48:59 +00:00
dave%intrec.com
4f984849fe Re-fixing bug 30824 the correct way (which also fixes bug 46753) 2000-08-12 23:30:51 +00:00
tara%tequilarista.org
a3381b1cba Landing Dave Miller's patch for #25693 2000-07-25 22:00:16 +00:00
endico%mozilla.org
8a39869b3c Bug moving code is now fully implemented. To use it, turn on the param and set the move related params. 2000-07-13 23:12:52 +00:00
terry%mozilla.org
169d4e8eeb Keywords were already enforced to never differ only in capitalization. So, changed the code so that case no longer matters when typing in the name of a keyword. 2000-07-13 20:04:15 +00:00
cyeh%bluemartini.com
6ae1b3ebf7 fixes for the attachment widths. fix by dave@intrec.com (Dave Miller), 
original bug found by timeless@bemail.org
 2000-07-05 18:21:54 +00:00
cyeh%bluemartini.com
1e39281c6b Checkin for Bug 42851 'Use listbox with input for CC management on bug form' 
contributed by dave@intrec.com (Dave Miller)
 2000-06-21 19:03:45 +00:00
endico%mozilla.org
fc9e1aa63e allow the reporter of a bug to change the status of a bug (e.g. reopen it) even if they don't have the editbug bit set. 2000-06-02 18:54:55 +00:00
tara%tequilarista.org
fdc1436c42 Making all system calls use paramter arguments 2000-05-17 21:29:33 +00:00
terry%mozilla.org
ce67e5637a Add a new param, musthavemilestoneonaccept, which requires users to 
set the target milestone when accepting a bug.
 2000-05-08 22:00:38 +00:00
dmose%mozilla.org
dec52fb3d2 adding a 'can confirm' radiobutton to 'reassign by component' 2000-03-29 00:34:56 +00:00
dmose%mozilla.org
ffaaebea3c allow users to watch the bugs of other users 2000-03-28 21:31:24 +00:00
terry%mozilla.org
c49fc801bc Patch by "Matt Masson" <matthew@zeroknowledge.com> -- allow definition 
of different target milestones by product.
 2000-03-21 16:47:06 +00:00
terry%mozilla.org
110d75d308 Sigh. We now need to lock the attachments table, too, just in case a 
midair collision happens which needs to generate text which needs to
look at the attachments table.  Sigh.
 2000-03-10 22:26:55 +00:00
terry%mozilla.org
fe49673050 Italicize the "Additional Comments From" stuff, so that you can tell 
the difference between new comments and people copying stuff in from
old comments.
 2000-03-10 18:01:32 +00:00
terry%mozilla.org
722e3ce72f Oops! canconfirm bit wasn't actually working. 2000-03-07 21:29:19 +00:00
terry%mozilla.org
10626c1f40 Make a universal routine to report errors in forms, so that we can 
have a universal (and more noticable) way of displaying them.
 2000-02-25 19:32:47 +00:00
terry%mozilla.org
732a4ab9f6 Added an optional ability to keep a read-only shadow database, so that 
bug queries can be run against it, so that these slow queries won't be
able to tie up the rest of the system.
 2000-02-17 21:41:39 +00:00
terry%mozilla.org
dd5e744669 Fixed bug where it was complaining that people without permissions 
were changing the resolution, even if they weren't.
 2000-02-17 19:27:46 +00:00
terry%mozilla.org
b995fd3665 Display all possible state transitions in a bug if the user is not 
logged in.  Since they haven't logged in, we don't know what they will
be allowed to do.  And users who disable cookies tend to pretty often
not be logged in.
 2000-02-17 15:53:40 +00:00
terry%mozilla.org
29a6c841a0 Ignore leading and trailing whitespace when trying to decide if 
someone changed something.
 2000-02-17 15:11:37 +00:00
terry%mozilla.org
eb2c661f2f Removed stupid debugging printf. 2000-02-17 15:09:32 +00:00
terry%mozilla.org
718ebdae52 Major spankage. Added a new state, UNCONFIRMED. Added new groups, 
"editbugs" and "canconfirm".  People without these states are now much
more limited in what they can do.

For backwards compatability, by default all users will have the
editbugs and canconfirm bits on them.  Installing this changes as is
should only have one major visible effect -- an UNCONFIRMED state
will appear in the query page.  But no bugs will become in that state,
until you tweak some of the new voting-related parameters you'll find
when editing products.
 2000-02-17 05:15:23 +00:00
terry%mozilla.org
cd28f843c4 Lock the tables as low-priority when writing. Maybe makes people making changes wait longer, but people doing read-only stuff should now never block for very long. 2000-02-15 21:29:14 +00:00
terry%mozilla.org
07aac12aff Nothing was checking that the bug number you entered for a duplicate 
bug was actually a legal bug number.
 2000-02-01 23:48:13 +00:00
terry%mozilla.org
2440cb6a46 REOPENing a bug now clears the resolution; most people will agree it 
should have always had this behavior.
 2000-01-31 22:50:10 +00:00
terry%mozilla.org
8ed4c20ca3 Added a new table fielddefs that records information about the 
different fields we keep an activity log on.  The bugs_activity table
now has a pointer into that table instead of recording the name directly.

Set up a new, highly experimental email-notification scheme.  To turn
it on, the maintainer has to turn on the "New email tech" param, and
then individual users have to turn on the "New email tech" preference.
 2000-01-22 04:24:42 +00:00
terry%mozilla.org
c308f025ee Moved all the long descriptions out of the bugs table, and into a new 
table.  There is now a separate entry for each new long description,
rather than appending them all together in one big field.
 2000-01-20 21:31:22 +00:00
terry%mozilla.org
23fbfe14b9 Allow whitespace to be used to separate keywords. 2000-01-19 19:32:05 +00:00
terry%mozilla.org
c53a69421b Added a "keywords" field to a bug, which is a cached string-based copy 
of all the keywords assigned to the bug.  Right now, we only have code
that generates and maintains this field; soon will come code that
actually uses it.
 2000-01-17 11:38:41 +00:00
terry%mozilla.org
ce249dd094 Checked in patch by Dawn Endico <endico@mozilla.org> -- when 
reassigning by component, reassign the qa contact too.
 2000-01-15 00:23:31 +00:00
terry%mozilla.org
f5e622daa8 Patch by Ramon Felciano <felciano@ingenuity.com>, with many tweaks by 
me.  Added a footer to every page.  Add some options to do things like
display checkboxes instead of scrolling lists, and a new formatting
for email diffs, and show list items capitalized instead of all upper
case.
 2000-01-14 22:35:49 +00:00
terry%mozilla.org
d5a1e935bc Send one last email notification to people when a bug gets reassigned 
away from them or they get removed from the CC list.
 2000-01-13 22:23:25 +00:00
terry%mozilla.org
ce53803244 Was sometimes putting a silly timestamp in the change log. 2000-01-13 17:46:01 +00:00
terry%mozilla.org
9ef2787d65 Don't complain that the user isn't doing anything if he is actually 
changing keywords.
 2000-01-13 16:19:19 +00:00
terry%mozilla.org
03994b0c80 Was making changes to bugs before validating the entries in the CC 
field.  This caused mid-air collisions and other weirdnesses.
 2000-01-11 18:25:11 +00:00
terry%mozilla.org
8ec2fa3b0f Add support for a new "keywords" feature. This lets some central 
authority maintain a list of keywords, and users can associate any
keyword with any bug.

The new functionality won't appear until at least one keyword is
defined.

Note that you *must* run the "checksetup.pl" script after updating
this change, in order to create the new required tables "keywords" and
"keyworddefs".
 2000-01-06 21:16:15 +00:00
terry%mozilla.org
0582508d69 Patch by freitag@suse.de (Klaas Freitag) -- add options to let Bugzilla require comments on certain operations. 1999-12-16 16:37:57 +00:00