The retry on download complete did not work properly, and we trust
the size of the file given that we download over https and check
with CertCheck, so I removed the other size checks which would have
retried infinitely given issues.
Differential Revision: https://phabricator.services.mozilla.com/D72746
Also fix two other installer problems that were getting missed because of this:
one build error in PostUpdate and one use of an uninitialized value in the
installer, causing it to record that it had not registered the task when it had.
Differential Revision: https://phabricator.services.mozilla.com/D67915
--HG--
extra : moz-landing-system : lando
This was originally planned in bugs 1458282 and 1458283, but it
fits naturally in this patch series.
Differential Revision: https://phabricator.services.mozilla.com/D37141
--HG--
extra : moz-landing-system : lando
CLOSED TREE
Backed out changeset 85ea1d36da66 (bug 1515451)
Backed out changeset 779bc1fa07ae (bug 1515451)
Backed out changeset 0c6771b60b76 (bug 1515451)
This was originally planned in bugs 1458282 and 1458283, but it
fits naturally in this patch series.
Differential Revision: https://phabricator.services.mozilla.com/D37141
--HG--
extra : moz-landing-system : lando
Allow Firefox to be specified as a handler for 'mailto:' urls on Windows.
Re commit of Phabricator differential D2247 -- that's too old to be reused.
Differential Revision: https://phabricator.services.mozilla.com/D65438
--HG--
extra : moz-landing-system : lando
This patch uses the `SetStretchedImageOLE` function that was developed for the
stub installer background image and landed in bug 1337856 part 1 to also
provide nicer scaling for the bitmap controls in the full installer dialogs,
instead of GDI's default which produces undesirably jagged curved edges.
Differential Revision: https://phabricator.services.mozilla.com/D61135
--HG--
extra : moz-landing-system : lando
At the end of any successful install, both the stub installer and full installer
(in interactive mode) attempt to launch the newly installed copy. But currently,
they first check if any copy of Firefox [1] is already running, and skip doing
that launch if so. The reason for this is that it used to be the case that no
two instances of Firefox could ever be running under default conditions because
there was only one default profile and it would be in use. It's clear that this
is the reason for the check because an exception is made for Developer Edition,
which had its own default profile and so wasn't subject to this restriction.
But now, we have per-install profiles by default, so there's no longer any need
to have this check, because launching the new instance won't be blocked by the
fact that there's already an instance running; all we're doing is creating
false positive prompts for something that isn't an issue anymore. So, this
patch removes the check and the prompt.
[1] At least that's the intent, but because of bug 1600905 we're actually now
checking for any Gecko-based product, because that's the best we can now do.
Differential Revision: https://phabricator.services.mozilla.com/D56959
--HG--
extra : moz-landing-system : lando
Bug 1295542 added empty chrome.manifest files to prevent malware from abusing
them. This workaround is no longer necessary because Firefox stopped reading
chrome.manifest outside omni.ja since bug 1543761.
Differential Revision: https://phabricator.services.mozilla.com/D55954
--HG--
extra : moz-landing-system : lando
Mostly all this does is link to the SUMO page; the point is to keep from
confusing people who don't realize the full installer and the MSI are
different things with independent documentation and try to apply one set of
docs to the opposite package.
Differential Revision: https://phabricator.services.mozilla.com/D55724
--HG--
extra : moz-landing-system : lando
We've been using the "FirefoxMessageWindow" class for this, but it no longer
exists as of bug 1518639, so switch to classes that should always be there.
Differential Revision: https://phabricator.services.mozilla.com/D56099
--HG--
extra : moz-landing-system : lando
The previous patch didn't work because the helper running as the unelevated
user is the only one that can read the pref out of its user registry hive,
which is where Firefox has to write it, but then since it's limited it can't
write to either the shortcut log or to HKLM. So everything has to happen in
HKCU so that the unelevated helper can both read and write where it needs to
read and write to.
Differential Revision: https://phabricator.services.mozilla.com/D53113
--HG--
extra : moz-landing-system : lando
My initial idea of using the shortcuts log to store this information didn't
work out because the helper, when run by an updater which was run by the
maintenance service, doesn't get write permissions on that file.
Differential Revision: https://phabricator.services.mozilla.com/D52276
--HG--
extra : moz-landing-system : lando
At least for now, this behavior is behind a hidden pref. The intent is to
experiment with the feature and determine that way whether enabling it
permanently is a good idea, and if so the pref gate will be removed in a
separate bug.
This patch depends on bug 1567247 and will fail to build without it.
Differential Revision: https://phabricator.services.mozilla.com/D41100
--HG--
extra : moz-landing-system : lando
We intentionally only clean out the prefs registry key during uninstall, unlike
the other registry keys that the installer creates, because we might want to do
experiments that involve the procedures that normally clean out registry keys.
This leaves open the possibility that an experiment causes some problem that
by its nature makes it difficult to disable the experiment, since it wouldn't
be disabled by either a normal update or a paveover install, but it's
necessary to make sure that experiments persist for longer than e.g. a single
update cycle.
Depends on D40327
Differential Revision: https://phabricator.services.mozilla.com/D40328
--HG--
extra : moz-landing-system : lando
MANUAL PUSH: This is mhowell manually combining a new contributor's patch stack.
Differential Revision: https://phabricator.services.mozilla.com//D41477
--HG--
extra : source : 7219965f391ab9b548ea0e9305ef5acafd2640d5
extra : amend_source : 9a7c03a5e8a7c6a2ec7ca005cda08336846ec977
The installer for aarch64 Windows has exceeded the current limit. This new one
(150 MB) should allow enough breathing room while still being reasonable.
Differential Revision: https://phabricator.services.mozilla.com/D38246
--HG--
extra : moz-landing-system : lando
This patch copies over the same fix that was used for the profile cleanup page
to the installing page, since in some locales it can run into the same problem
of the header string being so long that it causes the next control to get cut
off by the bottom of the window.
Differential Revision: https://phabricator.services.mozilla.com/D36523
--HG--
extra : moz-landing-system : lando
We can use MUI_BGCOLOR to change the background color, but there's no way to
globally override the text color, so we additionally need to set that on every
affected control in the Show functions (we have to wait until Show because
that's the earliest point that the controls have been created and we can get
handles to them).
This patch fixes both the full installer and the uninstaller.
Differential Revision: https://phabricator.services.mozilla.com/D33189
--HG--
extra : moz-landing-system : lando
