This patch will report the Type II Array subclassing.
A previous version of this patch had CacheIR support for this; however this has
proved to have less performance impact and more complexity challenges than
forseen. As a result, this support has been removed until proven necessary.
Differential Revision: https://phabricator.services.mozilla.com/D210535
The UI test failed when trying to click the "Add Automatically" system dialog button.
This seem to be happening because the page wasn't fully loaded.
Added a verifyPageContent() after opening the website and changed the website to be easier to verify the content
The UI test successfully passed 200x on Firebase. ✅
Differential Revision: https://phabricator.services.mozilla.com/D211976
Also:
- deactivate LLVM_SYMBOLIZER on android mozconfig as we don't cross compile it yet.
- enforce LLVM_SYMBOLIZER when fuzzing is on
- fix osx packaging to include llvm-symbolizer when fuzzing, and provide
it through tc
Differential Revision: https://phabricator.services.mozilla.com/D210190
Our implementation is in a reasonably good state. Only test failures
are:
* Long-standing bug 1533327.
* A test / spec issue that is covered by D211871 (the animation works
correctly).
* TypedOM
So I don't see a reason to keep gating this to nightly-only.
Differential Revision: https://phabricator.services.mozilla.com/D211880
This is a bit less complicated than lengths because there's no cycle
possible which could turn the color-scheme declaration invalid afaict.
So it's just that we need to defer the colors when color-scheme is
specified, which is slightly annoying, but maybe not too bad.
I had to tweak a bit the code to defer properties to fix a bug that we
were papering over accidentally. We were using the wrong registration
here:
https://searchfox.org/mozilla-central/rev/f60bb10a5fe6936f9e9f9e8a90d52c18a0ffd818/servo/components/style/custom_properties.rs#1613
That's the registration for reference.name, not for name, which
papered over some issues. The fix is simple tho, which is storing a
single CustomPropertiesMap.
Differential Revision: https://phabricator.services.mozilla.com/D211860
The algorithm proposed in the spec to search for whitespace does not treat ` ` correctly for our implementation, as ` ` has already been converted to `0xA0`.
This patch replaces this algorithm with checking for `0xA0` directly.
As a side-effect, the whitespace check is performed directly on a `nsTextFragment`, thus removing a string copy operation.
Differential Revision: https://phabricator.services.mozilla.com/D211963
So that when a node is removed and this node is related to the start or
the end point of the `CrossShadowBoundaryRange`, we can clear this
`CrossShadowBoundaryRange`. We clear it for now because we aren't sure
about what the new points should be.
`nsRange` does a similar thing to `mRoot`, and we can't rely on `nsRange` to
observer `mRoot` because `mRoot` could be root of a collapsed range, so
it's not the root of `CrossShadowBoundaryRange`.
Differential Revision: https://phabricator.services.mozilla.com/D211246
Removed the `Tag` template parameter from `ScaffoldingConverter`. It
was totally unused.
Updated UniFFITypeError to update it's message as
`addItemDescriptionPart` is called. 1897266 made the messages
more correct in some cases, but we lost the field name that generated
the type error in the process. This new code should work in all casse.
Updating the message has some runtime cost, but we shouldn't be
generating lots of UniFFITypeErrors in the first place.
Differential Revision: https://phabricator.services.mozilla.com/D211928
This is complaining that a worker runtime is accessing the shared permanent
atoms zone, which is owned by the main runtime. This is not a problem because we
only check the zone GC state here and the zone will never be collected while the
worker is running.
The patch adds a test to avoid the assertion failure.
Differential Revision: https://phabricator.services.mozilla.com/D211822