Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-23 12:51:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
940,915 Commits 615 Branches 98 Tags 6 GiB
09899e8f69
Commit Graph

576 Commits

Author SHA1 Message Date
Mark Banner
cbb55a4a55 Bug 1927798 - Re-enable the curly rule for ESLint. r=frontend-codestyle-reviewers,mossop 
This was accidentally disabled in bug 1920531 with the re-organisation of how eslint-plugin-mozilla worked.
The rule needs to be (re)enabled after eslint-config-prettier is applied, as eslint-config-prettier turns it off by default.

Differential Revision: https://phabricator.services.mozilla.com/D227621
 2024-11-01 14:15:01 +00:00
Mark Banner
072008e5f7 Bug 1881696 - Rework the ESLint environment so that eslint-plugin-mozilla is not enforcing the environment everywhere. r=frontend-codestyle-reviewers,Gijs 
This makes it easier for subscribers of eslint-plugin-mozilla to use it more generally as a set of recommended
rules. The only environment definitions are for mozilla-specific file types, where we should be safe to specify
them.

Differential Revision: https://phabricator.services.mozilla.com/D225704
 2024-10-18 09:21:27 +00:00
Mark Banner
fae021d5ee Bug 1920802 - Update node_modules related to ESLint as far as possible. r=frontend-codestyle-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D222622
 2024-09-25 06:37:10 +00:00
Mark Banner
9e50226bf3 Bug 1920531 - Remove html, json and prettier plugin dependencies from eslint-plugin-mozilla. r=frontend-codestyle-reviewers,Gijs 
Requiring these in eslint-plugin-mozilla seems a bit unnecessary:

* The html plugin is used as a parser and is only required if a project is parsing html.
* Similary, we use the recommended config for the JSON parser, and it only applies for JSON files.
* The prettier option is only required if a project wants to use prettier. Whilst I think we should have prettier for all Mozilla projects, I don't think we need to enforce/require it here.

Differential Revision: https://phabricator.services.mozilla.com/D222628
 2024-09-23 17:46:18 +00:00
Mark Banner
2387ca3533 Bug 1917532 - Remove overrides sections from *-test configurations in eslint-plugin-mozilla. r=frontend-codestyle-reviewers,mossop 
ESLint v9 doesn't support overrides/file specification in the configurations, so we don't want these
now.

The top-level configuration already strips out the overrides for these and handles them separately, so
there's nothing to add - simply remove the 'removeOverrides' function.

Differential Revision: https://phabricator.services.mozilla.com/D221447
 2024-09-12 21:08:45 +00:00
Mark Banner
533bbce8a6 Bug 1575506 - Enable ESLint rule no-redeclare with builtinGlobals on all module and worker files. r=frontend-codestyle-reviewers,devtools-reviewers,nchevobbe,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221446
 2024-09-12 21:08:45 +00:00
Mark Banner
0075a7ce1f Bug 1917530 - Enable ESLint rule no-shadow by default across the tree, disabling where it currently fails. r=frontend-codestyle-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221445
 2024-09-12 21:08:44 +00:00
Sandor Molnar
6a28b1e440 Backed out 8 changesets (bug 1917532, bug 1575506, bug 1917530) for causing node newtab failures CLOSED TREE 
Backed out changeset 8d6f7bc74d08 (bug 1917532)
Backed out changeset 7c963e72cf06 (bug 1575506)
Backed out changeset d5e110187781 (bug 1917530)
Backed out changeset 1d2325ffded6 (bug 1917530)
Backed out changeset 8a361e37e32c (bug 1917530)
Backed out changeset c4011d92c7f7 (bug 1917530)
Backed out changeset 1a45047dfb3c (bug 1917530)
Backed out changeset ed6b35444c45 (bug 1917530)
 2024-09-12 20:45:28 +03:00
Mark Banner
6b786d4a84 Bug 1917532 - Remove overrides sections from *-test configurations in eslint-plugin-mozilla. r=frontend-codestyle-reviewers,mossop 
ESLint v9 doesn't support overrides/file specification in the configurations, so we don't want these
now.

The top-level configuration already strips out the overrides for these and handles them separately, so
there's nothing to add - simply remove the 'removeOverrides' function.

Differential Revision: https://phabricator.services.mozilla.com/D221447
 2024-09-12 16:42:00 +00:00
Mark Banner
c7331a02cd Bug 1575506 - Enable ESLint rule no-redeclare with builtinGlobals on all module and worker files. r=frontend-codestyle-reviewers,devtools-reviewers,nchevobbe,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221446
 2024-09-12 16:41:59 +00:00
Mark Banner
1a8d60d410 Bug 1917530 - Enable ESLint rule no-shadow by default across the tree, disabling where it currently fails. r=frontend-codestyle-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221445
 2024-09-12 16:41:59 +00:00
Mark Banner
27fac51e12 Bug 1907841 - Change ESLint's .eslintignore to be an imported module. r=frontend-codestyle-reviewers,zeid,devtools-reviewers,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D216540
 2024-07-16 12:53:09 +00:00
Mark Banner
1d0ca7396f Bug 1905959 - Move jsm rule handling out of eslint-plugin-mozilla to the top-level config. r=frontend-codestyle-reviewers,Gijs 
This helps to simplify the combinations in eslint-plugin-mozilla ahead of supporting the ESLint flat config.

Differential Revision: https://phabricator.services.mozilla.com/D215541
 2024-07-03 11:41:30 +00:00
Mark Banner
c01122d19b Bug 1897898 - Separate out ESLint rule rollouts configurations to a separate module. r=frontend-codestyle-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D210992
 2024-05-21 13:38:01 +00:00
Mark Banner
82ae63cedb Bug 1897770 - Improve .sjs file environment definitions in ESLint. r=frontend-codestyle-reviewers,extension-reviewers,Gijs 
This stops sjs files from picking up the test environments/configurations which means they get just the sjs environment
which is what we want.

Differential Revision: https://phabricator.services.mozilla.com/D210928
 2024-05-20 13:49:44 +00:00
Mark Banner
2972287e22 Bug 1897770 - Move ESLint no-insecure-url definitions to general-test.js. r=frontend-codestyle-reviewers,Gijs 
This moves the general test definition to be first, so that the other test types can build on it.
It also re-arranges the no-insecure-url rule definitions to be defined in a single place in general-test.

This also exposes a few more places where we're not currently meeting the no-insecure-url rule, so we allowlist
those as well for now.

Differential Revision: https://phabricator.services.mozilla.com/D210927
 2024-05-20 13:49:44 +00:00
Dão Gottwald
2f419065da Bug 1837575 - Move Tabbed Browser related files to browser/components/tabbrowser/. r=mconley,desktop-theme-reviewers,zeid,tabbrowser-reviewers,frontend-codestyle-reviewers,Itiel 
This is a start, there are more modules and scripts we can/should move, as well as tests.

Differential Revision: https://phabricator.services.mozilla.com/D210676
 2024-05-17 13:25:23 +00:00
Mike Hommey
21bcae940a Bug 1885449 - Move GV code shared between Android and iOS to a shared directory. r=geckoview-reviewers,frontend-codestyle-reviewers,nalexander,owlish 
And hook them up to the iOS build.

Differential Revision: https://phabricator.services.mozilla.com/D204711
 2024-05-16 22:08:51 +00:00
Gijs Kruitbosch
6caf5c363c Bug 1895692 - turn off import/no-unassigned-import for storybook files, r=reusable-components-reviewers,frontend-codestyle-reviewers,hjones 
Differential Revision: https://phabricator.services.mozilla.com/D210475
 2024-05-15 16:08:57 +00:00
James Teow
12397ac331 Bug 1891982 - Part 1: Copy Top Sites Feed into the Top Sites component - r=dao,frontend-codestyle-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D207827
 2024-04-23 18:32:30 +00:00
Mark Banner
cbbf28809f Bug 1799465 - Enable require-jsdoc rules by default, disabling on code where there are existing failures. r=frontend-codestyle-reviewers,migration-reviewers,backup-reviewers,mossop,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D206878
 2024-04-08 13:34:13 +00:00
Mark Banner
3ea24d64fc Bug 1889087 - Enable ESLint rule mozilla/reject-chromeutils-import on devtools as well. r=arai,devtools-reviewers,profiler-reviewers,julienw,frontend-codestyle-reviewers,perftest-reviewers,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D206349
 2024-04-06 09:08:47 +00:00
Sandor Molnar
e1e4a33e82 Backed out changeset 50f86f169ee8 (bug 1889087) for causing talos performance test failures CLOSED TREE 2024-04-03 09:18:07 +03:00
Mark Banner
5f19d766d1 Bug 1889087 - Enable ESLint rule mozilla/reject-chromeutils-import on devtools as well. r=arai,devtools-reviewers,profiler-reviewers,julienw 
Differential Revision: https://phabricator.services.mozilla.com/D206349
 2024-04-02 19:05:48 +00:00
Irene Ni
f701879f1c Bug 1876432 - Added support for custom themes as its own menu in Reader View. r=reader-mode-reviewers,fluent-reviewers,desktop-theme-reviewers,hjones,accessibility-frontend-reviewers,bolsson,devtools-reviewers,sfoster,cmkm,jules,ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D204519
 2024-04-02 00:08:46 +00:00
Luca Greco
e364e07097 Bug 1883452 - Obliterate Corroborator remaining bits. r=rhelmer,Gijs,firefox-desktop-core-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D205735
 2024-03-27 16:29:42 +00:00
Dave Townsend
71420d91a6 Bug 1864896: Enable unused argument lint rule. r=Standard8,perftest-reviewers,geckoview-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,nchevobbe,robwu,sparky,issammani,sgalich,owlish,migration-reviewers,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D195632
 2024-03-21 08:50:00 +00:00
Gijs Kruitbosch
51a4c7d0e9 Bug 1880899 - add lint rule that prevents adding more browser.js globals, r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D202804
 2024-03-16 15:14:07 +00:00
Greg Tatum
5dd28ecc35 Bug 1814289 - Enable the jsdoc lint rule for translations and run auto-fix; r=translations-reviewers,nordzilla 
There will be lint errors reported, as the following patch will manually
fix the remaining errors.

Differential Revision: https://phabricator.services.mozilla.com/D204516
 2024-03-13 19:23:41 +00:00
Mark Banner
f4ce4f5c95 Bug 1885041 - Expand disallowing JSM based imports via ESLint to everything except for devtools. r=arai,omc-reviewers,aminomancer,zombie 
Differential Revision: https://phabricator.services.mozilla.com/D204441
 2024-03-13 17:38:28 +00:00
Mark Banner
43d2964f1b Bug 1884623 - Cleanup jsm references in ESLint files. r=mossop,devtools-reviewers,omc-reviewers,ochameau,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D204180
 2024-03-11 15:26:27 +00:00
Mark Banner
4f1d29d324 Bug 1883371 - Enable ESLint rule no-console on production code. r=mossop,webcompat-reviewers,devtools-reviewers,omc-reviewers,twisniewski,nchevobbe,aminomancer 
Allow for console.error, console.warn and console.createInstance, but fail for everything else.

Differential Revision: https://phabricator.services.mozilla.com/D203456
 2024-03-05 16:56:57 +00:00
Mark Banner
5ee6fc544c Bug 1883371 - Add a general configuration for rules specific for all tests. r=mossop 
This gives us the option to specify rule variations for all tests without having to copy across the configurations.

More importantly, we can also apply this to anything under `/test/` or `/tests/` and so we can catch utils and other files that the specific test configurations don't already catch.

Differential Revision: https://phabricator.services.mozilla.com/D203455
 2024-03-05 16:56:57 +00:00
Mark Banner
726c6acf03 Bug 1881266 - Enable ESLint recommended rule no-case-declarations globally, warning for existing cases. r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D202320
 2024-02-26 11:35:41 +00:00
Mark Banner
c9b5df99c1 Bug 1881266 - Enable ESLint recommended rule no-constant-condition globally, warning for existing cases. r=mossop,devtools-reviewers,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D202319
 2024-02-26 11:35:41 +00:00
Gijs Kruitbosch
3f42fcd65b Bug 1780071 - turn on no-comparison-or-assignment-inside-ok for xpcshell and browser tests, r=mossop,devtools-reviewers,fxview-reviewers,sclements,ochameau 
I'll split up the autofix commits separately assuming we're all happy to go ahead with this.

Differential Revision: https://phabricator.services.mozilla.com/D198594
 2024-02-20 12:40:07 +00:00
Marco Bonardo
2eaf2ecf1a Bug 1880510 - Use console.createInstance instead of Log.sys.mjs in Urlbar. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D201985
 2024-02-20 08:58:33 +00:00
Marco Bonardo
e7ff8da0d9 Bug 1862992 - Use console.createInstance for logging in SQLite JS Module. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D201981
 2024-02-19 16:21:27 +00:00
Mark Banner
e610a51084 Bug 1877940 - Enable remaining ESLint rules on dom/messagechannel. r=dom-core,peterv 
Differential Revision: https://phabricator.services.mozilla.com/D200280
 2024-02-12 22:28:14 +00:00
Mark Banner
5a0f9d9b3a Bug 1877940 - Enable remaining ESLint rules on dom/jsurl. r=dom-core,peterv 
Differential Revision: https://phabricator.services.mozilla.com/D200279
 2024-02-12 22:28:14 +00:00
Mark Banner
7aa835f970 Bug 1877940 - Enable remaining ESLint rules on dom/fetch. r=jesup 
Differential Revision: https://phabricator.services.mozilla.com/D200278
 2024-02-12 22:28:14 +00:00
Mike Conley
5ab28b68b9 Bug 1878731 - Convert ASRouterPreferences to an ESM. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201134
 2024-02-12 18:49:37 +00:00
Mark Banner
c689ddb4a2 Bug 1879811 - Replace deprecated ESLint rule no-new-object with no-object-constructor. r=Gijs,webdriver-reviewers,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D201362
 2024-02-12 18:46:29 +00:00
Mark Banner
3b17329c5f Bug 1878553 - Define *.config.(m)js files as node based for ESLint. r=mossop,devtools-reviewers,omc-reviewers,nchevobbe,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D200582
 2024-02-07 08:55:29 +00:00
Cristian Tuns
77f2a39423 Backed out 11 changesets (bug 1878554, bug 1878553, bug 1878556) for causing node failures in aboutwelcome CLOSED TREE 
Backed out changeset 425f70fa7e5a (bug 1878556)
Backed out changeset 2ab3a28f5c04 (bug 1878556)
Backed out changeset fb2e02682c8c (bug 1878556)
Backed out changeset 2fc5e630568e (bug 1878554)
Backed out changeset 78839d5841b4 (bug 1878554)
Backed out changeset e0ab31d2de1b (bug 1878554)
Backed out changeset 4eb59e4ebafa (bug 1878554)
Backed out changeset ab1e077d3f84 (bug 1878554)
Backed out changeset ef999f293e3e (bug 1878553)
Backed out changeset cf49920cb1ad (bug 1878553)
Backed out changeset 95f0fce63726 (bug 1878553)
 2024-02-07 01:26:39 -05:00
Mark Banner
239ead3884 Bug 1878553 - Define *.config.(m)js files as node based for ESLint. r=mossop,devtools-reviewers,omc-reviewers,nchevobbe,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D200582
 2024-02-06 22:32:51 +00:00
Karandeep
f19bf97d24 Bug 1855958 - Remove the experimental urlbar API (first patch). r=mak,extension-reviewers,desktop-theme-reviewers,robwu 
ext-urlbar.js is unused but will be removed in a separate
patch to avoid test failures in condprof tests. Condprof tests may use
an outdated profile directory that still references ext-urlbar.js in
startupcache files, which triggers a test-only test failure in
mozilla::net::CheckForBrokenChromeURL.

Differential Revision: https://phabricator.services.mozilla.com/D199769
 2024-02-05 17:04:37 +00:00
Mark Banner
56cc7346e1 Bug 1878009 - Remove Babel integration from ESLint. r=mossop,devtools-reviewers,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D200365
 2024-02-02 18:45:08 +00:00
Mike Conley
36547c669d Bug 1868838 - Move CFRMessageProvider into browser/components/asrouter/modules. r=pdahiya 
This requires a change to aboutwelcome's karma webpack packaging so that
resources loaded at "resource:///modules/asrouter/X.sys.mjs" get remapped
to "asroutermodules/X.sys.mjs".

Differential Revision: https://phabricator.services.mozilla.com/D198878
 2024-01-29 18:52:21 +00:00
Mark Banner
0b91be9f19 Bug 1875244 - Enable ESlint rules no-unused-vars and no-undef for dom/xslt. r=peterv 
Differential Revision: https://phabricator.services.mozilla.com/D198936
 2024-01-29 18:23:53 +00:00