Commit Graph

6 Commits

Author SHA1 Message Date
Josh Matthews
9eafebc4d0 servo: Merge #12772 - Avoid a common formatting problem in pull requests (from servo:jdm-patch-2); r=Manishearth
Increase the likelihood of a newline separating the pull request description from the checklist in pull request descriptions.

Source-Repo: https://github.com/servo/servo
Source-Revision: 8cd4b772e90224b344010cc6c38cebe47ce10c48
2016-08-08 12:12:39 -05:00
Josh Matthews
cc0c71cebb servo: Merge #11383 - Hide unnecessary information in the rendered PR template (from servo:jdm-patch-1); r=mbrubeck
These changes attempt to make the initial PR view less cluttered. Instructions are hidden in HTML comments, and there's a clear distinction between the PR description and the checklist.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:-->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy --faster` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because not part of the build

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: b898550149db5cdfc24cc2dfe5a7c7ad4d5d0a39
2016-05-26 02:30:48 -05:00
Mitchell Hentges
22e66c3da8 servo: Merge #11409 - Remove --faster flag from test-tidy, go fast by default. Fixes 11217 (from mitchhentges:test-tidy-faster-default); r=aneeshusa
Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11217 (github issue number if applicable).

Either:
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they just change command-line options, which aren't tested

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

This finishes #11267

Source-Repo: https://github.com/servo/servo
Source-Revision: ebb690d28c3c36ffba7059b64361fed3847861c7
2016-05-25 17:16:15 -05:00
Josh Matthews
048d9d30d3 servo: Merge #11201 - Suggest a faster tidy (from servo:jdm-patch-1); r=KiChjang
Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

Either:
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because documentation update.

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

Source-Repo: https://github.com/servo/servo
Source-Revision: 87fd387fa7f10d18b74f10e5126c0ea0f762bc99
2016-05-16 09:00:45 -07:00
Alan Jeffrey
402a9d47f7 servo: Merge #11141 - Reworded some of PULL_REQUEST_TEMPLATE.md (from asajeffrey:reword-pr-template); r=jdm
Thank you for contributing to Servo! Please add an `X` inside each `[ ]` when the step is complete, and replace `__` with appropriate data:
- [X] `./mach build` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

Either:
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they are just the PR template

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

r? @jdm

Source-Repo: https://github.com/servo/servo
Source-Revision: ef3c4102cf8edab962a950373f88bad5f71e2a90
2016-05-12 04:37:39 -07:00
Josh Matthews
4c97edbc2c servo: Merge #11118 - Create pull request template (from servo:jdm-patch-1); r=metajack
r? @metajack

Source-Repo: https://github.com/servo/servo
Source-Revision: 81246a7b61214fbbf7cf32208043afa670af1a7e
2016-05-11 08:36:14 -07:00