Commit Graph

15 Commits

Author SHA1 Message Date
Ting-Yu Lin
3277fc6dc5 Bug 1057256 - Part 2 - Add null pointer check for touch and selection carets. r=roc
TouchCaret::IsDisplayable() contains more null pointer check. It covers
what's original there in TouchCaret::HandleEvent().
2014-08-25 02:50:00 +02:00
Ting-Yu Lin
9a407aec80 Bug 1057256 - Part 1 - Remove NS_ENSURE_TRUE in SelectionCarets.cpp. r=roc
Remove NS_ENSURE_TRUE and NS_ENSURE_TRUE_VOID since they are deprecated,
and we do not need to print log in plain null pointer check.
2014-08-25 02:50:00 +02:00
Morris Tseng
ce44192262 Bug 1056457 - Remove batch changes in selection carets. r=roc 2014-08-20 20:23:00 +02:00
Robert O'Callahan
150ec76871 Bug 1048752. Part 24: Rename and deCOM Set/GetCaretVisible. r=tn
--HG--
extra : rebase_source : 04249e9b22a62b8f2952515fa48f4ba3227e235e
2014-08-06 17:19:29 +12:00
Robert O'Callahan
0a6d04586e Bug 1048752. Part 17: Rename Get/SetCaretDOMSelection to Get/SetSelection. r=tn
The forward declaration of Selection in nsCaret.h will be used in later patches.

--HG--
extra : rebase_source : d1b749adac983c04d3365bb6bfb76a50101beeb5
2014-08-06 17:19:27 +12:00
Robert O'Callahan
2489dc1f01 Bug 1048752. Part 16: Move nsFrameSelection::HINT to CaretAssociationHint.h. r=tn
This patch started an attempt to remove nsFrameSelection.h from nsCaret.h
and metastasized into a rather large refactoring patch that removed it
from some other header files as well, and changed nsFrameSelection::HINT
into a global-scope enum with better names. I also converted bools
into CaretAssociationHint in a few places where that was appropriate,
but there are still some more places (GetChildFrameContainingOffset)
where bools need to be converted. I figured this patch was big enough already.

--HG--
extra : rebase_source : cc618ef60e707e1360644340a2648de389383da0
2014-08-06 17:19:27 +12:00
Robert O'Callahan
b4ed20d441 Bug 1048752. Part 14: Split GetGeometry into a static and a non-static version. r=tn
GetGeometry is used in two different ways. Sometimes it's used to get
information about a particular caret. Sometimes it's used to get
information about a particular selection that's not associated with
a caret. Splitting GetGeometry into a non-static version for the former
and a static version for the latter makes this more clear. Also it saves
code since for the latter version we don't have to get an nsCaret first.

--HG--
extra : rebase_source : b7730dac56b308a82b79b175749234c9a92b6f59
2014-08-06 17:19:26 +12:00
Morris Tseng
f1d2262570 Bug 1050095 - Prevent drag event when calling SelectionCarets::SelectWord(). r=roc 2014-08-06 23:08:00 -04:00
Morris Tseng
f3682709b7 Bug 1046498 - Constrain frame to anchor subtree when dragging selection caret. r=roc 2014-08-06 01:55:00 -04:00
Morris Tseng
e805832aca Bug 1023041 - Part 1: Rename SetMouseDownState to SetDragState. r=roc 2014-08-04 00:26:00 -04:00
Morris Tseng
cc9241e019 Bug 987040 - Part 2: Add a flag indicate whether CollectClientRects should flush layout or not. r=ehsan 2014-07-23 23:06:00 +02:00
Morris Tseng
16565ccd04 Bug 1026431 - Determine tilt mode by next character of startFrame and previous character of endFrame. r=roc 2014-07-15 22:44:00 +02:00
Morris Tseng
e6c58de728 Bug 1024966 - Check mResultContent before using it. r=roc 2014-07-09 02:21:00 +02:00
Morris Tseng
3dd291a28e Bug 864595 - Provide a option which indicate to that offsets outside the frame box are allowed. [r=roc] 2014-06-27 13:58:57 -07:00
Morris Tseng
e0ddfe5e18 Bug 987718 - Part 5: Add SelectionCarets; r=roc 2014-06-04 22:57:00 +02:00