Automatic update from web-platform-tests
Fenced frame: Fix activeElement and hasFocus().
Currently, when a fenced frame has focus, its embedder's
`document.activeElement` will just return the body rather than the
fenced frame. Similarly, `document.hasFocus()` will return false when a
child fenced frame has focus, whereas it will return true if a child
iframe has focus. There's no security reason to not have fenced frames
behave like iframes in this case (the renderer has this information
anyway, nothing is leaked across a fenced frame boundary, and focus is
already gated to prevent cross-channel communication).
This CL modifies `FrameTree::Parent` to be able to traverse to the
parent of an HTMLFencedFrameElement. It does this by getting the
HTMLFencedFrameElement's owner's document's frame instead of the frame's
parent, which is null for a HTMLFencedFrameElement's frame. This change
will not affect anything inside of a fenced frame tree, since a fenced
frame root doesn't have access to its embedder's document.
As a result, when `FocusController::FocusedFrameOwnerElement` traverses
up a frame tree, it will be able to get the parent of an
HTMLFencedFrameElement when it's the focused element, and will be able
to properly check that `current_frame' is one of its ancestors.
We could previously make the assumption that if a frame tree doesn't
have focus, none of its children have focus. That assumption is broken
with MPArch. To fix that, this CL refactors
`FocusController::IsDocumentFocused` to account for the fact that an
HTMLFencedFrameElement can have focus while its embedder's frame tree
loses focus.
Change-Id: Ic7a1823113e2d9c4a22bff2b7b7b7df85c089d60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4892841
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Liam Brady <lbrady@google.com>
Cr-Commit-Position: refs/heads/main@{#1235177}
--
wpt-commits: 485bea6bb6e13e13959db7af8627bbca5518284c
wpt-pr: 42256
Automatic update from web-platform-tests
Cleaner fragment count change detection for paint invalidation.
Decouple fragment size and count change detection. Only detect size
changes during layout (and still only if we're fragmented). We can defer
detection of count changes to pre-paint. Doing that reliably in the
middle of layout is impossible, so there were false positives.
No behavior changes intended.
Add a test, to prove that the change in PaintPropertyTreeBuilder::
UpdateFragmentData() is needed.
Bug: 1285795
Change-Id: I4e2d6cfce9b6f8b7e4acd53c7c24f1cb5b77e5d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5096617
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1235111}
--
wpt-commits: 27143e969830f922c101e8af90c5e70fa801bbf8
wpt-pr: 43555
Automatic update from web-platform-tests
Prefetch: Allow use of HTTP cache for same-site prefetches
Adds functionality behind a feature flag that's enabled-by-default. In
addition to adding WPT and some browser test coverage, it also makes
most resources in external/wpt/speculation-rules/prefetch/resources
non-cacheable to prevent them from interfering with tests (in
particular we rely on request headers being injected by the wpt
server, which doesn't happen when a cached response is used).
Bug: 1506051
Change-Id: I0295feefb6621c54778ae62334cf20d711f69145
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5080758
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1235075}
--
wpt-commits: ea980464c32f84fcdfc1d13d3f04eef19cf298f2
wpt-pr: 43540
Automatic update from web-platform-tests
Make CSSPrimitiveValue ConvertTo use CssToLengthConversionData
Currently, number producing css math functions can have relative units,
but they are not resolved as the callers use GetDoubleValue() API,
which doesn't have a length resolve data.
This CL moves the API from GetDoubleValue() to ComputeInteger and
ComputeNumber as they make use of length resolve data and provide
support for the number producing math functions.
Bug: 1505817
Change-Id: Ia43b1db20164e6849d46c44f899eede4202c98f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5087972
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234933}
--
wpt-commits: 0bc5043bef2e7ca6774fab397fe063d03f806752
wpt-pr: 43562
Automatic update from web-platform-tests
Reland "Dispatch close event when MessagePort is disentangled"
This is a reland of commit 6a74d3d8049e1744b862757a73f90f3d7a5e08b0
The tests newly added by the original CL were failing on
chrome_wpt_tests on the Linux Tests bot:
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests/138259/overview
This is because the builder added in https://crrev.com/c/5005230 might be broken.
Specifically, chrome-wpt builder cannot run GC(Bug: 1509657) and BFCache doesn't
work on chrome-wpt builder(Bug: 1509303).
I changed two tests expectations described below.
・third_party/blink/web_tests/external/wpt/webmessaging/message-channels/close-event/garbage-collected.tentative.any.js
・third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/back-forward-cache/message-port-entangled-after-restore.https.tentative.window.js
Original change's description:
> Dispatch close event when MessagePort is disentangled
>
> We want to dispatch a close event when an entangled MessagePort is disconnected.
> Given a pair of entangled ports, port1 and port2, if port2 is closed at any point,
> a port1’s error handler is run.
> So we can change an error handler to dispatch a close event.
>
> The tests of close event are as follows:
> 1) port was explicitly closed.
> 2) owning document was destroyed.
> 3) owning document crashed.
> 4) port was garbage collected.
>
> Design Doc:https://docs.google.com/document/d/1lXZU2Pk2ycitqj8aL9kxT2aauwXqpA0vJDUalkXA29Y
> Explainer:https://github.com/fergald/explainer-messageport-close
> HTML spec PR:https://github.com/whatwg/html/pull/9933
>
> Bug: 1495616
> Change-Id: I99f9f5a0d7cc63f0916da316ec666ba793215019
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003089
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Commit-Queue: Nonoka Muraki <murakinonoka@chromium.org>
> Reviewed-by: Ming-Ying Chung <mych@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1231743}
Change-Id: I0a8f31245d7b5abe9ddfc262dff8063316e953df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5083156
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Nonoka Muraki <murakinonoka@chromium.org>
Reviewed-by: Ming-Ying Chung <mych@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234854}
--
wpt-commits: 05aab53917a8309fe7f1ab5c50d094ac488ce942
wpt-pr: 43491
Automatic update from web-platform-tests
Reland "[keepalive-migration] Add fieldtrial testing config"
This is a reland of commit 4d11ed9db093fc278985bea63c03f2a7b0a94bd7
There is another test `virtual/no-forced-frame-updates/external/wpt/html/browsers/browsing-the-web/history-traversal/pagereveal/tentative/order-in-prerender-activation.html` [1]
that also relies on the pre-migration side effect of
`PrerenderChannel`.
This patch disable the migration for that virtual test suite.
[1]: https://ci.chromium.org/ui/p/chromium/builders/findit/test-single-revision/4940/test-results?sortby=&groupby=
Original change's description:
> [keepalive-migration] Add fieldtrial testing config
>
> Also explicitly disable the flag for the virtual test suite that
> relies on the pre-migration side effect of making fetch keepalive
> requests, that Document being able to stay alive after unload, and
> hence being able to execute Promise result.
>
> Bug: 1356128
> Change-Id: I330672ab2e40e299d46f48771c665e31755013cc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5069563
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
> Auto-Submit: Ming-Ying Chung <mych@chromium.org>
> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1234386}
Bug: 1356128
Change-Id: I3ae9a0c23d15dbd0472041816aef50db27b9d112
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5101871
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Ming-Ying Chung <mych@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234841}
--
wpt-commits: 32e9e60f0fd4d7b0bc98c632ec45bc842982a4aa
wpt-pr: 43569
Automatic update from web-platform-tests
Revert "Fix NOTREACHED in layoutTheme::DefaultSystemColor"
This reverts commit ef6ca09bf1a50b107e7a3dae248d2a9811e46a5f.
Reason for revert: Probably cause of failure in https://ci.chromium.org/ui/p/chromium/builders/ci/Mac13%20Tests%20(dbg)/4670/test-results?q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fvirtual%2Fthreaded%2Fexternal%2Fwpt%2Fcss%2Fcss-backgrounds%2Fcolor-mix-currentcolor-background-repaint.html+VHash%3Afff8f2486dabd4c5
Original change's description:
> Fix NOTREACHED in layoutTheme::DefaultSystemColor
>
> CSS transitions and animations did not support unresolved color-mix.
>
> With this patch, transitions work with unresolved-color-mix, and CSS
> animations work with unresolved-color-mix in a neutral keyframe. Still
> need to support unresolved-color-mix with a string keyframe for a CSS
> animation.
>
> Bug: 1493430, 1500708, 1464035
> Change-Id: I7aa71ae8af4a8908f49bb41c5378f00c9a748c88
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5014009
> Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
> Commit-Queue: Kevin Ellis <kevers@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1232024}
Bug: 1493430, 1500708, 1464035, 1507138
Change-Id: I9ea8fc3824e126f0e24fb061730a3bc36f8a1010
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5101808
Owners-Override: Clement Yan <clamclamyan@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Clement Yan <clamclamyan@google.com>
Cr-Commit-Position: refs/heads/main@{#1234808}
--
wpt-commits: e883ed3101588a604d6d77b9bbaa44d748692b23
wpt-pr: 43568
Automatic update from web-platform-tests
[FedCM] Make accountHint required
Also change the error thrown when clientId or configURL are not
present in the disconnect() method. They cannot be marked as required
in the IDL due to prototypes which assume that they are optional.
Bug: 1473134
Change-Id: Ic14c327a63c99eb81058bd64ab9524402ea26539
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5100476
Auto-Submit: Nicolás Peña <npm@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234771}
--
wpt-commits: c41d8c520683379b1fbf99cbce610fe80f63988e
wpt-pr: 43567
Automatic update from web-platform-tests
[A11y] Simplification -- don't create tree holes for layout updates
When the layout tree changes, invalidate the related a11y subtree
completely.
This removes one more call site for RepairChildrenOfIncludedParent(),
leaving only one caller remaining, which we hope to remove in a
follow-up.
Also fixes a bug, where the descendants of a textarea were missing
a parent.
Fixed: 1503069
Change-Id: If2176b5d013a0c2e0ecbd581a99ac45e4619ceda
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4995912
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234765}
--
wpt-commits: 41414fff6d5b33b7b54ca248c8206bef75566fa2
wpt-pr: 43524
Automatic update from web-platform-tests
IndexedDB: run just a small subset of nested-cloning tests on MSAN.
Most of these related tests were already marked as timing out. After
some investigation it's apparent that reading and writing many
very large blobs is slow under MSAN. Therefore, split off a small
chunk of the tests to run under MSAN (hopefully that will retain
some potential to catch memory errors) while disabling the majority.
Use Skip instead of Timeout so as to stop wasting bot cycles.
Bug: 1508160
Change-Id: I40ba9ddb2ce4688a055c485044125a3eddd7b452
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5090079
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Nathan Memmott <memmott@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234729}
--
wpt-commits: 24b2021980addfbd3ab52a10a7df22493deda61e
wpt-pr: 43529
Automatic update from web-platform-tests
[FedCM] Do not crash for pending disconnect/getUserInfo
If the FederatedAuthRequestImpl is invoked and there are pending
requests, the destructor will clear out the FederatedAuthRequestImpl
members. This will in turn invoke the members' destructors, which then
complete their requests. However, to do so they run the completion
callback which is currently expecting the members to be present. This
CL fixes this by removing that expectation, and adding WPTs that would
have crashed in Chrome before this CL.
Bug: 1504569
Change-Id: I3327398740ee641d43a2a4b93420ac8ff56ae8fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5085229
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234701}
--
wpt-commits: 29cdefab41a941e0fce230c5475ee1459a390a02
wpt-pr: 43503
Automatic update from web-platform-tests
[FLEDGE] Calculate trusted_bidding_signals_slot_size_param
This CL makes InterestGroupAuction calculate the
trusted_bidding_signals_slot_size_param to append to trusted bidding
signals network requests based on interest group's
TrustedBiddingSignalsSlotSizeMode.
Also use Mojo to wire this value through the BidderWorklet to the
TrustedSignals layer.
This CL mostly uses WPT tests for the new behaviors, though it does
add a couple AuctionRunner tests for request batching, since that
isn't guaranteed by the spec.
Bug: 1506238
Change-Id: Ia33627c9049015404147a5ad245ca8cad28cb7d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5077540
Reviewed-by: Russ Hamilton <behamilton@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234623}
--
wpt-commits: 75dd6dec07645f9848668711ae335bf447f0b7e1
wpt-pr: 43518
Automatic update from web-platform-tests
Make transform builder use resolvable ComputeNumber for scale()
GetDoubleValue that doesn't pass the css to length conversion data and
just takes the raw double value of the expression.
But this approach doesn't work for cases where number producing math
functions are used.
Implement and use ComputeNumber instead.
Bug: 1505817
Change-Id: Iecf02eea030c76f16593fa2e4206e158c69cd863
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5079453
Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234524}
--
wpt-commits: e4e8e8c26d7afd7a221c5db0fa44ed65cff23e06
wpt-pr: 43556
Automatic update from web-platform-tests
[css-variables] Count “--foo: initial” as a style declaration.
When the current system of independent inheritance-like behavior
for custom properties was written, the ComputedStyle was marked as
having a variable declaration from fairly deep down in Resolve().
However, if using “initial” (or “inherit”, but that should be
irrelevant for this discussion), Resolve() would never be called,
and the ComputedStyle would erroneously be counted as not having
a variable declaration. Thus, independent inheritance would not
be properly stopped for such elements, leading to wrong results
in some recalcs.
Fix by setting the property in CustomProperty::Apply* instead,
which seems like a more logical place to begin with. (We could
also apply it in StyleBuilder::ApplyPhysicalProperty() if we
wish to have it only one place, but it would require an extra
test there that would be irrelevant for most properties.)
Change-Id: Ibd4ecba702ee82232f5093c91904cf4527056694
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5095744
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Steinar H Gunderson <sesse@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234453}
--
wpt-commits: ec42cbde465a2cae1c641c464bf52dcf6544f805
wpt-pr: 43552
Automatic update from web-platform-tests
Missing ::first-letter style update for size queries
Style for ::first-letter pseudo elements are updated as late as possible
to allow nodes to re-attach to make sure any first-letter text node
changes are included when computing style for the first rendered letter.
When the StyleRecalcChange were already marked for ReattachLayoutTree()
when reaching the ::first-letter update, we assumed some ancestor of the
::first-letter element would be re-attached, and the ::first-letter
style being updated in Element::AttachLayoutTree() for the originating
element. But, if the originating element was a size container, and we
skipped style recalc for its descendants, we would mark the stored
StyleRecalcChange for re-attachment of the children when resuming, even
if the originating element itself would be re-attached.
Instead, check that we also did not suppress style recalc for the
originating element for the ::first-letter before skipping its style
update during style recalc.
Bug: 1505250
Change-Id: I8d45c219e0d8c2a2d8ab6e0ec6149d9f34366fad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5097303
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234442}
--
wpt-commits: 94b37f7624fb523c15cdd581755a2556ddd2b65b
wpt-pr: 43543
Automatic update from web-platform-tests
Add noto fonts to the Docker image
This ensures that we have fallback glyphs for most/all
characters. This affects some tests
e.g. css/css-fonts/size-adjust-unicode-range-system-fallback.html (see
https://bugzilla.mozilla.org/show_bug.cgi?id=1860124)
Covering all of unicode does mean that we end up with a rather large
increase in the docker image size. If this causes problems we could
just install fonts-noto-cjk to fix the known breakage.
--
wpt-commits: 00dee68a67459b04b971f928c7360cb1be036613
wpt-pr: 42730
Automatic update from web-platform-tests
[keepalive-migration] Add fieldtrial testing config
Also explicitly disable the flag for the virtual test suite that
relies on the pre-migration side effect of making fetch keepalive
requests, that Document being able to stay alive after unload, and
hence being able to execute Promise result.
Bug: 1356128
Change-Id: I330672ab2e40e299d46f48771c665e31755013cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5069563
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Auto-Submit: Ming-Ying Chung <mych@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234386}
--
wpt-commits: e98188eff115b25d1b1f6bc4122bcd338dc65326
wpt-pr: 43533
Automatic update from web-platform-tests
Move popover=hint related code out of non-tentative test
This refactors the test logic into a shared JS file and splits
the popover=hint test code into a new .tentative.html file.
Per this comment:
https://github.com/web-platform-tests/interop/issues/423#issuecomment-1832409034
Bug: 1416284
Change-Id: Idda2716c476cf3d9b8fea724ece6e48d66e1fb62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5074321
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234222}
--
wpt-commits: fcd111f4f95c9dae1d0dd7f938fe427699534bc0
wpt-pr: 43436
Automatic update from web-platform-tests
Avoid bad relayout roots inside pagination.
We were already preventing this from happening when inside multicol, but
it turns out that we need it for printing as well.
It is actually (at least currently) possible for the print layout to be
updated after initial layout for pagination but before painting
(printing) it. Accessibility may trigger this via Document::
AddAXContext(), which may be called at such an inconvenient time, and it
may trigger a style recalc, and thus layout. Due to crbug.com/452672, it
may also happen inside a window.matchMedia("print") listener.
Bug: 1507840
Change-Id: I213efc610c2b57fc3beceef99e5c52c8655bc483
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5093875
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234192}
--
wpt-commits: d28d3aae7f6bcf91a8c3f1db12852cb17511d2f3
wpt-pr: 43535
Automatic update from web-platform-tests
Split out anchor-attribute related stuff from popover test
Per the [1] comment, this test contained things about the anchor
attribute which aren't (yet) standardized. So this CL splits
those parts out into a separate tentative test.
[1] https://github.com/web-platform-tests/interop/issues/423#issuecomment-1834039095
Bug: 1309178
Change-Id: I46969c0336a6260b4551ae9111fb0002231464fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5082149
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234212}
--
wpt-commits: e905d6af9e32b9cfa514f8950c6ec82e3d59e4ad
wpt-pr: 43501
Automatic update from web-platform-tests
Make ic-width consistent regardless of text orientation.
We obtained the ic-width using the FontMetrics::IdeographicFullWidth()
function. Unfortunately, this value is influenced by the text's
orientation. When the orientation is vertically upright,
IdeographicFullWidth() provides the vertical advance height of the CJK
water glyph. However, when the orientation is different, it returns the
horizontal width of the water glyph. As per the definition [1], the
ic-width for font-size-adjust should be a consistent value, which is the
horizontal advance width of the CJK water glyph divided by the font
size. This consistency should be maintained regardless of the text's
orientation.
[1] https://www.w3.org/TR/css-fonts-5/#valdef-font-size-adjust-ic-width
Test: external/wpt/css/css-fonts/font-size-adjust-text-orientation.html
Bug: 1219875
Change-Id: I3cc9e6128854aa7b127ba3932f34b9cfec1970ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4995847
Commit-Queue: ChangSeok Oh <changseok.oh@bytedance.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234205}
--
wpt-commits: d1bb35dae8f4a383b45e17558f4631a322cc8a54
wpt-pr: 42890
Automatic update from web-platform-tests
Add waitForCompositorReady to scroll-behavior-* tests.
Due to paint holding, the first composited programmatic smooth scroll
animation is usually not committed for 30+ rAFs, which is longer than
observeScrolling() is willing to wait.
Bug: 1489704
Change-Id: I4d111d0e3de6d482da0ac3a3bd711a4e119faa49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5091809
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234174}
--
wpt-commits: ae1e786b4a77e4256a6873b1fbeedf48c4437831
wpt-pr: 43531
Automatic update from web-platform-tests
[css-scroll-snap-2] Implement snapchanging for user scrolls
snapchanging should fire as soon as the browser determines to snap to a
position with a different set of snap targets than its current position
or its most recent snapchanging targets during a scroll.
Bug: 1494892, 1504159
Change-Id: I4e97688abb9ccc3fe6f1abac6e102316f4f97b0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5037501
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234129}
--
wpt-commits: 63bf12229d8b71f6f4abff0fd96b8418410797a7
wpt-pr: 43236
Automatic update from web-platform-tests
Allow cross-origin subframes to send automatic beacons.
Fenced frames can send out reporting beacons if an event occurs.
However, only same-origin documents are allowed to send automatic
beacons. This restriction is problematic when a subframe from a
third-party ad server is embedded in an ad loaded with a script from
that server. One such use case is when an ad frame embeds a subframe
that loads the actual contents of an ad. This is known as Third-party ad
serving, or 3PAS.
The solution to allow cross-origin subframes to send automatic beacons
involves four parts: subframes will opt in through a header, the main ad
frame will opt in to allow cross-origin subframes to use its automatic
beacon data when sending automatic beacons, the subframe will then be
able to use the automatic beacon data that is stored in its frame tree's
FencedFrameConfig, and the automatic beacon data will be stored
per-document rather than per-fenced frame config.
The opt-in mechanism for the main ad frame's data is a new
"crossOriginExposed" parameter in
`setReportEventDataForAutomaticBeacons()`, which defaults to false.
The opt-in mechanism for the cross-origin subframe is done through a new
"Allow-Fenced-Frame-Automatic-Beacons" response header.
The reason for storing the beacon data per-document is a security one.
With the current setup, a same-origin subframe of an ad frame could set
automatic beacon data, and a different cross-origin subframe could then
use that data. Since those two frames are not direct descendants of each
other, we want to prevent that behavior, and instead only allow
documents to use opted in data set by direct ancestors.
This CL also modifies the automatic beacon web platform tests to
properly handle multiple beacons being sent with the same data. The
automatic beacon store endpoint now accepts a "beacon type" parameter
that is added to the hash when storing/retrieving a beacon. This will
prevent collisions if two beacons with different types are sent with
the same data.
Change-Id: I4af9d7ef34732dcd56c4f6bcf677f48956f7968c
Bug: 1504306
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5018876
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Garrett Tanzer <gtanzer@chromium.org>
Commit-Queue: Liam Brady <lbrady@google.com>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234109}
--
wpt-commits: 458d51295af838f04608bda0dc912aaf88bc1de3
wpt-pr: 43125
Automatic update from web-platform-tests
wpt: Update some security-features scripts to run under Python 3.
In Python 3, dict.keys() returns an object which doesn't have
a remove() method. Instead, this is converted to a list so that
this kind of manipulation is possible.
basestring no longer exists in Python 3, so str is used instead.
Technically basestring also includes bytes, but as far as I can
tell it's not reasonable for bytes to end up here.
Finally, message is not guaranteed to exist, so the error object
itself is printed instead.
Change-Id: Iad38779f8cfcfe1f464b73e8cbabef923d90f6ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5090427
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234071}
--
wpt-commits: 8b2ff8f91555ee3cda84ad9bca665d960c4769e7
wpt-pr: 43526
Automatic update from web-platform-tests
Fix memory leak in mousemove_prevent_default_action.
The leak was likely the result of the following:
1. Promise.race only ensuring that one of the promises got resolved.
2. test-driver unable to complete the drag 'n drop operation.
Event sequence stalls at dragenter.
Resolve by cancelling the drag 'n drop operation during drag start.
The purpose of the test is not to ensure the successful completion of
a drag 'n drop operation, but rather to ensure that a preventDefault
on mousemove does not block a drag operation from starting.
Bug: 1508026
Change-Id: I9c94780b478a8a0dbb7cc577d0fb53fd7719ea62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5089155
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1233999}
--
wpt-commits: 730060196d22566dd233cdbfda9c0c807564ff16
wpt-pr: 43527
Automatic update from web-platform-tests
Revert "[css-images-4] Implement unprefixed cross-fade()."
This reverts commit b15018bba29189526bd341b796f37599a7f319de.
Reason for revert: The CL is likely the cause of crbug.com/1508861.
Original change's description:
> [css-images-4] Implement unprefixed cross-fade().
>
> This is similar to -webkit-cross-fade(), but differs in that it
> has a different syntax, and supports more (or less) than two images.
> It also supports cross-fading against a solid color, which we implement
> internally as a gradient for simplicity. (This may not be optimal for
> memory or performance, but it should do for now.)
>
> We do not implement parts of the spec that are not yet written
> but will be, in particular simplification at computed value time.
>
> The functionality is behind a new runtime flag CSSCrossFade,
> which is set to experimental as usual.
>
> Change-Id: I4d29e14b215a65223b98dcaee8ba99b8f62d94dc
> Bug: 614906
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5055552
> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
> Auto-Submit: Steinar H Gunderson <sesse@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1233870}
Bug: 614906
Change-Id: I77cfd8e9d833a5d000589068e4f1397c3afaad06
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5094054
Owners-Override: Felipe Andrade <fsandrade@chromium.org>
Auto-Submit: Felipe Andrade <fsandrade@chromium.org>
Commit-Queue: Felipe Andrade <fsandrade@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1233911}
--
wpt-commits: 99b9bc1e616081ad91397f7168d2f17e9992db93
wpt-pr: 43537
Automatic update from web-platform-tests
[css-images-4] Implement unprefixed cross-fade().
This is similar to -webkit-cross-fade(), but differs in that it
has a different syntax, and supports more (or less) than two images.
It also supports cross-fading against a solid color, which we implement
internally as a gradient for simplicity. (This may not be optimal for
memory or performance, but it should do for now.)
We do not implement parts of the spec that are not yet written
but will be, in particular simplification at computed value time.
The functionality is behind a new runtime flag CSSCrossFade,
which is set to experimental as usual.
Change-Id: I4d29e14b215a65223b98dcaee8ba99b8f62d94dc
Bug: 614906
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5055552
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Auto-Submit: Steinar H Gunderson <sesse@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1233870}
--
wpt-commits: 2f00e95d38dbb8969039840432c5fb42f3c23255
wpt-pr: 43417
Automatic update from web-platform-tests
Unload: reject promise on pagehide instead of unload
This test fails in Chrome because it depends on the promise triggered
by unload event. This CL changes it to pagehide handler so it would be
triggered as expected even after unload is deprecated in Chrome.
In other browsers, pagehide is also triggered for the case that is
tested by the test (detecting navigation), and is more reliable than
unload.
Bug: 1488371
Change-Id: If44b78e5ff89b1d5ba8901be48cb9ad118a67650
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5070653
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Nonoka Muraki <murakinonoka@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1233805}
--
wpt-commits: 746807e7a50fda7a427489a9c8f81552edd6c0c7
wpt-pr: 43412
Automatic update from web-platform-tests
Speculation Rules: Drive-by test fixes
Noticed a couple of things that needed fixing while working on another
CL.
Change-Id: I45bab97ce74a3119064a9133c0450be62d29dadc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5090807
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1233630}
--
wpt-commits: 82dbabc409af6754fe71aa14b3d7331b04374bef
wpt-pr: 43528
Automatic update from web-platform-tests
IndexedDB: fix structured-clone.any.html
There was a race between setting up the transaction event watcher and
the transaction auto-committing.
Unfortunately I don't see a great way to make this testing pattern more
full-proof, e.g. by checking whether the transaction is already finished
at the time of setting up the observer, since there's no way to check
the transaction's current state.
This is a good example of the pain of mixing IDB's unique flavor of
async with promises.
Bug: 1506270
Change-Id: I9cd630f9e2732532471c04841d4fbf8ddd722d66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5086039
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Nathan Memmott <memmott@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1233503}
--
wpt-commits: c0fdc0225d2294c8a5002f5684f00012609eb9ae
wpt-pr: 43520
Automatic update from web-platform-tests
[soft-navigations] Fix crash when user interaction precedes softnav (#43502)
[1] ended up causing crashes in cases a non-soft-navigation user
interaction precedes a soft navigation.
This CL fixes that by:
* Making sure we're not emitting soft nav entries before their time was
set.
* Emitting softnavs when the time is set, if all conditions were met
before then.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/5071732
Bug: 1507750
Change-Id: I9e26cebfcab2313b425261004a0e1eeaa8517842
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5079439
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1232691}
Co-authored-by: Yoav Weiss <yoavweiss@chromium.org>
--
wpt-commits: 565993e57b6cceae7f3a2ae7954929d9ab76b809
wpt-pr: 43502
