This revision adds a null check on mBounds in BundleFieldsForCache, in order to
avoid crashing in release when mBounds is empty.
Differential Revision: https://phabricator.services.mozilla.com/D225273
Automatic update from web-platform-tests
Account for spacing around `mo` in WPT test width-height-001.html
For `mo` elements, the preferred width of a shrink wrapper around the
operator includes the spacing around it.
This change introduces a special case for `mo` to account for this.
Bug: 370553386
Change-Id: Ie220443b57bb5ab63fd996acf9ec760a02ca612a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5924353
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1367094}
--
wpt-commits: 489e5375b841dca41b93b872e65a7fa9a7ce936b
wpt-pr: 48569
Automatic update from web-platform-tests
IDB WPTs: Extend several IDB WPTs to run on workers (Part 1)
This set of IndexedDB WPTs currently only run in a window environment.
This change extends them to also run in dedicated, shared, and service
worker environments.
Bug: 41455766
Change-Id: I2fb918988187e1f72406f4af058e0fca4d27544e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5923040
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Rahul Singh <rahsin@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1367074}
--
wpt-commits: c4de27055b51c63693554edc8efbf24d078ccdc4
wpt-pr: 48567
Automatic update from web-platform-tests
DOM: moveBefore() still runs the update selectedness algorithm
Per
https://docs.google.com/document/d/1qfYyvdK4zhzloABKeh0K1lHPm-SpnEcsWEE9UdDuoMk/edit, this CL adds tests for select/option/optgroup
move + selectedness semantics.
This CL also fixes a crash in ContainerNode::WillRemoveChildren(), which
is now reachable during an atomic move, via customizable select [1].
When an option element gets text-only rendered as a result of being
removed from a select element, it wipes *all* of its children, which
could include arbitrary content like iframes. The WillRemoveChildren()
path previously expected to never get called during an atomic move, but
this CL treats it the same as the WillRemoveChild() path, and gates the
child frame disconnector's use on non-SPAM flows.
[1]:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/forms/html_option_element.cc;l=581-583;drc=0afdaad03fc3fc271a751cb77dea8c8efb84b49f
R=masonf, nrosenthal
Bug: 40150299
Change-Id: I0e1064446b8a0359a62b1be152fec22fc9a583b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5921538
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Noam Rosenthal <nrosenthal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1366923}
--
wpt-commits: da7a99eda6c075329954fe13e87efed02a14a184
wpt-pr: 48551
Automatic update from web-platform-tests
Revert "Reland "webnn: add int4 and uint4 support for quantizeLinear and dequantizeLinear""
This reverts commit c80028acacc05ac6687d44d9af5c95851b88b11e.
Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/4613650955370496
Sample build with failed test: https://ci.chromium.org/b/8734476474207096209
Affected test(s):
[ninja://services:services_unittests/WebNNGraphImplTest.Resample2dTest](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fservices:services_unittests%2FWebNNGraphImplTest.Resample2dTest?q=VHash%3A447d241cfa07cbd2)
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F4613650955370496&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5918905&type=BUG
Original change's description:
> Reland "webnn: add int4 and uint4 support for quantizeLinear and dequantizeLinear"
>
> This is a reland of commit 3a1707bcd20fa2fc4b1036755259ed01dc6632d5.
> The original commit was reverted due to the crash of WebNNGraphImplTest.Resample2dTest for android-oreo-x86-rel.
>
> However, I can't reproduce this crash locally and the
> android-oreo-x86-rel bot in chromium can pass now without
> changing any code.
>
> Original change's description:
> > webnn: add int4 and uint4 support for quantizeLinear and dequantizeLinear
> >
> > This CL also adds some WPT conformance tests to verify the
> > implementation.
> >
> > Bug: 40206287
> > Change-Id: Ieb8ce3ae2182388ae7cc98cd1fc8e3d2dcd9c7d2
> > Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5861613
> > Commit-Queue: Lisha Guo <lisha.guo@intel.com>
> > Reviewed-by: ningxin hu <ningxin.hu@intel.com>
> > Reviewed-by: Alex Gough <ajgo@chromium.org>
> > Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
> > Cr-Commit-Position: refs/heads/main@{#1365343}
>
> Bug: 40206287
> Change-Id: I8c3b922d092214e4c56ffb5298b86c8d12baf8c0
> Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5918905
> Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
> Reviewed-by: ningxin hu <ningxin.hu@intel.com>
> Reviewed-by: Alex Gough <ajgo@chromium.org>
> Commit-Queue: Lisha Guo <lisha.guo@intel.com>
> Cr-Commit-Position: refs/heads/main@{#1366660}
>
Bug: 40206287
Change-Id: I6d5f975e9542dfa57d6a39feebddd09504a84b9f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5921347
Owners-Override: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1366838}
--
wpt-commits: 7d3a993557ebc6275849f090f855937610fb0a88
wpt-pr: 48562
Automatic update from web-platform-tests
Implement keyword sizes on atomic inlines
Adds support for min-content, max-content, fit-content and stretch,
for atomic inlines.
There are some new test failures because we don't support vertical
writing modes nor `transition-behavior:allow-discrete`.
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
--
wpt-commits: 1998b7ca2c7ebc8f9cd06cebb49f421a55f4cdb1
wpt-pr: 48525
Automatic update from web-platform-tests
Tweak fuzzy parameters for WPT clip-path-url-reference-external.html
Adjust the fuzziness parameters to allow bigger differences (due to
anti-aliasing) in the test:
wpt/css/css-masking/clip-path/clip-path-url-reference-external.html
Based on the data from wpt.fyi.
Bug: 40134477
Change-Id: Ied9d133173d9bcaa79a62ea9618f1e27b46b2788
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5920927
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1366797}
--
wpt-commits: ae1c8b0def67dc69428dcd480cf695df593aa8ae
wpt-pr: 48559
Automatic update from web-platform-tests
Call RebuildLayoutTreeForChild for pseudo elements
Use the same code path as for normal elements to make sure the
WhiteSpaceAttacher marks pseudo elements as visited to get correct
whitespace handling. Also use RebuildPseudoElementLayoutTree() for the
::marker pseudo since the implementation was basically the same.
Fixes an incorrect whitespace removal bug and a fuzzer crash caused by
inconsistent ::first-letter texts when size containers were involved.
Bug: 372252513, 372358471
Change-Id: I1f99f3b83809b9eef72b42aec9ad099bf3c56ded
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5920416
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1366747}
--
wpt-commits: f7366fb77eba1808af820524ad64744d9207a524
wpt-pr: 48548
Automatic update from web-platform-tests
Reland "webnn: add int4 and uint4 support for quantizeLinear and dequantizeLinear"
This is a reland of commit 3a1707bcd20fa2fc4b1036755259ed01dc6632d5.
The original commit was reverted due to the crash of WebNNGraphImplTest.Resample2dTest for android-oreo-x86-rel.
However, I can't reproduce this crash locally and the
android-oreo-x86-rel bot in chromium can pass now without
changing any code.
Original change's description:
> webnn: add int4 and uint4 support for quantizeLinear and dequantizeLinear
>
> This CL also adds some WPT conformance tests to verify the
> implementation.
>
> Bug: 40206287
> Change-Id: Ieb8ce3ae2182388ae7cc98cd1fc8e3d2dcd9c7d2
> Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5861613
> Commit-Queue: Lisha Guo <lisha.guo@intel.com>
> Reviewed-by: ningxin hu <ningxin.hu@intel.com>
> Reviewed-by: Alex Gough <ajgo@chromium.org>
> Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
> Cr-Commit-Position: refs/heads/main@{#1365343}
Bug: 40206287
Change-Id: I8c3b922d092214e4c56ffb5298b86c8d12baf8c0
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5918905
Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Lisha Guo <lisha.guo@intel.com>
Cr-Commit-Position: refs/heads/main@{#1366660}
--
wpt-commits: 481d2016333ec23268b2cca30ea11e9bcb5a53af
wpt-pr: 48554
Automatic update from web-platform-tests
Update the sampling option for imageFilterQuality set to Medium or High
Currently, we are using bi-cubic sampling method, CatmullRom(), when
filter quality is set to High; and using linear sampling when the
quality is set to medium.
However, the bicubic sampling under perform than the linear sampling
when the image is scaled down: https://fiddle.skia.org/c/9822e1bbf3e6e69498fe9a3e86ef49f3 (bicubic)
and https://fiddle.skia.org/c/2b9f1057f9437710a993844fc1b015e2 (linear).
In this cl, I updated the sampling method respected to the image scale,
i.e., uses Mitchell for scaling up and linear for scaling down for both
medium and high quality.
I choose Mitchell over CatmullRom because Mitchell produces less Ringing
around color change.
Bug: 40044062
Change-Id: Iae6df006a5153b0c31959d3767a9e0f782b7d5a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5806239
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1366572}
--
wpt-commits: 862d21cede6fcbc851b87245157d4a502c5f3243
wpt-pr: 48529
