Bug 1495569 - Part 0: web-platform-test that verifies handling of offer without mid.
Bug 1495569 - Part 1: Ensure that answers are created with the transceiver's mid when the offer did not have a mid.
Differential Revision: https://phabricator.services.mozilla.com/D8853
--HG--
extra : moz-landing-system : lando
It's not maintained and probably does not work anymore.
Differential Revision: https://phabricator.services.mozilla.com/D5438
--HG--
extra : rebase_source : ccd622e40844dda5d16266e49991462d4ea94224
For now, the H264 decoding support is rather sturdy. It handles change of resolution and content smoothly thanks to the H264Converter.
The VP8/VP9 one however, not so much.
So we make a preference to only enable H264 for now.
Depends on D7895
Differential Revision: https://phabricator.services.mozilla.com/D7908
--HG--
extra : moz-landing-system : lando
The only consumer of this code was Singleton, which we previously
removed, and everything that this code accomplished can be done more
simply and more foolproof-y by standard constructs these days.
When we remove singleton.h, some webrtc code will be unhappy, because of
cargo-culted definitions from singleton.h or included headers. Let's
fix those first
These are identical to the 32 bit versions and so are no longer necessary to correctly
generate moz.build files for windows.
Depends on D7101
Differential Revision: https://phabricator.services.mozilla.com/D7102
--HG--
extra : moz-landing-system : lando
The NEON codepaths could work, but they'd have to be converted to
MSVC-friendly assembly (or separate .asm files) first. Just disable
building them for now.
This removes the info messages and adds the packet type to the error messages.
Differential Revision: https://phabricator.services.mozilla.com/D6392
--HG--
extra : moz-landing-system : lando
This patch sets mDecoderStatus from the GMPThread so we can eventually report
an error back to the caller. Since this done during an asynchronous call, there
is no guarantee that the error will be associated with the correct frame, but
this workaround should eventually cause an error to be signalled, so that a
PLI can be requested and video will not freeze.
--HG--
extra : rebase_source : 2c32de4218b97ce1a47c5ec118cc864fff786060
webrtc.org is picky about resolutions for simulcasst layers.
As of current it will assert that all layers have identical aspect ratio.
We handle this by ignoring layers where the aspect ratio is not the same as
the highest layer's.
The new algorithm will, when simulcast is requested and at least one layer
is scaled to something other than 1.0, try to remedy this by:
- The highest resolution layer is cropped to 16-pixel alignment, to ensure
that scaling options exist.
- A separate VideoAdapter is used for simulcast layers, with the highest
layer's resolution as an aspect ratio requirement. This forces the
simulcast adapter to retain that aspect ratio in any scaling decisions.
This doesn't make scaling decisions spec-compliant (floor the width and
height respectively) but it does allow for control of scaling via
setParameters and keeps scaling decisions in upstream code to ensure
good compat with upstream's part of the pipe; encoders, etc.
Differential Revision: https://phabricator.services.mozilla.com/D4133
--HG--
extra : moz-landing-system : lando
A failure here typically indicates a test error, so it's useful for debugging.
Differential Revision: https://phabricator.services.mozilla.com/D4124
--HG--
extra : moz-landing-system : lando
Because all Rust crates in the tree are vendored, using the wildcard
"*" version dependency could have unintended reprecussions on
rsdparsa if another crate changes its log version dependency.
This patch, along with the others associated with this bug, upgrades
the log crate to 0.4.* throughout. This has the benefit that we
can get rid of the duplicate vendored log crates in third_party/rust.
By relaxing the version dependency on the log crate we are able to
get rid of duplicate vendored crates.
This particular version number, combined with rsdparsa depending
on "*" (anything) meant that a change to this version number in
audioipc would have reprecussions on the dependencies of rsdparsa.
I will address the wildcard version in a separate patch on rsdparsa.
Update content_decryption_module.h and other Widevine headers. This removes the
CDM8 interface and adds in the CDM10 and CDM11 interfaces. As such this patch
removes references to CDM8 from the code and adds some of the foundations for
supporting CDM10. Most of the CDM10 code will be implemented in another bug, but
there are a number of cases where it was straight forward to shuffle CDM8+9 code
-> CDM9+10, rather than deleting it and replacing it later.
Differential Revision: https://phabricator.services.mozilla.com/D5628
--HG--
extra : moz-landing-system : lando
This enables us to configure it for cropping to a certain resolution alignment in a future patch.
For instance with simulcast, so we don't have to skip a layer because it is impossible to scale
the highest layer any further without losing the aspect ratio.
--HG--
extra : rebase_source : 4560c60dfa95213b2f3357d0b279c07835402b33
extra : source : e80af22a3bf37ad8fa5762d9a16d677d2befd470
Summary:
The fix for Bug 1409018 accidentally removed saving the current desktop
configuration during Init() which causes it to not be set when a different
screen is selected, meaning that regardless of the choice made, only the
first screen is captured.
Reviewers: pehrsons
Tags: #secure-revision
Bug #: 1487419
Differential Revision: https://phabricator.services.mozilla.com/D5062
--HG--
extra : rebase_source : bb4f9a0f4e06dfbd9730b7af4a0748749d72c3da
Summary:
This implements the SRTP extension in TransportLayerDtls. My hope is
that we can expunge the SRTP code from NSS in a few releases.
Reviewers: drno
Subscribers: ekr
Tags: #secure-revision
Bug #: 1485883
Differential Revision: https://phabricator.services.mozilla.com/D4188
MozReview-Commit-ID: Cwjrn9wsCQr
This restores the separate mediapipeline and RtpLogger lazy log modules that
were unified with the Signaling log module in Bug 1402334.
Differential Revision: https://phabricator.services.mozilla.com/D4478
--HG--
extra : moz-landing-system : lando
In the MinGW browser build job, we're going to use -fms-extensions,
which will tell clang to start processing these comments. Clang
cannot process them correctly (it's an upstream bug) but it doesn't
need to, because we include the libs we need in moz.build files.
So we exclude them for MinGW builds. mingw-clang gets them wrong and
mingw-gcc (which doesn't even work anymore on -central) ignored them.
In the future, with a llvm fix, we could clean up the moz.build
files and re-enable these comments.
Differential Revision: https://phabricator.services.mozilla.com/D3527
--HG--
extra : moz-landing-system : lando
This fixes two problems:
1) On Windows, isdigit() is locale-dependent.
2) On platforms where char is signed, sign-extending char to int and passing
the result to isdigit() was UB when the high bit was set, because
isdigit() is defined to take a (signed) int with the value space of
unsigned char or EOF.
MozReview-Commit-ID: D1lY88PEcpc
Differential Revision: https://phabricator.services.mozilla.com/D4316
--HG--
extra : moz-landing-system : lando
Added a Telemetry histrogram which collects which DTLS cipher got
negotiated when a RTCPeerConnection connected.
Differential Revision: https://phabricator.services.mozilla.com/D3551
--HG--
extra : moz-landing-system : lando
When building binaries for Linux/aarch64, ./mach configure cannot generate
Makefile by the following error. So we need Linux/aarch64's gn-configs.
1:07.80 mozbuild.frontend.reader.SandboxValidationError:
1:07.80 ==============================
1:07.80 FATAL ERROR PROCESSING MOZBUILD FILE
1:07.80 ==============================
1:07.80 The error occurred while processing the following file or one of the files it includes:
1:07.80 /hg/mozilla-central/media/webrtc/trunk/webrtc/common_audio/common_audio_c_gn/moz.build
1:07.80 The error occurred when validating the result of the execution. The reported error is:
1:07.80 Source file should only be added to UNIFIED_SOURCES once: /media/webrtc/trunk/webrtc/common_audio/signal_processing/complex_bit_reverse.c
Differential Revision: https://phabricator.services.mozilla.com/D3607
--HG--
extra : moz-landing-system : lando
Added additional fmtp comparison for the parsing resutl comparer by
implementing the C++ == operator for SdpFmtpAttributeList.
Differential Revision: https://phabricator.services.mozilla.com/D3228
--HG--
extra : moz-landing-system : lando
Summary:
This disables building avx512 due to difficulty in getting a working set of
compiler flags across our supported platforms. Rather than carrying this patch
forward, we should revisit supporting avx512 when we do the next update.
Reviewers: jya
Tags: #secure-revision
Bug #: 1433158
Differential Revision: https://phabricator.services.mozilla.com/D2942
--HG--
extra : rebase_source : 0b828be5559a985a8ec5f12d6712b970545d0d83
Summary:
This patch is already applied to the webrtc.org code and doing a libvpx update
does not remove it, so having this present leads to merge conflicts during the
update as it attempts to patch already patched code.
Reviewers: jya
Tags: #secure-revision
Bug #: 1433158
Differential Revision: https://phabricator.services.mozilla.com/D2939
--HG--
extra : rebase_source : e641e8645467565f329c72f0869fe18aa2def846
Removed the enum RustSdpAttributeType and replaced it with the SdpAttributeType enum.
MozReview-Commit-ID: IcJnbnWa4IB
--HG--
extra : rebase_source : befb118948740122dbbdd033e20176351bdd2884
Added a telemetry probe that records failed rsdparsa parsings and whether the sipcc result contains errors.
MozReview-Commit-ID: BHfDRy8MyfZ
--HG--
extra : rebase_source : 9b03f1a8d0655926af1e561cc27e5549490616b2
When a transceiver is stopped, its mid should not be reused by a new transceiver.
Differential Revision: https://phabricator.services.mozilla.com/D2518
--HG--
extra : moz-landing-system : lando
Renamed the pref media.webrtc.rsdparsa_enabled to media.peerconnection.sdp.rust.compare
Added the pref media.peerconnection.sdp.rust.enabled
Added both to all.js
media.peerconnection.sdp.rust.compare: Controls whether the parsing result comparer for sipcc and rsdparsa runs or not.
media.peerconnection.sdp.rust.enabled: Controls whether the rsdparsa runs in parallel to the sipcc parser.
MozReview-Commit-ID: Ac5P7T2NBYD
--HG--
extra : rebase_source : afd60243ccba27965bea193bbe29d91bf7bf2644
Presumably the Rust portion of this will have to land externally first and
then be imported, but I have no idea how or where to submit it.
MozReview-Commit-ID: 2gzQbRKxaZ9
--HG--
extra : rebase_source : 582e41200e69ff3722585c7664ddd122eb0de2fe
extra : intermediate-source : e0a021b27d2c66d46ba973d66d1360678411da26
extra : source : 6d18a8bd5ee351da1a0cdfaa63f49706a2f95ba3
Summary: We want the clang interpretation of -Wall, not the clang-cl one,
which translates -Wall as -Weverything.
Reviewers: dmajor
Tags: #secure-revision
Bug #: 1478000
Differential Revision: https://phabricator.services.mozilla.com/D2468
--HG--
extra : rebase_source : df684c3ca3088e91d584c715f6219f4318d00c62
Summary: I didn't have time to get this upstreamed prior to this update.
Reviewers: TD-Linux
Tags: #secure-revision
Bug #: 1476408
Differential Revision: https://phabricator.services.mozilla.com/D2359
--HG--
extra : rebase_source : ec43830e191d7c0d899d93f08d912c64a4eba002
Summary:
Upstream can now code generate the rtcd interface files directly from the
aom_config.h header, so we no longer have to generate an intermediate file by
running lint_config.sh. This also means we can remove the code for creating a
temporary directory.
Reviewers: TD-Linux
Tags: #secure-revision
Bug #: 1476408
Differential Revision: https://phabricator.services.mozilla.com/D2357
--HG--
extra : rebase_source : 8effc0fc61403db473fc90bc3989912b46133c3e
Presumably the Rust portion of this will have to land externally first and
then be imported, but I have no idea how or where to submit it.
MozReview-Commit-ID: 2gzQbRKxaZ9
--HG--
extra : source : 6d18a8bd5ee351da1a0cdfaa63f49706a2f95ba3
extra : histedit_source : aa7995595e2699d53f1dc60410b90cfd0d4a5c4e
Presumably the Rust portion of this will have to land externally first and
then be imported, but I have no idea how or where to submit it.
MozReview-Commit-ID: 2gzQbRKxaZ9
--HG--
extra : rebase_source : 05924114b7ff1c48ce0c4584469b3b2ef0bc26cb
Removed the enum RustSdpAttributeType and replaced it with the SdpAttributeType enum.
MozReview-Commit-ID: IcJnbnWa4IB
--HG--
extra : rebase_source : 5a446b1624f763c6db02419c525a324ee18a2f69
Added comment stating that these are unused: label, ice-mismatch and connection
Handled rtcp-rsize attribute.
MozReview-Commit-ID: JdWfq0PR480
--HG--
extra : rebase_source : f92a1aec957672202fbd93a4ef5c6cbd1757a15a
Summary:
This adds a clangcl flag to gyp.mozbuild and then uses that to set the same
warnings flags for clang-cl as for clang.
Reviewers: dmajor
Tags: #secure-revision
Bug #: 1478000
Differential Revision: https://phabricator.services.mozilla.com/D2427
--HG--
extra : rebase_source : 6137d2f59e5504d448d4fb32a7e734756ff76afa
Static analysis reveals that there are several places we could be using const references in PeerConnectionImp. This patch addresses all of those places.
Differential Revision: https://phabricator.services.mozilla.com/D2304
--HG--
extra : moz-landing-system : lando
The deletions in xptcall are when we don't even have support for the CPU
in moz.configure, so I assume that people haven't been compiling on
those architectures for quite some time.
The current code is somewhat non-obvious to a first-time reader, and
OS_TEST is a bizarre thing anyway, since it's actually the name of the
CPU we're running on. We'd do well to minimize the use of OS_TEST.
Note that the complete nuking of the xptcall/md/unix/moz.build lines are
because we don't support OS X/x86 anymore.
