The git repo may have tags of the form 'mozilla-<rev>' which tell the
converter script that the git commit is synced from given mozilla-central
hg rev. Those git commits are likely to be created manually from mozilla-central
push heads, which may or may not contain changes to the code being synced.
In this instance, the push head being referenced by tag did not contain changes,
and so the rev was pruned as uninteresting to the conversion. This led to a
busted graph and failure during git commit building.
This patch ensures that any hg rev referenced by a git commit doesn't get
pruned as boring, and so can be used as a base to build additional git commits
on top of.
Differential Revision: https://phabricator.services.mozilla.com/D64135
--HG--
extra : moz-landing-system : lando
Might as well automate what we can automate. I considered making the
"update package.json" logic part of setup_helper.py, so that it can be
used more broadly, but it's not clear it would be used with the
general push towards vendoring into the tree as part of `mach vendor`.
Depends on D63370
Differential Revision: https://phabricator.services.mozilla.com/D63371
--HG--
extra : moz-landing-system : lando
I couldn't find an exact version for the introduction of the flag, but
it appears to be at least NPM v3. We recently started to install and
require at least NPM v6.13.4 in tree.
Differential Revision: https://phabricator.services.mozilla.com/D63370
--HG--
extra : moz-landing-system : lando
We added a workaround to skip `LoadLibraryEx` avoid NVIDIA's crash (bug 1607574),
however we still hit the same crash via the call to `xul!GetVersion`. This patch
removes that call, and put an empty string as the version of detoured.dll instead.
Differential Revision: https://phabricator.services.mozilla.com/D63735
--HG--
extra : moz-landing-system : lando
This removes the need for explicit #ifdef NS_BUILD_REFCNT_LOGGING without
introducing user-defined destructors when it is not defined.
Also, some uses of virtual for declaring destructors are replaced by the
appropriate override declaration through these changes.
Differential Revision: https://phabricator.services.mozilla.com/D62604
--HG--
extra : moz-landing-system : lando
This removes the need for explicit #ifdef NS_BUILD_REFCNT_LOGGING without
introducing user-defined destructors when it is not defined.
Also, some uses of virtual for declaring destructors are replaced by the
appropriate override declaration through these changes.
Differential Revision: https://phabricator.services.mozilla.com/D62604
--HG--
extra : moz-landing-system : lando
Install moz-phab using the correct command for the current operating system as
per moz-phab's documentation.
Differential Revision: https://phabricator.services.mozilla.com/D59139
--HG--
extra : moz-landing-system : lando
AWS apparently has a 50 routing rule limit on their S3 bucket websites. We are
currently applying all our redirect rules 3 times, so have exceeded the limit
despite only having 18 defined rules.
This patch ensures we only apply the rules twice, giving us a bit more
breathing room. In the future, I'd like to try and set up a redirect
from '/' to '/latest' so we can further reduce the number of places we
upload files.
Differential Revision: https://phabricator.services.mozilla.com/D63200
--HG--
extra : moz-landing-system : lando
This patch upgrades the major browsertime version used in-tree from 4 to 8 (including some additional fixes to fix some failing tests on our end).
We also add the node v10 requirement in this patch. Also, there were some changes in the browsertime repo's visualmetrics.py script that made it necessary to change where we find the file.
Differential Revision: https://phabricator.services.mozilla.com/D59235
--HG--
extra : moz-landing-system : lando
The previous patch got backed out, and couldn't be patched itself, so here's a new one.
Differential Revision: https://phabricator.services.mozilla.com/D62844
--HG--
extra : moz-landing-system : lando
Currently, the GNU version of basename from string.h is used, which
has behavior that conflicts with the POSIX version in libgen.h.
The GNU basename is not available in all libcs. In particular, it
is missing in musl libc, causing a build failure:
error: 'basename' was not declared in this scope
The GNU version has the following implementation:
char *p = strrchr (filename, '/');
return p ? p + 1 : (char *) filename;
The POSIX version has slightly different semantics. It may modify
its argument string, or copy part of it to static storage. However,
it will also delete trailing slashes, while the GNU version will
return the empty string if there is a trailing slash.
This change resolves the issue by including libgen.h, adopting POSIX
basename semantics. This should be a safe change for the following
reasons:
- The google-breakpad code, from which this code was derived, has
also switched to the POSIX basename:
072f86ca83%5E%21/#F4
- The version of LulElf.cpp in mozglue/baseprofiler has also switched
to the POSIX basename:
https://hg.mozilla.org/mozilla-central/annotate/de1c3ae8df14cdb2c94a817b02dcffcb2cee12e2/mozglue/baseprofiler/lul/LulElf.cpp#l54
- The BaseFileName function is called only with paths to ELF files,
never directories, so the paths will never contain a trailing
slash, and the two versions of basename will behave identically.
Differential Revision: https://phabricator.services.mozilla.com/D61047
--HG--
extra : moz-landing-system : lando
Add duration estimates to push summary. Refactored preview script - needed to be moved in order to import module.
Differential Revision: https://phabricator.services.mozilla.com/D61195
--HG--
rename : tools/tryselect/formatters/preview.py => tools/tryselect/preview.py
extra : moz-landing-system : lando
This patch adds the PerfDocs Generator. Some modificiations to `run_perfdocs` were also made because verification always has to occur before the documentation generation, and generation always has to be run after verification (if verification passes).
Differential Revision: https://phabricator.services.mozilla.com/D57111
--HG--
extra : moz-landing-system : lando
