Commit Graph

2851 Commits

Author SHA1 Message Date
Robert Bartlensky
4c9812d3ea Bug 1476644: Fix DEAD_STORE error in media/webrtc/signaling/gtest/videoconduit_unittests.cpp. r=ekr
MozReview-Commit-ID: 8QRXhxgqYXm

--HG--
extra : rebase_source : 9ab2030ac8c78416018b3fe1b89243f777a8448d
2018-07-19 14:07:06 +01:00
Johannes Willbold
5084e841a5 Bug 1437169: Improved error checking in the the fingerprint parsing, r=bwc
Improved the error checking in the fingerprint parsing
Changed the way the fingeerprint stores the hash algorihtm to an enum.
Extended the rust unit test for fingerprint
Fixed C++ unit tests

MozReview-Commit-ID: AS2FroZxDNv

--HG--
extra : rebase_source : be0b6d5c390ffaa90c9371436ece717e5e4e002c
2018-07-17 15:35:34 -07:00
Johannes Willbold
c420368865 Bug 1432930: Part 2: Added C++/Rust glue code for imageattr, r=bwc
Added C++/Rust glue code for imageattr.
Added U32vec interface
Added F32vec interface
Enabled C++ unit test CheckMalformedImageattr
Removed redundant parsing code with "Bug 1469702"

MozReview-Commit-ID: Lwj8len4xPR

--HG--
extra : rebase_source : a260799c0a3146b5bf2f461762c9b7db0849a266
2018-07-02 15:10:19 -07:00
Johannes Willbold
c34d1a7a92 Bug 1432930: Part 1: Added imageattr parsing in rust, r=bwc
Added imageattr parsing in rust.
Expanded the imageattr test cases in rust.

MozReview-Commit-ID: IeMkbrbJAoe

--HG--
extra : rebase_source : 05e4105983e7d735bce21de3bd4e99da754589ed
2018-06-29 14:42:19 -07:00
Nico Grunbaum
c8937fbffe Bug 1474658 - P2 - RTCRtpStreamStats.ssrc is now a unsigned long r=mjf
RTCRtpStreamStats.ssrc used to be a DOMString but is now an unsigned long.
When gathering this stat it needs to be constructed accordingly.

MozReview-Commit-ID: IOq9IQQxFVh

--HG--
extra : rebase_source : 3c5fc6144f6fa0435fc1ccce1a3fa371b9ffc162
2018-07-12 13:50:26 -07:00
Johannes Willbold
5b98a7844f Bug 1432920: Part 2: Added C++/Rust glue code for dtls-message, r=bwc
Added C++/glue code for the dtls-message attribute.
Enabled the C++ unit test CheckDtlsMessage.
Added a branch in the rust parsing that discardes dtls-messages on media level.

MozReview-Commit-ID: 9tcWOtH8GbV

--HG--
extra : rebase_source : 4853e51e1cc6734760c243da8e27dc714c89d219
2018-07-05 17:09:10 -07:00
Johannes Willbold
c0ae9af419 Bug 1432920: Part1: Added dtls-message parsing in rust, r=bwc
Added dtls-message parsing in rust.
Added a rust testcase for the dtls-message parsing.

MozReview-Commit-ID: G8boBkxlJmX

--HG--
extra : rebase_source : 40ee205294adf099f51321ec7bde8cbff5db6297
2018-07-05 16:33:30 -07:00
Andreas Pehrson
f78f8582c7 Bug 1471588 - Trace track and stream media consumers. r=padenot
MozReview-Commit-ID: DDkVUEHi0dg

--HG--
extra : rebase_source : d05a30ae43fe1e26d11c6a75a6b47dc6cf8d9b71
2018-06-27 18:25:49 +02:00
Andreas Pehrson
ebd2cf6c8c Bug 1471588 - Trace all NotifyPull calls. r=padenot
MozReview-Commit-ID: XlYfZ0CVZM

--HG--
extra : rebase_source : 8c147419731942a35e27d0aab0e2c4a6a9747438
2018-06-27 17:59:19 +02:00
Andreas Pehrson
9c80f60f71 Bug 1471588 - Turn on MediaPipeline tracing. r=padenot
MozReview-Commit-ID: 1OtmOGnXmRw

--HG--
extra : rebase_source : c0f87262d0ec9c6a36b7fb49aa98cca6a82759f1
2018-06-27 17:41:45 +02:00
Margareta Eliza Balazs
fb3762edac Merge inbound to mozilla-central. a=merge 2018-07-18 12:33:29 +03:00
Johannes Willbold
104efdacd0 Bug 1476081: Removed two leftover debugging statements, r=dminor
Removed two leftover debugging statements

MozReview-Commit-ID: 7Cbsa2MJ2OS

--HG--
extra : rebase_source : dd5125022c842ac8db17000976d25f5108cb4fe6
2018-07-16 12:20:06 -07:00
Johannes Willbold
8d7c4afeb3 Bug 1474711: Added C++/Rust glue code for rtcp-fb transport-cc, r=bwc
Added the C++/Rust glue code for the rtcp-fb transport-cc type.
Extended the C++ unit test CheckRtcpFb
Extended the Rust unit tests for rtcp-fb.

MozReview-Commit-ID: 26hAexM0QeV

--HG--
extra : rebase_source : 1615700ac62ee5d61a26ad7234d42b82e4151109
2018-07-11 10:49:17 -07:00
Johannes Willbold
ea1567d09c Bug 1474712: Added support for whitespace seperacted ssrc-values in the Rust parser, r=bwc
Added support for whitespace in source-level attributes
Extended C++ unti test CheckSsrc
Extended Rust unti test for ssrc

MozReview-Commit-ID: 1xiYyZBYf5o

--HG--
extra : rebase_source : 26d8ee11592e40fa1c25021b86953c72b14636a7
2018-07-11 11:13:56 -07:00
Nils Ohlmeier [:drno]
cf44315a16 Bug 1474517: merge rsdparsa from upstream r=johannes.willbold+610943
Updated rsdparsa to 75d5c6df6728fbab502db06940062e0358536f9f from github
upstream

MozReview-Commit-ID: 9hr7DV6KTkK

--HG--
extra : rebase_source : c5b2c003e76489e267390402ebb5947cf3ec48b6
2018-07-09 23:56:42 -07:00
Byron Campen [:bwc]
0df53d9bd5 Bug 1471697: Stop unsetting mListener on main. r=mjf
MozReview-Commit-ID: 1swVwMyRatC

--HG--
extra : rebase_source : 0c8a95de625b10b460cdfc54f2c6c9cf6dbe8adc
2018-07-02 10:43:26 -05:00
Johannes Willbold
2919be8a89 Bug 1438536: Added bool field to indicate whether direction was specified to RustSdpAttributeExtmap, r=drno
Added a bool field in RustSdpAttributeExtmap that tracks whether the direction was specified.
Added the correspodning C++/Rust glue code

MozReview-Commit-ID: yGL8yTDb49

--HG--
extra : rebase_source : d65f35051338673062d13b7bde591de880052558
2018-07-10 16:23:50 -07:00
Nico Grunbaum
e75e58a710 Bug 1474808 - MediaPipeline set description even when there is no DOM Track r=bwc
Early bailout was preventing mDescription from getting set in MediaPipeline::SetTransport.

MozReview-Commit-ID: HIIva7R3fLe

--HG--
extra : rebase_source : 847b001372e6aedf59fc8f3f38b57a2a51b0f4e1
2018-07-10 22:54:10 -07:00
Dan Minor
6fa2ea51b7 Bug 1371485 - Fix gflags root; r=chmanchester
Summary:
I think the webrtc.org gtests are the only user of gflags in tree. We can switch
over to using gn to build this when we start building the tests using gn,
which is Bug 1430779.

Tags: #secure-revision

Bug #: 1371485

Differential Revision: https://phabricator.services.mozilla.com/D1802

--HG--
extra : rebase_source : ba496d6f262d3679031f0b933a80ce3e2a2236a5
2018-06-22 14:25:31 -04:00
Dan Minor
d1d877cbe8 Bug 1371485 - Remove unnecessary gyp files from webrtc; r=chmanchester
Tags: #secure-revision

Bug #: 1371485

Differential Revision: https://phabricator.services.mozilla.com/D1799

--HG--
extra : rebase_source : 21f5238db3fe517aca5a19344847a883a277e6b6
2018-06-22 14:57:17 -04:00
Dan Minor
f92a35478e Bug 1371485 - Remove webrtc copy of gyp; r=chmanchester
Tags: #secure-revision

Bug #: 1371485

Differential Revision: https://phabricator.services.mozilla.com/D1798

--HG--
extra : rebase_source : d3abc38a88e9f3a5543f2bb46726f47a75115785
2018-06-21 14:42:08 -04:00
Johannes Willbold
e5d310f78d Bug 1473967: Added C++/Rust glue code for maxptime, r=dminor
Added the C++/Rust glue code for maxptime.
Added the C++ unit test CheckMaxPtime.

MozReview-Commit-ID: 58Qbrpktxwx

--HG--
extra : rebase_source : 1aed17367e230f0e397b196b759deaf18e4a3fd8
2018-07-06 10:51:30 -07:00
Johannes Willbold
0e35e80e48 Bug 1433529: Fixed TODOs in parse_sdp, r=dminor
Changed parse_sdp to use StringView instad of raw pointers
Fixed all TODOs by using the existing StringView::into trait instead of doing a manual string conversion.

MozReview-Commit-ID: 5m7rLAu8vwS

--HG--
extra : rebase_source : f34cf389829772b4ca84d7ba895a8b71bd620f64
2018-06-29 15:03:58 -07:00
Johannes Willbold
01d9eeb9af Bug 1444354: Fixed intermittent in RsdparsaSdpAttributeList::GetGroup, r=dminor
Fixed the signature of the sdp_get_groups function in the C++/Rust glue code.

MozReview-Commit-ID: PljpUKk829

--HG--
extra : rebase_source : 92e221ce5e437bf5a994740f3b34f7336668e431
2018-07-03 17:28:17 -07:00
Johannes Willbold
8be45915c4 Bug 1433534: Removed the comment referencing this bug, r=dminor
Nothing to do for this bug. All TODOs were solved by previous tickets.

MozReview-Commit-ID: JFvWvGRlJvy

--HG--
extra : rebase_source : e402f5844508f5b9809b9ad40184f88aba3574be
2018-06-29 15:47:50 -07:00
Johannes Willbold
1a499e7000 Bug 1473686: Enabled SDP unit test CheckSctpmap, r=dminor
The test passes without further changes.

MozReview-Commit-ID: G3TecTmP1QY

--HG--
extra : rebase_source : 4df5aa53730847417175005a15d6c8d79ffba9f3
2018-07-05 12:34:04 -07:00
Andrea Marchesini
a053cf1c15 Bug 1476306 - Moving NullPrincipal/ContentPrincipal/SystemPrincipal under mozilla namespace - part 1 - NullPrincipal, r=ckerschb 2018-07-17 21:37:48 +02:00
shindli
5cc2efce78 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-07-04 01:01:25 +03:00
Johannes Willbold
ac43f2bc5c Bug 1432931: Added sanity check for simulcast send rid. r=bwc
Added sanity check to check if the send rid in simulcast is defined by any send rid.

MozReview-Commit-ID: GISzaQqdqBI

--HG--
extra : rebase_source : 32416045cdb8c96dff72ee74d1d84121323d358f
2018-06-28 10:55:50 -07:00
Jean-Yves Avenard
d586f6f943 Bug 1409664 - P9. Remove AutoTaskQueue and its use r=bryce
Summary:
TaskQueue no longer requires an explicit call to BeginShutdown() as such we no longer have a need for AutoTaskQueue.

Depends on D1621

Tags: #secure-revision

Bug #: 1409664

Differential Revision: https://phabricator.services.mozilla.com/D1622
2018-07-03 11:45:19 -07:00
Johannes Willbold
dda45bc2ca Bug 1437166: Removed GetSsrcGroup entirely. r=dminor,drno
Removed all occurances of GetSsrcGroup in the C++/Rust and C++/sipcc glue code
Removed C++ unit test CheckSsrcGroupInSessionLevel

MozReview-Commit-ID: DImctiH6mUo

--HG--
extra : rebase_source : afd243f5658114f017d94d8bc9527b734901c303
2018-06-25 14:12:04 -07:00
Johannes Willbold
cebc31c9ec Bug 1436403: Setting rtpmap channels in rust. r=dminor
Removed the code setting the channels for an rtpmap attribute in the C++ glue code.
Added Rust code that accounts the data in SdpMedia accordingly for rtpmap.

MozReview-Commit-ID: 2D5MVLJxXoh

--HG--
extra : rebase_source : ae54885e3d2cccdd04f5f758bddcf2d134f3a843
2018-06-25 14:01:37 -07:00
Nils Ohlmeier [:drno]
bfea03ea24 Bug 1335206: enable emitting datachannel draft 21 format. r=bwc
MozReview-Commit-ID: 9zWz8ct4ERZ

--HG--
extra : rebase_source : 83a7fc8f3d20e59436bbc37fe93dc00ec8c30683
2018-06-22 15:49:03 -07:00
Johannes Willbold
239744b151 Bug 1438290: Part 2: Added testcases for AddDataChannel, r=bwc
Added C++ unit test CheckAddDataChannel
Added C++ unit test CheckAddDataChannel_Draft05

MozReview-Commit-ID: HsSdFb0nKUe

--HG--
extra : rebase_source : 18fc6f3bdc04ea0983ce5376177a41df68b93ac2
2018-06-21 15:48:55 -07:00
Johannes Willbold
19dbebcd08 Bug 1438290: Part 1: Implemented RsdparsaSdpMediaSection::AddDataChannel, r=dminor
Implemented RsdparsaSdpMediaSection::AddDataChannel
Added C++/Rust glue code for the "sctp port" attribute
Added C++/Rust glue code for the "max message size" attribute

MozReview-Commit-ID: 5MQC7I1MiU0

--HG--
extra : rebase_source : f9e1457b45c63ae53b339ea43e8645a00d83e369
2018-06-20 12:13:38 -07:00
Johannes Willbold
e44df5acde Bug 1438539: Added sanity check for connection attributes. r=bwc
Added sanity check that ensure that there is either a connection on the session level or in each media secion.
Extended create_dummy_sdp_session

Alterted Rust unit tests:
	parse_minimal_sdp_with_emtpy_lines
	parse_minimal_sdp

MozReview-Commit-ID: yVEhUvns57

--HG--
extra : rebase_source : ea354701995bf62c4231e654d12ad038a6e29bb0
2018-06-25 15:02:58 -07:00
Dorel Luca
f51c4fa5d9 Merge mozilla-inbound to mozilla-central. a=merge 2018-06-27 13:26:49 +03:00
Johannes Willbold
5c6e8a5e28 Bug 1438574: Changed unknown group semantic handling, r=dminor
Unknown group semantics are no longer an error but a warning indicating that the lines was skipped.
Made rust unit test test_parse_attribute_group more explicit.

MozReview-Commit-ID: 7adMSzH195H

--HG--
extra : rebase_source : b5edcdd389d5435808cb4faed5b8bf816774d0e4
2018-06-25 16:16:18 -07:00
Jeff Gilbert
5b753da289 Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot
MozReview-Commit-ID: JtTcLL5OPF0
2018-06-26 17:05:01 -07:00
Johannes Willbold
ab3a514169 Bug 1432932: Sanity check for simulcast recv rids. r=bwc,dminor
Added Rid attribute parsing
Added C++/Rust glue code for the rid attribute
Added SdpInternalError for ParseFloatError
Added Rust unit test for parse_rid in Rust
Added U16Vec in C++/Rust glue code.
The C++ glue code no longer parses rid attributes on his own if the rust parser is used.
Reworked Simulcast parsing in rust
Added C++/rust glue code for Simulcast
Enabled CheckSimulcast c++ unit test
Added sanity check, that checks for simulcast rids that have nt been defined
Enabled ParseInvalidSimulcastNoSuchRecvRid C++ unit test
Added comments with bug number to remove redundant parsing functions.
Removed C++ unit test ParseInvalidSimulcastNoSuchPt
Added C++ unit test ParseInvalidRidNoSuchPt
Added sanity check for rid pts.

MozReview-Commit-ID: 7rvsOKIbxVP

--HG--
extra : rebase_source : abfc74e5f57b51158cf9acdf81078e5a4147fb29
2018-06-08 13:22:16 -07:00
Johannes Willbold
6b5105b7a1 Bug 1436080: Implemented RsdparsaSdp::AddMediaSection, r=dminor
Implemented RsdparsaSdp::AddMediaSection
Added sdp_add_media_section to Rust/C++ glue code
Added SdpSession::add_media in Rust
Added C++ unit test CheckAddMediaSection

MozReview-Commit-ID: 8cUviY3atsb

--HG--
extra : rebase_source : 8efee17758cdfd4927f630c383ec281db5a6a9ef
2018-06-14 11:20:50 -07:00
Nils Ohlmeier [:drno]
f358484625 Bug 1465253: use postfix as prefix when logging and log in clear. r=bwc
MozReview-Commit-ID: 4bfVQZyM9qy

--HG--
extra : rebase_source : 35ebc6834ab729f7da9d9cffe450a60221c8d18e
2018-05-07 13:30:00 -07:00
Nico Grunbaum
2dc9bc2b7c Bug 1456101 - ensure X11 DesktopCapture module is created on main thread r=dminor
MozReview-Commit-ID: 8lP03135ttK

--HG--
extra : rebase_source : 0ba001a933637e2ef76810d2e85a71b12dd49017
2018-06-04 22:03:14 -07:00
Chris Manchester
5d3eea5c07 Bug 1467319 - Re-generate gn moz.build files. r=mshal
MozReview-Commit-ID: Bo7TsDT9pZv

--HG--
extra : rebase_source : 2ad5dba380b3484b8cc01513aff7dfc6930ca639
2018-06-06 17:39:51 -07:00
Chris Manchester
707810c078 Bug 1466254 - Re-generate gn moz.build files. r=mshal
MozReview-Commit-ID: IyG7d8GhqEC

--HG--
extra : rebase_source : 9126b11cad87029125f2f9d9d7d678018f3ae68d
2018-06-06 17:17:37 -07:00
Dan Minor
907222260a Bug 1409018 - Defer RegisterRefreshAndMoveHandlers call; r=pehrsons
This defers the call to register the refresh and move handlers to the
CaptureFrame() call so that they will be registered on the ScreenCapture
thread.

This also calls CFRunLoopInMode to process any pending sources in the
run loop corresponding to the ScreenCapture thread so that the
refresh and move notifications are received.

MozReview-Commit-ID: G4aEchnGuUz

--HG--
extra : rebase_source : b74d95015cccb2efa64a711a1824adb379531ca2
2018-06-05 08:13:01 -04:00
Dan Minor
33e28e7269 Bug 1409018 - Remove ifdefs for OS X 10.7 from webrtc; r=pehrsons
MozReview-Commit-ID: Ahc7KPlY8uW

--HG--
extra : rebase_source : e1038ef18daf2f6e680a2c54aeaedcb179eaf671
2018-06-05 08:11:56 -04:00
Andi-Bogdan Postelnicu
8a8ae803a1 Bug 1453795 - WebRTC/Signaling - Initialize member fields in classes/ structures. r=jesup
--HG--
extra : rebase_source : 40725f05d2085edca36f1566f649855d8f547b3b
extra : amend_source : fe6b442fc1d94a559722304f93fb26ece61b93dd
2018-06-15 18:36:21 +03:00
Nils Ohlmeier [:drno]
f9f2b9b6e4 Bug 1464063 - Remove sdp_getchoosetok. r=bwc 2018-06-13 14:29:20 -07:00
Steve Fink
70f3630002 Bug 1343620 - Use JS_HAZ_ROOTED everywhere instead of programmatic annotations, r=pbone
--HG--
extra : topic : haz.rooted
extra : rebase_source : 69a2c810ccfecdf7c59fe030a83aad9cb6d5f8ad
2018-06-06 16:28:38 -07:00