L. David Baron
800fa5292f
Fix miscellaneous typos in comments that I've had in my tree for ages.
2009-04-22 10:13:48 -07:00
Benjamin Smedberg
3498a5f86e
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.
--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
73a6fab34b
Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal.
2009-01-09 11:35:24 -05:00
Benjamin Smedberg
802d1a10c7
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
L. David Baron
1347910ac9
Change the binding parent for native anonymous content to work like the binding parent for XBL anonymous content, and be the parent of the anonymous content subtree rather than the root of the anonymous content subtree. (Bug 436453) r=bzbarsky,smaug,surkov sr=bzbarsky
2008-07-22 21:50:20 -07:00
Zack Weinberg
a1072e86a3
Delete nsLayoutUtils::GetAbsoluteCoord(); fold logic into callers and simplify. (Bug 437335) r+sr=dbaron
2008-07-17 16:37:12 -07:00
Robert O'Callahan
fae2cd25c6
Backing out bug 421436 due to regression bug 439462
2008-06-17 10:39:30 +12:00
Robert O'Callahan
1fb32e25c0
Bug 421436. Remove hack that gives <br> 1-appunit width in standards mode; it's no longer necessary and it can cause subtle bugs. r+sr=dbaron
2008-06-14 20:48:07 +12:00
Robert O'Callahan
1b6c71eabf
Bug 439004. Check whether there's logically empty content already placed on the line instead of just checking whether the line has advanced horizontally. r+sr=dbaron.
2008-06-14 20:28:07 +12:00
aaronleventhal@moonset.net
d146e7db59
Bug 409473. New crash caused by bug 405248. r+sr=roc, a=blocking1.9
2008-01-14 06:34:40 -08:00
roc+@cs.cmu.edu
18ec94e683
Bug 392829. Clean up nsLineLayout code that's not used (or at least used differently). r+sr+a=dbaron
2007-10-01 19:36:26 -07:00
roc+@cs.cmu.edu
a0ce273d02
Bug 96041. Compute precise glyph extents for high-quality text, and when requested. r=vlad,r+sr=dbaron
2007-09-23 19:19:14 -07:00
roc+@cs.cmu.edu
f5ea55f8b4
Backing out due to test bustage
2007-09-22 06:28:16 -07:00
roc+@cs.cmu.edu
f2b87e6c9a
Bug 96041. Compute true glyph bounding metrics. r=vlad,dbaron,sr=dbaron
2007-09-22 05:43:52 -07:00
roc+@cs.cmu.edu
bbc848d48f
Bug 389421. Rework word selection, in particular so that layout.word_select.stop_at_punctuation is applied to boundaries between punctuation and non-punctuation, and all Unicode punctuation is treated as punctuation.
2007-08-29 20:10:19 -07:00
jwalden@mit.edu
6d7584839a
Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros.
2007-07-08 00:08:04 -07:00
dbaron@dbaron.org
3897543ff9
Make text-indent contribute to intrinsic widths, and handle negative text-indent and negative margin properly by distinguishing forced and optional breaks when accumulating minimum widths. b=368155 r+sr=roc
2007-06-21 15:32:47 -07:00
dbaron@dbaron.org
3cfbaf7cc5
Don't propagate line layout in reflow state when we're not in the line. b=320502 r+sr=roc
2007-05-17 23:04:04 -07:00
bzbarsky@mit.edu
073d7a78a6
Make computed style handle eStyleUnit_Chars. Bug 371043, r+sr=dbaron
2007-05-04 23:09:50 -07:00
bzbarsky@mit.edu
9cd2a580d0
Make computed style handle "normal" for line-height by computing an actualnumeric height. Bug 371041, r+sr=dbaron
2007-05-04 22:30:10 -07:00
dbaron%dbaron.org
9d7f938b99
Clean up IsFrameOfType methods to call their base class IsFrameOfType methods reliably. b=341326 r+sr=roc
2007-02-24 18:33:33 +00:00
cvshook%sicking.cc
a39ff30284
Kill remainders of ns(XBL|HTML|XUL|Layout)Atoms. r/sr=jst b=368128
2007-01-30 00:06:41 +00:00
dbaron%dbaron.org
f6245f0ed9
Change the bulk of ascent (baseline) computation to happen on a virtual method on nsIFrame, and remove the redundant descent member from nsHTMLReflowMetrics, primarily to support having both first-line and last-line baselines. b=367332 r+sr=roc
2007-01-23 04:06:56 +00:00
timeless%mozdev.org
4e651390ef
Bug 355300 There should be only one nsGkAtoms creature
...
r=dbaron
2006-12-26 17:47:52 +00:00
dbaron%dbaron.org
31f1898810
Bug 300030: Move intrinsic width computation out of nsIFrame::Reflow and into its own methods on nsIFrame. Replace reflow reasons, types, and commands with dirty bits/notifications. Thanks to bzbarsky for almost all of the HTML form controls (mozilla/layout/forms) changes, and many others for help testing and patching. For detailed commit logs, see REFLOW_YYYYMMDD_BRANCH, where YYYYMMDD is one of 20061031, 20060830, 20060603, 20060302, 20060119, 20051011, 20050804, 20050429, 20050315, 20050111, and 20041213.
2006-12-08 05:38:33 +00:00
uriber%gmail.com
38c1e056e9
Refactor nsIFrame::PeekOfset to use iteration instead of recursion, plus some more related refactoring. bug=300131 r+sr=roc
2006-09-11 20:43:01 +00:00
uriber%gmail.com
0fa608ce5e
Backing out bug 300131 until I figure out how to deal with the bustage.
2006-09-11 08:03:28 +00:00
uriber%gmail.com
95b377fc13
Refactor nsIFrame::PeekOfset to use iteration instead of recursion, and some related refactoring. bug=300131 r+sr=roc
2006-09-11 06:39:56 +00:00
aaronleventhal%moonset.net
43788a6301
Fixing bustage
2006-07-12 14:35:43 +00:00
aaronleventhal%moonset.net
eeb76de112
Bug 340667. New ATK: Expose <br>'s as \n character, combining before & after blocks of text together. r+sr=roc
2006-07-12 13:51:50 +00:00
aaronleventhal%moonset.net
29bbce1d33
Bug 342596. Allow start/end of word to be specified for PeekOffset(). Necessary for upcoming nsIAccessibleText::GetText[At|Before|After]Offset() methods. r=uriber, sr=roc
2006-07-11 22:11:02 +00:00
roc+%cs.cmu.edu
aac1b0d44f
Bug 330305. Rename nsSelection to nsFrameSelection, and deCOMtaminate it, removing nsIFrameSelection. patch by Marc Liddell, r+sr=roc
2006-04-26 02:01:07 +00:00
dbaron%dbaron.org
0e88f73bc6
Single line comments to describe files (helpful in LXR)
2006-03-29 18:29:03 +00:00
roc+%cs.cmu.edu
0a10a79f62
Bug 330934. Set a nsIFrame's stylecontext in its constructor, to ensure that there's always one available for GetPresContext() to use even if Init hasn't been called. Patch by Marc Liddell, r+sr=roc
2006-03-26 21:30:36 +00:00
sharparrow1%yahoo.com
35f936ecec
Bug 320326: deCOMtaminate GetContentAndOffsetsFromPoint, plus some slight behavior changes. r+sr=roc.
2006-02-27 05:57:37 +00:00
roc+%cs.cmu.edu
77bca74243
Bug 317375. Reorganize frame painting and mouse event targeting around frame display lists. Some review from dbaron, lots of testing help from Martijn, Julien and others
2006-01-26 02:29:17 +00:00
roc+%cs.cmu.edu
a710fcd15d
Bug 316281. Rework GetContentAndOffsetsFromPoint. r=uriber,sr=roc,patch by Eli Friedman
2005-12-07 23:08:39 +00:00
roc+%cs.cmu.edu
a5f65bfee7
Bug 313817. DeCOMtaminate more NS_New*Frame functions. r+sr=roc, patch by Marc Liddell
2005-11-01 20:40:54 +00:00
ginn.chen%sun.com
e12bf01c19
Bug 304891 Using ctrl+right arrow in textarea, first word after hard line break is skipped
...
r=uriber sr=roc
2005-09-19 05:16:25 +00:00
bryner%brianryner.com
5c02a6978c
Change nsIPresContext to nsPresContext globally, follow-up to bug 253470. rs=roc
2004-07-31 23:15:21 +00:00
gerv%gerv.net
708b56cff4
Bug 236613: change to MPL/LGPL/GPL tri-license.
2004-04-18 14:30:37 +00:00
bryner%brianryner.com
92499cbd13
Inline TwipsToPixels and PixelsToTwips on nsIPresContext. Bug 229371, r+sr=dbaron.
2004-02-11 04:57:07 +00:00
dbaron%dbaron.org
352509b071
Account for 1 twip width of BR when computing the size of textareas. b=228752 Patch by Mats Palmgren <mats.palmgren@bredband.net>. r+sr=dbaron a=brendan
2003-12-18 06:06:00 +00:00
uid502
d81619b4fa
Bug 190735. DeCOMtaminate nsIFrame::GetFrameType. r+sr=bzbarsky
2003-10-31 20:19:18 +00:00
dbaron%dbaron.org
3de4dc91e0
Use the correct term "float" instead of "floater". b=218654 r+sr=bzbarsky
2003-10-13 21:51:02 +00:00
jst%mozilla.jstenback.com
5037b2a4a2
Fixing bug 215981. DeCOMtaminating nsIContent and nsIDocument some, and also some minor changes to other related interfaces. r=caillon@aillon.org, sr=peterv@propagandism.org.
2003-09-27 04:18:26 +00:00
bzbarsky%mit.edu
e2e733b5de
DeCOMify GetParent/GetBindingParent/GetDocument on nsIContent. Bug 213823,
...
r+sr=jst
2003-07-28 21:25:13 +00:00
caillon%returnzero.com
2df173e9c8
Bug 209087
...
Content interface out-parameters should use ptr-to-ptrs instead of ref-to-ptrs and some small deCOMtamination.
r+sr=jst@netscape.com
2003-06-13 20:10:01 +00:00
dbaron%dbaron.org
57124d8115
Replace computation of max-element-size (height and width) with max-element-width alone, since the max-element-height is practically unused and not meaningful for layout. b=186953 r+sr=bzbarsky
2003-01-09 14:26:32 +00:00
bryner%netscape.com
7f0488eb18
Phase 1 of style context deCOMtamination (bug 114713). Remove all dependencies on nsIStyleContext from outside of content and layout. Make nsIFrame::GetStyleData be a non-inline virtual function when called from outside of layout, since the nsStyleContext implementation won't be available to those callers. r=dbaron, sr=bzbarsky.
2003-01-09 06:49:07 +00:00
