Commit Graph

3541 Commits

Author SHA1 Message Date
Cosmin Sabou
69acba5002 Backed out 8 changesets (bug 1551088) for causing build bustages. CLOSED TREE
Backed out changeset 02d9dc4d39a5 (bug 1551088)
Backed out changeset d7684ca35c0d (bug 1551088)
Backed out changeset b061b1bf8281 (bug 1551088)
Backed out changeset 4760b8b22ffd (bug 1551088)
Backed out changeset 4685fc022257 (bug 1551088)
Backed out changeset 91300f9f99bb (bug 1551088)
Backed out changeset 6da767c8d55c (bug 1551088)
Backed out changeset ec69be661551 (bug 1551088)
2019-09-21 14:52:41 +03:00
Andrew Osmond
8c8d2ae1df Bug 1551088 - Part 8. Add reftest annotations for slight premultiplication differences. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D46451

--HG--
extra : moz-landing-system : lando
2019-09-20 18:54:04 +00:00
Andrew Osmond
cf7d9c7ae1 Bug 1551088 - Part 7. Add gtests for SwizzleFilter. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D46450

--HG--
extra : moz-landing-system : lando
2019-09-20 18:53:56 +00:00
Andrew Osmond
7f20ed4927 Bug 1551088 - Part 6. Make image decoders use accelerated methods for swizzling and premultiplication. r=tnikkel
The PNG decoder lacks fast implementations for swizzling/unpacking
inside the library, and both PNG and WebP may need to perform
premultiplication due to the alpha channel. This patch adds a new filter
allowing us to take advantage of our accelerated implementations to
perform these transformations on their behalf.

Differential Revision: https://phabricator.services.mozilla.com/D46449

--HG--
extra : moz-landing-system : lando
2019-09-21 07:13:45 +00:00
Andrew Osmond
bd60a922c2 Bug 1551088 - Part 5. Expose SurfaceFilter input row directly to avoid copy if possible. r=tnikkel
Some filters can do the copy of the given data into the working buffer
as part of the filter operation. For those that cannot, we will just
copy the data first, and then advance the row.

Differential Revision: https://phabricator.services.mozilla.com/D46448

--HG--
extra : moz-landing-system : lando
2019-09-20 19:36:00 +00:00
Timothy Nikkel
c860a49663 Bug 1580820. Update the inner window id as well as the context (document) pointer on an imgRequest if we validate it for that document/inner window id. r=aosmond
If we just update the document pointer and not the inner window id then the request is unusable by any document since both the inner window id and the document pointer must match for it to be re-usable.

Differential Revision: https://phabricator.services.mozilla.com/D46121

--HG--
extra : moz-landing-system : lando
2019-09-17 13:16:19 +00:00
Hiroyuki Ikezoe
daa68529bc Bug 1581137 - Allow one frameUpdate observation for the animated image which is out of the display port for now. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D45945

--HG--
extra : moz-landing-system : lando
2019-09-15 22:03:07 +00:00
Hiroyuki Ikezoe
1785543e7b Bug 1580703 - Use wider spacers to ensure that the given scroll position is outside of the display port. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D45814

--HG--
extra : moz-landing-system : lando
2019-09-13 10:18:08 +00:00
Timothy Nikkel
be0d8b9e93 Bug 1284651. Allow the image surface cache to grow beyond 1GB on 64bit builds with sufficient memory. r=aosmond
Before this patch: surface cache size = min(1GB, system_memory/4)
After this patch: surface cache size = min(32bit ? 1GB : 2GB , system_memory/4)

sizeof(uintptr_t) is the best I can figure out to detect 32bit builds.

Differential Revision: https://phabricator.services.mozilla.com/D45092

--HG--
extra : moz-landing-system : lando
2019-09-10 00:55:13 +00:00
championshuttler
7141b73975 Bug 1552317 - Fix codespell errors for image/. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D45553

--HG--
extra : moz-landing-system : lando
2019-09-12 09:00:52 +00:00
Hiroyuki Ikezoe
2e1a793c8c Bug 1541705 - Test for offscreen image in out-of-process iframe. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D44424

--HG--
extra : moz-landing-system : lando
2019-09-12 08:09:34 +00:00
Timothy Nikkel
0effe6b521 Bug 1580087. Fix 32bit * 32bit integer multiplies so they don't overflow in imagelib. r=aosmond
Differential Revision: https://phabricator.services.mozilla.com/D45303

--HG--
extra : moz-landing-system : lando
2019-09-11 20:57:17 +00:00
Brindusan Cristian
e7929f4db7 Backed out changeset 7793fa575497 (bug 1580087) for build bustages at nsIconChannel.cpp. CLOSED TREE 2019-09-11 22:43:19 +03:00
Timothy Nikkel
8bd7132fe7 Bug 1580087. Fix 32bit * 32bit integer multiplies so they don't overflow in imagelib. r=aosmond
Differential Revision: https://phabricator.services.mozilla.com/D45303

--HG--
extra : moz-landing-system : lando
2019-09-11 13:05:30 +00:00
Bogdan Tara
4f6f7b7336 Backed out changeset 3519c255f86e (bug 1284651) for gtest failures CLOSED TREE 2019-09-10 03:49:53 +03:00
Timothy Nikkel
687189b407 Bug 1284651. Allow the image surface cache to grow beyond 1GB on 64bit builds with sufficient memory. r=aosmond
Before this patch: surface cache size = min(1GB, system_memory/4)
After this patch: surface cache size = min(32bit ? 1GB : 2GB , system_memory/4)

sizeof(uintptr_t) is the best I can figure out to detect 32bit builds.

Differential Revision: https://phabricator.services.mozilla.com/D45092

--HG--
extra : moz-landing-system : lando
2019-09-09 23:44:58 +00:00
Timothy Nikkel
e0a79ba9f2 Bug 1578164. Use async notifications when requesting decode of an image in most places. r=aosmond
Most of things will likely be no real change because they ask for the exact frame they want immediately before.

Differential Revision: https://phabricator.services.mozilla.com/D44359

--HG--
extra : moz-landing-system : lando
2019-09-03 15:36:23 +00:00
Eric Rahm
f6aea79235 Bug 1577867 - Remove using namespace std from image/ r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D44250

--HG--
extra : moz-landing-system : lando
2019-08-30 19:58:25 +00:00
Timothy Nikkel
dc486dab60 Bug 1567418. Try to diagnose crash in png decoder. r=aosmond
Call WriteRow from a different line number if we have an interlacing buffer. I think the compiler shouldn't be able to optimize these into the same code, and so we should be able to distinguish them.

Differential Revision: https://phabricator.services.mozilla.com/D44061

--HG--
extra : moz-landing-system : lando
2019-08-30 11:27:58 +00:00
Timothy Nikkel
f1e7c2285d Bug 1577155. Make image/test/mochitest/test_bug415761.html copy both the test and reference icon so the OS doesn't include an extra badge indicating it is a sym link. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D44082

--HG--
extra : moz-landing-system : lando
2019-08-30 13:28:24 +00:00
kanurag94
17e4078da3 Bug 1556840 - Enable more ESLint rules for image/. r=Standard8,aosmond
Differential Revision: https://phabricator.services.mozilla.com/D43351

--HG--
extra : moz-landing-system : lando
2019-08-29 12:59:57 +00:00
Edgar Chen
20182dbcb2 Bug 1576154 - Check mSVGDocumentWrapper when trying to report use counters; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D43256

--HG--
extra : moz-landing-system : lando
2019-08-25 22:45:33 +00:00
Mike Hommey
66d7fe943e Bug 1575420 - Replace MOZ_WIDGET_TOOLKIT value of "gtk3" with "gtk". r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D42765

--HG--
extra : moz-landing-system : lando
2019-08-21 12:25:42 +00:00
Edgar Chen
a3adabe5a7 Bug 1568950 - Part 5: Remove nsIDOMWindowUtils::forceUseCounterFlush; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D42818

--HG--
extra : moz-landing-system : lando
2019-08-21 12:52:19 +00:00
Edgar Chen
21c9ba65da Bug 1568950 - Part 2: Record use counters for SVG image when the image is going to be discarded; r=smaug
Part-1 patch (moving ReportUseCounters call to Document::Destroy) doesn't help SVG image case because the SVGDocumentWrapper::DestroyViewer() still happens too late.

Differential Revision: https://phabricator.services.mozilla.com/D42368

--HG--
extra : moz-landing-system : lando
2019-08-21 12:58:12 +00:00
Thomas Nguyen
bbd6f51a56 Bug 1528697 - Add cenum referrerpolicy in ReferrerInfo.idl r=ckerschb,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D41955

--HG--
extra : moz-landing-system : lando
2019-08-21 13:28:23 +00:00
Thomas Nguyen
32ab8293ff Bug 1528697 - Expose ReferrerPolicy.webidl and use referrerpolicy enum r=smaug
ReferrerPolicy gets tossed back and forth as a uint32_t and
ReferrerPolicy enum in header file. Expose ReferrerPolicyValues from
webidl file and use consistently in native code.

Differential Revision: https://phabricator.services.mozilla.com/D41954

--HG--
extra : moz-landing-system : lando
2019-08-21 13:24:45 +00:00
Nicolas Silva
bd9e647162 Bug 1562091 - Partial backout of bug 1521027. r=aosmond
Differential Revision: https://phabricator.services.mozilla.com/D42468

--HG--
extra : moz-landing-system : lando
2019-08-19 11:16:27 +00:00
Bogdan Tara
745a1d73ea Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE 2019-08-15 01:06:23 +03:00
Sebastian Streich
6658520ea2 Bug 1571742 - Move Nosniff-Check into Sniffers r=ckerschb,dragana
Differential Revision: https://phabricator.services.mozilla.com/D41504

--HG--
extra : moz-landing-system : lando
2019-08-14 13:59:06 +00:00
Tom Schuster
2c4cb96468 Bug 1558915 - Use infallible nsIURI::SchemeIs everywhere. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D41367

--HG--
extra : moz-landing-system : lando
2019-08-09 15:17:06 +00:00
Nika Layzell
143941e2d4 Bug 1523638 - Part 9: Use provided 'WindowGlobalChild' actors to create the initial about:blank document, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D37656

--HG--
extra : moz-landing-system : lando
2019-08-08 16:07:12 +00:00
Tom Schuster
4e01ab1787 Bug 1558915 - Use infallible nsIURI::SchemeIs in image/ r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D40459

--HG--
extra : moz-landing-system : lando
2019-08-03 09:44:12 +00:00
Junior Hsu
523fb9c06b Bug 1569772 - Release load group on main thread in win/nsIconChannel r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D39795

--HG--
extra : moz-landing-system : lando
2019-07-29 22:42:39 +00:00
Kannan Vijayan
3fb6190ec6 Bug 1559414 - Rename unaudited pre-fission methods with SameProcess for future audit burndown. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D39378

--HG--
extra : moz-landing-system : lando
2019-07-26 16:48:31 +00:00
Nicholas Nethercote
18fae65f38 Bug 1563139 - Remove StaticPrefs.h. r=glandium
This requires replacing inclusions of it with inclusions of more specific prefs
files.

The exception is that StaticPrefsAll.h, which is equivalent to StaticPrefs.h,
and is used in `Codegen.py` because doing something smarter is tricky and
suitable for a follow-up. As a result, any change to StaticPrefList.yaml will
still trigger recompilation of all the generated DOM bindings files, but that's
still a big improvement over trigger recompilation of every file that uses
static prefs.

Most of the changes in this commit are very boring. The only changes that are
not boring are modules/libpref/*, Codegen.py, and ServoBindings.toml.

Differential Revision: https://phabricator.services.mozilla.com/D39138

--HG--
extra : moz-landing-system : lando
2019-07-26 01:10:23 +00:00
Timothy Nikkel
ffe1230491 Bug 1568655. Handle null return value from nsGlobalWindowInner::GetScriptableTop in ImageCacheKey::GetTopLevelBaseDomain. r=aosmond
Every other call to this function in the tree null checks the return value.

Differential Revision: https://phabricator.services.mozilla.com/D39243

--HG--
extra : moz-landing-system : lando
2019-07-25 14:34:06 +00:00
Thomas Nguyen
db9e147a01 Bug 1566411 Use ReferrerInfo class in imgLoader.idl r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D38177

--HG--
extra : moz-landing-system : lando
2019-07-25 08:23:32 +00:00
Ciure Andrei
c0756f3389 Backed out 10 changesets (bug 1523638) for causing high frequency Android 7.0 mochitests failures CLOSED TREE
Backed out changeset 644ceb2fe568 (bug 1523638)
Backed out changeset 27647ee7a927 (bug 1523638)
Backed out changeset 96f1ccb95570 (bug 1523638)
Backed out changeset b60a17ea716a (bug 1523638)
Backed out changeset 507e63186c5f (bug 1523638)
Backed out changeset 33255408ca61 (bug 1523638)
Backed out changeset d97b2d223616 (bug 1523638)
Backed out changeset eba2a0514cde (bug 1523638)
Backed out changeset d7065174c5c4 (bug 1523638)
Backed out changeset c21b361e175d (bug 1523638)
2019-07-23 05:13:32 +03:00
Nika Layzell
83236ff0f4 Bug 1523638 - Part 9: Use provided 'WindowGlobalChild' actors to create the initial about:blank document, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D37656

--HG--
extra : moz-landing-system : lando
2019-07-18 19:38:22 +00:00
Boris Zbarsky
0f70d08ec8 Bug 1566595. Stop using [array] in nsIBinaryOutputStream. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D38387

--HG--
extra : moz-landing-system : lando
2019-07-22 20:27:39 +00:00
Ciure Andrei
98278afa46 Backed out changeset a858e4411532 (bug 1566595) for causing Windows MinGW builds bustages CLOSED TREE 2019-07-22 21:39:08 +03:00
Boris Zbarsky
9c74919340 Bug 1566595. Stop using [array] in nsIBinaryOutputStream. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D38387

--HG--
extra : moz-landing-system : lando
2019-07-22 14:52:04 +00:00
Nicholas Nethercote
7974362afd Bug 1567329 - Append _AtStartup to once static pref getters. r=erahm
Currently it's completely unclear at use sites that the getters for `once`
static prefs return the pref value from startup, rather than the current pref
value. (Bugs have been caused by this.) This commit improves things by changing
the getter name to make it clear that the pref value obtained is from startup.

This required changing things within libpref so it distinguishes between the
"base id" (`foo_bar`) and the "full id" (`foo_bar` or
`foo_bar_DoNotUseDirectly` or `foo_bar_AtStartup` or
`foo_bar_AtStartup_DoNotUseDirectly`; the name used depends on the `mirror` and
`do_not_use_directly` values in the YAML definition.) The "full id" is used in
most places, while the "base id" is used for the `GetPrefName_*` and
`GetPrefDefault_*` functions.

(This is a nice demonstration of the benefits of the YAML file, BTW. Making
this change with the old code would have involved adding an entry to every
single pref in StaticPrefList.h.)

The patch also rejigs the comment at the top of StaticPrefList.yaml, to clarify
some things.

Differential Revision: https://phabricator.services.mozilla.com/D38604

--HG--
extra : moz-landing-system : lando
2019-07-22 02:10:14 +00:00
Kris Maglione
0962c2b731 Bug 1566182: Annotate mochitests that fail with Fission enabled. r=mccr8
My preference was to annotate most of the failing tests with `fail-if` so that
if they start passing, the `fail-if` needs to be removed and they need to keep
passing. That doesn't work for tests that timeout, or which trigger failures
from their cleanup functions, however, so those tests need skip-if. And tests
with fail in their cleanup functions likely leave the browser in an
inconsistent state for subsequent tests, anyway, so really should be skipped
regardless.

There are some remaining tests which still fail because of crashes. I chose
not to skip them here, but to fix the crashes in separate bugs instead.

Differential Revision: https://phabricator.services.mozilla.com/D38247

--HG--
extra : rebase_source : 39ba8fec2e882cfe577c5f2b58ab7e4b461f1178
2019-07-15 16:19:32 -07:00
Olli Pettay
bbc417c890 Bug 1565056, merge ImgDecoder and mozStorage threads in THREAD_WAKEUP telemetry, r=tnikkel,asuth
Differential Revision: https://phabricator.services.mozilla.com/D37643

--HG--
extra : moz-landing-system : lando
2019-07-11 04:03:44 +00:00
Barret Rennie
a0f1bf2888 Bug 1289211 - Rename InfallibleTArray to nsTArray in image/ r=aosmond
Differential Revision: https://phabricator.services.mozilla.com/D36960

--HG--
extra : moz-landing-system : lando
2019-07-10 03:31:04 +00:00
Mihai Alexandru Michis
f19168911c Bug 1560617 - Disable trc-type.html on windows 7 for frequent failures r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D37392

--HG--
extra : moz-landing-system : lando
2019-07-09 14:51:05 +00:00
Mihai Alexandru Michis
7f22196a1c Backed out changeset 5f2e580b3639 (bug 1560617) for missing reviewer CLOSED TREE
--HG--
extra : rebase_source : c64934a6a57a1445ffb967f0265024a30fb3041c
extra : amend_source : 35a0fc9a7258076c04b135c4e05e4f51740dcbb6
2019-07-09 17:29:52 +03:00
Mihai Alexandru Michis
cfaa8d133a Bug 1560617 - Disable trc-type.html on windows 7 for frequent failures
Differential Revision: https://phabricator.services.mozilla.com/D37392

--HG--
extra : moz-landing-system : lando
2019-07-09 14:03:31 +00:00