7927 Commits

Author SHA1 Message Date
ffxbld
2420fb4c51 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D138425
2022-02-10 13:42:48 +00:00
Dana Keeler
437958626e Bug 1754294 - remove some unused files in PSM that should have been removed in bug 1751078 r=jschanck
Depends on D138215

Differential Revision: https://phabricator.services.mozilla.com/D138224
2022-02-09 21:13:24 +00:00
Dana Keeler
9731d7145f Bug 1754294 - take the appropriate lock when accessing SECMODModule slot information r=jschanck
When accessing a SECMODModule's slots or slotCount members, the read lock of
the module list must be acquired.

Differential Revision: https://phabricator.services.mozilla.com/D138215
2022-02-09 21:13:24 +00:00
Nika Layzell
dabb46c84d Bug 1736371 - Default new actors to be refcounted, r=alwu,media-playback-reviewers,mccr8
The changes to ipdl actors were mechanical, and largely automated using
a script.

Differential Revision: https://phabricator.services.mozilla.com/D137237
2022-02-09 17:29:47 +00:00
ffxbld
cca27e2e77 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D137993
2022-02-07 14:00:06 +00:00
ffxbld
8eeb283be2 No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D137731
2022-02-04 19:26:02 +00:00
John M. Schanck
072f8043fa Bug 1748820 - land NSS NSS_3_75_RTM UPGRADE_NSS_RELEASE, r=bbeurdouche
```
2022-02-03  John M. Schanck  <jschanck@mozilla.com>

	* doc/rst/releases/index.rst:
	Release notes for NSS 3.75
	[27194d9a9ebd] [NSS_3_75_RTM] <NSS_3_75_BRANCH>

2022-02-03  Benjamin Beurdouche  <bbeurdouche@mozilla.com>

	* lib/nss/nss.h, lib/softoken/softkver.h, lib/util/nssutil.h:
	Set version numbers to 3.75 final
	[151f1680d540] <NSS_3_75_BRANCH>
```

Differential Revision: https://phabricator.services.mozilla.com/D137783
2022-02-03 19:29:01 +00:00
Masatoshi Kimura
66e773f594 Bug 1752683 - Stop passing 8.3 names to NSS for SQLite db paths. r=keeler,florian
We pass 8.3 names to NSS to avoid non-ASCII characters because NSS still
depends on the system code page (although this workaround is not effective on
East-Asian locales).

We don't have to use 8.3 names to NSS for SQLite db paths because SQLite
always use UTF-8 for file names.

Differential Revision: https://phabricator.services.mozilla.com/D137379
2022-01-31 19:43:36 +00:00
ffxbld
ebd97d7fe2 No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D137436
2022-01-31 14:29:01 +00:00
ffxbld
963405e466 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D137130
2022-01-27 14:52:04 +00:00
Dana Keeler
161c96d597 Bug 1751078 - avoid passing an extra copy of the server certificate's bytes during verification r=jschanck
Differential Revision: https://phabricator.services.mozilla.com/D136680
2022-01-26 21:23:50 +00:00
Dana Keeler
b9b204d558 Bug 1751078 - prefer nsIX509Cert over the concrete class r=necko-reviewers,jschanck,kershaw
This patch updates some uses of RefPtr<nsNSSCertificate> to
nsCOMPtr<nsIX509Cert> because it's not necessary to use the concrete class.
This patch also removes some empty files that should have been removed in a
previous bug.

Differential Revision: https://phabricator.services.mozilla.com/D136679
2022-01-26 21:23:50 +00:00
Dana Keeler
36d40547fa Bug 1751078 - use mozilla::pkix to do time comparisons in DetermineCertOverrideErrors r=jschanck
Firefox uses mozilla::pkix to implement certificate verification. Before this
patch, though, DetermineCertOverrideErrors still used NSS to determine if a
certificate had any time-related errors (in addition to the primary error
returned by verification). This wasn't great from a consistency and
attack-surface point of view, so this patch updates that function to use
mozilla::pkix as well.

Differential Revision: https://phabricator.services.mozilla.com/D136678
2022-01-26 21:23:50 +00:00
Dana Keeler
e184b598ae Bug 1751078 - remove unnecessary CERTCertificate instantiation in TLS telemetry r=jschanck
After successfully verifying a TLS server certificate, Firefox collects some
telemetry based on the built certificate chain's root certificate. Before this
patch, the implementation would unnecessarily create CERTCertificates out of
the built cert chain (unnecessary because the telemetry only relies on the
bytes of the root certificate). This patch avoids the unnecessary work.

Differential Revision: https://phabricator.services.mozilla.com/D136677
2022-01-26 21:23:49 +00:00
Dana Keeler
05c772d969 Bug 1751078 - remove SSL_SERVER_AUTH_EKU telemetry probe r=jschanck
SSL_SERVER_AUTH_EKU has served its purpose. It has demonstrated that in the web
PKI (as defined by TLS web server certificates that chain up to root
certificates in Mozilla's CA program), all server certificates will have the
EKU extension, and the extension will be valid for TLS server authentication.
We no longer need to gather this data, so this patch removes this probe.

Differential Revision: https://phabricator.services.mozilla.com/D136676
2022-01-26 21:23:49 +00:00
ffxbld
f340974921 No Bug, mozilla-central repo-update HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D136719
2022-01-24 22:46:16 +00:00
R. Martinho Fernandes
9c6150db68 Bug 1736763 - correctly delimit ipv6 hostnames for keying certificate overrides r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D136499
2022-01-24 13:07:15 +00:00
John Schanck
a60cfaa300 Bug 1640316 - Add tests for corrupted CRLite information. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D136284
2022-01-20 18:09:24 +00:00
John Schanck
211bff8723 Bug 1747320 - Only query CRLite on covered certificates. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D134566
2022-01-20 18:09:24 +00:00
ffxbld
5a1297e35b No Bug, mozilla-central repo-update HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D136506
2022-01-20 17:50:51 +00:00
Dana Keeler
9af0bfbdd8 Bug 1750089 - remove some unnecessary uses of nsIX509Cert::GetCert() r=jschanck
nsIX509Cert::GetCert() may cause a CERTCertificate to be instantiated. Doing so
can have performance and stability implications, so it's best to avoid it.
This patch avoids it where possible.

Differential Revision: https://phabricator.services.mozilla.com/D135945
2022-01-19 21:24:47 +00:00
Julien Cristau
39453238c6 Bug 1749017 - bring the date back in X509CertValidity::FormatTime. r=gregtatum,keeler
Differential Revision: https://phabricator.services.mozilla.com/D135357
2022-01-19 10:43:08 +00:00
Iulian Moraru
d8fce573b5 Backed out 2 changesets (bug 1750089) for causing mochitest failures on browser_webconsole_certificate_messages.js.
Backed out changeset 7ebb345a9293 (bug 1750089)
Backed out changeset 40bd1975208d (bug 1750089)
2022-01-19 04:07:44 +02:00
Dana Keeler
2d07f1cf5d Bug 1750089 - remove some unnecessary uses of nsIX509Cert::GetCert() r=jschanck
nsIX509Cert::GetCert() may cause a CERTCertificate to be instantiated. Doing so
can have performance and stability implications, so it's best to avoid it.
This patch avoids it where possible.

Depends on D135943

Differential Revision: https://phabricator.services.mozilla.com/D135945
2022-01-18 23:54:12 +00:00
ffxbld
8a40305182 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D136115
2022-01-18 15:18:18 +00:00
Barret Rennie
85a8370332 Bug 1747464 - Remove FileUtils.getFile from security/ r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D134901
2022-01-17 17:42:12 +00:00
Norisz Fay
4475b51bcb Backed out changeset d4a6f5cb9b3f (bug 1747320) for breaking connectivity with many https sites (bug 1750188) a=backout 2022-01-14 15:15:26 +02:00
Dana Keeler
2e8fed5c24 Bug 1748341 - only instantiate CERTCertificate in nsNSSCertificate if needed r=jschanck
To avoid doing unnecessary work and to reduce NSS resource contention and
crashes, this patch lazily instantiates the CERTCertificate in
nsNSSCertificate.

Depends on D134979

Differential Revision: https://phabricator.services.mozilla.com/D134980
2022-01-13 22:10:52 +00:00
Dana Keeler
6ba439cc95 Bug 1748341 - use mDER over mCert in nsNSSCertificate where possible r=jschanck
To prepare to lazily instantiate the CERTCertificate in nsNSSCertificate, this
patch avoids the CERTCertificate in nsNSSCertificate as much as possible and
instead uses the bytes of the certificate directly.

Depends on D134978

Differential Revision: https://phabricator.services.mozilla.com/D134979
2022-01-13 22:10:51 +00:00
Dana Keeler
a5b07a3a15 Bug 1748341 - remove superfluous nsNSSCertificate "constructors" r=necko-reviewers,kershaw,jschanck
nsNSSCertificate had a few functions that acted as constructors. This patch
removes these unnecessary functions and uses actual constructors.

Depends on D134977

Differential Revision: https://phabricator.services.mozilla.com/D134978
2022-01-13 22:10:51 +00:00
Dana Keeler
020dbe7b52 Bug 1748341 - misc nsNSSCertificate cleanup r=jschanck
This removes some leftover cruft in nsNSSCertificate.

Differential Revision: https://phabricator.services.mozilla.com/D134977
2022-01-13 22:10:50 +00:00
John Schanck
e4407de1ad Bug 1747320 - Only query CRLite on covered certificates. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D134566
2022-01-13 19:27:46 +00:00
R. Martinho Fernandes
73a91c8fd6 Bug 1736763: Correctly parse IPv6 hosts in certificate overrides r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D135617
2022-01-13 14:29:41 +00:00
ffxbld
60d27d6358 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D135850
2022-01-13 13:41:59 +00:00
Butkovits Atila
435a77f1a1 Merge autoland to mozilla-central. a=merge 2022-01-12 23:13:24 +02:00
Narcis Beleuzu
255a2c1d2d Backed out 4 changesets (bug 1748341) for causing Bug 1749735 . a=pascal
Backed out changeset 667470bfefbb (bug 1748341)
Backed out changeset 4c8bf5c43e12 (bug 1748341)
Backed out changeset 7aa1f58a893e (bug 1748341)
Backed out changeset 1e1f1620d1bb (bug 1748341)
2022-01-12 18:31:40 +02:00
Cristian Tuns
189d64b412 Backed out changeset 8b97bc59958e (bug 1749017) for causing xpcshell failures on test_nsIX509CertValidity.js CLOSED TREE 2022-01-12 09:14:51 -05:00
Julien Cristau
279ea846f7 Bug 1749017 - bring the date back in X509CertValidity::FormatTime. r=gregtatum,keeler
Differential Revision: https://phabricator.services.mozilla.com/D135357
2022-01-12 13:19:41 +00:00
Dennis Jackson
0622807c18 Bug 1748469 - Update hardcoded ECHConfigs in Firefox Unit Tests r=mt,necko-reviewers,kershaw
This will need to be landed in conjunction with the ECH changes in NSS.

Differential Revision: https://phabricator.services.mozilla.com/D135205
2022-01-12 10:40:38 +00:00
Dana Keeler
c3d9c4a9fb Bug 1748341 - only instantiate CERTCertificate in nsNSSCertificate if needed r=jschanck
To avoid doing unnecessary work and to reduce NSS resource contention and
crashes, this patch lazily instantiates the CERTCertificate in
nsNSSCertificate.

Depends on D134979

Differential Revision: https://phabricator.services.mozilla.com/D134980
2022-01-12 00:40:14 +00:00
Dana Keeler
b3e9aadfa8 Bug 1748341 - use mDER over mCert in nsNSSCertificate where possible r=jschanck
To prepare to lazily instantiate the CERTCertificate in nsNSSCertificate, this
patch avoids the CERTCertificate in nsNSSCertificate as much as possible and
instead uses the bytes of the certificate directly.

Depends on D134978

Differential Revision: https://phabricator.services.mozilla.com/D134979
2022-01-12 00:40:14 +00:00
Dana Keeler
aff97c6002 Bug 1748341 - remove superfluous nsNSSCertificate "constructors" r=necko-reviewers,kershaw,jschanck
nsNSSCertificate had a few functions that acted as constructors. This patch
removes these unnecessary functions and uses actual constructors.

Depends on D134977

Differential Revision: https://phabricator.services.mozilla.com/D134978
2022-01-12 00:40:14 +00:00
Dana Keeler
3efb3751c8 Bug 1748341 - misc nsNSSCertificate cleanup r=jschanck
This removes some leftover cruft in nsNSSCertificate.

Differential Revision: https://phabricator.services.mozilla.com/D134977
2022-01-12 00:40:13 +00:00
Kershaw Chang
f159addb13 Bug 1741425 - Enable more xpcshell tests with socket process, r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D134484
2022-01-11 09:50:14 +00:00
Kershaw Chang
5d806765a0 Bug 1741425 - Enable more mochitest with socket process, r=ahal,webdriver-reviewers,preferences-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D134485
2022-01-11 09:49:45 +00:00
Dana Keeler
089b93e8b8 Bug 1749071 - remove unused nsIX509Cert.equals method r=jschanck,necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D135425
2022-01-10 18:30:10 +00:00
ffxbld
75f8385828 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D135493
2022-01-10 13:51:30 +00:00
Nika Layzell
e8f83d2043 Bug 1748718 - Part 3: Remove now-unnecessary xpidl constant casts, r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D135166
2022-01-07 20:35:15 +00:00
Dana Keeler
740734288a Bug 1748409 - regenerate expiring test certificates for 2022 r=jschanck
* the certificates were regenerated using `./mach generate-test-certs`
* the build/pgo/certs/ changes were made using
  `./mach python build/pgo/genpgocert.py`
* the zip files in security/manager/ssl/tests/unit/test_signed_apps/ were
  updated per the directions in the corresponding moz.build file
* security/manager/ssl/tests/unit/test_cert_override_read.js needed manual
  updating

Differential Revision: https://phabricator.services.mozilla.com/D135283
2022-01-07 02:13:06 +00:00
ffxbld
0ccecaefc0 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D135204
2022-01-06 14:09:41 +00:00