Commit Graph

177 Commits

Author SHA1 Message Date
Nick Fitzgerald
51675a240f Bug 947044 - Part 2: Fix tests that check ReferenceError's message. r=gavin 2014-09-22 16:13:00 +02:00
Shu-yu Guo
59ccd2fecb Bug 1001090 - Part 5: Fix errors in tests throughout the tree. (r=robcee,gavin) 2014-09-15 16:30:47 -07:00
Florian Quèze
528c7343e7 Bug 838458 - Fix 'rest.js - setting a property that has only a getter' warnings, r=rnewman. 2014-08-27 16:52:21 +02:00
Gregory Szorc
8ea5c183d9 Bug 1055102 - Properly handle Unicode in Bagheera payloads; r=bsmedberg
It was observed that FHR was sending invalid JSON payloads to the
server. Specifically, JSON payloads contained invalid Unicode strings.

Investigation revealed that the culprint was CommonUtils.convertString()
silently swallowing high bytes. When the Bagheera client went to gzip
the JSON payload, the input buffer into gzip was missing high bytes.

This patch changes the bagheera client to UTF-8 encode strings before
gzip, thus ensuring all data is preserved. A corresponding change was
also added to the mock bagheera server implementation.

Alternatively, we could have changed CommonUtils.convertString() to
be high byte aware. However, many consumers rely on this function.
This patch is written with the intent of being uplifted and the change
performed is targeted at the specific problem.

Tests for Unicode preserving behavior have been added to both the
generic Bagheera client and to FHR. The latter test is arguably
not necessary, but peace of mind is a good thing, especially with
FHR.

See also bug 915850.

--HG--
extra : rebase_source : 4efddea7767c2e5f8cf19df247c3aba07c40eec6
extra : amend_source : ae3b6d89efa54fc9ed1794404476622946ad4b22
2014-08-19 09:12:12 -07:00
Nathan Froyd
b600fe311e Bug 1045617 followup - remove dummy mach command DONTBUILD; r=me 2014-08-06 12:28:37 -04:00
Nathan Froyd
a9ceaeb4dd Bug 1045617 - move services's run_server.py Makefile rules into mach; r=gps 2014-07-30 15:44:13 -04:00
Nathan Froyd
cd91df4210 Bug 1054476 - move INSTALL_TARGETS in services/ Makefiles to EXTRA_{PP_,}JS_MODULES; r=gps 2014-07-28 15:24:01 -04:00
Nathan Froyd
4c895ecac4 Bug 1054476 - use PREF_JS_EXPORTS in services/ Makefiles; r=gps 2014-07-28 14:42:26 -04:00
Birunthan Mohanathas
c8bac35511 Bug 1048989 - Fix 'useless expression' warnings with MERGED_COMPONENT. r=gps 2014-08-07 21:52:05 -07:00
Steve Workman
55ac136605 Bug 982816 - Remove extra calls to nextTest in test_hawkrequest.js r=ckarlof 2014-07-08 11:44:03 -07:00
Gregory Szorc
25170257c3 Bug 1033836 - Convert TESTING_JS_MODULES to moz.build; r=glandium
--HG--
extra : rebase_source : 1cd9e402c507260358af7a93c6fb2fc91c24994b
2014-07-02 16:43:41 -07:00
Gregory Szorc
04d5343419 Bug 1033836 - Rename services-common to services/common; rs=rnewman
The upcoming build system patches don't support hypthens in path names.
Changing this for that reason is kind of silly, but it's the easiest
way. Besides, nothing else uses hyphens in directory names.

--HG--
extra : rebase_source : 42dda2b1f16a3c0bfe17397a70092362e400530f
2014-07-02 16:49:36 -07:00
Fernando Jiménez
fce1090b0d Bug 1027595 - TypeError: deriveHawkCredentials is not a function after bug 1020859. r=jedp 2014-06-21 07:43:39 +01:00
Mark Banner
59a1c3ac3e Bug 1020859 Part 1 - Make HawkClient return all the response details for a request, and make deriveHawkCredentials common code. r=jparsons 2014-06-18 10:42:15 +01:00
Mark Hammond
79bf688cfb Bug 1024812 - unhandled exceptions in hawkclient no longer cause sync to hang. r=rnewman 2014-06-14 11:47:34 +10:00
Mark Hammond
3446835782 Bug 1015794 - use Object.create to create services timer objects. r=rnewman 2014-06-12 10:06:47 +10:00
Fernando Jiménez
3a335772ca Bug 988469 - MSISDN verification API for privileged apps. Part 2: Make FxA specific stuff generic. r=markh 2014-06-07 19:30:18 +02:00
Mark Hammond
3da402253d Bug 1010531 - Prevent async callback from throwing when a callback is made with an error. r=rnewman 2014-05-28 10:00:00 +10:00
Mark Hammond
cc68451c4d Bug 1015794 - avoid mutating the prototype of a timer object to prevent warnings. r=rnewman 2014-05-28 09:54:52 +10:00
Mark Hammond
57de1ea9c6 Bug 1006943 - non-sensitive FxA log info is included with sync logs. r=rnewman 2014-05-15 12:00:59 +10:00
Ehsan Akhgari
d661bb68d0 Bug 1005710 - Avoid preprocessing the services JS exports files needlessly; r=mshal 2014-05-05 21:28:55 -04:00
Irving Reid
c53a02f070 Bug 966674: #2 Move exceptionStr() and stackTrace() from utils.js to Log.jsm; r=gps,rnewman 2014-04-29 10:09:27 -04:00
Mark Hammond
b608d2c829 Bug 990834 (part 2) - Add support/tweak retry and backoff header support to hawk and tokenserverclient. r=rnewman 2014-04-10 12:08:19 +10:00
Marco Castelluccio
f16a25d558 Bug 993173 - Use encoding option in readJSON. r=Yoric 2014-04-08 04:47:00 +02:00
Mark Hammond
bf9bb90ec8 Bug 985902 - expose fxaccounts/MOZ_SERVICES_FXACCOUNTS to mozinfo and only run test_hawkclient when enabled. r=ted 2014-03-31 14:15:05 +11:00
Mark Hammond
80b2f9e857 Bug 985212 - check if the username looks like an email address to determine what sync to use. r=rnewman 2014-03-24 11:44:43 +11:00
Phil Ringnalda
5b1152ce0e Back out b9597187a3d6 (bug 985212) for xpcshell bustage
CLOSED TREE
2014-03-22 21:30:46 -07:00
Mark Hammond
6a5ecb9cbc Bug 985212 - check if the username looks like an email address to determine what sync to use. r=rnewman 2014-03-23 14:20:38 +11:00
Phil Ringnalda
a06cadf42b Back out 61454adff1d6 (bug 985212) for xpcshell bustage 2014-03-20 21:50:21 -07:00
Mark Hammond
8f728efcd1 Bug 985212 - check if the username looks like an email address to determine what sync to use. r=rnewman 2014-03-21 14:39:35 +11:00
Richard Newman
e5a7647359 Bug 978876 - Part 0: add set utilities to CommonUtils. r=gps 2014-03-13 16:37:25 -07:00
Mark Hammond
d03eaa8b9c Bug 958447 - respect Retry-After header from token server. r=rnewman 2014-03-12 19:27:22 -07:00
Jed Parsons
ed60f7b54c Bug 969892 - Fixes and improvements to FxAccounts test suite; r=ttaubert 2014-02-18 09:47:52 -08:00
Mark Hammond
7c71c437c3 Bug 977502 (part 2) - add tests with mock http responses simulating errors. r=ckarlof 2014-03-07 15:41:32 +11:00
Mark Hammond
eeab61d217 Bug 976393 - ensure authentication errors log as much detail as possible. r=jedp 2014-03-03 09:55:30 +11:00
Mark Hammond
744d2d3b48 Bug 977931 - return an error object even when restResponse.headers is null. r=spenrose 2014-02-28 13:24:49 +11:00
Sam Penrose
c8f20a7b58 Bug 945449 - FxAccountsClient should support auth server's backoff protocol. r=ferjm 2014-02-26 10:11:49 -08:00
Jed Parsons
ceb73476f1 Bug 974990 - hawk request to access lang prefs as infrequently as possible. r=rnewman
--HG--
rename : services/common/hawk.js => services/common/hawkclient.js
rename : services/common/tests/unit/test_hawk.js => services/common/tests/unit/test_hawkclient.js
2014-02-25 09:19:47 -08:00
Geoff Brown
45f4e11fa5 Bug 969624 - Skip test_storageservice_client.js on Android 2.3 emulator; r=dminor 2014-02-24 17:51:15 -07:00
Sam Penrose
b431a8c4a8 Bug 955953 - FxAccountsClient should set Accept-Language header on all server calls. r=rnewman 2014-02-16 08:39:05 -08:00
Gregory Szorc
7b9f6f570a Bug 972093 - Detect run_next_test() during add_task(); r=ted, rnewman
If an xpcshell test called run_next_test() from inside an add_task(),
bad things would happen. This patch detects that behavior and aborts the
test immediately with an actionable error message.

--HG--
extra : rebase_source : c5cf11070421b95a6fcf476d0a86289a3d0ba73a
extra : amend_source : cec6ad2a751bba01e7d4ecbff0735b39e3326efb
2014-02-12 16:47:29 -08:00
Jed Parsons
4d16783da7 Bug 967372 - Fix intermittent test_hawk.js failures on Windows. r=ttaubert 2014-02-08 17:07:34 -08:00
Gregory Szorc
5bb470c361 Bug 970336 - test_restrequest.js times out on Android 2.3 emulator; r=rnewman
--HG--
extra : rebase_source : 686beb0c5ccfab3ebde27f554a3fa60439df5e53
extra : amend_source : 787e95b977f4557073f8c30b9e4e97269e6d1572
2014-02-12 17:16:44 -08:00
Mark Hammond
e992f475d3 Bug 965896 - allow a sync startOver to re-enable Firefox Accounts. r=rnewman 2014-02-12 17:25:41 +11:00
Jed Parsons
ebbd34b84b Bug 943521 - Use onepw prototcol in fxa client. r=ckarlof 2014-02-04 22:14:30 -08:00
Ryan VanderMeulen
2905a47b7f Backed out changeset 79b198be3e50 (bug 943521) for xpcshell failures. 2014-02-07 17:55:12 -05:00
Jed Parsons
7deb4b713b Bug 943521 - Use onepw prototcol in fxa client. r=ckarlof 2014-02-04 22:14:30 -08:00
Peiyong Lin
730f628efa Bug 964735 - Convert libc into Library to make it link lazily. r=Yoric 2014-02-07 10:37:21 -05:00
Fernando Jiménez
6ce92b7a6a Bug 967503 - Make HawkClient work in b2g. r=rnewman 2014-02-04 20:32:16 +01:00
Tim Taubert
abed7621c4 Bug 964922 - Enable FxA Sync on Nightly r=markh 2014-01-30 12:09:12 -08:00