Commit Graph

30 Commits

Author SHA1 Message Date
Gurzau Raul
123404288d Backed out changeset 0192efea1b66 (bug 1486137) for failing at netwerk/test/unit/test_trr.js on a CLOSED TREE 2018-08-28 16:29:25 +03:00
Daniel Stenberg
ec82b55b39 bug 1486137 - TRR: fix the FAMILY field in the ECS code r=mcmanus
... since AF_INET wouldn't actually use IPv4!

MozReview-Commit-ID: FCf7psawENI

Differential Revision: https://phabricator.services.mozilla.com/D4328

--HG--
extra : moz-landing-system : lando
2018-08-27 16:03:30 +00:00
Daniel Stenberg
315e5ddcc0 bug 1466462 - TRR: disable EDNS Client Subnet by default r=mcmanus
Set the "network.trr.disable-ECS" pref to false to disable.

MozReview-Commit-ID: GE6L8Vpvuu0

Differential Revision: https://phabricator.services.mozilla.com/D2933

--HG--
extra : moz-landing-system : lando
2018-08-13 15:45:15 +00:00
Daniel Stenberg
fcdada427b bug 1466860 - upgrade DOH code to draft-12 level r=mcmanus
MozReview-Commit-ID: FSVh7qUbBig

Differential Revision: https://phabricator.services.mozilla.com/D2828

--HG--
extra : moz-landing-system : lando
2018-08-08 15:01:05 +00:00
Daniel Stenberg
7e7f7eeb34 bug 1463356 do not count "not started" TRR resolves as failures r=mcmanus
... when comparing against the native resolver. DNS_TRR_COMPARE is meant
to compare how the actually performed name resolves fare against each
other.

MozReview-Commit-ID: 98NoUGPpHr6

--HG--
extra : rebase_source : 4042c81da3e5478de26feb7f83c98ee5eb298156
2018-06-20 11:00:19 +02:00
Valentin Gosu
d9800226a5 Bug 1417827 - Pass DNS arguments as nsACString& instead of char* r=bagder
MozReview-Commit-ID: 7Zk0wM2wsJF

--HG--
extra : rebase_source : 6bfe7a9c21d447252db1b0a5351305bdecb0fa3a
2018-06-15 01:15:13 +02:00
Jeff Hemphill
0d0efc9d92 Bug 1417827: Convert internal char* to nsCString in DNS.h r=bagder
MozReview-Commit-ID: Js1mXiKaKnt

--HG--
extra : rebase_source : 55ae6349a65f20a2401aa76711b1e9c871b0c167
2017-11-29 23:30:27 -08:00
Dorel Luca
ff4d587dc8 Backed out 2 changesets (bug 1417827) for windows build bustage. CLOSED TREE
Backed out changeset 35655153f9c9 (bug 1417827)
Backed out changeset 9606d0d95b53 (bug 1417827)

--HG--
extra : amend_source : ce9a86c7b5ded39d1b00a7c626ba7a082efaabde
2018-06-14 22:07:18 +03:00
Valentin Gosu
e5efdc876d Bug 1417827 - Pass DNS arguments as nsACString& instead of char* r=bagder
MozReview-Commit-ID: GqNYfjy9SFp

--HG--
extra : source : 190c4f057ffafa28a9abec657a0c70fe8a9489ab
2018-06-14 14:30:40 +02:00
Jeff Hemphill
deb1d4dff1 Bug 1417827: Convert internal char* to nsCString in DNS.h r=bagder
MozReview-Commit-ID: Js1mXiKaKnt

--HG--
extra : source : fc388a747aba88d3eb535e6105305bd85914600b
2017-11-29 23:30:27 -08:00
Gurzau Raul
f2d3a45d49 Backed out 2 changesets (bug 1417827) backed out due to gecko decision task failure, tests did not run
Backed out changeset 190c4f057ffa (bug 1417827)
Backed out changeset fc388a747aba (bug 1417827)
2018-06-14 19:07:48 +03:00
Valentin Gosu
3620424d66 Bug 1417827 - Pass DNS arguments as nsACString& instead of char* r=bagder
MozReview-Commit-ID: GqNYfjy9SFp

--HG--
extra : rebase_source : 6bd7c4fcb1f6a5bbbaa9654907ce1b1224be64b2
2018-06-14 14:30:40 +02:00
Jeff Hemphill
85150abc1d Bug 1417827: Convert internal char* to nsCString in DNS.h r=bagder
MozReview-Commit-ID: Js1mXiKaKnt

--HG--
extra : rebase_source : 835ab465653aef0d9d513b8836ba54a27b98e556
2017-11-29 23:30:27 -08:00
Emilio Cobos Álvarez
fffb25b74f Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
This was done automatically replacing:

  s/mozilla::Move/std::move/
  s/ Move(/ std::move(/
  s/(Move(/(std::move(/

Removing the 'using mozilla::Move;' lines.

And then with a few manual fixups, see the bug for the split series..

MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Patrick McManus
f18aa94399 Bug 1462357 - remove the channel and socket interface id r=bagder,baku
the id was a b2g feature only settable via chrome privd xhr and is no
longer active in the code base

MozReview-Commit-ID: 84GPNvhvjNb

--HG--
extra : rebase_source : ab5c2229b98e1407b8b74ef2ee00dcfea45e046a
2018-05-16 16:05:03 -04:00
Daniel Stenberg
06c7a72bf8 bug 1460327 - make the DNS packet decoder verify the answer qname r=mcmanus
... and before chasing a cname, check if the address record for that
CNAME is actually in fact already provided in the DNS packet that passed
on the CNAME!

Some existing tests ajusted for this. Two new tests added.

MozReview-Commit-ID: CBMO7N7jMEX

--HG--
extra : rebase_source : 1110a8df6d89fcbb0ad2a35b3762b837ce7a1e18
2018-05-08 19:30:07 +02:00
Daniel Stenberg
cc57e08b25 bug 1450630 - use DataStorage in main thread only r=mcmanus
Move the TRR blacklist check to the main thread, and since it is now
done a little later and for each separate request, make sure to only do
the telemetry counting for one of the record types (A) so that we don't
count them twice.

MozReview-Commit-ID: BgvU4TzrpCq

--HG--
extra : rebase_source : 304bc75a6f22963b51e89034de1b30506337b6ec
2018-04-30 09:08:07 +02:00
Andi-Bogdan Postelnicu
3f2298c2f6 Bug 1457411 - Update netwerk module to make use of newer methods introduced with c++11 and c++14. r=valentin
MozReview-Commit-ID: 666LNaHyiuQ

--HG--
extra : rebase_source : f3a24e0342d8dcdf9020dd473bc6b1045cbc533b
2018-04-30 19:46:04 +03:00
Daniel Stenberg
af8824af35 bug 1455972 - make TRR prefer address responses to CNAME r=mcmanus
In a DOH response to a query asking for an A or AAAA record, a CNAME
response is often accompanied by A/AAAA resources as well. With this
change, TRR now rather use those address records than following the
CNAME record. This saves name resolver round-trips.

MozReview-Commit-ID: GcjZj5Ehz68

--HG--
extra : rebase_source : b80d9818cb8fa6139feeeec3d2fb11a5b800ee48
2018-04-23 11:26:04 +02:00
Nathan Froyd
7bb7ffd8c9 Bug 1453134 - part 1 - add a string input stream constructor that accepts move references; r=baku
This method is more efficient when we know we're not going to need the
string afterwards, and should cut down on intermediate allocations.
2018-04-11 10:06:17 -04:00
Daniel Stenberg
d8d095de79 bug 1451883 - fix pointer handling in the DOH response decoding r=mcmanus
In the section of the response body parser that just skips over the
answer section, the code wrongly assumed there could only be a pointer
at the start, while in fact every label can be made as a pointer. Just
turned out to not be used very often.

MozReview-Commit-ID: 8ZYtlq8HDPw

--HG--
extra : rebase_source : cc790caf36b4d4e77b113f89ed427ee537a539d8
2018-04-05 23:28:26 +02:00
Daniel Stenberg
c9bc3d9398 bug 1452568 - inhibit cache use when doing TRR in PB r=valentin
MozReview-Commit-ID: MmdSMBdH4v

--HG--
extra : rebase_source : 7e4c2ed2b38d2255d24e5e67ace22a3fe1ec9a3c
2018-04-09 12:14:28 +02:00
Daniel Stenberg
11c34a5b83 bug 1451928 - loop detection added for the TRR CNAME parser r=valentin
MozReview-Commit-ID: 8vLjS7hOYKU

--HG--
extra : rebase_source : 69b82c3df7db7d19f0667e9de0c6c67b7c7794fe
2018-04-06 00:47:15 +02:00
Daniel Stenberg
f0caae2f7c bug 1441391 - TRR: restart failed NS confirms in TRR-only mode r=valentin
MozReview-Commit-ID: FHw3Zx07iFG

--HG--
extra : rebase_source : 55a09920127aa54e542ed736b92ca6fda63f889c
2018-03-09 09:05:48 +01:00
Dorel Luca
150521bb4b Backed out changeset 798a47cd74d5 (bug 1441391) for build bustages. CLOSED TREE 2018-03-09 14:49:02 +02:00
Daniel Stenberg
fd2336dfd3 bug 1441391 - TRR: restart failed NS confirms in TRR-only mode r=valentin
MozReview-Commit-ID: FHw3Zx07iFG

--HG--
extra : rebase_source : baa674f1a488c6ee5383a4f72c66bb595285db60
2018-03-09 09:05:48 +01:00
Daniel Stenberg
76003c2ab0 bug 1440563 - set the RD bit in DOH requests r=valentin
RFC 1035 section 4.1.1 documents this bit as:

RD - Recursion Desired - this bit may be set in a query and is copied
into the response.  If RD is set, it directs the name server to pursue
the query recursively.  Recursive query support is optional.

MozReview-Commit-ID: 8iHDgNtA1L1

--HG--
extra : rebase_source : a29010a2894fd00ebfbfb869f5938cf507345a2f
2018-03-05 08:47:52 +01:00
Daniel Stenberg
27d3309d96 bug 1439067 - let TRR access TRRService through the null-checked global. r=valentin
... and also store allow-rfc1918 bool locally to remove later accesses
to TRRservice.

MozReview-Commit-ID: KkO4u2N9gfE

--HG--
extra : rebase_source : 2fdfecb127987cdbfdccd0e77f7b4bb65f6f5f5d
2018-02-19 22:54:14 +01:00
Daniel Stenberg
74167930bd bug 1438947 - avoid unnecessary timer cancels + clears r=valentin
To avoid race risk.

MozReview-Commit-ID: 2h8xkmgjPP7

--HG--
extra : rebase_source : 31e0fef119862343467049347b012cc6e3056f2c
2018-02-17 00:35:14 +01:00
Daniel Stenberg
e5d3226694 bug 1434852 - introducing TRR (DOH); r=mcmanus,valentin
Provides an optional resolver mechanism for Firefox that allows running
together with or instead of the native resolver.

TRR offers resolving of host names using a dedicated DNS-over-HTTPS server
(HTTPS is required, HTTP/2 is preferable).

DNS-over-HTTPS (DOH) allows DNS resolves with enhanced privacy, secure
transfers and improved performance.

To keep the failure rate at a minimum, the TRR system manages a dynamic
persistent blacklist for host names that can't be resolved with DOH but works
with the native resolver. Blacklisted entries will not be retried over DOH for
a couple of days. "localhost" and names in the ".local" TLD will not be
resolved via DOH.

TRR is preffed OFF by default and you need to set a URI for an available DOH
server to be able to use it. Since the URI for DOH is set with a name itself,
it may have to use the native resolver for bootstrapping. (Optionally, the
user can set the IP address of the DOH server in a pref to avoid the required
initial native resolve.)

When TRR starts up, it will first verify that it works by checking a
"confirmation" domain name. This confirmation domain is a pref by default set
to "example.com". TRR will also by default await the captive-portal detection
to raise its green flag before getting activated.

All prefs for TRR are under the "network.trr" hierarchy.

The DNS-over-HTTPS spec: https://tools.ietf.org/html/draft-ietf-doh-dns-over-https-03

MozReview-Commit-ID: GuuU6vjTjlm

--HG--
extra : rebase_source : 53fcca757334090ac05fec540ef29d109d5ceed3
2018-02-01 10:20:49 +01:00