Commit Graph

259 Commits

Author SHA1 Message Date
Nicolas Chevobbe
925311bc77 Bug 1568779 - Remove editors settings comments in devtools files. r=pbro.
Differential Revision: https://phabricator.services.mozilla.com/D42300

--HG--
extra : moz-landing-system : lando
2019-08-19 12:48:16 +00:00
Julian Descottes
3df7a88f3b Bug 1572390 - Split main.js in debugger-server and debugger-server-connection r=yulia,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D41009

--HG--
rename : devtools/server/main.js => devtools/server/debugger-server-connection.js
rename : devtools/server/main.js => devtools/server/debugger-server.js
extra : moz-landing-system : lando
2019-08-08 12:44:13 +00:00
Alexandre Poirot
abb81825ef Bug 1570604 - Rename DebuggerClient.getActor to getFrontByID. r=jdescottes,yulia
Differential Revision: https://phabricator.services.mozilla.com/D40785

--HG--
extra : moz-landing-system : lando
2019-08-07 10:35:02 +00:00
Panos Astithas
4993f3303e Bug 1406915 - Convert uses of defer to DOM promises in devtools/shared/client/. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D37747

--HG--
extra : moz-landing-system : lando
2019-07-12 14:37:29 +00:00
yulia
cc00bf541b Bug 1559819 - rename threadClient to threadFront; r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D32848

--HG--
rename : devtools/client/debugger/src/actions/tests/helpers/threadClient.js => devtools/client/debugger/src/actions/tests/helpers/threadFront.js
rename : devtools/shared/client/thread-client.js => devtools/shared/fronts/thread.js
extra : moz-landing-system : lando
2019-07-11 09:45:32 +00:00
Panos Astithas
b290fc08af Bug 1233891 - Use DOM promises instead of deprecated sync promises in devtools/. r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D37138

--HG--
extra : moz-landing-system : lando
2019-07-09 17:26:32 +00:00
Victor Porof
b8157dfaaf Bug 1561435 - Format remaining devtools/, a=automatic-formatting, CLOSED TREE
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35894

--HG--
extra : source : 4722b924e08478f5337ab509718bd66906bf472f
extra : amend_source : a5baa1aab21639fdba44537e3a10b179b0073cb4
2019-07-05 11:29:32 +02:00
Logan Smyth
76d6b8f5c2 Bug 1550835 - DOM mutation breakpoint server API. r=jlast,gl
Differential Revision: https://phabricator.services.mozilla.com/D33528

--HG--
extra : moz-landing-system : lando
2019-06-26 06:23:03 +00:00
Logan Smyth
bf92dc5ae0 Bug 1549999 - Use notification infrastructure to implement DOM event breakpoints. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D31002

--HG--
extra : moz-landing-system : lando
2019-06-19 22:27:57 +00:00
yulia
9ab3272468 Bug 1494796 - fix verify test r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D34981

--HG--
extra : moz-landing-system : lando
2019-06-14 20:34:04 +00:00
yulia
6f57978eb3 Bug 1494796 - Delete registerClient functionality; r=jdescottes
The webConsoleFront and the threadClient front both used to depend on the debugger-client
to destroy them via registered clients. This is no longer the case, and this code can be deleted

Differential Revision: https://phabricator.services.mozilla.com/D32699

--HG--
extra : moz-landing-system : lando
2019-06-14 04:24:11 +00:00
yulia
0f5736a52e Bug 1494796 - maintain backwards compatibility r=jdescottes
Introduce a flag to maintain backwards compatibility with old servers

Differential Revision: https://phabricator.services.mozilla.com/D34184

--HG--
extra : moz-landing-system : lando
2019-06-14 04:23:59 +00:00
yulia
bf027a18fa Bug 1494796 - use getFront to retrieve threadClient; r=jdescottes
In order for a front to be available to getFront on a given target, it must be first --
registered on the target scope, and second -- set on the target's targetForm. This makes that update
for both browsing context and worker targets. This works as part of a work around until we can get
the server into better shape.

Differential Revision: https://phabricator.services.mozilla.com/D32698

--HG--
extra : moz-landing-system : lando
2019-06-14 04:24:13 +00:00
yulia
5f77a853c5 Bug 1494796 - Removing threadClient specifics from DebuggerClient Special case resume; r=jdescottes,jlast
The resume case is much more complex than the other events, because we do an
unsafeSynchronize to send an unsolicited pause. In the old system, the resume response would have
been ignored, but that is no longer the case. With the new system, we do not want to send a response
to a resume action if it did not come from the UI. This also update the debugger panel code to
accept a resume.

Differential Revision: https://phabricator.services.mozilla.com/D32697

--HG--
extra : moz-landing-system : lando
2019-06-14 04:24:17 +00:00
yulia
dd7caa0576 Bug 1494796 - get rid of ThreadClient specifics in DebuggerClient, attach/detach methods and events; r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D32845

--HG--
extra : moz-landing-system : lando
2019-06-14 04:24:01 +00:00
yulia
33ce714526 Bug 1494796 - get rid of ThreadClient specifics in DebuggerClient ; r=jdescottes
This is part one of removing threadClient specifics out of the debuggerClient. We were
managing messages from the thread client in a special way -- this was the "Unsolicited Pauses"
object that we had before. This patch updates the threadClient to use Front style events. This
required updating the spec for the threadClient, and several of the methods. What has not been fully
migrated here is the "resumed" event, as this is much more complex. This is taken care of in the
next patch.

Differential Revision: https://phabricator.services.mozilla.com/D32695

--HG--
extra : moz-landing-system : lando
2019-06-14 04:24:15 +00:00
yulia
6816bf4706 Bug 1494796 - Convert ThreadClient into a Front; r=jdescottes
This is the first part of the threadClient refactor. It only moves the methods to the new
front. and does some basic fixes.

Differential Revision: https://phabricator.services.mozilla.com/D32692

--HG--
extra : moz-landing-system : lando
2019-06-14 04:24:19 +00:00
yulia
e9327cc5a4 Bug 1494796 - fork threadclient for backwards compatibility r=jdescottes
make sure we have a copy of thread client for old servers

Differential Revision: https://phabricator.services.mozilla.com/D34179

--HG--
rename : devtools/shared/client/thread-client.js => devtools/shared/client/deprecated-thread-client.js
extra : moz-landing-system : lando
2019-06-14 04:23:55 +00:00
Narcis Beleuzu
7d018750a1 Backed out 13 changesets (bug 1494796) for dt failures on browser_dbg-navigation.js . CLOSED TREE
Backed out changeset 5db908b26d50 (bug 1494796)
Backed out changeset c48f00f0df72 (bug 1494796)
Backed out changeset 591453b88e8b (bug 1494796)
Backed out changeset a14e820311bc (bug 1494796)
Backed out changeset 0e214d450b35 (bug 1494796)
Backed out changeset 1a4ab8b35a85 (bug 1494796)
Backed out changeset fe1559f5f1d4 (bug 1494796)
Backed out changeset 35d967de4223 (bug 1494796)
Backed out changeset 1d21a55cae15 (bug 1494796)
Backed out changeset 33eec873a43e (bug 1494796)
Backed out changeset 25e69c21dc2e (bug 1494796)
Backed out changeset b900d41c8ae8 (bug 1494796)
Backed out changeset c2a034e34fa6 (bug 1494796)
2019-06-14 07:20:42 +03:00
yulia
35d91ebc2b Bug 1494796 - Delete registerClient functionality; r=jdescottes
The webConsoleFront and the threadClient front both used to depend on the debugger-client
to destroy them via registered clients. This is no longer the case, and this code can be deleted

Differential Revision: https://phabricator.services.mozilla.com/D32699

--HG--
extra : moz-landing-system : lando
2019-06-14 00:18:32 +00:00
yulia
a2f0af32b2 Bug 1494796 - maintain backwards compatibility r=jdescottes
Introduce a flag to maintain backwards compatibility with old servers

Differential Revision: https://phabricator.services.mozilla.com/D34184

--HG--
extra : moz-landing-system : lando
2019-06-14 00:18:25 +00:00
yulia
542bcd0e56 Bug 1494796 - use getFront to retrieve threadClient; r=jdescottes
In order for a front to be available to getFront on a given target, it must be first --
registered on the target scope, and second -- set on the target's targetForm. This makes that update
for both browsing context and worker targets. This works as part of a work around until we can get
the server into better shape.

Differential Revision: https://phabricator.services.mozilla.com/D32698

--HG--
extra : moz-landing-system : lando
2019-06-14 00:18:19 +00:00
yulia
607a83590c Bug 1494796 - Removing threadClient specifics from DebuggerClient Special case resume; r=jdescottes,jlast
The resume case is much more complex than the other events, because we do an
unsafeSynchronize to send an unsolicited pause. In the old system, the resume response would have
been ignored, but that is no longer the case. With the new system, we do not want to send a response
to a resume action if it did not come from the UI. This also update the debugger panel code to
accept a resume.

Differential Revision: https://phabricator.services.mozilla.com/D32697

--HG--
extra : moz-landing-system : lando
2019-06-14 00:18:17 +00:00
yulia
844b51e01a Bug 1494796 - get rid of ThreadClient specifics in DebuggerClient, attach/detach methods and events; r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D32845

--HG--
extra : moz-landing-system : lando
2019-06-14 00:32:28 +00:00
yulia
ecc3907641 Bug 1494796 - get rid of ThreadClient specifics in DebuggerClient ; r=jdescottes
This is part one of removing threadClient specifics out of the debuggerClient. We were
managing messages from the thread client in a special way -- this was the "Unsolicited Pauses"
object that we had before. This patch updates the threadClient to use Front style events. This
required updating the spec for the threadClient, and several of the methods. What has not been fully
migrated here is the "resumed" event, as this is much more complex. This is taken care of in the
next patch.

Differential Revision: https://phabricator.services.mozilla.com/D32695

--HG--
extra : moz-landing-system : lando
2019-06-14 00:28:03 +00:00
yulia
650d7f9c31 Bug 1494796 - Convert ThreadClient into a Front; r=jdescottes
This is the first part of the threadClient refactor. It only moves the methods to the new
front. and does some basic fixes.

Differential Revision: https://phabricator.services.mozilla.com/D32692

--HG--
extra : moz-landing-system : lando
2019-06-14 00:14:58 +00:00
yulia
57a1e6ce79 Bug 1494796 - fork threadclient for backwards compatibility r=jdescottes
make sure we have a copy of thread client for old servers

Differential Revision: https://phabricator.services.mozilla.com/D34179

--HG--
rename : devtools/shared/client/thread-client.js => devtools/shared/client/deprecated-thread-client.js
extra : moz-landing-system : lando
2019-06-14 00:14:36 +00:00
yulia
a9f8c70111 Bug 1042642 - Use EventEmitter instead of EventSource for the threadClient; r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D29373

--HG--
extra : moz-landing-system : lando
2019-05-30 08:37:55 +00:00
yulia
29a61755bc Bug 1042642 - use EventEmitter instead of eventSource on the DebuggerClient; r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D29371

--HG--
extra : moz-landing-system : lando
2019-05-29 15:51:28 +00:00
Jason Laster
77d4bd0ad9 Bug 1552453 - Breakpoint doesnt pause in file during page load. r=loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D32161

--HG--
extra : moz-landing-system : lando
2019-05-23 12:52:34 +00:00
Brian Hackett
c201146e83 Bug 1547084 Part 2 - Remove reverseStepIn and reverseStepOut logic, r=loganfsmyth.
--HG--
extra : rebase_source : 9cd48bddd6d4156036b5732a94d3a2c79fd3e992
2019-05-12 13:15:05 -10:00
Oriol Brufau
4be85f2295 Bug 1392760 - Avoid exponential behavior when inspecting nested proxies. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D28214

--HG--
extra : moz-landing-system : lando
2019-05-14 06:46:30 +00:00
Daniel Varga
f59107b417 Backed out changeset a0a023dac829 (bug 1392760) for debugger failure at object-inspector/types 2019-05-06 03:14:57 +03:00
Oriol Brufau
4687ff5e88 Bug 1392760 - Avoid exponential behavior when inspecting nested proxies. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D28214

--HG--
extra : moz-landing-system : lando
2019-04-26 15:32:50 +00:00
yulia
77f46589d6 Bug 1494796 - Use promise pattern rather than callback pattern for threadClient methods; r=ochameau
This is preparation for moving the threadClient to a front. Fronts do not support the
callback style that clients have, they only support promises. As such, this patch migrates all
instances of the threadClient using callback style methods to promises. I have cc'd the debugger
team so that they are aware of this change and it doesn't take them by surprise.

try run : https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=242251058&revision=dbd6cca9619ca0880e920d5b86fc6d6e0c728113

Differential Revision: https://phabricator.services.mozilla.com/D28966

--HG--
extra : moz-landing-system : lando
2019-05-02 15:39:20 +00:00
yulia
2a531fdb64 Bug 1529247 - remove unused pausedLongString method, threadLongString and arrayBuffer methods; r=ochameau
Finally! the goal of all of this: removing three functions from threadClient that really belong as part of source client. PauseLongString is never used except in tests. ThreadLongString is only ever used by sourceClient. Same goes for the arrayBuffer method. This clears all of that out.

Differential Revision: https://phabricator.services.mozilla.com/D21715

--HG--
extra : moz-landing-system : lando
2019-04-30 14:44:23 +00:00
yulia
ef38cc7174 Bug 1545021 - Convert ArrayBuffer to a Front and Protocoljs actor; r=ochameau,jdescottes
This introduces an ArrayBuffer front, so that we no longer need to go through the thread client to get an array buffer for the sourceFront (this is the only place it is used).

It also converts the arrayBufferActor to a protocol.js actor. I was running into an issue between them. I need to double check what this issue was. If these two refactors need to be split, I can do that, but for now it looks like it wasn’t that large of a change.

Differential Revision: https://phabricator.services.mozilla.com/D27878

--HG--
rename : devtools/shared/client/array-buffer-client.js => devtools/shared/fronts/array-buffer.js
extra : moz-landing-system : lando
2019-04-30 14:40:43 +00:00
yulia
9c5ed9f5ef Bug 1042642 - Remove eventSource from EnvironmentClient; r=jdescottes
After reviewing how the EnvironmentClient is used, it looks like the use of eventSource
might be some cruft from the past. Here is the try run:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=242251058&revision=df4bb52f188f79b8006e8c40401e5af2258493ce

with the exception of whatever is going on Window 7 (which appeares also on central), it looks like
things are working as expected. The environment client will eventually have the event emitter, once
it is moved to being a front.

adding @nchevobbe as a subscriber, as this touches a dependancy of the scratchpad.

Differential Revision: https://phabricator.services.mozilla.com/D28962

--HG--
extra : moz-landing-system : lando
2019-04-30 14:57:10 +00:00
Jason Laster
d831a88525 Bug 1547314 - Remove references to updatedSource. r=loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D29036

--HG--
extra : moz-landing-system : lando
2019-04-29 17:52:58 +00:00
yulia
1aa3bce3f9 Bug 1544694 - move and rename SourceClient to SourceFront; r=ochameau,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D27709

--HG--
rename : devtools/shared/client/source-client.js => devtools/shared/fronts/source.js
extra : moz-landing-system : lando
2019-04-26 13:50:47 +00:00
yulia
47738413e6 Bug 1544694 - Convert Source Client to a Front; r=ochameau,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D27708

--HG--
extra : moz-landing-system : lando
2019-04-26 12:51:07 +00:00
yulia
418c70d897 Bug 1544694 - remove unused client getters 'request' and '_transport' from sourceClient; r=ochameau,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D27707

--HG--
extra : moz-landing-system : lando
2019-04-26 12:43:45 +00:00
yulia
854b687951 Bug 1544694 - remove unused method 'getExecutableLines' from sourceClient; r=ochameau,jdescottes,loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D27706

--HG--
extra : moz-landing-system : lando
2019-04-23 13:48:59 +00:00
Dorel Luca
e349607790 Backed out 2 changesets (bug 1544694) for XPCshell failures in devtools/server/tests/unit/test_blackboxing-01.js. CLOSED TREE
Backed out changeset 63d133aae187 (bug 1544694)
Backed out changeset fc739beb6782 (bug 1544694)
2019-04-23 13:09:41 +03:00
yulia
ffb0df9c92 Bug 1544694 - remove unused client getters 'request' and '_transport' from sourceClient; r=ochameau,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D27707

--HG--
extra : moz-landing-system : lando
2019-04-19 09:21:56 +00:00
yulia
a2dd505a24 Bug 1544694 - remove unused method 'getExecutableLines' from sourceClient; r=ochameau,jdescottes,loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D27706

--HG--
extra : moz-landing-system : lando
2019-04-17 16:15:15 +00:00
yulia
994e78fd2f Bug 1532567 - remove unused eval method from threadClient and threadActor; r=bhackett
Differential Revision: https://phabricator.services.mozilla.com/D21700

--HG--
extra : moz-landing-system : lando
2019-03-12 15:03:47 +00:00
Jason Laster
d11dedc8c5 Bug 1532791 - Breaking on exception even if option is off. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D22186

--HG--
extra : moz-landing-system : lando
2019-03-12 19:01:40 +00:00
Ciure Andrei
1cea309572 Backed out changeset e2316f37b988 (bug 1532791)for perma failing test_blackboxing-05.js, test_pause_exceptions-01.js CLOSED TREE 2019-03-12 19:45:39 +02:00
Jason Laster
34482fc99e Bug 1532791 - Breaking on exception even if option is off. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D22186

--HG--
extra : moz-landing-system : lando
2019-03-12 15:41:39 +00:00