Any time we QI to nsIFrameLoaderOwner in tests, we're really accessing
a MozFrameLoader. We don't need to be doing that anymore.
Differential Revision: https://phabricator.services.mozilla.com/D19727
--HG--
extra : moz-landing-system : lando
* New topLevel loads get the nsILoadInfo.openerPolicy of the current top level document
* Parsing the Cross-Opener-Origin-Policy of a channel will update mLoadInfo.openerPolicy and this value will get propagated to the child process.
* SessionStore now checks nsIHttpChannel.hasCrossOriginOpenerPolicyMismatch (preffed off) and performs a process switch if needed
Differential Revision: https://phabricator.services.mozilla.com/D19000
--HG--
rename : toolkit/components/remotebrowserutils/tests/browser/browser_httpResponseProcessSelection.js => toolkit/components/remotebrowserutils/tests/browser/browser_httpCrossOriginOpenerPolicy.js
extra : moz-landing-system : lando
- Adds nsIHttpChannelInternal.setTopWindowPrincipal used to pass the principal from the child to the parent
Differential Revision: https://phabricator.services.mozilla.com/D18391
--HG--
extra : moz-landing-system : lando
If we got past the first iteration we shouldn't stop for the skipped count matching
the total tests since we increment this with the total tests on each iteration.
Differential Revision: https://phabricator.services.mozilla.com/D20153
--HG--
extra : moz-landing-system : lando
Minor post-patch linting to silence some clippy warnings.
Depends on D19434
Differential Revision: https://phabricator.services.mozilla.com/D19435
--HG--
extra : moz-landing-system : lando
This will print something along the line of:
geckodriver: error: invalid --port: invalid digit found in string: asd
Or:
geckodriver: error: invalid --port: number too large to fit in target type: 123123123123
We also Include the error message from IpAddr::from_str() to the user.
This will make the error seen by the user look something like this:
geckodriver: error: invalid IP address syntax: 123123:4444
Depends on D19433
Differential Revision: https://phabricator.services.mozilla.com/D19434
--HG--
extra : moz-landing-system : lando
For completeness, this makes sure the --help flag is included in
its own help message.
Depends on D19432
Differential Revision: https://phabricator.services.mozilla.com/D19433
--HG--
extra : moz-landing-system : lando
Flag parsing and application logic belong to one, very long,
spaghetti-like function. This patch introduces a distinction
between checking the sanity of the CLI input and what action to
take depending on that input.
Depends on D19431
Differential Revision: https://phabricator.services.mozilla.com/D19432
--HG--
extra : moz-landing-system : lando
The help message is implicitly included in clap error descriptions, but
they are not for errors originating from this file. By introducing
a FatalError::help_included() function we make sure we print the
help message in all cases.
An alternative implementation, which perhaps would be more idiomatic,
would be to prepare the help message within the fmt::Display trait
implementation for FatalError, but I could find no way of passing
in a reference to clap::App without storing it in an atomic global const.
Depends on D19430
Differential Revision: https://phabricator.services.mozilla.com/D19431
--HG--
extra : moz-landing-system : lando
Because we emit the flag parsing errors to the log, through error!(),
they are subject to whether the logging subsystem is enabled.
Because logging is disabled by default, no error information is
currently displayed to the user.
Since we cannot initialise logging implicitly due to the risk of
emitting log messages the user did not request, this patch changes
geckodriver to print the flag parsing errors to stderr
Depends on D19429
Differential Revision: https://phabricator.services.mozilla.com/D19430
--HG--
extra : moz-landing-system : lando
We replaced --webdriver-port with --port to better match
EdgeDriver and chromedriver, but it was discovered in
https://github.com/mozilla/geckodriver/issues/154 that this broke
Selenium clients.
We decided on a two-spearhead approach by reintroducing --webdriver-port
as a temporary alias, whilst submitting fixes for the Selenium clients.
The fixes to Selenium landed over three years ago.
This patch removes the --webdriver-port alias from geckodriver.
Depends on D19427
Differential Revision: https://phabricator.services.mozilla.com/D19428
--HG--
extra : moz-landing-system : lando
Instead of returning a tuple of (i32, String), causing us to lose
details and the cause of an error, this patch formalises the error
scenarios that may occur during command-line parsing and startup
of the WebDriver server.
Exit codes are encoded with each variant of FatalError, instead of
being specified in each case.
Type conversions are implemented for clap::Error (flag parsing)
and io::Error (webdriver::server).
Depends on D19426
Differential Revision: https://phabricator.services.mozilla.com/D19427
--HG--
extra : moz-landing-system : lando
We don't need an enum for exit codes as we never have to match
on them. Converting them to consts also has the benefit that we
will not have to coerce them to i32.
i32 is the correct type to use here, since it is what std::process::exit()
takes and what the libc crate uses.
Depends on D19424
Differential Revision: https://phabricator.services.mozilla.com/D19425
--HG--
extra : moz-landing-system : lando
Making use of clap::Arg::default_value() removes duplicated magic
strings, by not having to use .unwrap_or("default value").
Depends on D19423
Differential Revision: https://phabricator.services.mozilla.com/D19424
--HG--
extra : moz-landing-system : lando
The behaviour of switching to an already opened tab for an item in the stream
list was already in place, this patch just modifies the item's layout by
adding a text hint about this possibility - "Switch to tab", dynamically,
depending on if a tab is already opened or not in the current session.
Each stream item will implement `Tabs.OnTabsChangedListener` and check if the
changed Tab had stream's Url.
If so it will pass this event to the list's Adapter which will refresh the
stream item's layout.
Differential Revision: https://phabricator.services.mozilla.com/D18997
--HG--
extra : moz-landing-system : lando
The error happened because aboutPerformance provided an unused
parameter to Classify API which is removed in Bug 1501458.
Check tracking protection tables via Classify API is not supported now.
We should use asyncClassifyLocalWithFeatures API instead.
Differential Revision: https://phabricator.services.mozilla.com/D19793
--HG--
extra : moz-landing-system : lando
Added check for AES128GCM encoding since we won't have separate enckey and cryptokey but rather encoded in the body.
Differential Revision: https://phabricator.services.mozilla.com/D19806
--HG--
extra : moz-landing-system : lando
Removed intended throw of IllegalStateException for Nightly when a page was not considered safe as a PWA.
Differential Revision: https://phabricator.services.mozilla.com/D18533
--HG--
extra : moz-landing-system : lando
Replaces custom generated hashes with the actorIDs which are stable
during the editing session enough to use as unique identifiers.
For future restore / persistence, we still have the metadata about each
rule and stylesheet to attempt to identify them again.
Differential Revision: https://phabricator.services.mozilla.com/D18660
--HG--
extra : moz-landing-system : lando
By using WebRenderTextureHostWrapper for canvas, we could avoid triggering frame build on WebRender backend if WebRenderTextureHostWrapper is only change.
Differential Revision: https://phabricator.services.mozilla.com/D19896
--HG--
extra : moz-landing-system : lando
