Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 21:31:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
777,067 Commits 615 Branches 98 Tags 6 GiB
149cd3677e
Commit Graph

24034 Commits

Author SHA1 Message Date
Nicolas Chevobbe
149cd3677e Bug 1740453 - [devtools] Handle onTargetSelected in accessibility panel. r=ochameau. 
A couple tests are added to check that the panel works fine when using the iframe picker.

Differential Revision: https://phabricator.services.mozilla.com/D130611
 2021-11-18 13:22:34 +00:00
Raphael Ferrand
702f0ad086 Bug 1498224 - [devtools] Apply new classnames as you type in the .cls section of the rule-view r=jdescottes 
Differential Revision: https://phabricator.services.mozilla.com/D129515
 2021-11-18 12:52:22 +00:00
Alexandre Poirot
8ed2c76f1f Bug 1740292 - [devtools] Remove target actor's _detach method. r=nchevobbe 
Well, the RDP method "detach" still exists, but is now destroying the target actor.
There is no more intermediate state where the actor is "detached" but not destroyed,
which is confusing and no longer useful now that we can longer attach again.

Differential Revision: https://phabricator.services.mozilla.com/D130916
 2021-11-18 10:57:02 +00:00
Alexandre Poirot
71f51e2a2f Bug 1740292 - [devtools] Remove all notion of "attached" in target actors. r=nchevobbe 
This might make the leftover "detach" method a bit more special.
But ideally we would get rid of it and convert it to a call to target actor's destroy method.

Differential Revision: https://phabricator.services.mozilla.com/D130915
 2021-11-18 10:57:02 +00:00
Alexandre Poirot
841b8e961c Bug 1740292 - [devtools] Remove target actor's attach method entirely. r=nchevobbe,devtools-backward-compat-reviewers 
(except for the special edgecase of worker's hybrid descriptor/target)

Differential Revision: https://phabricator.services.mozilla.com/D130914
 2021-11-18 10:57:01 +00:00
Alexandre Poirot
487d9677f3 Bug 1740292 - [devtools] Stop calling target front attach method. r=nchevobbe 
Previous patches made attach method become a no-op, so all these callsites can be removed.

Differential Revision: https://phabricator.services.mozilla.com/D130913
 2021-11-18 10:57:01 +00:00
Alexandre Poirot
5aea7b3306 Bug 1740292 - [devtools] Merge target actor's attach methods into their constructors. r=nchevobbe 
By doing that, we no longer have to ensure calling attach here and there.
Some followups will be helpful to get rid of detach and all mentions of attach/detach/attached.
Some code, like descriptors and tests are still calling attach, which is now a no-op.
Gettind rid of detach might be slightly more complicated.

Differential Revision: https://phabricator.services.mozilla.com/D130843
 2021-11-18 10:57:01 +00:00
Alexandre Poirot
95bb482288 Bug 1740292 - [devtools] Stop calling Target actor's attach method from the frontend. r=nchevobbe,devtools-backward-compat-reviewers 
Calling attach was important to bootstrap the thread actor and retrieve its actorID.
But now with server target this is done early on and we already retrieve the actorID
via form(). Except for workers, but I fixed that.

The next patch will ensure that, on the server side we fully initialize the target actors
as soon as they are created.

Differential Revision: https://phabricator.services.mozilla.com/D130842
 2021-11-18 10:57:00 +00:00
Alexandre Poirot
19f5a90b8b Bug 1740292 - [devtools] Avoid exception in DOCUMENT_EVENT listener when running xpcshell tests. r=nchevobbe 
Note that these exception doesn't seem to make the test fail (for ex in test_nesting-03.js).

Differential Revision: https://phabricator.services.mozilla.com/D130841
 2021-11-18 10:56:59 +00:00
Alexandre Poirot
572abaa684 Bug 1740292 - [devtools] Use a single method to create xpcshell target globals. r=nchevobbe 
testGlobal and createTestGlobal were redundant.

Differential Revision: https://phabricator.services.mozilla.com/D130840
 2021-11-18 10:56:59 +00:00
Florian Quèze
bc5e79f3ae Bug 1741235 - Merge the 'Firefox Front-End' and 'Firefox Platform' profiler presets, r=julienw,fluent-reviewers,nbaumgardner,kpatenio. 
Differential Revision: https://phabricator.services.mozilla.com/D131158
 2021-11-17 18:37:43 +00:00
Julian Descottes
b9f00defcc Bug 1736321 - [devtools] Document DevTools Sheriffing process r=devtools-reviewers,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D128717
 2021-11-17 16:16:43 +00:00
Clinton
3c6ae051d2 [devtools] Bug 1737990 - Remove lodash uniq usage r=nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D129965
 2021-11-17 15:33:08 +00:00
Tawah Peggy
1cf3aba54d Bug 1737989 - Remove lodash union usage. r=nchevobbe. 
Differential Revision: https://phabricator.services.mozilla.com/D131227
 2021-11-17 15:31:58 +00:00
Csoregi Natalia
63c1f53d14 Backed out 2 changesets (bug 1709267) for causing devtools failures. CLOSED TREE 
Backed out changeset e4dc58404c6c (bug 1709267)
Backed out changeset 88f46043876e (bug 1709267)
 2021-11-17 17:50:00 +02:00
Jan Odvarko
90968a4061 Bug 1740964 - [devtools] The link for yarn is outdated r=jdescottes 
Differential Revision: https://phabricator.services.mozilla.com/D131330
 2021-11-17 14:21:41 +00:00
Nicolas Chevobbe
70a89dbb2c Bug 1740455 - [devtools] Add a test for TabbingOrder highlighter. r=ochameau. 
A new method is added in the HighlighterTestActor to retrieve information about
the highglighter.
The test highlights (pun intended) the issue described in Bug 1740509.

Differential Revision: https://phabricator.services.mozilla.com/D130875
 2021-11-17 14:07:38 +00:00
Alexandre Poirot
aff1b7a2ce Bug 1709267 - [devtools] Add support for target switching in about:debugging. r=jdescottes 
The challenges here are:
* xpcshell tests still don't support the watcher actor and server side targets. So we have to ensure still using client side target fetched via Descriptor.getTarget RDP request. (We still also need that for WebExtension)
* some tests weren't spawning the TargetCommand while querying TabDescriptor.getTarget. I tuned them to call TargetCommand.startListening so that we start instantiating server side targets, including the top level one retrieved via TabDescriptor.getTarget.

Otherwise, thanks to this patch a few check can now be moved from `if (isLocalTab)` to `if (isTabDescriptor)`.

Differential Revision: https://phabricator.services.mozilla.com/D130761
 2021-11-17 14:05:15 +00:00
Alexandre Poirot
0fcb928cf6 Bug 1709267 - [devtools] Remove unused "target" query parameter from toolbox location. r=jdescottes 
This wasn't used except for a test and wasn't working with server side targets.
Making this compatible with SST wasn't trivial, so I went for removing this.

Differential Revision: https://phabricator.services.mozilla.com/D130919
 2021-11-17 14:05:15 +00:00
Julian Descottes
0e2fb01932 Bug 1741369 - [devtools] Import devtools require in head.js for some xpcshell test suites r=ochameau 
Depends on D131218

Differential Revision: https://phabricator.services.mozilla.com/D131329
 2021-11-17 12:43:27 +00:00
Julian Descottes
212faeb0c3 Bug 1741369 - [devtools] Update paths to loader files in devtools/ r=ochameau 
Depends on D131216

Differential Revision: https://phabricator.services.mozilla.com/D131217
 2021-11-17 12:43:26 +00:00
Julian Descottes
2a2ef964fb Bug 1741369 - [devtools] Move all loader-related files to devtools/shared/loader r=ochameau 
Differential Revision: https://phabricator.services.mozilla.com/D131216
 2021-11-17 12:43:26 +00:00
Niklas Goegge
5d592a6adb Bug 1617611: Annotate each failing test individually. r=webdriver-reviewers,necko-reviewers,ckerschb,whimboo,valentin 
Annotating each test individually lets us avoid introducing new failing tests
while we go through the backlog of failing tests.

Depends on D129162

Differential Revision: https://phabricator.services.mozilla.com/D129163
 2021-11-17 11:04:34 +00:00
Julian Descottes
5b84fb14b0 Bug 1740281 - [devtools] Cancel node picker correctly when using client side shortcuts r=nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D131174
 2021-11-17 10:56:39 +00:00
Markus Stange
7a7d1b26de Bug 1726281 - Allow symbolication WebChannel requests for profiler tabs that weren't opened by a profile capturing action. r=julienw 
This makes it easier to symbolicate profiles that were captured to a file
without symbolication.

Differential Revision: https://phabricator.services.mozilla.com/D122928
 2021-11-16 20:41:24 +00:00
Markus Stange
a9992f19f4 Bug 1625309 - Use /from-browser. r=julienw 
This was implemented in https://github.com/firefox-devtools/profiler/pull/3466.

Differential Revision: https://phabricator.services.mozilla.com/D122923
 2021-11-16 20:41:24 +00:00
Markus Stange
c6b6868ce0 Bug 1625309 - Make fake-frontend.html work with the WebChannel. r=julienw 
Differential Revision: https://phabricator.services.mozilla.com/D131189
 2021-11-16 20:41:23 +00:00
Markus Stange
c9d0a2af2a Bug 1625309 - Remove the frame script and instead use the WebChannel to expose the profile and symbolication. r=julienw 
Differential Revision: https://phabricator.services.mozilla.com/D121933
 2021-11-16 20:41:23 +00:00
Julian Descottes
d226afc848 Bug 1740438 - [devtools] Remove backward compatibility code for recordAllocations target configuration option r=devtools-reviewers,bomsy 
Depends on D130847

Differential Revision: https://phabricator.services.mozilla.com/D130848
 2021-11-16 14:34:27 +00:00
Julian Descottes
474ba47047 Bug 1740438 - [devtools] Remove backward compatibility code for clearPickerSupport trait r=devtools-reviewers,bomsy 
Depends on D130846

Differential Revision: https://phabricator.services.mozilla.com/D130847
 2021-11-16 14:34:27 +00:00
Julian Descottes
cbd04951b9 Bug 1740438 - [devtools] Remove backward compatibility code for typename browsingContextTarget r=devtools-reviewers,bomsy 
Depends on D130845

Differential Revision: https://phabricator.services.mozilla.com/D130846
 2021-11-16 14:34:26 +00:00
Julian Descottes
a33af7064f Bug 1740438 - [devtools] Remove backward compatibility code for useChildTargetToFetchChildren r=devtools-reviewers,bomsy 
Depends on D130844

Differential Revision: https://phabricator.services.mozilla.com/D130845
 2021-11-16 14:34:26 +00:00
Julian Descottes
4e5f134653 Bug 1740438 - [devtools] Remove backward compatibility code for event-breakpoints trait r=devtools-reviewers,bomsy 
Differential Revision: https://phabricator.services.mozilla.com/D130844
 2021-11-16 14:34:25 +00:00
criss
507f143b88 Backed out 2 changesets (bug 1617611) for causing mochitest failures on storageAccessWithDynamicFpi.js. CLOSED TREE 
Backed out changeset fdb2c6bfc0c6 (bug 1617611)
Backed out changeset c3352f4b3681 (bug 1617611)
 2021-11-16 13:02:05 +02:00
Niklas Goegge
5b684c7fc6 Bug 1617611: Annotate each failing test individually. r=webdriver-reviewers,necko-reviewers,ckerschb,whimboo,valentin 
Annotating each test individually lets us avoid introducing new failing tests
while we go through the backlog of failing tests.

Depends on D129162

Differential Revision: https://phabricator.services.mozilla.com/D129163
 2021-11-16 10:15:45 +00:00
Hubert Boma Manilla
de4e58224c Bug 1736366 - [devtools] Refactor the getBreakpointSources selector to no longer use makeShallowQuery r=ochameau 
Differential Revision: https://phabricator.services.mozilla.com/D128742
 2021-11-16 09:51:18 +00:00
Sylvestre Ledru
39a2e463ea Bug 1714788 - doc: Fix a Pygments warning r=firefox-source-docs-reviewers,championshuttler DONTBUILD 
Warning:
lexer name 'bz_comment_text' is not known

Depends on D131047

Differential Revision: https://phabricator.services.mozilla.com/D131095
 2021-11-16 07:59:49 +00:00
Sylvestre Ledru
1df999712f Bug 1714788 - doc: do not provide the language if the code isn't valid r=firefox-source-docs-reviewers,championshuttler DONTBUILD 
Otherwise, the warning is displayed:
```
WARNING: Could not lex literal_block as "json". Highlighting skipped.
```

Depends on D131092

Differential Revision: https://phabricator.services.mozilla.com/D131093
 2021-11-16 07:59:48 +00:00
Sylvestre Ledru
cc801c974a Bug 1714788 - doc: Remove an html artifact r=firefox-source-docs-reviewers,championshuttler,nchevobbe DONTBUILD 
Depends on D131091

Differential Revision: https://phabricator.services.mozilla.com/D131092
 2021-11-16 07:59:47 +00:00
Sylvestre Ledru
e747d0c0f5 Bug 1714788 - doc: Fix a warning 'Inline interpreted text' r=firefox-source-docs-reviewers,championshuttler DONTBUILD 
WARNING: Inline interpreted text or phrase reference start-string without end-string.

Depends on D131090

Differential Revision: https://phabricator.services.mozilla.com/D131091
 2021-11-16 07:59:47 +00:00
Markus Stange
39942c6822 Bug 1728602 - Use IOUtils.openFileForSyncReading in symbolication-worker.js. r=canaltinova 
Differential Revision: https://phabricator.services.mozilla.com/D124208
 2021-11-16 00:17:40 +00:00
Dão Gottwald
84973358a7 Bug 1740954 - Remove the arrowposition attribute. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D131059
 2021-11-15 23:03:43 +00:00
Norisz Fay
212a384c46 Backed out 5 changesets (bug 1740438) for causing xpcshell failures on test_action-toggle-recording-allocations.js CLOSED TREE 
Backed out changeset 28518fbe3077 (bug 1740438)
Backed out changeset f33ea874875c (bug 1740438)
Backed out changeset f20e36b0d1d4 (bug 1740438)
Backed out changeset 2f166a7bc13b (bug 1740438)
Backed out changeset 9d9bcf855ceb (bug 1740438)
 2021-11-15 12:40:16 +02:00
Julian Descottes
9a7494f5c7 Bug 1740438 - [devtools] Remove backward compatibility code for recordAllocations target configuration option r=devtools-reviewers,bomsy 
Depends on D130847

Differential Revision: https://phabricator.services.mozilla.com/D130848
 2021-11-15 08:46:37 +00:00
Julian Descottes
2c9b193c11 Bug 1740438 - [devtools] Remove backward compatibility code for clearPickerSupport trait r=devtools-reviewers,bomsy 
Depends on D130846

Differential Revision: https://phabricator.services.mozilla.com/D130847
 2021-11-15 08:46:37 +00:00
Julian Descottes
d55289222a Bug 1740438 - [devtools] Remove backward compatibility code for typename browsingContextTarget r=devtools-reviewers,bomsy 
Depends on D130845

Differential Revision: https://phabricator.services.mozilla.com/D130846
 2021-11-15 08:46:36 +00:00
Julian Descottes
fd96986f11 Bug 1740438 - [devtools] Remove backward compatibility code for useChildTargetToFetchChildren r=devtools-reviewers,bomsy 
Depends on D130844

Differential Revision: https://phabricator.services.mozilla.com/D130845
 2021-11-15 08:46:36 +00:00
Julian Descottes
793ef6b2aa Bug 1740438 - [devtools] Remove backward compatibility code for event-breakpoints trait r=devtools-reviewers,bomsy 
Differential Revision: https://phabricator.services.mozilla.com/D130844
 2021-11-15 08:46:35 +00:00
Julian Descottes
167e19ec64 Bug 1737790 - [devtools] Color picker should fallback on getClosestBackgroundColor for elements without quads r=nchevobbe 
The getBackgroundColor already has fallback paths for several situations.
We now use the fallback in case getAdjustedQuads returned an empty array.

A browser mochitest is added to cover this issue as well.

Differential Revision: https://phabricator.services.mozilla.com/D130750
 2021-11-15 08:44:46 +00:00
Nicolas Chevobbe
674b6582ba Bug 1740454 - [devtools] Fix a11y panel react warnings. r=ochameau. 
Differential Revision: https://phabricator.services.mozilla.com/D130855
 2021-11-15 07:00:03 +00:00