Benjamin Smedberg
3498a5f86e
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.
--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
73a6fab34b
Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal.
2009-01-09 11:35:24 -05:00
Benjamin Smedberg
802d1a10c7
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
bzbarsky@mit.edu
dc7ecebfee
Make image controls splittable just like regular images. Bug 409659, r+sr=roc, a=dsicore
2008-01-04 22:44:38 -08:00
jwalden@mit.edu
6d7584839a
Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros.
2007-07-08 00:08:04 -07:00
mats.palmgren@bredband.net
42a227c78a
Cleanup implementations of QueryInterface. b=385750 r+sr=dbaron r+sr=jst
2007-07-03 19:15:31 -07:00
dbaron%dbaron.org
9d7f938b99
Clean up IsFrameOfType methods to call their base class IsFrameOfType methods reliably. b=341326 r+sr=roc
2007-02-24 18:33:33 +00:00
asqueella%gmail.com
e70812ddff
bug 370371 - remove nsIImageControlFrame, have the frame set the last clicked point as a property on its mContent instead.
...
r+sr=roc
2007-02-18 16:49:54 +00:00
cvshook%sicking.cc
a39ff30284
Kill remainders of ns(XBL|HTML|XUL|Layout)Atoms. r/sr=jst b=368128
2007-01-30 00:06:41 +00:00
timeless%mozdev.org
4e651390ef
Bug 355300 There should be only one nsGkAtoms creature
...
r=dbaron
2006-12-26 17:47:52 +00:00
dbaron%dbaron.org
31f1898810
Bug 300030: Move intrinsic width computation out of nsIFrame::Reflow and into its own methods on nsIFrame. Replace reflow reasons, types, and commands with dirty bits/notifications. Thanks to bzbarsky for almost all of the HTML form controls (mozilla/layout/forms) changes, and many others for help testing and patching. For detailed commit logs, see REFLOW_YYYYMMDD_BRANCH, where YYYYMMDD is one of 20061031, 20060830, 20060603, 20060302, 20060119, 20051011, 20050804, 20050429, 20050315, 20050111, and 20041213.
2006-12-08 05:38:33 +00:00
Olli.Pettay%helsinki.fi
8b6f4c022e
Consolidate NS_MOUSE_***_UP/DOWN/CLICK/DBLCLICK events, r=jst,roc,josh,sergei_d,emaijala,mkaply
2006-11-16 21:35:39 +00:00
mats.palmgren%bredband.net
47bd18fde6
Remove the special painting code for a 165-twips checkbox. Move the remaining parts of nsFormControlHelper to its consumers and remove nsFormControlHelper.{cpp,h} from the tree. b=343495 r+sr=roc (r=me on roc's part)
2006-07-06 10:43:51 +00:00
roc+%cs.cmu.edu
a7f03736a9
Bug 328926. Remove aPresContext parameter from nsIFrame::Destroy, nsIFrame::SetInitialChildList and nsIFrame::RemovedAsPrimaryFrame. patch by Marc Liddell, r+sr=roc
2006-04-10 00:16:29 +00:00
roc+%cs.cmu.edu
0a10a79f62
Bug 330934. Set a nsIFrame's stylecontext in its constructor, to ensure that there's always one available for GetPresContext() to use even if Init hasn't been called. Patch by Marc Liddell, r+sr=roc
2006-03-26 21:30:36 +00:00
pavlov%pavlov.net
131e8794e2
backing out roc's patch for bug 328926 due to crash running tests on vc8 machines.
2006-03-15 06:43:36 +00:00
roc+%cs.cmu.edu
557b089a47
Bug 328926. Remove aPresContext parameter from Destroy and SetInitialChildList. patch by Marc Liddell, r+sr=roc
2006-03-15 03:14:02 +00:00
roc+%cs.cmu.edu
b65c655ed9
Bug 254755. deCOMtaminate nsIFormControlFrame. patch by jpl24, r+sr=roc
2005-12-12 23:53:06 +00:00
roc+%cs.cmu.edu
a5f65bfee7
Bug 313817. DeCOMtaminate more NS_New*Frame functions. r+sr=roc, patch by Marc Liddell
2005-11-01 20:40:54 +00:00
cvshook%sicking.cc
64a0fbd45f
Bug 311827: Make GetAttr return a bool rather then an nsresult.
...
r/sr=bz
2005-10-28 11:25:24 +00:00
roc+%cs.cmu.edu
6377fe1d40
Bug 296036. Remove the very poorly specified (and redundant) field 'point' of nsEvent. r+sr=roc, patch by Eli Friedman
2005-08-23 03:57:07 +00:00
jst%mozilla.jstenback.com
50de4a3e1d
Fixing bug 289940. Make chrome event handlers only receive trusted events by default. r=jonas@sicking.cc, sr=peterv@propagandism.org, a=chofmann@mozilla.org
2005-04-28 23:48:28 +00:00
aaronleventhal%moonset.net
a87209aaa6
Bug 287390. Problems with accessibility of image, submit, reset and file control buttons. r=pkwarren, sr=jst
2005-03-27 03:03:11 +00:00
cbiesinger%web.de
b71e2a3790
38447 layout,content,dom and xpwidget part: Implement Handling of URI Values on
...
CSS "cursor" Properties
for dom,layout,content: r+sr=bz
for widget: r+sr=roc
2004-12-30 21:56:11 +00:00
bmlk%gmx.de
d3197a9276
remove unused prescontext argument from GetOffsetFromView bug 276015 r/sr=dbaron
2004-12-26 19:48:54 +00:00
bryner%brianryner.com
5c02a6978c
Change nsIPresContext to nsPresContext globally, follow-up to bug 253470. rs=roc
2004-07-31 23:15:21 +00:00
rbs%maths.uq.edu.au
e2527bce29
Cleanup font usage in form input controls, b=251637, r=jshin, sr=bzbarsky
2004-07-21 01:05:44 +00:00
gerv%gerv.net
708b56cff4
Bug 236613: change to MPL/LGPL/GPL tri-license.
2004-04-18 14:30:37 +00:00
roc+%cs.cmu.edu
17f81274ba
Bug 227838. Remove unused RequiresWidget method from nsIFormControlFrame. r+sr=bzbarsky
2004-04-13 03:11:05 +00:00
roc+%cs.cmu.edu
8397ac8d8f
Bug 235264. Clean up invalidation to go through a single nsIFrame::Invalidate function and take account of 'outline' where necessary. r+sr=dbaron
2004-03-10 03:09:05 +00:00
roc+%cs.cmu.edu
e6f646d474
Bug 236438. Make nsImageControlFrame translate its event point properly even if it has no view
2004-03-06 04:48:15 +00:00
roc+%cs.cmu.edu
87b13e8430
Bug 53966. Remove unnecessary view creation from nsImageControlFrame, and remove unused fields and functions from nsImageControlFrame/nsHTMLButtonControlFrame. r+sr=bzbarsky
2004-02-28 15:01:38 +00:00
bryner%brianryner.com
92499cbd13
Inline TwipsToPixels and PixelsToTwips on nsIPresContext. Bug 229371, r+sr=dbaron.
2004-02-11 04:57:07 +00:00
bryner%brianryner.com
dfe3513814
Change all callers of nsIPresContext::GetShell() to use the non-refcounting versions. Most callers now use PresShell(), a few that were checking for null conditions are using GetPresShell() -- this will be remedied once we can ensure that a prescontext never has a null pres shell. Bug 227690, r+sr=bzbarsky.
2003-12-21 05:36:36 +00:00
uid502
d81619b4fa
Bug 190735. DeCOMtaminate nsIFrame::GetFrameType. r+sr=bzbarsky
2003-10-31 20:19:18 +00:00
roc+%cs.cmu.edu
0b15c3893e
Ongoing deCOMtamination. r+sr=dbaron
2003-07-04 12:50:32 +00:00
dbaron%dbaron.org
4afcaa0e69
DeCOMtaminate nsIFrame::GetView and SetView, and add HasView, GetClosestView, and AreAncestorViewsVisible to consolidate common patterns. b=208004 r+sr=roc
2003-06-19 23:44:01 +00:00
dbaron%dbaron.org
75ff60c62f
Clean up API (and its callers) for getting style data: remove unneeded null checks and switch to new inline member functions (one for each struct) that return values. b=197205 r+sr=roc a=brendan
2003-05-15 03:42:21 +00:00
bryner%netscape.com
e43f5a49fd
Remove nsIStyleContext (bug 114713), r/sr=dbaron. Changed lots of methods to use nsStyleContext* or already_AddRefed<nsStyleContext> as return values, depending on whether a reference is returned. Turn on nsRefPtr (bug 104346), and change nsDerivedSafe to not declare AddRef and Release explicitly virtual, r=jag, sr=dbaron.
2003-02-22 00:32:13 +00:00
jkeiser%netscape.com
cb84e04c70
Make GetType() return int instead of nsresult (bug 167762), r=peterl@netscape.com, sr=kin@netscape.com
2002-12-18 23:38:09 +00:00
roc+%cs.cmu.edu
88a7759322
Bug 113083. Concentrate view setup code into a few shared functions in nsContainerFrame. Only change style-dependent view properties after style change, not during reflow, in response to nsChangeHint_SyncFrameView. Change 'clip' to only do SyncFrameView, not reflow. r=dbaron,sr=kin
2002-09-30 11:56:37 +00:00
dbaron%fas.harvard.edu
a7f0385127
Clean up unneeded includes of nsStyleUtil.h, and some other include cleanup in MathML. r=rbs b=71257 (|#include| changes only)
2002-08-16 11:52:20 +00:00
bzbarsky%mit.edu
5d1c18865d
clean up some form control stuff (use common helpers and superclasses
...
for shared functionality where possible). r=jkeiser, sr=jst
2002-08-06 23:50:08 +00:00
jkeiser%netscape.com
4d507d3aff
Remove nsFormFrame forever. bug 125578, r=alexsavulov@netscape.com, sr=jst@netscape.com
2002-06-04 00:44:04 +00:00
jst%netscape.com
1075a3f80d
Fixing bug 146034. Getting rid of nsHTMLIIDs.{h,cpp}. r=jfrancis@netscape.com, sr=rpotts@netscape.com
2002-05-23 00:00:34 +00:00
locka%iol.ie
08b77d441d
Stop image control frame stomping on the event status. This stops context menu events being propogated to their parents and sent twice for input elements with images. bugscape=14131 r=saari@netscape.com sr=jst@netscape.com
2002-05-01 20:15:44 +00:00
dbaron%fas.harvard.edu
66238732c8
Convert users of nsAReadable[C]String and nsAWritable[C]String typedefs to [const] nsA[C]String. b=131899 r=scc sr=jag a=asa
2002-03-23 22:26:36 +00:00
bryner%netscape.com
94aaf03246
Bug 124298 - moving form submit/reset event firing into the content node. r=jkeiser, sr=attinasi
2002-02-08 23:50:51 +00:00
roc+%cs.cmu.edu
c88233916b
Bug 73382. Clean up view manager interfaces, 2nd attempt. r=kmcclusk,rs=attinasi
2001-12-01 14:31:45 +00:00
roc+%cs.cmu.edu
c26c9711f3
My cleanup checkin for bug 73382 caused 5% increase in page load times. Backing out.
2001-11-24 05:37:25 +00:00