Depends on D11506
Removes the `fonts` field from the Redux slice previously used by the FontOverview component
in the Font Inspector version of the Fonts panel. This field is duplicated with the `fonts`
used by the Font Editor. The telemetry can use that one instead.
Refactors the update() method which updates the Redux slice for the FontOverview component.
In time, the update() and refreshFontEditor() method will merge. So will the Redux slices:
`fontEditor` and `fonts` in order to save a duplicate call to the server for `allFonts`.
Differential Revision: https://phabricator.services.mozilla.com/D11507
--HG--
extra : moz-landing-system : lando
Depends on D11505
The `otherFonts` field in the Redux store slice for Fonts was used by the old Font Inspector to differentiate
between fonts on the element and fonts elsewhere on the page. This is no longer used with the Font Editor.
Differential Revision: https://phabricator.services.mozilla.com/D11506
--HG--
extra : moz-landing-system : lando
This patch removes the `devtools.inspector.fonteditor.enabled` pref and all its uses in the Fonts panel.
Obsolete actions for the case when the pref was off are also removed. This is mostly old Font Inspector code.
One test is temporarily disabled because it tests the old Font Inspector. It will be removed along with other
pieces on the next part of this commit series.
Differential Revision: https://phabricator.services.mozilla.com/D11505
--HG--
extra : moz-landing-system : lando
To make $0 autocompletion work, we need to pass the current
selectedNode actor from the frontend, so we can retrieve the
object reference later.
For $_, we need the webconsole actor reference to be able
to retrieve the last input result.
Since the list of parameters of JsPropertyProviders was
getting a bit long, we transform them in an object so it's
more legible on the consumer side.
Mochitests are added for both helpers to ensure this work
as expected.
Differential Revision: https://phabricator.services.mozilla.com/D11866
--HG--
extra : moz-landing-system : lando
This patch removes the following functions:
* nsContentUtils::IsCustomElementsEnabled()
* CustomElementRegistry::IsCustomElementEnabled(JSContext* aCx, JSObject* aObject)
* CustomElementRegistry::IsCustomElementEnabled(nsIDocument* aDoc)
and all references of the pref.
Depends on D11183
Differential Revision: https://phabricator.services.mozilla.com/D11249
--HG--
extra : moz-landing-system : lando
This patch removes the dom.webcomponents.shadowdom.enabled pref and all its
references, including the following functions:
* nsContentUtils::IsShadowDOMEnabled()
* nsIDocument::IsShadowDOMEnabled()
* nsDocument::IsShadowDOMEnabled(JSContext* aCx, JSObject* aGlobal)
* nsDocument::IsShadowDOMEnabled(const nsINode* aNode)
* nsTextNode::IsShadowDOMEnabled(JSContext* aCx, JSObject* aObject)
This function is renamed and updated to nsDocument::IsCallerChromeOrAddon():
* nsDocument::IsShadowDOMEnabledAndCallerIsChromeOrAddon(JSContext* aCx, JSObject* aObject)
I didn't change the tests that load Shadow DOM tests in an iframe, in the interest of keeping hg annotation history.
Differential Revision: https://phabricator.services.mozilla.com/D11183
--HG--
extra : moz-landing-system : lando
The patch for Bug 1502857 accidentally removed the pref guard for the Changes panel. This patch reintroduces it.
This patch also addresses Bug 1503925 - Reposition Changes tab in Inspector sidebar to be right after Computed tab.
Differential Revision: https://phabricator.services.mozilla.com/D11802
--HG--
extra : moz-landing-system : lando
Depends on D11640
Leftover from the previous bug that introduced the testing solution for USB runtimes.
Differential Revision: https://phabricator.services.mozilla.com/D11641
--HG--
extra : moz-landing-system : lando
This patch removes the following functions:
* nsContentUtils::IsCustomElementsEnabled()
* CustomElementRegistry::IsCustomElementEnabled(JSContext* aCx, JSObject* aObject)
* CustomElementRegistry::IsCustomElementEnabled(nsIDocument* aDoc)
and all references of the pref.
Depends on D11183
Differential Revision: https://phabricator.services.mozilla.com/D11249
--HG--
extra : moz-landing-system : lando
This patch removes the dom.webcomponents.shadowdom.enabled pref and all its
references, including the following functions:
* nsContentUtils::IsShadowDOMEnabled()
* nsIDocument::IsShadowDOMEnabled()
* nsDocument::IsShadowDOMEnabled(JSContext* aCx, JSObject* aGlobal)
* nsDocument::IsShadowDOMEnabled(const nsINode* aNode)
* nsTextNode::IsShadowDOMEnabled(JSContext* aCx, JSObject* aObject)
This function is renamed and updated to nsDocument::IsCallerChromeOrAddon():
* nsDocument::IsShadowDOMEnabledAndCallerIsChromeOrAddon(JSContext* aCx, JSObject* aObject)
I didn't change the tests that load Shadow DOM tests in an iframe, in the interest of keeping hg annotation history.
Differential Revision: https://phabricator.services.mozilla.com/D11183
--HG--
extra : moz-landing-system : lando
Add a new themes/images/arrow.svg icon (keeping themes/images/devtools-components/arrow.svg
for now because it's used in the debugger and reps) for theme-twisty, Console, etc.
Update twisty colors to be slightly more contrasted.
Differential Revision: https://phabricator.services.mozilla.com/D11657
--HG--
extra : moz-landing-system : lando
Depends on D11209
We need to take care when deleting a declaration. This means shifting the indexes of declarations which follow it in the CSS rule. To do this, we iterate over all tracked added/removed declarations and make sure to decrement their index if it is larger than the index of the deleted one.
The Rule view and specialized editors do not support inserting declarations at any other position other than at the end of the existing declarations list. For now, it is safe to assume all newly added declarations will not shift any tracked indexes. But we will need to handle this for other use cases, like the Style Editor or manual editing of element style attributes.
MozReview-Commit-ID: InrNbsNsqz6
Differential Revision: https://phabricator.services.mozilla.com/D11318
--HG--
extra : moz-landing-system : lando
Depends on D11208
Updates the reducer from considering the property of a declaration as a unique key to using the declaration's index within its rule. This enables tracking changes to declarations with the same property name and even duplicate declarations.
The change object incoming to the reducer is always expected to have an array of declarations, even when changing a single declaration. This provides interoperability with whole rule changes (add, remove, selector rename).
To aggregate changes, the reducer attempts to see if there's a matching declaration in its add/remove array and operates on that match. If the declaration has no previous changes, it gets put as-is in the corresponding array.
The React component also updates slightly to take into account the change from objects with key/value pairs to arrays with objects.
Differential Revision: https://phabricator.services.mozilla.com/D11209
--HG--
extra : moz-landing-system : lando
By adding a min-width to the grid items used to display things in the flex outline, we make
sure they each have at least some room to be visible.
Even if that means the outline isn't a perfect 1:1 mapping of what the item actually is.
I also made 2 other minor fixes to the outline:
- using display:grid on the point labels makes sure they fit nicely where they are supposed
to and the little border drawn next to them to indicate their position doesn't stick out
- I removed a specific override for display the combined final-basis point in column mode
that was making the border for that point show on the incorrect side
Differential Revision: https://phabricator.services.mozilla.com/D11747
--HG--
extra : moz-landing-system : lando
The component is wrapping the `Frames` component from the debugger
in order to have access to frames grouping.
It also handles sourcemaps, since the debugger component
does not by itself.
Tests are added to ensure the component behaves as expected.
Depends on D11602
Differential Revision: https://phabricator.services.mozilla.com/D11603
--HG--
extra : moz-landing-system : lando
This will allow the "copy message" context menu
entry to work as expected for console messages
with a stacktrace (exception, error message, console.trace, …)
Differential Revision: https://phabricator.services.mozilla.com/D11602
--HG--
extra : moz-landing-system : lando