Commit Graph

10643 Commits

Author SHA1 Message Date
Alexandre Poirot
1578b6da37 Bug 1506549 - Return target fronts out of RootFront.getProcess and getMainProcess. r=yulia
MozReview-Commit-ID: EGWYEmAkbtr

Depends on D11693

Differential Revision: https://phabricator.services.mozilla.com/D11622

--HG--
extra : moz-landing-system : lando
2018-11-15 10:22:49 +00:00
Alexandre Poirot
bf45800c90 Bug 1506549 - Either pass a front or a form to Target constructor. r=yulia
MozReview-Commit-ID: BWsvAcWthnF

Differential Revision: https://phabricator.services.mozilla.com/D11693

--HG--
extra : moz-landing-system : lando
2018-11-15 10:22:47 +00:00
Razvan Caliman
09f776c6bd Bug 1485324 - (Part 3) Remove obsolete font on element no longer used in Fonts panel; r=gl
Depends on D11506
Removes the `fonts` field from the Redux slice previously used by the FontOverview component
in the Font Inspector version of the Fonts panel. This field is duplicated with the `fonts`
used by the Font Editor. The telemetry can use that one instead.

Refactors the update() method which updates the Redux slice for the FontOverview component.
In time, the update() and refreshFontEditor() method will merge. So will the Redux slices:
`fontEditor` and `fonts` in order to save a duplicate call to the server for `allFonts`.

Differential Revision: https://phabricator.services.mozilla.com/D11507

--HG--
extra : moz-landing-system : lando
2018-11-14 16:33:09 +00:00
Razvan Caliman
7aee2429e1 Bug 1485324 - (Part 2) Remove obsolete subset of fonts not used on current element; r=gl
Depends on D11505
The `otherFonts` field in the Redux store slice for Fonts was used by the old Font Inspector to differentiate
between fonts on the element and fonts elsewhere on the page. This is no longer used with the Font Editor.

Differential Revision: https://phabricator.services.mozilla.com/D11506

--HG--
extra : moz-landing-system : lando
2018-11-13 18:55:34 +00:00
Razvan Caliman
d5f2881bd2 Bug 1485324 - (Part 1) Remove pref for Font Editor and obsolete conditionals; r=gl
This patch removes the `devtools.inspector.fonteditor.enabled` pref and all its uses in the Fonts panel.
Obsolete actions for the case when the pref was off are also removed. This is mostly old Font Inspector code.

One test is temporarily disabled because it tests the old Font Inspector. It will be removed along with other
pieces on the next part of this commit series.

Differential Revision: https://phabricator.services.mozilla.com/D11505

--HG--
extra : moz-landing-system : lando
2018-11-13 18:55:30 +00:00
Razvan Caliman
b476025c74 Bug 1503595 - Add empty state for Changes panel; r=gl
Design spec: https://mozilla.invisionapp.com/share/6MLNVPYGR97#/screens

- add localization file
- add strings to show when no CSS changes are available to show
- conditionally show empty state message or diff of changes in React component

MozReview-Commit-ID: 8xYJmg0yGAM

Differential Revision: https://phabricator.services.mozilla.com/D11468

--HG--
extra : moz-landing-system : lando
2018-11-15 12:18:45 +00:00
Nicolas Chevobbe
78252467c2 Bug 1216632 - Make autocompletion work on $_ and $0; r=bgrins.
To make $0 autocompletion work, we need to pass the current
selectedNode actor from the frontend, so we can retrieve the
object reference later.
For $_, we need the webconsole actor reference to be able
to retrieve the last input result.
Since the list of parameters of JsPropertyProviders was
getting a bit long, we transform them in an object so it's
more legible on the consumer side.
Mochitests are added for both helpers to ensure this work
as expected.

Differential Revision: https://phabricator.services.mozilla.com/D11866

--HG--
extra : moz-landing-system : lando
2018-11-15 09:49:14 +00:00
Julian Descottes
99e9b458c0 Bug 1504355 - Do not return inlineTextChild for shadow hosts in inspector walker;r=ladybenko
Differential Revision: https://phabricator.services.mozilla.com/D11742

--HG--
extra : moz-landing-system : lando
2018-11-15 10:46:06 +00:00
Julian Descottes
a4c664d70b Bug 1503914 - Add mochitest to check that USB runtimes are not disconnected on refresh;r=daisuke
Depends on D11798

Differential Revision: https://phabricator.services.mozilla.com/D11799

--HG--
extra : moz-landing-system : lando
2018-11-14 03:57:38 +00:00
Julian Descottes
2e04bdefaa Bug 1503914 - Stop disconnecting all devices when clicking on Refresh Devices;r=daisuke
Depends on D11663

Differential Revision: https://phabricator.services.mozilla.com/D11798

--HG--
extra : moz-landing-system : lando
2018-11-14 03:44:00 +00:00
Julian Descottes
c0588f8311 Bug 1506581 - Add mochitest to test updates of the addon list for USB runtimes;r=daisuke
Depends on D11651, Depends on D11643

Differential Revision: https://phabricator.services.mozilla.com/D11663

--HG--
extra : moz-landing-system : lando
2018-11-13 18:13:35 +00:00
Julian Descottes
569e17be39 Bug 1506581 - Listen to addons list changes on DevTools client instead of AddonManager;r=daisuke
Depends on D11644

Differential Revision: https://phabricator.services.mozilla.com/D11651

--HG--
extra : moz-landing-system : lando
2018-11-13 06:46:41 +00:00
Timothy Guan-tin Chien
af2973ef61 Bug 1503019 - Part II, Remove dom.webcomponents.customelements.enabled pref r=smaug
This patch removes the following functions:

* nsContentUtils::IsCustomElementsEnabled()
* CustomElementRegistry::IsCustomElementEnabled(JSContext* aCx, JSObject* aObject)
* CustomElementRegistry::IsCustomElementEnabled(nsIDocument* aDoc)

and all references of the pref.

Depends on D11183

Differential Revision: https://phabricator.services.mozilla.com/D11249

--HG--
extra : moz-landing-system : lando
2018-11-15 06:52:01 +00:00
Timothy Guan-tin Chien
2b5881e46b Bug 1503019 - Part I, Remove dom.webcomponents.shadowdom.enabled r=smaug
This patch removes the dom.webcomponents.shadowdom.enabled pref and all its
references, including the following functions:

* nsContentUtils::IsShadowDOMEnabled()
* nsIDocument::IsShadowDOMEnabled()
* nsDocument::IsShadowDOMEnabled(JSContext* aCx, JSObject* aGlobal)
* nsDocument::IsShadowDOMEnabled(const nsINode* aNode)
* nsTextNode::IsShadowDOMEnabled(JSContext* aCx, JSObject* aObject)

This function is renamed and updated to nsDocument::IsCallerChromeOrAddon():

* nsDocument::IsShadowDOMEnabledAndCallerIsChromeOrAddon(JSContext* aCx, JSObject* aObject)

I didn't change the tests that load Shadow DOM tests in an iframe, in the interest of keeping hg annotation history.

Differential Revision: https://phabricator.services.mozilla.com/D11183

--HG--
extra : moz-landing-system : lando
2018-11-15 06:51:07 +00:00
Andreea Pavel
d51566f085 Backed out 2 changesets (bug 1503019) for failing crashtests at dom/base/crashtests/1505811.html on a CLOSED TREE
Backed out changeset 06b12fd41ff1 (bug 1503019)
Backed out changeset 7b845eac9dd7 (bug 1503019)
2018-11-15 01:52:30 +02:00
Yura Zenevich
e7d364f6ea Bug 1507241 - fixing svg icon for Learn More icon. r=gl
MozReview-Commit-ID: 6MPdICcrQ3C

Differential Revision: https://phabricator.services.mozilla.com/D11918

--HG--
extra : moz-landing-system : lando
2018-11-14 19:14:51 +00:00
Andreea Pavel
9cabbb0b47 Merge mozilla-central to autoland. a=merge on a CLOSED TREE 2018-11-15 00:35:07 +02:00
Razvan Maries
6c55ab0f9e Merge mozilla-inbound to mozilla-central a=merge 2018-11-15 00:16:46 +02:00
Andreea Pavel
b1857361c4 Backed out 5 changesets (bug 1506549) for failing devtools at devtools/client/aboutdebugging/test/browser_service_workers_status.js on a CLOSED TREE
Backed out changeset 6be66dea928c (bug 1506549)
Backed out changeset da0d76d0e8fc (bug 1506549)
Backed out changeset 490eeba8f9f7 (bug 1506549)
Backed out changeset 97554f465eca (bug 1506549)
Backed out changeset 4f259de6cce0 (bug 1506549)
2018-11-14 21:46:07 +02:00
Julian Descottes
0b39aac101 Bug 1495381 - Show Manifest URL for addon target only with This Firefox;r=daisuke
Depends on D11643

Differential Revision: https://phabricator.services.mozilla.com/D11666

--HG--
extra : moz-landing-system : lando
2018-11-14 17:15:18 +00:00
Alexandre Poirot
c5b46b077f Bug 1506549 - Return target fronts out of RootFront.getProcess and getMainProcess. r=yulia
MozReview-Commit-ID: EGWYEmAkbtr

Depends on D11693

Differential Revision: https://phabricator.services.mozilla.com/D11622

--HG--
extra : moz-landing-system : lando
2018-11-14 15:48:16 +00:00
Alexandre Poirot
d4b4263a27 Bug 1506549 - Either pass a front or a form to Target constructor. r=yulia
MozReview-Commit-ID: BWsvAcWthnF

Differential Revision: https://phabricator.services.mozilla.com/D11693

--HG--
extra : moz-landing-system : lando
2018-11-14 15:48:14 +00:00
Julian Descottes
0cedb74d8c Bug 1507071 - Explicitly uninstall valence and adbhelper when starting aboutdebugging and webide;r=ochameau
Depends on D11862

Differential Revision: https://phabricator.services.mozilla.com/D11890

--HG--
extra : moz-landing-system : lando
2018-11-14 15:33:01 +00:00
Coroiu Cristina
63146aea67 Merge mozilla-central to autoland a=merge 2018-11-14 15:21:19 +02:00
Sebastian Hengst
22537c7687 Bug 1506516 - Remove now unused arrow.svg after debugger dropped it in Bug 1506688: Also remove it from jar.mn. a=bustage-fix 2018-11-14 14:39:15 +02:00
Sebastian Hengst
efebafca9e Bug 1506516 - Remove now unused arrow.svg after debugger dropped it in bug 1506688. a=devtools-fix 2018-11-14 14:21:47 +02:00
Coroiu Cristina
d850d799a0 Merge inbound to mozilla-central a=merge 2018-11-14 11:51:31 +02:00
Razvan Caliman
d1e6152b99 Bug 1506916 - Remove obsolete ChangesManager; r=bradwerth
The ChangesManager has been made obsolete by the use of the Changes front.

Differential Revision: https://phabricator.services.mozilla.com/D11801

--HG--
extra : moz-landing-system : lando
2018-11-13 21:27:20 +00:00
Razvan Caliman
23c86f45c1 Bug 1506903 - Show Changes tab only when pref is on; r=pbro
The patch for Bug 1502857 accidentally removed the pref guard for the Changes panel. This patch reintroduces it.

This patch also addresses Bug 1503925 - Reposition Changes tab in Inspector sidebar to be right after Computed tab.

Differential Revision: https://phabricator.services.mozilla.com/D11802

--HG--
extra : moz-landing-system : lando
2018-11-14 05:41:18 +00:00
Paolo Amadini
f6b106efb2 Bug 1496827 - Remove the "notification" binding. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D11650

--HG--
rename : browser/components/customizableui/content/.eslintrc.js => browser/components/translation/content/.eslintrc.js
rename : browser/components/translation/jar.mn => browser/components/translation/content/jar.mn
rename : browser/components/translation/microsoft-translator-attribution.png => browser/components/translation/content/microsoft-translator-attribution.png
rename : browser/components/customizableui/content/moz.build => browser/components/translation/content/moz.build
rename : browser/components/translation/translation-infobar.xml => browser/components/translation/content/translation-notification.js
extra : rebase_source : 598396d2da96b04782413946976f7bb9fb6be75f
2018-11-13 12:56:42 +00:00
Julian Descottes
e075607926 Bug 1495381 - Create debug-target-pane test for USB runtimes;r=daisuke
Depends on D11642

Differential Revision: https://phabricator.services.mozilla.com/D11643

--HG--
extra : moz-landing-system : lando
2018-11-13 06:43:39 +00:00
Julian Descottes
400743a0b8 Bug 1495381 - Create a UsbMocks helper to simplify USB tests;r=daisuke,ladybenko
Depends on D11641

This adds a wrapper that aims to simplify USB tests.

Differential Revision: https://phabricator.services.mozilla.com/D11642

--HG--
extra : moz-landing-system : lando
2018-11-14 16:30:06 +00:00
Julian Descottes
07ceb3fa69 Bug 1495381 - Fix USB runtime test and client-wrapper mock;r=daisuke
Depends on D11640

Leftover from the previous bug that introduced the testing solution for USB runtimes.

Differential Revision: https://phabricator.services.mozilla.com/D11641

--HG--
extra : moz-landing-system : lando
2018-11-13 04:56:10 +00:00
Julian Descottes
b269dcc59a Bug 1495381 - Enable extension debugging for USB devices;r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D11640

--HG--
extra : moz-landing-system : lando
2018-11-13 06:57:25 +00:00
Timothy Guan-tin Chien
c69315234b Bug 1503019 - Part II, Remove dom.webcomponents.customelements.enabled pref r=smaug
This patch removes the following functions:

* nsContentUtils::IsCustomElementsEnabled()
* CustomElementRegistry::IsCustomElementEnabled(JSContext* aCx, JSObject* aObject)
* CustomElementRegistry::IsCustomElementEnabled(nsIDocument* aDoc)

and all references of the pref.

Depends on D11183

Differential Revision: https://phabricator.services.mozilla.com/D11249

--HG--
extra : moz-landing-system : lando
2018-11-14 19:37:42 +00:00
Timothy Guan-tin Chien
c0cc4f74e7 Bug 1503019 - Part I, Remove dom.webcomponents.shadowdom.enabled r=smaug
This patch removes the dom.webcomponents.shadowdom.enabled pref and all its
references, including the following functions:

* nsContentUtils::IsShadowDOMEnabled()
* nsIDocument::IsShadowDOMEnabled()
* nsDocument::IsShadowDOMEnabled(JSContext* aCx, JSObject* aGlobal)
* nsDocument::IsShadowDOMEnabled(const nsINode* aNode)
* nsTextNode::IsShadowDOMEnabled(JSContext* aCx, JSObject* aObject)

This function is renamed and updated to nsDocument::IsCallerChromeOrAddon():

* nsDocument::IsShadowDOMEnabledAndCallerIsChromeOrAddon(JSContext* aCx, JSObject* aObject)

I didn't change the tests that load Shadow DOM tests in an iframe, in the interest of keeping hg annotation history.

Differential Revision: https://phabricator.services.mozilla.com/D11183

--HG--
extra : moz-landing-system : lando
2018-11-14 19:34:52 +00:00
Micah Tigley
4a3e26848d Bug 1114936 - Add a context menu item to copy a stylesheet's URL in the Style Editor. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D11419

--HG--
extra : moz-landing-system : lando
2018-11-14 01:55:02 +00:00
Gurzau Raul
dcee77ca0f Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-11-13 23:49:10 +02:00
Alexandre Poirot
a8d8b5dffc Bug 1506545 - Instantiate Target for ContentProcessTargetActor via its front. r=yulia
MozReview-Commit-ID: EE4d0YULRBU

Depends on D11614

Differential Revision: https://phabricator.services.mozilla.com/D11615

--HG--
extra : moz-landing-system : lando
2018-11-13 20:39:58 +00:00
Jason Laster
43ed289025 Bug 1506688 - Update Debugger Frontend v101. r=dwalsh 2018-11-12 13:07:00 +02:00
lenpel
4d50a6165d Bug 1503554 - Network header panel now has 1 vertical scrollbar for entire area; r=Honza
--HG--
extra : histedit_source : 4900984e39b977eb768a3b313291c365e173e687
2018-11-12 16:25:04 +01:00
Florens Verschelde
cf6161a5e9 Bug 1506516 - Update twisty SVG icon for crisp rendering at 8px; r=gl
Add a new themes/images/arrow.svg icon (keeping themes/images/devtools-components/arrow.svg
for now because it's used in the debugger and reps) for theme-twisty, Console, etc.
Update twisty colors to be slightly more contrasted.

Differential Revision: https://phabricator.services.mozilla.com/D11657

--HG--
extra : moz-landing-system : lando
2018-11-13 15:24:24 +00:00
Razvan Caliman
bb53752bc3 Bug 1500947 - (Part 3) Update indices of tracked declarations when one is removed; r=pbro
Depends on D11209

We need to take care when deleting a declaration. This means shifting the indexes of declarations which follow it in the CSS rule. To do this, we iterate over all tracked added/removed declarations and make sure to decrement their index if it is larger than the index of the deleted one.

The Rule view and specialized editors do not support inserting declarations at any other position other than at the end of the existing declarations list. For now, it is safe to assume all newly added declarations will not shift any tracked indexes. But we will need to handle this for other use cases, like the Style Editor or manual editing of element style attributes.

MozReview-Commit-ID: InrNbsNsqz6

Differential Revision: https://phabricator.services.mozilla.com/D11318

--HG--
extra : moz-landing-system : lando
2018-11-13 09:00:48 +00:00
Razvan Caliman
1eb3c8fc37 Bug 1500947 - (Part 2) Update track changes reducer to account for declaration position; r=pbro
Depends on D11208

Updates the reducer from considering the property of a declaration as a unique key to using the declaration's index within its rule.  This enables tracking changes to declarations with the same property name and even duplicate declarations.

The change object incoming to the reducer is always expected to have an array of declarations, even when changing a single declaration. This provides interoperability with whole rule changes (add, remove, selector rename).

To aggregate changes, the reducer attempts to see if there's a matching declaration in its add/remove array and operates on that match. If the declaration has no previous changes, it gets put as-is in the corresponding array.

The React component also updates slightly to take into account the change from objects with key/value pairs to arrays with objects.

Differential Revision: https://phabricator.services.mozilla.com/D11209

--HG--
extra : moz-landing-system : lando
2018-11-13 12:33:27 +00:00
Patrick Brosset
7243c540c0 Bug 1497179 - Make sure things displayed in the flex sizing outline have enough room; r=mtigley
By adding a min-width to the grid items used to display things in the flex outline, we make
sure they each have at least some room to be visible.
Even if that means the outline isn't a perfect 1:1 mapping of what the item actually is.

I also made 2 other minor fixes to the outline:
- using display:grid on the point labels makes sure they fit nicely where they are supposed
  to and the little border drawn next to them to indicate their position doesn't stick out
- I removed a specific override for display the combined final-basis point in column mode
  that was making the border for that point show on the incorrect side

Differential Revision: https://phabricator.services.mozilla.com/D11747

--HG--
extra : moz-landing-system : lando
2018-11-13 15:09:27 +00:00
Dão Gottwald
d2ef203a7b Bug 1506858 - Fix about:debugging Debug link color. r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D11770

--HG--
extra : moz-landing-system : lando
2018-11-13 15:09:55 +00:00
Alexandre Poirot
fb3dcac40b Bug 1498280 - Introduce RootClient.getMainProcess to fetch ParentProcessTargetActor. r=yulia
MozReview-Commit-ID: E9OiwqDwNk7

Differential Revision: https://phabricator.services.mozilla.com/D11758

--HG--
extra : moz-landing-system : lando
2018-11-13 14:07:36 +00:00
Nicolas Chevobbe
a406663013 Bug 1390768 - Use new SmartTrace component in webconsole; r=Honza.
Depends on D11603

Differential Revision: https://phabricator.services.mozilla.com/D11604

--HG--
extra : moz-landing-system : lando
2018-11-12 15:42:40 +00:00
Nicolas Chevobbe
61a9fac112 Bug 1390768 - Create a new React component to render stacktraces; r=Honza.
The component is wrapping the `Frames` component from the debugger
in order to have access to frames grouping.
It also handles sourcemaps, since the debugger component
does not by itself.
Tests are added to ensure the component behaves as expected.

Depends on D11602

Differential Revision: https://phabricator.services.mozilla.com/D11603

--HG--
extra : moz-landing-system : lando
2018-11-12 15:42:06 +00:00
Nicolas Chevobbe
606ab53809 Bug 1390768 - Insert tab and new line chars in Frame component; r=Honza.
This will allow the "copy message" context menu
entry to work as expected for console messages
with a stacktrace (exception, error message, console.trace, …)

Differential Revision: https://phabricator.services.mozilla.com/D11602

--HG--
extra : moz-landing-system : lando
2018-11-12 15:41:32 +00:00