Commit Graph

2800 Commits

Author SHA1 Message Date
Byron Campen [:bwc]
777bf8b996 Bug 1455647 - Part 4: Make a place to live for context about media packets, to fix packet dump hooks. r+drno r=drno
MozReview-Commit-ID: 1HMF93mLa7r

--HG--
rename : media/mtransport/transportlayersrtp.cpp => media/webrtc/signaling/src/mediapipeline/TransportLayerPacketDumper.cpp
rename : media/mtransport/transportlayersrtp.h => media/webrtc/signaling/src/mediapipeline/TransportLayerPacketDumper.h
extra : rebase_source : 062814836325b69da17e8f592774f006e29905ad
2018-05-09 17:13:35 -05:00
Byron Campen [:bwc]
148a322296 Bug 1455647 - Part 3: Move SRTP into a TransportLayer. r=drno
MozReview-Commit-ID: LWZFPVDYZKb

--HG--
rename : media/webrtc/signaling/src/mediapipeline/SrtpFlow.cpp => media/mtransport/SrtpFlow.cpp
rename : media/webrtc/signaling/src/mediapipeline/SrtpFlow.h => media/mtransport/SrtpFlow.h
extra : rebase_source : 16e1e38c0c6f9153375735b7cb93a8286364df5f
2018-04-23 13:14:30 -05:00
Byron Campen [:bwc]
ab2913f71d Bug 1455647 - Part 2: Allow TransportLayers to be arranged in trees. r=drno
MozReview-Commit-ID: BQgNbCsmkke

--HG--
extra : rebase_source : f21dbdd6f5477786f200a3336240d724aa8cc9b8
2018-04-27 16:57:28 -05:00
Byron Campen [:bwc]
cb8df81f4c Bug 1455647 - Part 1: Simplify TransportFlow. r+drno r=drno
MozReview-Commit-ID: 1jJuln4WAw9

--HG--
extra : rebase_source : e5d9cba95e7e79815e9842edac2fc5eec54aac06
2018-04-27 12:14:40 -05:00
Nils Ohlmeier [:drno]
e4164ef1b0 Bug 1467938 - Fix out-of-bounds memory access in WebRTC VP9 Missing Frame Processing. r=ng
--HG--
extra : histedit_source : f18e4e92f3cdb17b80d092b13dc370386119d437%2C06a923f89cefae172e29d0af18800c401394f940
2018-06-08 19:49:40 -07:00
Johannes Willbold
73c1f3e815 Bug 1467502: Merged Rsdparser changes from github to mozilla central. r=drno
Merged Rsdparser changes from github to mozilla central.
This includes:  Syntax fixes for older rust versions
		The TransportCC parameter for rtcp-fb
		Serialization marcos and code

MozReview-Commit-ID: JqYttvTx2QS

--HG--
extra : rebase_source : 4f0c9e374fcdbd01d729cda2ddbfe5c67bf6cbc9
2018-06-08 09:27:34 -07:00
Johannes Willbold
11f081e25f Bug 1438289: Implemented RsdparsaSdpMediaSection::AddCodec and ::ClearCodecs. r=dminor
Implemented RsdparsaSdpMediaSection::ClearCodecs and RsdparsaSdpMediaSection::AddCodec
Added sdp_media_clear_codecs
Added corresponding C++/Rust glue code
Added rust trait to convert StringView to rust std::String
Added testcase CheckAddCodec and CheckClearCodec

MozReview-Commit-ID: 5pxl8hR9iz2

--HG--
extra : rebase_source : f075c80b1723c794873fb53a77471820ed34569f
2018-06-04 17:23:42 -07:00
Johannes Willbold
50ef419773 Bug 1432934: Added sanity check for recvonly attribute. r=bwc
Added a sanity check, that checks for recvonly and whether simulcast defines send options

MozReview-Commit-ID: Hi5U9ZZVKY8

--HG--
extra : rebase_source : 67aa4d6cea6ad7d3956ce606c529e6023e9e5382
2018-06-04 14:07:28 -07:00
Johannes Willbold
ef7cd48646 Bug 1432936: Added sanity check for sendonly attribute. r=bwc
Moved RustSdpAttributeType and renamaed it to SdpAttributeType
Replaced the has_extmap_attribute functions by a generic has_attribute function
Added a sanity check, that checks for sendonly and if simulcast defines receive options

MozReview-Commit-ID: DXAEVu0SRap

--HG--
extra : rebase_source : c5732414f6e199c1e6a85d7d47921ca6ee601550
2018-06-04 10:05:27 -07:00
Johannes Willbold
a126aacfe7 Bug 1433093: Implemented RsdparsaSdpMediaSection::SetPort. r=dminor
Add C++/Rust glue code
Added set_port function SdpMedia
Added unit test: CheckSetPort

MozReview-Commit-ID: 6pbbuSxzhqM

--HG--
extra : rebase_source : 8695de52970ff8fafa3f9b92a4e62217da4320ac
2018-06-04 16:01:43 -07:00
Byron Campen [:bwc]
39ab428ca2 Bug 1466175: Check if TransceiverImpl has been shut down in SyncWithJS. r=mjf
MozReview-Commit-ID: 9FaUEKdr9jn

--HG--
extra : rebase_source : c6a4e75b75835637288b765f1f45da1a88597d0d
2018-06-05 12:33:47 -05:00
Miko Mynttinen
4c85ef17cc Bug 1465060 - Part 1: Fix warnings for std::move() use r=froydnj
MozReview-Commit-ID: HpdFXqQdIOO

--HG--
extra : rebase_source : 1e7eea4f2d4ec16ec0c559a8afb26976ddbf4d07
2018-06-01 17:59:07 +02:00
arthur.iakab
7e765f798b Backed out 2 changesets (bug 1465060) for build bustages on security/sandbox/linux/reporter/SandboxReporter.cpp
Backed out changeset 7c8905b6b226 (bug 1465060)
Backed out changeset 10446073eca8 (bug 1465060)
2018-06-03 19:25:41 +03:00
Miko Mynttinen
8d9dc85cd4 Bug 1465060 - Part 1: Fix warnings for std::move() use r=froydnj
MozReview-Commit-ID: HpdFXqQdIOO

--HG--
extra : rebase_source : 619d0e0ff63a2453c80f0c4d9beb906d43fa9b01
2018-06-01 17:59:07 +02:00
Mike Hommey
cf60ab0a62 Bug 1466054 - Run mach build-backend -b GnMozbuildWriter. r=froydnj
This refreshes the gn-generated moz.builds with the change from previous
commit. Somehow, this does unrelated changes, there must be something
funky in the gn-moz.build-generator.

--HG--
extra : rebase_source : 7e1a9d75f7a80c0981b2534e4959ada6c611bae2
2018-06-01 17:22:28 +09:00
Csoregi Natalia
468205953d Merge inbound to mozilla-central. a=merge 2018-06-02 01:01:33 +03:00
Cosmin Sabou
1bc774a842 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-06-01 12:44:57 +03:00
Emilio Cobos Álvarez
fffb25b74f Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
This was done automatically replacing:

  s/mozilla::Move/std::move/
  s/ Move(/ std::move(/
  s/(Move(/(std::move(/

Removing the 'using mozilla::Move;' lines.

And then with a few manual fixups, see the bug for the split series..

MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Johannes Willbold
1142310e25 Bug 1432922: Implemented parsing support for rtcpfb-wildcard. r=bwc,dminor
Implemented Rust/C++ glue code for rtcp-fb
Implemented parsing support for rtcpfb-wildcard in rust
Activated c++ unit tests

MozReview-Commit-ID: 5xRSQz7pucZ

--HG--
extra : rebase_source : 97fdfda9134197381d16e0a61dda5357bba9e9da
2018-05-29 16:32:52 -07:00
Jan Keromnes
88a09b356c Bug 1464162 - Make a few vector operations more efficient by reserving size beforehand. r=jya
Summary:
These automated fixes were generated like so:
    ./mach configure --enable-clang-plugin
    ./mach build-backend --backend=CompileDB
    run-clang-tidy-6.0.py -p obj-x86_64-pc-linux-gnu/ -fix -checks=-*,performance-inefficient-vector-operation *

Reviewers: jya

Reviewed By: jya

Subscribers: jya

Bug #: 1464162

Differential Revision: https://phabricator.services.mozilla.com/D1381

--HG--
extra : amend_source : 648dc48989c5af122a33f8d50c98c0f1efcf3874
2018-05-31 14:52:59 +03:00
Jan Beich
b191e43264 Bug 1464680 - Add more WebRTC's gn-configs for BSDs on ARM. r=chmanchester
Based on output from FreeBSD armv7/aarch64.

MozReview-Commit-ID: L7mKj6FIGS5

--HG--
extra : rebase_source : 82729a252c941d4011fc764372fc4943e0a6dd9a
2018-05-27 13:49:33 +00:00
Jan de Mooij
ce3eb7d5c0 Bug 1464374 part 2 - Pass JS::Realm* instead of JSCompartment* to CallSetup. r=bz,luke
The principals are on the realm so we need a realm instead of a compartment. Also adds js::GetNonCCWObjectRealm to get the realm of a non-CCW object.
2018-05-31 11:28:48 +02:00
arthur.iakab
f1046ac67f Merge mozilla-central to inbound 2018-05-31 01:08:35 +03:00
arthur.iakab
fb18cb09bd Merge mozilla inbound to central a=merge 2018-05-31 01:05:10 +03:00
Andrea Marchesini
1273dc5391 Bug 1446933 - Remove 'using namespace mozilla::net' from BackgroundUtils.h, r=qdot 2018-05-30 21:21:17 +02:00
Cameron Kaiser
af336fb099 Bug 1465274 - Add ppc64 to webrtc, regenerate moz.build to remove SSE2 dependency for Linux. r=froydnj
--HG--
extra : source : 3a2d42c1c0d47e11a1efc666cce491f3064469ef
2018-05-27 22:21:07 -07:00
Ryan VanderMeulen
7978cab95f Backed out changeset 3a2d42c1c0d4 for landing with the wrong bug number in the commit message. 2018-05-30 12:44:07 -04:00
Dan Minor
50a3ab6cd4 Bug 1450658 - Should bring window to front when screen-sharing a window; r=pehrsons
This adds a FocusOnSelectedSource method to PCameras and uses it to focus the
selected window while window sharing. We can't just focus the window as soon as
it is shared because we have a live preview in the getUserMedia permissions
prompt which would cause the prompt to lose focus. Instead, this only focuses the
window when the sharing is not done from a chrome context.


MozReview-Commit-ID: 5jre75E3JLi

--HG--
extra : rebase_source : 5f5154fc9fc7590cc02eb25146e5bc20b2243fa3
2018-05-08 15:55:36 -04:00
Christian Holler
570031d38c Bug 1464202 - Improve and centralize libFuzzer flag management. r=froydnj
MozReview-Commit-ID: HFrQDAZWtpo

--HG--
extra : rebase_source : ab1da001d7e9280fbfb37858505f1d0d0caf7d54
2018-05-24 21:11:46 +02:00
Dorel Luca
8e1a0ee1c6 Backed out changeset c13ca75c9bcb (bug 1450658) for Browser-Chrome failures on browser/base/content/test/webrtc/browser_devices_get_user_media_screen.js 2018-05-23 17:07:33 +03:00
Cameron Kaiser
fbc0928677 Bug 1434589: Add ppc64 to webrtc, regenerate moz.build to remove SSE2 dependency for Linux. r=froydnj
--HG--
extra : rebase_source : 7915ec4e623b3e35fcdf84b21a4f8a869044bac8
2018-05-27 22:21:07 -07:00
Dan Minor
40fcbf60d9 Bug 1450658 - Should bring window to front when screen-sharing a window; r=pehrsons
This adds a FocusOnSelectedSource method to PCameras and uses it to focus the
selected window while window sharing. We can't just focus the window as soon as
it is shared because we have a live preview in the getUserMedia permissions
prompt which would cause the prompt to lose focus. Instead, this only focuses the
window when the sharing is not done from a chrome context.


MozReview-Commit-ID: 5jre75E3JLi

--HG--
extra : rebase_source : 97f472f6ed1c5d6bed1af01fb7243a82b2629b03
2018-05-08 15:55:36 -04:00
Mike Hommey
af5ff10060 Bug 1462873 - Link chromium_atomics to webrtc tests. r=froydnj
This redoes bug 1257888 which bug 1393119 undid.

--HG--
extra : rebase_source : 1f2e9225c1548d34d7b0d46a4c754ef594c44ee3
2018-05-19 13:00:56 +09:00
Jim Chen
4053e24872 Bug 1458020 - 3. Set JavaVM when actually using video capture; r=jib
We currently set the Android JavaVM pointer in MediaEngineWebRTC.
However, because of that, we end up setting the pointer in the child
process, even though we really want to set the pointer in the parent
process because that's where the camera will be accessed.

This patch makes us set JavaVM inside VideoEngine itself, where we
actually access the camera in the parent process.

MozReview-Commit-ID: 3TeLiiK2vyh
2018-05-18 10:16:04 -04:00
Randell Jesup
809e9aa0d4 Bug 1346291: update code that accidentally assumed libyuv would define things like int32 r=sotaro,jib 2018-05-09 23:59:16 -04:00
David Major
4ac65c8eef Bug 1459617: Merge upstream webrtc fix for build bustage with clang trunk. r=dminor
https://webrtc.googlesource.com/src/+/bda78c9464f4d0e6ff26b0035624a967269c3b0a
2018-05-09 16:32:31 -04:00
Dan Minor
b9bfaf036c Bug 1456071 - Do not dispatch InsertDTMFTone call to sts thread; r=bwc
This removes the dispatch to the sts thread prior to calling
AudioConduit::InsertDTMFTone. There are assertions in ChannelProxy which
restrict the methods there to running on the main thread, so the current
code crashes immediately when inserting a tone in a debug build. The
inserted DTMF event ends up in a queue, so there is no reason not to just do
the insertion from the main thread.

MozReview-Commit-ID: G8JM9QDLrGF

--HG--
extra : rebase_source : 65168ee08efa5fc1960e35fd5acf4bdde0420b84
2018-04-26 11:36:19 -04:00
Dan Minor
21cb54ff16 Bug 1414829 - Fix VideoConduitTest gtest assertion failures; r=drno
--HG--
extra : rebase_source : 9e881c4a84389f480f2dcdd1c6be714bba2fdc72
2017-11-28 15:58:47 -05:00
Dan Minor
f09687bfc8 Bug 1414829 - Add DeleteStreams to media conduits; r=jesup
--HG--
extra : rebase_source : da8ae4e2cb53e787f1730c2f5efcd65421de300f
2018-01-08 12:40:38 -05:00
Paul Adenot
c6e563b490 Bug 1456115 - Make last_sample_rate_ in neteq_impl.cc atomic. r=dminor
This allows removing locking, and allows other threads to progress without
taking the lock, hence lowering the probability that the lock will be taken for
a long time when we need to pull NeqEQ.

MozReview-Commit-ID: HMO67A0hher

--HG--
extra : rebase_source : aa5c77895eb57d60b61d9a8a5822e53593348830
2018-04-23 11:55:19 +02:00
Paul Adenot
f412eb58ae Bug 1456115 - Re-serialize inbound NotifyPull. r=jya
We made NotifyPull parallel to try to lower the load, and we initially measured
an improvement. However, we did the measurements with a profiler that did an
aggregation of the results. Our results had an high variance, so the mean load
was in fact not meaningful.

More careful measurement performed without doing any aggregation show that,
under load, relying on the fact that the scheduler schedules the tasks on time
is too risky, and that the code is fast enough to not have to parallelize.

MozReview-Commit-ID: CMhSn8Sc0OO

--HG--
extra : rebase_source : cfb41f861089bce9e10446bee81c13f8565ba90e
2018-04-12 14:23:03 +02:00
Paul Adenot
1c6c907315 Bug 1456115 - Remove locking in AcmReceiver::GetAudio. r=dminor
This also causes a lot of dropouts. We don't need to lock here. NetEQ is thread
safe, and its created in the ctor. The rest of the members are made atomic or is
simply never accessed in multiple threads.

MozReview-Commit-ID: 2fRw5ZgxdpQ

--HG--
extra : rebase_source : f2aa082a3e856e873cfcd96ff721ccdc77df3633
2018-04-12 14:36:02 +02:00
Paul Adenot
19325f0f09 Bug 1456115 - Stop locking when getting the sampling rate from the channel in acm_receiver.cc. r=dminor
This accounts for half of our audio dropouts, there is very high contention on
this piece of data.

MozReview-Commit-ID: 2HSfqZHT2MK

--HG--
extra : rebase_source : 10c451ac60563a0f1c14a314f5a12cc45055e20b
2018-04-09 13:52:08 +02:00
Narcis Beleuzu
d6e889b127 Backed out 4 changesets (bug 1456115) for Asan Mochitest filures "AddressSanitizer: stack-overflow /celt/bands.c:1437:4 in quant_all_bands". CLOSED TREE
Backed out changeset 3379d4fc07f6 (bug 1456115)
Backed out changeset 9c77f5b53b56 (bug 1456115)
Backed out changeset e48268ffa4d8 (bug 1456115)
Backed out changeset bffecfd92808 (bug 1456115)
2018-04-24 21:47:07 +03:00
Paul Adenot
a1d88e5fb9 Bug 1456115 - Make last_sample_rate_ in neteq_impl.cc atomic. r=dminor
This allows removing locking, and allows other threads to progress without
taking the lock, hence lowering the probability that the lock will be taken for
a long time when we need to pull NeqEQ.

MozReview-Commit-ID: HMO67A0hher

--HG--
extra : rebase_source : aa5c77895eb57d60b61d9a8a5822e53593348830
2018-04-23 11:55:19 +02:00
Paul Adenot
0640ca7fdb Bug 1456115 - Re-serialize inbound NotifyPull. r=jya
We made NotifyPull parallel to try to lower the load, and we initially measured
an improvement. However, we did the measurements with a profiler that did an
aggregation of the results. Our results had an high variance, so the mean load
was in fact not meaningful.

More careful measurement performed without doing any aggregation show that,
under load, relying on the fact that the scheduler schedules the tasks on time
is too risky, and that the code is fast enough to not have to parallelize.

MozReview-Commit-ID: CMhSn8Sc0OO

--HG--
extra : rebase_source : cfb41f861089bce9e10446bee81c13f8565ba90e
2018-04-12 14:23:03 +02:00
Paul Adenot
2d783a2f32 Bug 1456115 - Remove locking in AcmReceiver::GetAudio. r=dminor
This also causes a lot of dropouts. We don't need to lock here. NetEQ is thread
safe, and its created in the ctor. The rest of the members are made atomic or is
simply never accessed in multiple threads.

MozReview-Commit-ID: 2fRw5ZgxdpQ

--HG--
extra : rebase_source : f2aa082a3e856e873cfcd96ff721ccdc77df3633
2018-04-12 14:36:02 +02:00
Paul Adenot
581308e902 Bug 1456115 - Stop locking when getting the sampling rate from the channel in acm_receiver.cc. r=dminor
This accounts for half of our audio dropouts, there is very high contention on
this piece of data.

MozReview-Commit-ID: 2HSfqZHT2MK

--HG--
extra : rebase_source : 10c451ac60563a0f1c14a314f5a12cc45055e20b
2018-04-09 13:52:08 +02:00
Nils Ohlmeier [:drno]
cf2d709fb0 Bug 1455557: accept new line as RTCP FB NACK terminator. r=bwc
MozReview-Commit-ID: B0KaqRvLqNs

--HG--
extra : rebase_source : 97bca7eb56b1e112fc3ff091e58323ff1d09d43e
2018-04-20 21:52:16 -07:00
Paul Adenot
fbf116232d Bug 1444976 - Trace some initial real-time media stuff. r=pehrsons
MozReview-Commit-ID: 7mmDHVS2t8f

--HG--
extra : rebase_source : ac56722792f99aadd8e359ef9ae4b30f6dc78076
extra : source : 7b9d0ce0b1cb20540d1c5bf4c77596359b5cb73e
2018-04-12 17:51:35 +02:00