Commit Graph

56 Commits

Author SHA1 Message Date
Julian Descottes
9f859ee6b8 Bug 1436303 - Enable mozilla/no-define-cc-etc for some DevTools files;r=ochameau,standard8
MozReview-Commit-ID: IbSt6lAhOYt

--HG--
extra : rebase_source : 61b562240f83da0ec15e584cd0e965466b6be4b1
2018-06-08 16:46:59 +02:00
Mark Banner
fe1b5d201f Bug 1466497 - Enable ESLint rule require-expected-throws-or-rejects for storage/test/unit. r=mak
MozReview-Commit-ID: KZNpShBcfjJ

--HG--
extra : rebase_source : 8e11f26fe9d713bfc17e97f0fb4871bd9f3b0bad
2018-06-01 14:03:20 +01:00
Mark Banner
7fcdf73fc3 Bug 1466497 - Enable ESLint rule require-expected-throws-or-rejects for head_devtools_inspector_sidebar.js. r=jdescottes
MozReview-Commit-ID: LnOPs92HNPK

--HG--
extra : rebase_source : 24c68cfd55b40d942bbaf56217c9f1aec7151769
2018-06-01 12:49:41 +01:00
Mark Banner
087fb7a351 Bug 1465762 - Enable ESLint rule require-expected-throws-or-rejects for toolkit/**/extensions. r=aswan
MozReview-Commit-ID: 5pS6RHs0naW

--HG--
extra : rebase_source : 23704b62cfccef6b43ce08657116398cbfb9beee
2018-05-31 13:45:44 +01:00
Narcis Beleuzu
08e410f7c9 Backed out changeset 6630148c9bea (bug 1465762) for xpcshell failures on test_ext_schemas_async.js. CLOSED TREE 2018-06-01 12:32:24 +03:00
Mark Banner
ba6c2dc836 Bug 1465762 - Enable ESLint rule require-expected-throws-or-rejects for toolkit/**/extensions. r=aswan
MozReview-Commit-ID: 5pS6RHs0naW

--HG--
extra : rebase_source : 1859cf05dc269ef6873e0836f1f855e8ce1e9fed
2018-05-31 13:45:44 +01:00
Mark Banner
dd6cb31203 Bug 1465530 - Enable ESLint rule require-expected-throws-or-rejects for testing/marionette/. r=ato
MozReview-Commit-ID: 2CM4x0vUXbC

--HG--
extra : rebase_source : 8b4fb90744b780c42359de173420e699e6d2dd73
2018-05-30 17:35:12 +01:00
Mark Banner
7b90b63d69 Bug 1465385 - Enable ESLint rule require-expected-throws-or-rejects for browser/. r=MattN
MozReview-Commit-ID: GoVFNM7CFDu

--HG--
extra : rebase_source : f1e9bfdaa1396b2ce27ee499fc547f239ca132a9
2018-05-30 11:50:45 +01:00
Mark Banner
2faa59b5ca Bug 1463673 - Enable ESLint rule require-expected-throws-or-rejects for toolkit/. r=mossop
MozReview-Commit-ID: AWqIwOIZsMa

--HG--
extra : rebase_source : 8e70a0ca689989b2224b334e6d30de0acb3a27f3
2018-05-22 20:52:49 +01:00
Mark Banner
127c1ce9e9 Bug 1463499 - Enable ESLint rule require-expected-throws-or-rejects for services/. r=markh
MozReview-Commit-ID: LBGpRrw3zTx

--HG--
extra : rebase_source : 28353d39dd495114d987df36fd0ea1bd10ede1a3
2018-05-16 19:06:24 +01:00
Mark Banner
f692609ef4 Bug 1461997 - Add an ESLint rule to ensure that Assert.rejects is preceeded by await. r=mossop
MozReview-Commit-ID: kVrHRIi9l6

--HG--
extra : rebase_source : affa22c03c3d0fafc11d6fb62fed272e289802dd
2018-05-16 21:04:13 +01:00
Mark Banner
55d1e986ea Bug 1461997 - Enable ESLint rule mozilla/require-expected-throws-or-rejects for browser/components. r=Gijs
MozReview-Commit-ID: JXqwIyF6v6k

--HG--
extra : rebase_source : 2220610f8facc9096c4427ff543f5fc31e6ce7b0
2018-05-16 20:23:06 +01:00
Mark Banner
0237d1df76 Bug 1461997 - Create a rule to prevent usages of Assert.throws/rejects without an 'expected' argument. r=mossop
MozReview-Commit-ID: 979uJQUjybl

--HG--
extra : rebase_source : 1e0cb11ac28e35391c92a06bbd5894f7fc507baa
2018-04-09 18:54:13 +01:00
Mark Banner
fde1cad4f2 Bug 1461966 - Enable ESLint rule mozilla/use-services for extensions/pref. r=mkaply
MozReview-Commit-ID: 77pSaX70zdJ

--HG--
extra : rebase_source : 5889808b650902f06e0a7d911fd1d23313247217
2018-05-16 14:39:29 +01:00
Mark Banner
a32bc883e7 Bug 1434446 - Enable no-unused-vars for global scope on jsm files in browser/. r=mossop
MozReview-Commit-ID: ERT1Fili25d

--HG--
extra : rebase_source : c62ad4e97fc5da7c59cbb03ba08928f7bbe5be6b
2018-03-01 20:06:06 +00:00
Mark Banner
b78260f4b8 Bug 1439831 - Enable ESLint rule mozilla/use-services for mobile/android. r=nechen
MozReview-Commit-ID: 3MuRD78hMuE

--HG--
extra : rebase_source : 772d31d98af3c5204b4000903a5e5e9fecc9dc52
2018-02-21 08:57:28 +00:00
Florian Quèze
8922be9c58 Bug 1433175 - enable the use-cc-etc eslint rule, r=Standard8. 2018-02-28 18:51:35 +01:00
Mark Banner
2e4db142aa Bug 1440761 - Enable no-unused-vars for global scope on jsm files in toolkit/. r=mossop
MozReview-Commit-ID: 7Okqmw5dBcL

--HG--
extra : rebase_source : 6fff67e5e4bf483e6903a68a713d0b7d6c659d3b
2018-02-23 19:25:59 +00:00
Mark Banner
6afe18b30a Bug 1440379 - Tidy up ESlint no-unused-vars definitions wrt Ci/Cu/Cr/Cc usage for varsIgnorePattern. r=florian
MozReview-Commit-ID: HmliR8iNRDq

--HG--
extra : rebase_source : 483ae0b54b9e781cceac2accdfb2255d725ace6a
2018-02-22 16:55:36 +00:00
Mark Banner
4bc9f77582 Bug 1440718 - Enable no-unused-vars for global scope on jsm files in services/sync/. r=kitcambridge
MozReview-Commit-ID: 77z0qScZw2P

--HG--
extra : rebase_source : a2fa7688e72e225bc54a047c2e46822f13af21f2
2018-02-23 17:05:05 +00:00
Mark Banner
3e6b2c9400 Bug 1440711 - Enable no-unused-vars for global scope on jsm files in accessible/. r=surkov
MozReview-Commit-ID: DMsHpliLTOi

--HG--
extra : rebase_source : 528581974ca2e37e139be1a7ac354ce80eef9464
2018-02-23 16:50:43 +00:00
Mark Banner
01319d9d04 Bug 1437584 - Enable ESLint rule mozilla/use-services for testing/. r=jmaher
MozReview-Commit-ID: DMkgj5UAId4

--HG--
extra : rebase_source : 155f657e68f04850e878535afdb1421933b4a13b
2018-02-12 17:10:00 +00:00
Mark Banner
21e6e270a4 Bug 1438489 - Enable ESLint rule mozilla/use-services for devtools/. r=jdescottes
MozReview-Commit-ID: FZscEA6Q3Kb

--HG--
extra : rebase_source : b1b8699288a3595e52bcff3c7684bfe095f41dd1
2018-02-15 12:00:17 +00:00
Mark Banner
4cd77e3a20 Bug 1436389 - Switch xbl related files to a different method for determining their environment. r=mossop
MozReview-Commit-ID: JLqFrKZykw

--HG--
extra : rebase_source : 34628f4ead954ba9642b3814bb5692a1bebafb39
2018-02-07 16:02:25 +00:00
Mark Banner
54c4111311 Bug 1230369 - Add ESLint rules to disallow defining Cc/Ci etc and to prefer the use of Cc/Ci rather than the Components.* equivalents. r=florian
MozReview-Commit-ID: 9eAgUO3iIJW

--HG--
extra : rebase_source : 3208d5f74477733e4c81206613f74d7c7821ac0d
2018-02-06 22:40:12 +00:00
Mark Banner
3cdde49426 Bug 1421379 - Finish enabling ESLint's mozilla/use-services in browser/. r=mossop
MozReview-Commit-ID: HHhik24haPT

--HG--
extra : rebase_source : 31f44525daf8998bc4eb08ba3b87f473e980581e
2018-02-01 10:48:00 +00:00
Mark Banner
9a2172526a Bug 1434449 - Enable no-unused-vars for the global (as well as local) scope on jsm files, whitelist directories still to be fixed. r=florian.
MozReview-Commit-ID: 3vBWDR3UjGF

--HG--
extra : rebase_source : 61495d14a8d761e71b4072b02e2ca57e77f44059
2018-01-30 22:10:08 +00:00
Mark Banner
d2eba76015 Bug 1429701 - Enable ESLint rule mozilla/use-services for dom/indexedDB. r=bevis
MozReview-Commit-ID: 9OgcN56ziip

--HG--
extra : rebase_source : ca4e88e8bd9bd20888659b095c62c30161279ed0
2018-01-10 17:25:52 +00:00
Mark Banner
e11ad103d3 Bug 1429705 - Enable ESLint rule mozilla/use-services for tools/profiler. r=mstange
MozReview-Commit-ID: elODEiff9w

--HG--
extra : rebase_source : fb25e0a840f21a09759aca04f643aa74e78b1207
2018-01-10 19:16:17 +00:00
Mark Banner
351ae38da6 Bug 1427745 - Enable ESLint rule mozilla/use-services for dom/media. r=jib
MozReview-Commit-ID: 5UfN1TJH6D4

--HG--
extra : rebase_source : 07597f865d3ccf5955f99501e3fedb6adbf47b72
2018-01-03 15:11:03 +00:00
Mark Banner
ec4d7eb2fd Bug 1427754 - Enable ESLint rule mozilla/use-services for accessible/ r=surkov
MozReview-Commit-ID: EJoFyhMfQzv

--HG--
extra : rebase_source : 4df24c322ff9144f9c38d4d8d7aff35ef0f7419d
2018-01-03 15:26:19 +00:00
Mark Banner
770685e15e Bug 1425688 - Enable ESLint rule mozilla/use-services for security/. r=gcp,keeler
MozReview-Commit-ID: 4Kd9L8ExNGl

--HG--
extra : rebase_source : 02a5242629c7b597d7fd4e5e1373781fcbb82905
2017-12-16 13:10:40 -06:00
Cosmin Sabou
6c33dde6ca Backed out 2 changesets (bug 1425688) on request from jorgk for breaking the Certificate Manager r=backout a=backout
Backed out changeset f73324a4d033 (bug 1425688)
Backed out changeset bd2bf7b7fead (bug 1425688)
2017-12-28 15:26:09 +02:00
Mark Banner
bed9b1d6c8 Bug 1425688 - Enable ESLint rule mozilla/use-services for security/. r=gcp,keeler
MozReview-Commit-ID: 4Kd9L8ExNGl

--HG--
extra : rebase_source : d8383ef464e9f0d19c7642a07967f3e2fa56d0dc
2017-12-16 13:10:40 -06:00
Mark Banner
7242ebf417 Bug 1424862 - Enable mozilla/use-services from chrome/. r=mossop
MozReview-Commit-ID: ILZTMzuBAZ1

--HG--
extra : rebase_source : 3fe4420fa4fec5509c8174d4f6b7d636dfcc42ef
2017-12-11 20:29:28 +00:00
Mark Banner
2b0445fe18 Bug 1424879 - Enable mozilla/use-services for xpcom/. r=froydnj
MozReview-Commit-ID: FnQDHG3w6RQ

--HG--
extra : rebase_source : 7b7b16775eaad6022f544f7a65e8d950a3d6fdd0
2017-12-11 20:19:38 +00:00
Mark Banner
499ca20f31 Bug 1421968 - Enable ESLint rule mozilla/use-services by default, but whitelist it for various directories still to be fixed. r=mossop
MozReview-Commit-ID: KOZWr7FiDQZ

--HG--
extra : rebase_source : 92c9bc236c9043f6ce25cc2ba45264918eb2ac15
2017-11-28 19:24:12 +00:00
Mark Banner
c62d0c64f8 Bug 1371293 - Upgrade ESLint to version 4.8.0, configuration changes. r=mossop
MozReview-Commit-ID: 2YHYOLTtqxu

--HG--
extra : rebase_source : 7bbc673bb72d546e1fca63227d54b6607a4ab33e
2017-10-09 10:54:16 +01:00
Mark Banner
0ce286101c Bug 1359011 - Make the mozilla/recommended eslint configuration the default for the whole tree. r=mossop
MozReview-Commit-ID: HtUW43tCli1

--HG--
extra : rebase_source : 6496bc47860d9c1ab522a78e73b41550700021cb
2017-04-25 20:12:21 +01:00
Mark Banner
2bf9485071 Bug 1362947 - Upgrade eslint-plugin-html to 2.0.3 to pick up --fix support. r=jaws
MozReview-Commit-ID: 5fVG7akPnGM

--HG--
extra : rebase_source : e462e84bf8f2ffd893d1fd6b5ea14bbc093168dd
2017-05-08 10:29:47 +01:00
Sebastian Hengst
95a418ca5b Backed out changeset e0f9c56c15f0 (bug 1362947) for linting failures, e.g. at accessible/tests/mochitest/jsat/doc_content_text.html:15. r=backout 2017-05-11 10:15:55 +02:00
Mark Banner
256aeb441c Bug 1362947 - Upgrade eslint-plugin-html to 2.0.3 to pick up --fix support. r=jaws
MozReview-Commit-ID: 5fVG7akPnGM

--HG--
extra : rebase_source : f1b9eeb1b2048b551ee8c0a596e6395d0031cc4d
2017-05-08 10:29:47 +01:00
Frederik Braun
cd1cbcef0f Bug 1359350: Add no-eval rule to eslint config (and whitelist failures in tests) r=standard8
MozReview-Commit-ID: 4nYlX4sSdbF

--HG--
extra : rebase_source : cf610e7d8bf2b8dbd5a0d40c5b835bc6620c3bba
2017-05-08 14:50:50 +02:00
Frederik Braun
777b70a929 Bug 1358050: Add no-implied-eval rule to eslint config r=standard8
MozReview-Commit-ID: KdmpXq2rg1q

--HG--
extra : rebase_source : fc89233a590604e1035be4aebfee9cda894ee07e
2017-04-20 10:33:22 +02:00
Mark Banner
9f564cd9e1 Bug 1352969 - Improve ESLint environment browser-window globals list, and automatically inject it into browser-window scripts. r=mossop
MozReview-Commit-ID: 3lv0K1unAc

--HG--
extra : rebase_source : 4e4ef0f40f377298013dc17ca0f077890d32669c
2017-03-09 17:17:26 +00:00
Florian Quèze
be00c3b9e8 Bug 1345294 - add an eslint rule to reject usage of {get,set}ComplexValue for nsISupportsString and suggest {get,set}StringPref instead, and make it pass, r=Mossop. 2017-03-16 19:26:02 +01:00
Florian Quèze
e2b53c13ce Bug 1344711 - Add an eslint rule to report an error when a get*Pref call is the only instruction in a try block, r=jaws.
--HG--
extra : rebase_source : b98fc9c75089c3eeb2f1317623b08ee9cd4d1541
2017-03-07 15:29:47 +01:00
Florian Quèze
535b5bcde6 Bug 1338585 - Add an eslint rule to require using .ownerGlobal instead of .ownerDocument.defaultView, r=jaws. 2017-02-13 13:01:32 +01:00
Florian Quèze
77bac28360 Bug 1334831 - add an eslint rule to report usage of .parentNode.removeChild when .remove() could be used instead, r=jaws. 2017-01-30 08:10:18 +01:00
Florian Quèze
03d00b4c13 Bug 1331599 - add an eslint rule to reject removeEventListener calls when the once option can be used instead, r=jaws. 2017-01-25 07:03:50 +01:00