Commit Graph

3447 Commits

Author SHA1 Message Date
Andrew McCreight
5446225d17 Bug 1201271 - Warn about unused results for more methods of nsTArray. r=froydnj
This leaves alone the AppendElement methods.
2015-09-15 15:30:44 -07:00
Shu-yu Guo
64db2267cf Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Bradley Garlick
e838fa9135 Bug 416611 - Changed BookmarkHTMLUtils.jsm to import bookmark tags from HTML document. r=mak 2015-09-14 13:36:27 +05:30
Marco Bonardo
c136532480 Bug 1182046 - undeclared variables in nsLivemarkService.js. r=ttaubert
--HG--
extra : commitid : 7xgBC4cccws
2015-09-07 23:07:22 +02:00
Marco Bonardo
a530c7b60d Bug 1194568 - Renaming live bookmark while adding it renames the wrong one. r=ttaubert
--HG--
extra : commitid : Fom0hKHZmzq
2015-09-02 16:41:10 +02:00
Ryan VanderMeulen
ac8565e1ce Backed out changesets b2c46fdeca8b, 6b768986595f, and 78c891ba5de1 (bug 1089695) for frequent Marionette crashes. 2015-08-31 22:03:20 -04:00
David Rajchenbach-Teller
894ea1194a Bug 1089695 - Fixing wrong dependency in Places shutdown. r=mak
--HG--
extra : transplant_source : %FB%DC%ED%1D%02%9D%CF%AAn%06%A66%C4%A7%07%95%9F%86%28r
2015-08-10 11:07:54 +02:00
Ryan VanderMeulen
0f38752ebc Merge inbound to m-c. a=merge 2015-08-31 15:21:02 -04:00
Mark Hammond
fe93f04c90 Bug 1190131 - have GuidHelper use withConnectionWrapper to work around issues with PlacesUtils.bookmarks.runInBatchMode. r=mak 2015-08-31 12:17:14 +10:00
Yoshi Huang
e6070e9062 Bug 1165272 - Part 2: replace getNoAppCodebasePrincipal. r=bholley 2015-08-18 15:01:42 +08:00
Mark Hammond
5de13ebb49 Bug 1186714 - bookmark backup yields the event loop occasionally to reduce jank. r=mak 2015-08-26 10:43:07 +10:00
Bobby Holley
edfe287f26 Backed out 3 changesets (bug 1165272) for b2g sanity blocker. 2015-08-25 11:16:21 -07:00
Yoshi Huang
de47f4b89f Bug 1165272 - Part 2: Replace getNoAppCodebasePrincipal. r=bholley 2015-08-24 01:18:00 -04:00
Nicholas Nethercote
f44287005f Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium.
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.

--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
2015-08-27 20:44:53 -07:00
Jan de Mooij
d44488d68c Bug 889158 part 1 - Fix chrome and tests to not use arrow functions with arguments. r=Waldo 2015-08-22 13:49:11 +02:00
Marco Bonardo
aa69e0adff Bug 1182572 - Location bar search suggestions should not include things that look like URLs. r=Mossop
--HG--
extra : commitid : 7AK27UlkgJq
2015-08-13 14:54:14 +02:00
Mark Hammond
28d41728d9 Bug 1192692 - ensure PlacesUtils.promiseBookmarksTree() correctly primes the guid cache. r=mak 2015-08-13 17:52:28 +10:00
Drew Willcoxon
5ca042183f Bug 1176437 - Don't show fallback "Search with" result when the awesomebar is empty. r=mak 2015-08-07 15:00:08 -07:00
Carsten "Tomcat" Book
bfa6580a77 merge mozilla-inbound to mozilla-central a=merge 2015-08-07 13:13:06 +02:00
Drew Willcoxon
63591bbd24 Bug 959567 - Change urlbar search suggestions from opt-out to opt-in, add opt-in prompt to urlbar popup. r=mak 2015-08-06 20:13:00 -07:00
Marco Bonardo
ddb1ecd87c Bug 1150678 - Part 1: notify the old value in onItemChanged (only URI changes for now). r=ttaubert
--HG--
extra : commitid : KYeXHLc1S0W
2015-08-05 23:10:11 +02:00
Wes Kocher
c906ee5d44 Backed out 2 changesets (bug 1150678) for xpcshell bustage
Backed out changeset 1c24d237080c (bug 1150678)
Backed out changeset 9f1f1e11ca37 (bug 1150678)
2015-08-05 16:24:58 -07:00
Marco Bonardo
c59f2ffded Bug 1150678 - Part 2: allow to change uri for a single bookmark keyword and remove the old keyword when needed. r=ttaubert
--HG--
extra : commitid : 1nWe1X4t8xb
2015-08-05 23:10:16 +02:00
Marco Bonardo
0aae79f32c Bug 1150678 - Part 1: notify the old value in onItemChanged (only URI changes for now). r=ttaubert
--HG--
extra : commitid : L3Sje2jJyiY
2015-08-05 23:10:11 +02:00
Marco Bonardo
fc4223158d Bug 1187753 - Autocomplete popup displays wrong message when typing only a search keyword. r=adw
--HG--
extra : commitid : 5SWM67W3LKr
2015-08-05 22:04:58 +02:00
Birunthan Mohanathas
7315345693 Bug 1191100 - Remove XPIDL signature comments in .cpp files. r=ehsan
Comment-only so DONTBUILD.
2015-08-04 16:17:36 -07:00
Ryan VanderMeulen
f6bdd4e7a5 Merge m-c to inbound. a=merge 2015-08-06 15:47:49 -04:00
Christoph Kerschbaumer
1c05a94924 Bug 1191107 - Split TYPE_XMLHTTPREQUEST and TYPE_DATAREQUEST for EventSource (r=sicking,ehsan) 2015-08-06 11:17:24 -07:00
Carsten "Tomcat" Book
7d6f90f702 Backed out 2 changesets (bug 1191107, bug 1180273) for causing xpcshell and m-oth testfailures on a CLOSED TREEi IGNORE IDL
Backed out changeset c5f710ed8718 (bug 1191107)
Backed out changeset d98d82f9981b (bug 1180273)
2015-08-06 08:39:05 +02:00
Christoph Kerschbaumer
cb37e46dd2 Bug 1191107 - Split TYPE_XMLHTTPREQUEST and TYPE_DATAREQUEST for EventSource - IGNORE IDL (r=sicking,ehsan) 2015-08-05 12:58:05 -07:00
Andrew McCreight
71ab6cac45 Bug 1189369, part 9 - Use early return in nsMaybeWeakPtr<T>::GetValue(). r=mak 2015-08-04 13:55:01 -07:00
Andrew McCreight
cff130b6b9 Bug 1189369, part 8 - Clean up some minor style issues in nsMaybeWeakPtr.h. r=mak 2015-08-04 13:55:01 -07:00
Andrew McCreight
e01c86d0ab Bug 1189369, part 7 - Use nicer nsTArray functions in nsMaybeWeakPtrArray. r=mak 2015-08-04 13:55:01 -07:00
Andrew McCreight
27043d2398 Bug 1189369, part 6 - Inline AppendWeakElement and RemoveWeakElement. r=mak
This class is only instantiated three times, so it doesn't seem worth
the contortions to save a bit of code.
2015-08-04 13:55:01 -07:00
Andrew McCreight
fe85799ea3 Bug 1189369, part 5 - Use the nice cycle collector macro template for nsNavHistoryResult. r=mak
Also, fix up the CC template so it works.
2015-08-04 13:55:01 -07:00
Andrew McCreight
cec9b2142a Bug 1189369, part 4 - Get rid of some old style QIs from nsMaybeWeakPtrArray. r=mak 2015-08-04 13:55:01 -07:00
Andrew McCreight
27edb194c3 Bug 1189369, part 3 - Inline nsMaybeWeakPtr_base. r=mak
nsMaybePtr<> is only ever instantiated with 3 different classes, so it
doesn't seem like it worth the contortions to save a little code.
2015-08-04 13:55:01 -07:00
Andrew McCreight
058dc9a336 Bug 1189369, part 2 - Don't implicitly convert nsMaybeWeakPtr to an nsCOMPtr. r=mak
This is only used in a few places, and it obscures what is happening.
2015-08-04 13:55:01 -07:00
Andrew McCreight
f197361a7f Bug 1189369, part 1 - Remove trailing whitespace from some nsNavHistory* files. r=mak 2015-08-04 13:55:01 -07:00
Marco Bonardo
19e86a8419 Bug 1172937 - Action row doesn't always update correctly with unified autocomplete. r=adw
Original patch by Felipe Gomes <felipc@gmail.com>

--HG--
extra : commitid : Cen9r3nQixn
2015-07-30 16:54:27 +02:00
Marco Bonardo
f6079ea3fd Bug 1188688 - Frequent "TypeError: this._searchSuggestionController is null" when using the location bar. r=ttaubert
--HG--
extra : commitid : 4GgebUU3vpj
2015-08-03 18:26:28 +02:00
Marco Bonardo
ec86dfbe2f Bug 1092607 - Intermittent failure in test_PlacesUtils_asyncGetBookmarkIds.js, r=ttaubert
--HG--
extra : commitid : AD8l8ohDSiF
2015-08-03 15:00:03 +02:00
Marco Bonardo
9689c3ff22 Backout 85afe1aa3e6f (bug 1092607) for failures in test_PlacesUtils_asyncGetBookmarkIds.js.
--HG--
extra : commitid : 4YFfFFvxeyb
2015-08-03 17:34:07 +02:00
Marco Bonardo
31385d43b8 Bug 1092607 - Intermittent failure in test_PlacesUtils_asyncGetBookmarkIds.js, r=ttaubert
--HG--
extra : commitid : 93mJX5HA3xS
2015-08-03 15:00:03 +02:00
Ryan VanderMeulen
7c486ed4c2 Merge inbound to m-c. a=merge 2015-07-30 16:08:21 -04:00
Ryan VanderMeulen
5a0dad74c7 Backed out changeset 91b6fe481685 (bug 1172937) for test_autocomplete_with_composition_on_input.html failures. 2015-07-30 12:45:03 -04:00
Marco Bonardo
d2d3c3a83b Bug 1172937 - Action row doesn't always update correctly with unified autocomplete. r=adw
Original patch by Felipe Gomes <felipc@gmail.com>

--HG--
extra : commitid : 9zGMBGXYqlm
2015-07-30 16:54:27 +02:00
Andrew McCreight
37f672e11e Bug 1074416 - Don't AddRef or Release nav history result observers during CC traversal. r=smaug
Doing an AddRef or Release of a cycle collected object during CC
traversal can cause leaks. traverseResultObservers does this in two
places. First, it accidentally copies the array that is passed
in. Second, the GetValue() method that is being implicitly called in
the line with |aObservers.ElementAt(i);| does a QI.

This patch fixes the former problem by passing a reference. It fixes
the latter problem by returning the raw underlying pointer held by the
nsMaybeWeakPtrArray, which is what the CC wants anyways, because it
does not care about weak referents.
2015-07-29 20:36:00 -04:00
Marco Bonardo
3e1cc635e6 Bug 1179153 - location bar shows "search with Google" as the default action even when keyword.enabled is false. r=Mossop
--HG--
extra : commitid : JLoFmIM7q0f
2015-07-28 17:51:18 +02:00
Marco Bonardo
9e192ff73a Bug 1184960 - Limit the usable text to get search suggestions. r=Mossop
--HG--
extra : commitid : DgkoyfBbnzA
2015-07-28 10:21:40 +02:00