Commit Graph

2435 Commits

Author SHA1 Message Date
jake%acutex.net
ed69b4acf1 Fix for bugs 55161 and 12819. The activity log now stores only what's changed in multi-value fields.
r= justdave@syndicomm.com
2001-07-20 15:18:30 +00:00
justdave%syndicomm.com
16f7d90c34 Re-fix for bug 77699: the undefined error affected other browsers than just IE5, so work around it for all browsers.
Patch by Stephen Lee <slee@uk.bnsmc.com>
r= afranke@ags.uni-sb.de
2001-07-20 08:25:30 +00:00
timeless%mac.com
f4c8cd4d0b Bugzilla Bug 90704 there is a correct spelling for gobbeldygook and this is not it
r=terry [C=WP, A=OED]
2001-07-16 20:15:03 +00:00
jake%acutex.net
98a3075c9b Correcting the URL for MySQL's web page. Bug 90553.
Patch by Myk Melez <myk@mozilla.org>
2001-07-16 19:50:17 +00:00
justdave%syndicomm.com
eae6e119bd Fixing minor problem caused by the original bug 77473 checkin where an SQL error was being produced if you tried to log in
with an invalid username.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-07-16 19:38:34 +00:00
timeless%mac.com
8d0478157a Bugzilla Bug 90598 spelling and minor syntactic correctness [doeHs]
r=mpt a=terry. [C=WP, A=OED]
2001-07-13 17:45:52 +00:00
justdave%syndicomm.com
6b3b75de75 Fix for bug 77473, bug 74032, and bug 85472: Passwords are no longer stored in plaintext in the database. Passwords are no longer encrypted with MySQL's ENCRYPT() function (because it doesn't work on some installs), but with Perl's crypt() function. The crypt-related routines now properly deal with salts so that they work on systems that use methods other than UNIX crypt to crypt the passwords (such as MD5). Checksetup.pl will walk through your database and re-crypt everyone's passwords based on the plaintext password entry, then drop the plaintext password column. As a consequence of no longer having a plaintext password, it is no longer possible to email someone their password, so the login screen has been changed to request a password reset instead. The user is emailed a temporary identifying token, with a link back to Bugzilla. They click on the link or paste it into their browser and Bugzilla allows them to change their password.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com, jake@acutex.net
2001-07-11 05:29:21 +00:00
justdave%syndicomm.com
babcf8d29e Fix for bug 87701: Invalid username in bug changes echoed back without escaping HTML data
Patch by Gervase Markham <gervase.markham@univ.ox.ac.uk>
r= justdave@syndicomm.com
2001-07-04 07:06:00 +00:00
justdave%syndicomm.com
eefbb08052 Killing the "used only once" error that suddenly popped up out of nowhere on tinderbox. 2001-07-04 05:33:37 +00:00
justdave%syndicomm.com
a8d4f31ac9 removing "Use Carp" and "sub die_with_dignity" that I was supposed to remove from the previous patch before checking it in. 2001-07-04 05:28:39 +00:00
justdave%syndicomm.com
a713e052fd Fix for bug 59349: Processmail now runs in taint (perl -T and $db->{Taint}=1) mode. Hooks also added to globals.pl to make converting other files in Bugzilla to run in Taint mode easier.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-07-04 04:41:27 +00:00
gerv%gerv.net
703d842ab9 Add strikethrough to resolved bug numbers. Bug 79816. r=jake. 2001-07-01 20:17:28 +00:00
gerv%gerv.net
44a89994a3 Make bug chart filenames other-OS friendly by removing colons. Bug 88179. r=jake. 2001-07-01 19:09:29 +00:00
justdave%syndicomm.com
1597e271bd Fix for bug 87596: improper definition of $::components in globals.pl
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-07-01 02:00:56 +00:00
justdave%syndicomm.com
9d2900700d Fix for bug 76183 and bug 71555: consolidates chmod activity in one place in checksetup.pl and also provides permission setting for bugzilla installations installed in a personal user directory as opposed to the server's main web space. (makes the files world-readable so the webserver can see them, since you can't set the group)
Patch by Christian Reis <kiko@async.com.br>
r= justdave@syndicomm.com
2001-06-29 03:47:56 +00:00
justdave%syndicomm.com
40361d84c3 Fix for but 76073: - and + didn't work in quicksearch in IE and Opera
Patch by Andreas Franke <afranke@ags.uni-sb.de>
r= justdave@syndicomm.com
2001-06-28 16:27:37 +00:00
jake%acutex.net
8baa1e7854 Refix bug 80289. Don't print header for groups if there aren't any groups to display (was printing a header without groups in rare instances).
Patch by Joe Robins <jmrobins@tgix.com>
r= jake@acutex.net
2001-06-28 15:42:30 +00:00
justdave%syndicomm.com
8fbb787774 Fix for bug 87983: backdoor.cgi is Netscape-specific, and not part of the bugzilla package. Removing from CVS. 2001-06-28 06:49:06 +00:00
justdave%syndicomm.com
5b0c76aa66 Fixing "used only once" errors flagged by tinderbox on the last checkin. 2001-06-27 02:31:55 +00:00
justdave%syndicomm.com
8efbae9be1 Fix for bug 80289: Group restrictions are now identified with checkboxes instead of select widgets. Also, product groups are now only offered if they are either already set, or match the current product (i.e. the option to set a product bit for a product other than the one the bug is in is no longer available) This results in much less clutter for the admin folks on sites with lots of products.
Patch by Joe Robbins <jmrobins@tgix.com>
r= justdave@syndicomm.com
2001-06-27 01:44:34 +00:00
ian%hixie.ch
8c97591eed * Implemented dispatcher.output service in CosesEditor.pm
* Implemented dispatcher.output.generic service in CosesEditor.pm
* Fixed a semantic error in the string data source
2001-06-23 04:07:21 +00:00
ian%hixie.ch
3f420d2309 (this checkin comment applies to the previous checkin on this file as well)
* Added some comments to various files indicating work to do and documenting some methods
* Fleshed out the Strings Data Source API (and implemented it in the MySQL version)
* Added the name "MySQL" to the MySQL-specific ID method of the Database Helper
* Factored out the XML parser dependency into an XML service
* Added a generic content sink implementation to the XML service
* Added a convenience method for manipulating user settings
* Added and implemented all the COSES commands
* Removed trailing spaces
2001-06-23 00:20:22 +00:00
ian%hixie.ch
225d339cd5 * Added some comments to various files indicating work to do and documenting some methods
*
2001-06-23 00:10:43 +00:00
justdave%syndicomm.com
d5331a298b Re-fix for bug 28458: AddFDef always replaces the fielddefs every time you run checksetup.pl, so the change to them during doeditparams was nullified if you updated. Other recent changes have nullified the reason for changing it in editparams anyway, so just backing that part out.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-06-21 15:03:11 +00:00
justdave%syndicomm.com
8dec4d01ce Fix for "used only once" error reported by tinderbox after the last checkin. (Aaargh!) 2001-06-21 02:42:41 +00:00
justdave%syndicomm.com
32a7a16306 Fix for bug 47914: buglist.cgi always had a not-logged-in footer if you were unlucky enough to have a login cookie that got corrupted in the shadow database. This patch makes buglist.cgi switch back to the primary database before looking up your login cookie for the footer.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-06-21 02:02:30 +00:00
jake%acutex.net
bc48c29b44 Fix for bug 86447 - ChangeFieldType() wasn't dealing with 'not null' properly.
r= justdave@syndicomm.com
2001-06-20 01:37:19 +00:00
justdave%syndicomm.com
a2bac692b3 Fix for bug 85833: show_bug.cgi (and probably others) now allow leading or trailing spaces in the bug id, to allow for user input error. This used to work, and recent bug validation changes broke it.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-06-19 22:48:21 +00:00
justdave%syndicomm.com
947a2b4e84 Fix for bug 45918: the old password field on the userprefs page is now used to log you back in if you try to change your password with cookies turned off, which avoids the confusing login screen after entering your new password in which you used to have to enter your old password one more time in order to let it set your new password (yes, it used to be as confusing as that just sounded :)
r= tara@tequilarista.org
2001-06-19 22:02:53 +00:00
dmose%mozilla.org
199ed6f301 Changing despot owner to endico@mozilla.org with her permission 2001-06-19 04:04:34 +00:00
jake%acutex.net
936d1b7a02 Running a query using the Added Comment option was very slow (bug 57350).
Patch by Myk Melez <myk@mozilla.org> and Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-19 02:05:08 +00:00
jake%acutex.net
aca8112d7e Refixing bug 71396. Each PushGlobalSQLState() needs a PopGlobalSQLState() and this file instead had two "pushes". 2001-06-19 01:37:02 +00:00
jake%acutex.net
a520791008 Allow '\' as a path delimiter (bug 29064)
Patch Concept by <timeless@mac.com>
r= jake@acutex.net
2001-06-18 23:13:18 +00:00
jake%acutex.net
333fb5fbb7 Fix for bug 85832 - QuickSearch should strip leading and trailing spaces.
Patch by Andreas Franke <afranke@ags.uni-sb.de>
2001-06-18 19:24:17 +00:00
tara%tequilarista.org
6915ed5a77 applying handy patch to refix version table to be 64 instead of 16--partial fix of bug 9352 2001-06-16 23:01:12 +00:00
jake%acutex.net
560a59fcb1 Fix for bug 71396 - $::db->do isn't needed anymore
Patch by Christian Reis <kiko@async.com.br>
r= jake@acutex.net
2001-06-16 14:51:16 +00:00
jake%acutex.net
9bb10e28c9 Fix for bug 83619 - QuickSearch was crashing Netscape 4.76 and 4.77 on Unix
Patch by Andreas Franke <afranke@ags.uni-sb.de>
2001-06-15 20:16:59 +00:00
jake%acutex.net
9a8e390762 Checking in the cleaner version of the fix for "No Available Products". This was attached to bug 65311.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-14 20:02:31 +00:00
jake%acutex.net
c2f223f052 Backing out previous changes as there was a better patch already attached to a different bug 2001-06-14 20:00:03 +00:00
jake%acutex.net
22c2912d66 Bugzilla shouldn't display empty header in the New: email notifications (bug 85734)
r=timeless
2001-06-14 14:16:27 +00:00
justdave%syndicomm.com
45bd565c70 Fix for bug 84596: Syncshadowdb wasn't using the db_user and db_pass from localconfig, which meant that it previously wouldn't run unless it was running under a user that had access to the bugs and shadowbugs dbs and didn't have a password. It now looks for db_user and db_pass and specifies them on the command line to mysqldump and mysql if they're in use.
r= tara
2001-06-10 17:38:15 +00:00
justdave%syndicomm.com
6fe1144587 Re-fix for bug 21253: fix calling conventions for syncshadowdb so that a phony parameter to get past the multi-param system() test in tinderbox actually works.
r= tara
2001-06-10 17:15:56 +00:00
jake%acutex.net
9e4a6d0caf Give a logical error message if no products are available to a user for bug entry (bug 84285).
Patch by Paul Thomas <paul.thomas@sse.ie>
r= jake@acutex.net
2001-06-08 13:12:13 +00:00
justdave%syndicomm.com
7ca1d33f14 Hopefully the fix for bug 77778: component lists, etc stuttering due to corruption in data/versioncache.
Patch design by Terry Weissman <terry@mozilla.org>
Patch implemented by Dave Miller <justdave@syndicomm.com>
r= tara@tequilarista.org
2001-06-07 21:26:49 +00:00
justdave%syndicomm.com
3b98736d18 Fix for bug 15980: Password is no longer shown in the location bar on the first page you load after logging in.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-07 20:26:40 +00:00
justdave%syndicomm.com
78dceec13b fix typo 2001-06-07 01:31:51 +00:00
justdave%syndicomm.com
e28badd576 Fix "used only once" error, per tinderbox build log. 2001-06-06 23:09:54 +00:00
justdave%syndicomm.com
336d245aa5 Fix for bug 21253: removing all single-parameter system() calls from Bugzilla
Patch by Dave Miller <justdave@syndicomm.com>
r= tara@tequilarista.org
2001-06-06 21:17:42 +00:00
justdave%syndicomm.com
d92a5f89ec Fix for bug 83872: Bugzilla no longer requires the Mysql Perl module, but the DBD::mysql Perl module, and has been this way for a while. Fixing the version checks in checksetup.pl to check the correct module. Also eliminates a DBD::mysql-specific database function call that is depricated in the current version of DBD_mysql.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net, tara@tequilarista.org
2001-06-06 21:10:47 +00:00
jake%acutex.net
53dba83bd9 Users should only be able to view attachments if they can view the bug that the file is attached to (bug 70189)
r=tara
2001-06-06 18:36:25 +00:00
jake%acutex.net
2c20a3ead5 Fixing typo. Attachments isn't spelled 'Attachemnts' (bug 84295). 2001-06-06 14:25:18 +00:00
justdave%syndicomm.com
4273abfb58 Fix for bug 39557: doeditvotes.cgi will no longer create a vote record for a nonexistant bug if the HTML is tampered with or other bugs cause bad bug numbers in the submitted form.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-06-06 04:51:55 +00:00
justdave%syndicomm.com
4fe1f1c9c3 Fix for bug 82781: describecomponents.cgi now checks viewing permissions to make sure you can see a product
Patch by Myk Melez <myk@mozilla.org>
r= tara@tequilarista.org
2001-06-06 04:32:45 +00:00
justdave%syndicomm.com
7f393c1d85 Fix for bug 28458: "NEW" bugs were not getting CC or QA Contact information displayed.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-06-06 04:28:52 +00:00
justdave%syndicomm.com
450514d585 Fix for bug 75482: adding the capability to deactivate a group without deleting it (prevent new bugs from being placed into that group, but don't remove the group restriction from bugs already in it).
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-06-06 03:16:52 +00:00
ian%hixie.ch
86e3bcd2ae * Improved the helpfulness of the extremely verbose debugging information of PLIF.pm by quoting embedded variables
* Implemented MagicCollectingArray, which acts like MagicPipingArray except that the result is collected into one big array instead of multiple arrayrefs
* Added the relevant getCollecting*List methods to the Controller class
* Added DESTROY methods to the magic array to prevent DESTROY method calls from being propagated
* Made the debug.dumpVars string more robust when the data hash includes one of the three magic characters '(', '.' or ')'
* Implemented sanitation in COSES so that any keys in the data hash containing one of the three magic characters '(', '.' or ')' will have them transliterated to '[', ':' and ']' respectively (sanitation is optional and can be bypassed)
* Changed the API of the generic output module's 'output' method to take the optional $session argument last, thus simplifying the call sites a lot
* Implemented the 'dispatcher.output' service in several classes to return strings that must be support in variants (required for a good UI in the COSES editor)
* Renamed the Login module's strings so that they use the dot-notation separating significant parts
2001-06-04 06:13:22 +00:00
ian%hixie.ch
a6faa21a5f Stub implementation of a COSES editor component, plus added 'component.nameOfComponent' to the list of services provided by the other two components 2001-06-03 23:06:09 +00:00
ian%hixie.ch
15b9f89cde Moved AdminCommands.pm and Login.pm to a Component directory 2001-06-03 22:45:37 +00:00
ian%hixie.ch
407f43e493 Minor bug fixes required to make the code run without crashing... 2001-06-03 16:14:41 +00:00
ian%hixie.ch
02d609eb82 Some more minor corrections to get it to run as well as compile... (removes some XXX comments and adds some error checking) 2001-06-03 15:27:16 +00:00
ian%hixie.ch
5dd8af9c83 Fixing a gazillion syntax, logic and XML errors and adding some debug code. It compiles! 2001-06-03 14:49:41 +00:00
ian%hixie.ch
7daa595cd4 * Added some comments (including some XXX comments where I realised we had missing code)
* Added implicit data to the hash passed to the string expander from the generic output service
* To support the implicit data, added a |hash| stub method to the Session.pm module (and changed the already implemented version in the descendant user service to take this into account)
* To support the implicit data, added |hash| and |getArguments| methods to the Input.pm module (and implemented |getArguments| in the Arguments.pm module)
* To support the implicit data, made the Program.pm module keep track of the executing command
* To support the implicit data, added |hash| and |name| methods to the Program.pm module (actually, |name| was already assumed to exist in other parts of the codebase)
* Corrected trivial semantic mistake in Program.pm's |verifyInput| method
* Added a way to get a user not by username but by a specific address (modifies the user service and the user data source and it's MySQL implementation)
* Implemented GenericOutputs.pm, an implementation of 'dispatcher.output.generic' and 'dataSource.strings.default' for some strings used by other parts of PLIF (currently only supports 'stdout' and 'http' protocols, and minimally at that)
* Implemented Login.pm, a helper module that implements user authentication, user creation and the sending of a new password if it is forgotten, a utility method |hasRight| to ensure that the authenticated user has a particular right (resulting in a message if not), and various routines to support all this.
2001-06-03 10:11:58 +00:00
tara%tequilarista.org
eda44f5b9f Landing Myk's patch for bug #71767 2001-06-02 22:02:02 +00:00
jake%acutex.net
dd724b762d sanitycheck.cgi was able to be run by anybody - even people without Bugzilla accounts. It is now restricted to only people with the editbugs permission (bug 54556).
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-06-02 14:24:45 +00:00
justdave%syndicomm.com
770e473d23 Fix for bug 65190: add comparison type "all words as substrings" and "any words as substrings" to the text fields in query.cgi
Patch by Andreas Franke <afranke@ags.uni-sb.de>
r= justdave@syndicomm.com
2001-06-02 04:02:13 +00:00
justdave%syndicomm.com
46f339c5a5 Fix for bug 78407: extra safeguard against overpopping the email list when pruning people who aren't supposed to get mail.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-06-02 03:19:26 +00:00
justdave%syndicomm.com
6e09c91524 Fix for bug 83596: optional dependency on XML::Parser now checked in checksetup.pl
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-02 01:57:22 +00:00
justdave%syndicomm.com
988054fcd5 Fix for bug 83618: checksetup.pl crashes if DBI module isn't already installed.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-02 01:53:01 +00:00
jake%acutex.net
d92f61970d More leak pluggin. This one fixes bug 39526.
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-06-01 13:38:01 +00:00
justdave%syndicomm.com
a490c6a17a Fix for bug 83633: perl warnings in 5.6
r= Hixie
2001-06-01 10:03:52 +00:00
justdave%syndicomm.com
b2c86ed7e1 Fix for bug 73249: perl warnings under 5.6.0.
Patch by Chris Yeh <Chris.Yeh@nokia.com>
r= justdave@syndicomm.com
2001-06-01 08:34:45 +00:00
justdave%syndicomm.com
d3e70e89ba Fix for bug 79317: dependency on CGI::Carp not caught by checksetup.pl
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-01 03:13:28 +00:00
justdave%syndicomm.com
8ab8f92481 backing out previous fix to importxml.pl. It fixed it on Perl 5.6 and broke it on Perl 5.005. Will need to investigate. 2001-06-01 02:27:52 +00:00
justdave%syndicomm.com
bb1c25a4d0 Fix for bug 72862: fixes more Perl warnings in RelationSet.pm and globals.pl 2001-06-01 02:14:23 +00:00
justdave%syndicomm.com
ed939131dc Fix for bug 57848, perl warnings in several files.
Patch by Nick Hibma <n_hibma@qubesoft.com>
r= justdave@syndicomm.com
2001-06-01 02:07:28 +00:00
ian%hixie.ch
07b4d3d583 * fixing some syntactic errors
* added addUserGroup and removeUserGroup to the data source interface for users
* added some comments
* changed many double quotes |"| to single quotes |'| where double quotes were not needed
* implemented the remaining methods for the MySQL implementation of the user data source
* added a mode flag to user fields (idea from MattyT) so that fields can be disabled, hidden, etc
2001-06-01 00:32:35 +00:00
jake%acutex.net
d520cdb669 Bugzilla was leaking information about bugs marked secure (using bug groups). This checkin fixes bugs 39524, 39527, 39531, and 39533.
Patches by Myk Melez <myk@mozilla.org>.
r= jake@acutex.net
2001-05-31 15:52:25 +00:00
jake%acutex.net
7da1a248bc Bug 80388 - cvsblame shouldn't require layers for popups
r=baloo
2001-05-30 22:13:03 +00:00
jake%acutex.net
8cbb7741ca Fix for bug 45164 - New users created by the admin were not subject to the userregexp for groupsets.
Patch by Joe Robins <jmrobins@tgix.com>
r= jake@acutex.net
2001-05-30 15:47:30 +00:00
justdave%syndicomm.com
17dff3efe0 Dummy commit so I can put the attributions I forgot in the previous one.
Patch from bug 65290 was by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-05-29 21:27:12 +00:00
justdave%syndicomm.com
8f363f7f6e Fix for bug 65290: can now edit user-regexps for system groups 2001-05-29 21:25:02 +00:00
ian%hixie.ch
76d1f38fb9 Change the semantics of address changing, making it faster, smaller, simpler, and better. Aaah... :-) In the new system, instead of cloning the current $session object to pass it back to the output code, you pass the real $session object to the output code, just making sure that the relevant field has been warned to return a different address than found in the database. 2001-05-29 20:34:12 +00:00
justdave%syndicomm.com
de23e17707 Fix for bug 65399: Can't use string ("") as an ARRAY ref while "strict refs" in use at query.cgi due to no components defined in a product.
Patch by Matthias Radestock <matthias@sorted.org>
r= justdave@syndicomm.com
2001-05-29 20:30:51 +00:00
justdave%syndicomm.com
3aaea9ad25 Additional cleanup for bug 73191. newquip.html is no longer needed. 2001-05-29 18:44:00 +00:00
ian%hixie.ch
1b89023d7a Adding some XXX comments regarding a known bug (when the user is changing their address, fields try to update the database before the new address has been authenticated) 2001-05-29 09:11:33 +00:00
ian%hixie.ch
2411ff6005 * Fixing a minor bug in the MySQL implementation of the string data source
* Started implementing the MySQL version of the user data source (completed so far: database creation and a few of the SELECT calls)
* Changed the user property 'disabled' to 'mode' to enable extensibility
* Fix a potential bug with changing addresses (make sure the fake session object doesn't update the database -- this is an incomplete solution so far, fields still have the bug)
2001-05-29 09:07:10 +00:00
justdave%syndicomm.com
c2cf48b4bd Fix for bug 78045: change references to README in error messages to point to the Bugzilla Guide instead.
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave@syndicomm.com
2001-05-29 08:10:28 +00:00
justdave%syndicomm.com
5205d71b1c Landing quips.cgi (bug 73191) by Owen Taylor <otaylor@redhat.com>
Submitted by Martin Baulig <baulig@suse.de> from bugzilla.gnome.org
r= justdave@syndicomm.com
2001-05-29 04:01:48 +00:00
justdave%syndicomm.com
93046edb9a Fix for bug 77699 and bug 71503: fix javascript errors in quicksearch and improve IE5 compatibility
Patch by Stephan Lee <slee@uk.bnsmc.com> and Andreas Franke <afranke@ags.uni-sb.de>
2001-05-29 03:05:46 +00:00
ian%hixie.ch
fe6643848b * Moving 'type' to the front of the list of things returned by the User data source's 'getField*' methods so that they map more directly to the user field constructor arguments
* Moving 'typeData' around in the order of the user field constructor arguments to match the User data source's 'getField*' methods so that, again, they map more directly
* Renaming the 'getFieldFrom*' methods to 'getFieldBy*' to be consistent with 'getUserBy*'
* Implemented UserFieldFactory.pm
* Implemented Passwords.pm
2001-05-28 23:43:56 +00:00
ian%hixie.ch
e60cd56ae6 * Correcting a typo in Input.pm
* Added a comment to DataSource/User.pm explaining how (typically) to search for a username
* Fleshed out the DataSource/User.pm API by adding some schema management methods
* Added notes on which fields in the database schema should be keys
* Added comment to Service/User.pm noting the difference between Objects, Services, and Service Instances
* Changed 'user.field.factory' to 'user.fieldFactory' to prevent a namespace collision with 'user.field.(type)'
* Calling 'insertField' in one case which I missed when adding the method
* Implemented 'hash', 'joinGroup', 'invalidateRights', 'writeProperties' and 'writeGroups'
* Changed Service/UserField.pm so that one user field class can be used for any category
* Added a 'username' convenience method and implemented 'write'
* Added a comment to Service/UserFieldFactory.pm explaining how it should work
* Removed the 'user.field.generic.generic' field implementation, replaced it with a simpler 'user.field.string' implementation
2001-05-28 20:09:23 +00:00
jake%acutex.net
bbb2c13524 Bug 79739 - Initial Owner and QA Contact were not being handled correctly by the email interface after they were changed to userid's in bug 66876.
r= justdave@syndicomm.com
2001-05-25 12:48:47 +00:00
jake%acutex.net
4cf2c59aa4 Mention the Bugzilla project page and where to report bugs
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave@syndicomm.com, jake@acutex.net
2001-05-24 12:58:33 +00:00
ian%hixie.ch
1ffb74226d Added some minor corrections and clarifications to the documentation.
Added some comments to various user-related files.
Factored out some code that started becoming common when inserting fields in Service/User.pm.
Added code to deal with adding new contact details.
Added code to support removing fields from a user.
2001-05-24 07:06:41 +00:00
timeless%mac.com
68152b8d2a 62446 extra spaces inside links on some lxr-generated pages
r=terry
2001-05-24 04:10:23 +00:00
timeless%mac.com
2ed9571632 45785 Swapped ALIGN/VALIGN attributes
39224 duplicate word on lxr.mozilla.org/ ("use use")
r=terry
2001-05-24 04:07:43 +00:00
jake%acutex.net
7d7408335b Bug 71552 - Remove oldemailtech from Bugzilla
r= justdave@syndicomm.com
2001-05-24 03:10:49 +00:00
ian%hixie.ch
d9c627c0b9 Started work on fleshing out the user components. This is still work in progress. 2001-05-14 06:45:08 +00:00
ian%hixie.ch
76a1624abe Initial checkin of the Field part of the User work. Just ideas at the moment, nothing here is implemented, and much of it is likely to change. 2001-05-13 20:54:35 +00:00
ian%hixie.ch
57c85fb025 First pass at adding User objects (derived from Session). Lots of XXX code -- none of this works, it's basically all stubs.
In addition to the code that actually does stuff, I still need to add a MySQL implementation of the data source and the Field class and its associated Factory.
Also added Passwords.pm (stubs for a password generator and encryptor) and made Session objects store a pointer to the controller object.
2001-05-13 18:11:54 +00:00
ian%hixie.ch
a47f424255 Added a bit more support for objects (as opposed to services): added a new objectCreate() constructor and an objectInit() method.
Added an optimisation to Controller.pm so that service names will be hashed once accessed. This should make multiple accesses of the same service a lot quicker. To go with this I added some diagnostics code (on exit) and moved the code around a little bit.
Fixed a minor transgression of the coding style guidelines in Magic*Array.pm. :-)
Neatened up the code in Output.pm.
Made it so Session objects assume they have an 'app' property, and so don't need to be passed $app all the time. (Sessions are objects now.)
Added an unimplemented getAddress() method to the Session class.
2001-05-13 18:04:52 +00:00
ian%hixie.ch
b211b52c46 fixing two rather serious (albeit simple) bugs in the strings data source; adding a comment to Input.pm in preparation for doing the user authentication stuff 2001-05-13 05:52:24 +00:00
justdave%syndicomm.com
66952b81d2 Fix for bug 38859: escape invalid email addresses for HTML before displaying to the user.
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net, justdave@syndicomm.com
2001-05-11 18:02:38 +00:00
justdave%syndicomm.com
c3637c7ac6 Fix for bug 80045: 500 Server Error in IE (but not Netscape or Mozilla) on errors looking up email addresses.
Patch by <jake@acutex.net>
r= justdave@syndicomm.com
2001-05-10 18:16:51 +00:00
justdave%syndicomm.com
08322c85b4 Fix for bug 38854: reports.cgi needs to escape (untrusted) url params
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-05-10 03:02:52 +00:00
justdave%syndicomm.com
6d5e40ea64 Fix for bug 38855: showvotes.cgi needs to escape (untrusted) url params
Patch by Myke Melez <myk@mozilla.org>
r= jake@acutex.net
2001-05-10 02:53:22 +00:00
justdave%syndicomm.com
c699c249ad Fix for bug 79730: Minor minor typo in move.pl (recieve -> receive).
Patch by gavins@iplbath.com (Gavin Shelley).
r= justdave@syndicomm.com
2001-05-09 18:32:35 +00:00
ian%hixie.ch
0ecf1d5628 adding some progress messages to the setup output; making COSES more resilient to invalid input 2001-05-08 00:05:42 +00:00
ian%hixie.ch
572285560e Slight changes to make output code more flexible 2001-05-07 07:04:17 +00:00
ian%hixie.ch
b8a735d31d * fixed the methodMissing() method so that it actually is possible to use it to do method dispatching;
* factored out some of the method dispatching code by adding a dispatchMethod() method to the controller;
* turned the Dispatcher class into simply a function on the base Service class and removed Dispatcher.pm;
* made it possible for services to be both services and objects and provide different services depending on which context they were called in (and used this to make the AdminCommands module actually do what it was intended to in the first place, namely, only work for CommandLine access);
* fixed it so if a service is first created by getServiceList the constructed version will actually be cached;
* made output more generic by allowing services to implement arbitrary parts of the output API, used that to make AdminCommands usable without requiring additional code to support it;
* added some documentation;
* added some dump(10) statements to help debugging;
* fixed the string datasource SQL;
* fixed the DBI database so it can handle errors;
* added tableExists API to the DBI database helper.
Thanks to myk, justdave and zach for some ideas.
2001-05-06 06:26:24 +00:00
ian%hixie.ch
aac5db9914 Made the lack of a configuration file be non-fatal (and factored out the low level code while I was at it). We need that so that the configuration data source can actually go in and create the configuration file if it is missing; otherwise the program exits with "no configuration file! waah!" before you get to the configuration-file-creation code! 2001-05-05 19:00:06 +00:00
ian%hixie.ch
1dc1d947ea Implementing (and documenting!) PLIF::debug() as suggested by zach. a=hixie 2001-05-05 18:28:08 +00:00
ian%hixie.ch
0baba2d269 work in progress 2001-05-05 07:12:56 +00:00
ian%hixie.ch
1987fac6eb Blatantly copied http://scarab.tigris.org/scarab-design.html and changed it to suit Bugzilla 2001-05-03 10:57:46 +00:00
ian%hixie.ch
318280bff2 Creating new Bugzilla 3 directory. Nothing to see here yet! 2001-05-03 10:41:12 +00:00
ian%hixie.ch
cfc5246ba6 Fixing various typos and spelling mistakes spotted by timeless. There shouldn't be any code level changes here. moa=hixie 2001-04-29 08:35:29 +00:00
justdave%syndicomm.com
4f193d1f18 rolling version number to 2.13 for development 2001-04-27 19:36:20 +00:00
justdave%syndicomm.com
6c276b00a8 addition to 2.12 release notes 2001-04-27 19:32:27 +00:00
Chris.Yeh%nokia.com
ad4e9851e6 Fix for sendmail daemons that don't support EHLO. We never use the extended
functionality anyway, so replace it with a standard HELO. Thanks to Ken Key for
helping me track this down.
2001-04-26 22:53:20 +00:00
justdave%syndicomm.com
4a8cfd0de6 Backing out .htaccess commit, these don't belong here yet. It broke checksetup.pl, too. 2001-04-26 04:16:03 +00:00
barnboy%trilobyte.net
8ab8b154ac Added .htaccess files for shadow/, data/, and /.
I added related information to the Bugzilla Guide, and
tacked in a couple of last-minute additions.  Also fixed the
annoying "Tip: HINT:" thing.
2001-04-26 01:51:59 +00:00
tara%tequilarista.org
b9aa9e56ce Tara is a bucket head. Floating version to 2.12 ship for tag and stripe 2001-04-25 15:45:27 +00:00
tara%tequilarista.org
c992df21c5 Removing forward planning text 2001-04-25 15:38:34 +00:00
barnboy%trilobyte.net
84bd6fdde8 Fix for confusing language regarding protection of data/ & shadow/ directories
and localconfig file.
2001-04-25 07:38:24 +00:00
barnboy%trilobyte.net
ef649afe1a Updated Bugzilla Guide and README to fix bug 76156, bug 76841, and bug 26242.
The README is now gutted, pointers to Guide.  Also some new sections added,
old ones fixed, and notes appended to deprecated sections I've not yet had
the heart to remove.
2001-04-25 07:12:20 +00:00
tara%tequilarista.org
4e02dfa8a8 Checking in the last of the changes for 76837 for 2.12. Good enough for government work. 2001-04-23 22:16:12 +00:00
tara%tequilarista.org
49f8b594ad README now points everybody to the release notes and the new user guide 2001-04-23 22:14:50 +00:00
ian%hixie.ch
8be7b6f9d9 Changing release numbers to 2.0 to match mozbot version number. 2001-04-23 07:09:20 +00:00
ian%hixie.ch
9660807d69 Updating mozbot to version 2.0: changed to a more modular architecture, added support for multiple channels, added support for multiple nicks, generally cleaned up the code, etc. Uses some code and ideas from timeless and zach. 2001-04-23 07:07:17 +00:00
myk%mozilla.org
66f79b8224 updated url to stats on mothra 2001-04-23 06:02:59 +00:00
justdave%syndicomm.com
1c9ac30c82 Adding reference to data/comments needing to be an exception to the blocking of the 'data' folder. 2001-04-22 18:56:58 +00:00
justdave%syndicomm.com
634cb5c1f9 Checking in Matty's update to the release notes 2001-04-22 18:48:04 +00:00
gerv%gerv.net
8ab3da9fc6 Added a couple of lines about mysqld-watcher.pl. Bug 76862. 2001-04-22 18:13:40 +00:00
justdave%syndicomm.com
c121d848ae Per bug 76862, moving mysqld-watcher.pl into contrib 2001-04-22 17:48:12 +00:00
gerv%gerv.net
8707e0cc16 Lots of formatting fixups, removed tab characters. Also removed incorrect DB_File requirement. 2001-04-22 17:26:35 +00:00
gerv%gerv.net
9f556a9d3e Fix bug 76524 - mostfreqhtml param text has a few issues. Patch by matty@chariot.net.au . 2001-04-22 16:44:10 +00:00
Chris.Yeh%nokia.com
b270b1400a column change from when to ci_when a long time ago. make repophook.cgi
match database schema
2001-04-21 00:10:39 +00:00
tara%tequilarista.org
b87c492ac9 Checking in massive changes to make this document more generic to all bugzilla installations 2001-04-20 22:08:09 +00:00
tara%tequilarista.org
4ac9c20af6 Adding new Release Notes for MattyT 2001-04-20 16:46:59 +00:00
justdave%syndicomm.com
a9263af4df another chmod with a leading 1 (Perl interprets this as a decimal instead of octal) 2001-04-20 14:41:44 +00:00
justdave%syndicomm.com
bf4fc36ffe Changing all chmod 1777 to chmod 01777. Without the leading 0 it's interpreted as decimal instead of octal (oops) 2001-04-19 20:46:53 +00:00
tara%tequilarista.org
056744dad1 Bullshit checkin to add the fact that the previous changes also include the final fix for bug 72721. I am a buckethead 2001-04-19 17:35:23 +00:00
tara%tequilarista.org
4aeb7565b6 landing final patch for bug 76261 2001-04-19 17:19:07 +00:00
endico%mozilla.org
788ade41ba initial checkin 2001-04-18 18:01:28 +00:00
justdave%syndicomm.com
8e2cc80353 Correcting my email address in the comments 2001-04-17 02:26:16 +00:00
myk%mozilla.org
62514913c5 bug 75991: removed bugzilla-specific stuff and added bugzilla-specific script since bugzilla is moving to mothra; genstats.cgi will do the bonsai stats and genstats-bz.cgi will do the bugzilla stats 2001-04-14 01:47:40 +00:00
mcafee%netscape.com
fb70aca709 Adding Ts to legend 2001-04-10 09:49:33 +00:00
mcafee%netscape.com
1cee933ffa Adding startup.dat 2001-04-10 06:13:08 +00:00
mcafee%netscape.com
96b6669e1c Adding support for startup test. 2001-04-10 05:55:12 +00:00
mcafee%netscape.com
44c8693eeb process build log to create startup.dat file 2001-04-10 05:54:29 +00:00
justdave%syndicomm.com
247adaf957 Fix for bug 18349: query.cgi target_milestone value does not reload SELECTed item.
Patch by <jake@acutex.net>
r= justdave
2001-04-10 03:49:01 +00:00
justdave%syndicomm.com
5fe70f7653 Fix for bug 72379: query.cgi component value does not reload SELECTed item.
Patch by Myl Melez <myk@mozilla.org>
r= jake, justdave
2001-04-10 03:41:44 +00:00
mcafee%netscape.com
265438d001 remove bogus l 2001-04-10 01:26:52 +00:00
mcafee%netscape.com
03d96219d4 Adding white background, so linux sees white 2001-04-10 01:10:07 +00:00
mcafee%netscape.com
99b0b09921 shrinking who iframe a bit 2001-04-10 01:09:35 +00:00
endico%mozilla.org
a62419aabd change to using google links instead of the defunct deja.com links 2001-04-09 23:49:51 +00:00
justdave%syndicomm.com
5e45ff8188 Fix for bug 71659: New bugs weren't creating email if the reported didn't give a long description, and the first person who added a comment had their comment become the long description of the bug.
Patch by <jake@acutex.net>
r= justdave
2001-04-09 19:10:43 +00:00
endico%mozilla.org
4e717fdc0e only attempt to wrap the newsbot file if template and wrap script exist. Sometimes they don't if this script is run while the web site is being rebuilt. 2001-04-09 04:21:18 +00:00
justdave%syndicomm.com
24adb74e78 Fix for bug 66014: Correct sanitycheck for the new initialowner and
initialqacontact fields in the components table.
Patch by Matthew Tuck <matty@chariot.net.au>
r= afranke, justdave
2001-04-08 02:33:02 +00:00
justdave%syndicomm.com
a3c8569fdf Fix for bug 71808: Can't set email preferences for voters (which caused voters to get OldEmailTech notifications.
Patch by jake@acutex.net
r= justdave
2001-04-07 17:09:28 +00:00
justdave%syndicomm.com
47cea0555a Fix for bug 71912: changes email pref for "If I'm removed from that capacity" to "If I'm added to or removed from that capacity", so you can still get mail when someone adds you to a CC. Patch by <jake@acutex.net> r= justdave 2001-04-07 16:36:45 +00:00
justdave%syndicomm.com
d89ccdc16c Fix for bug 71607: remove "month-day only" date format from bug list views.
Patch by Stephan Niemz <st.n@gmx.net>
r= justdave
2001-04-07 03:30:59 +00:00
justdave%syndicomm.com
926fa731c5 Fix for bug 72721 (duplicates.cgi performs poorly with lots of bugs) and bug 69054 (DB_File not portable): dependence on DB_File removed, now uses AnyDBM_File which comes standard with Perl. Duplicates.cgi now runs its queries against the shadow database if it's available, among many other improvements.
Patch by gervase.markham@univ.ox.ac.uk (Gervase Markham)
r= justdave
2001-04-06 18:19:47 +00:00
justdave%syndicomm.com
c09b1fd81e Re-fix for bug 29820: remove "Changed" from email subject line. Based on patch submitted by Stephan Niemz [faniz] <st.n@gmx.net>, r= jake, cyeh
UPGRADE NOTES: when you install this update, you will need to change the subject line in your 'changedmail' and 'newchangedmail' params from the web by running editparams.cgi.  The subject line needs to be changed from:
Subject: [Bug %bugid%] %neworchanged% - %summary%
to
Subject: [Bug %bugid%] %neworchanged%%summary%

Or whatever is appropriate for the subject you are using on your system.  Note the removal of the " - " in the middle.
2001-04-06 17:40:49 +00:00
justdave%syndicomm.com
f09960cb4a Fix for bug 74394: editmilestones.cgi can't edit the name and sortkey at the same time
Patch by slee@uk.bnsmc.com (Stephen Lee)
2001-04-06 16:47:49 +00:00
justdave%syndicomm.com
06b3d0b211 Backing out Blake's misfire 2001-04-06 04:44:41 +00:00
mcafee%netscape.com
d617e6fb40 Adding support for pageloader test. 2001-04-06 04:02:25 +00:00
mcafee%netscape.com
4898b51f3e Adding support for pageloader test. 2001-04-06 03:56:50 +00:00
mcafee%netscape.com
80409a1106 Adding pageloader.dat to copyfile list 2001-04-06 03:42:36 +00:00
mcafee%netscape.com
65e9828273 First add 2001-04-06 03:40:08 +00:00
blakeross%telocity.com
c9b9689e26 Use more efficient command structure, refactor commands, broadcasters and keys, remove unused attributes, do some other optimization (72923). Landing navigator part only; this should help new window opening and some other areas. r=ben sr=hyatt 2001-04-05 19:53:13 +00:00
kestes%tradinglinx.com
df9cba1f8e auto generate the version number based on the output of the date command 2001-04-05 17:48:23 +00:00
kestes%tradinglinx.com
1cc06e04fd relax the uid/gid security checks for Debian 2001-04-04 14:23:36 +00:00
dave%intrec.com
900965b19d Fix for bug 74529: backward email filtering fixed. patch by jake@acutex.net 2001-04-03 20:54:53 +00:00
dave%intrec.com
8c81eb9243 Fix for bug 53696: periods(.) and plusses(+) were not being accepted as valid in mime-types, which are legal per RFC2045 and RFC2048. 2001-04-03 20:42:58 +00:00
kestes%tradinglinx.com
0c6d2da4cd relax the uid/gid security checks for redhat 7.0 2001-04-03 15:14:27 +00:00
kestes%tradinglinx.com
5a3e1f56e0 do not have blank lines before the mail headers, postfix will choke. 2001-03-30 22:44:54 +00:00
kestes%tradinglinx.com
526caf9356 do not have blank lines before the mail headers, postfix will choke. 2001-03-30 22:44:10 +00:00
kestes%tradinglinx.com
f51084f38a remove duplicate printing of unmonitored build list. 2001-03-30 19:54:50 +00:00
kestes%tradinglinx.com
1c0f2a2618 I seem to have trouble keeping the interface
TinderDB::Build::all_build_names($tree);
consistent will all usage of this function.
2001-03-30 15:37:44 +00:00
blakeross%telocity.com
2b5153d392 Backing out on request of module owner (no review, no module owner approval, unstable code). Don't shoot the messenger (with the checkin access)! 2001-03-30 00:34:31 +00:00
timeless%mac.com
78638cd1e0 fix version. 2001-03-29 22:40:51 +00:00
timeless%mac.com
8b6f15dc64 Bugzilla Bug 74024 check techbot1 into cvs
Land techbot1 into mozbot tree. This has been a long time coming.

techbot1 includes support for arbitrary commands, bugzilla features including
bug, component and keyword queries. more support for tinderbox including
sheriff querying.  support for multiple channels.  it handles missing
components better.
2001-03-29 22:38:35 +00:00
mcafee%netscape.com
dfce4b727f Adding bonsai tree name field, plus hints in parens so it's easier for newbies to figure this out. 2001-03-29 03:45:38 +00:00
cyeh%bluemartini.com
5efba7210d add comment about DB_File requirement for collectstats.pl 2001-03-29 00:36:38 +00:00
cyeh%bluemartini.com
29502ab302 fix for 71798: bugmail not sent when moving from cc to assigned fields
checked in patch based on patch submitted by jake@acutex.net
2001-03-28 23:43:39 +00:00
terry%mozilla.org
98f92a6f09 Improve error message 2001-03-26 22:10:36 +00:00
kestes%tradinglinx.com
89fa987d61 put correct mailing address in comment. 2001-03-26 14:08:42 +00:00
kestes%tradinglinx.com
42e0d5ea22 put correct mailing address in comment. 2001-03-26 14:05:48 +00:00
kestes%tradinglinx.com
fda5601a8f for security, set a umask.
typo with $MINIMUM_BUILD_SECONDS was causing too little sleeping and
many builds occured flooding my disk space.
2001-03-26 13:37:24 +00:00
kestes%tradinglinx.com
1480e5a432 for security, set a umask 2001-03-26 13:36:28 +00:00
kestes%tradinglinx.com
ea51ad7e61 got the mindate/maxdate backwards for the "C" link. I thought I fixed
this already.
2001-03-26 13:36:00 +00:00
timeless%mac.com
486382c27a Bugzilla Bug 73426 fix viewallnotes.cgi compile errors <q src="tinderbox" class="errors"/>
fixes tinderbox bustage
2001-03-26 10:49:46 +00:00
cls%seawood.org
176d0306a5 Backing out previous checkin. 2001-03-25 23:53:37 +00:00
endico%mozilla.org
b0e5e6903d Lets be consistant. Switch back to #!/usr/bonsaitools/bin/perl -w 2001-03-25 08:59:55 +00:00
cls%seawood.org
7ed82ce239 Add prelim support for tracking multiple branches on tinderbox 2001-03-25 06:21:35 +00:00
mcafee%netscape.com
026b494b97 Fixing strict JS warnings (20364). patch=david.gardner 2001-03-21 03:57:33 +00:00
kestes%tradinglinx.com
77d321e2aa always show the last few lines of the build. 2001-03-19 23:35:13 +00:00
kestes%tradinglinx.com
797f9199a6 add system3() so that we can send reports while the
build is running.
2001-03-19 23:33:43 +00:00
kestes%tradinglinx.com
259da77fdc fix typo in header generation.
take out the <p> in the info, it makes the windows too big.
also increase the window sizing algorithm for the headers
   to be compatible with what I do for the build.
2001-03-19 23:32:43 +00:00