There was a bug where the panel would be hidden on the first click on Windows (and I think Linux, too). This was happening because the focusin event would trigger after mousedown and hide the panel on the first click. Then the button would have focus and we wouldn't get a focusin on the second click.
This updates the focusin handler to check if this is the first focusin event, and ignore it if the event target matches our triggering event's target.
Differential Revision: https://phabricator.services.mozilla.com/D28587
--HG--
extra : moz-landing-system : lando
Adds a new step parameter for download information named downloadInfo.
Adds checks for both nsIIncrementalDownload and BITS download result codes.
Makes 8 tests run using BITS for the update download.
Adds test tags for bits and internal browser chrome tests.
Removes the duplicate logging from UpdateService.jsm when running tests locally.
Differential Revision: https://phabricator.services.mozilla.com/D28602
--HG--
extra : moz-landing-system : lando
We made changes to change the visibility of this button whenever the panel is opened, so
more lazily. I think this caused some intermittents where the assertion was runinng before
the hide/show code executed.
Differential Revision: https://phabricator.services.mozilla.com/D28628
--HG--
extra : moz-landing-system : lando
FatalError uses Services.startup.quit and this is apparently fine
to run in an xpcshell test with an optimised build, but not with
debug builds where it causes MOZ_CRASH() to be hit.
This removes test_FatalError so that we can run test_Error.js on try.
Differential Revision: https://phabricator.services.mozilla.com/D28705
--HG--
extra : moz-landing-system : lando
The remote debugger mochitest browser-chrome tests do not have to
be run in a separate subsuite. Removing the subsuite condition
will make them appear as part of the normal M-bc* jobs on try.
Differential Revision: https://phabricator.services.mozilla.com/D27932
--HG--
extra : moz-landing-system : lando
The previous commit disabled the remote agent by flipping the
remote.enabled preference to false. That prevented the remote
agent from initialising or being included in the --help message.
This patch implies --enable-cdp in the default Firefox build on Firefox
Nightly. Firefox for Android is not supported. This will cause
builds to include the remote agent component that lives under remote/.
Since the remote agent is disabled by default, users will first
have to set the remote.enabled preference to true in order to use it.
If you wish to explicitly opt out of including the remote agent
when building Firefox, you may do so by using the --disable-cdp
build flag in your mozconfig:
ac_add_options --disable-cdp
Differential Revision: https://phabricator.services.mozilla.com/D27540
--HG--
extra : moz-landing-system : lando
This disables the remote agent through flipping the remote.enabled
preference to false. This will cause the help text to disappear from
--help and the RemoteAgent#init() (in remote/RemoteAgent.jsm) to fail.
We also change RemoteAgent.jsm to being loaded lazily so that it
isn't imported.
Differential Revision: https://phabricator.services.mozilla.com/D27539
--HG--
extra : moz-landing-system : lando
The browser.fission.simulate preference has been split
into two preferences: fission.frontend.simulate-events and
fission.frontend.simulate-messages.
The remote agent briefly used the child actor system from the
Firefox frontend code when we prototyped the initial remote agent,
but it no longer relies on it. This means we can drop the reference
to browser.fission.simulate altogether.
DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D27538
--HG--
extra : moz-landing-system : lando
They are only used in non-Intl resp. system ICU builds in jsdate.cpp.
Depends on D28481
Differential Revision: https://phabricator.services.mozilla.com/D28482
--HG--
extra : moz-landing-system : lando
The remote debugger mochitest browser-chrome tests do not have to
be run in a separate subsuite. Removing the subsuite condition
will make them appear as part of the normal M-bc* jobs on try.
Differential Revision: https://phabricator.services.mozilla.com/D27932
--HG--
extra : moz-landing-system : lando
The previous commit disabled the remote agent by flipping the
remote.enabled preference to false. That prevented the remote
agent from initialising or being included in the --help message.
This patch implies --enable-cdp in the default Firefox build on Firefox
Nightly. Firefox for Android is not supported. This will cause
builds to include the remote agent component that lives under remote/.
Since the remote agent is disabled by default, users will first
have to set the remote.enabled preference to true in order to use it.
If you wish to explicitly opt out of including the remote agent
when building Firefox, you may do so by using the --disable-cdp
build flag in your mozconfig:
ac_add_options --disable-cdp
Differential Revision: https://phabricator.services.mozilla.com/D27540
--HG--
extra : moz-landing-system : lando
This disables the remote agent through flipping the remote.enabled
preference to false. This will cause the help text to disappear from
--help and the RemoteAgent#init() (in remote/RemoteAgent.jsm) to fail.
We also change RemoteAgent.jsm to being loaded lazily so that it
isn't imported.
Differential Revision: https://phabricator.services.mozilla.com/D27539
--HG--
extra : moz-landing-system : lando
The browser.fission.simulate preference has been split
into two preferences: fission.frontend.simulate-events and
fission.frontend.simulate-messages.
The remote agent briefly used the child actor system from the
Firefox frontend code when we prototyped the initial remote agent,
but it no longer relies on it. This means we can drop the reference
to browser.fission.simulate altogether.
DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D27538
--HG--
extra : moz-landing-system : lando
We've landed some recent changes that implicitly require SDK
10.0.17134.0. Since we've been building with that version for some time
in automation, let's go ahead and raise the minimum version accordingly.
Differential Revision: https://phabricator.services.mozilla.com/D28671
--HG--
extra : moz-landing-system : lando
TabManager.addTab(), and consequently gBrowser.addTab(), causes
tabs to open before Target#createTarget() gets time to install an
listener for a new target.
Since targets are created on the TabOpen event, we must install the
listener before we open the tab. This has the consequence that we
cannot reliably tell where the first target that connects comes from.
For this reason, this makes a functional change to return an error
if such an eventuality should arise.
This patch fixes the failing remote/test/browser/browser_target.js
browser-chrome test.
Differential Revision: https://phabricator.services.mozilla.com/D28492
--HG--
extra : moz-landing-system : lando
We were waiting for a condition which in beta would not be true. All other waitForCondition in this file should be future-proof.
Differential Revision: https://phabricator.services.mozilla.com/D28088
--HG--
extra : moz-landing-system : lando
The one optimization introduced by this is the rearrangement of branches to
prefer fallthrough whenever possible, as well as folding branches when
comparing against 0. See also
https://github.com/CraneStation/cranelift/pull/629 for details.
Differential Revision: https://phabricator.services.mozilla.com/D28512
--HG--
extra : rebase_source : f0d765a1cb1e2f7872037c18b9951077a08ae4b7
extra : histedit_source : 1a1dd95618e166705f7165c045f3b5af12f96d5b
MachineStackTracker::setGCPointer claims in a comment that its argument
`offsetFromSP` is an index up from the lowest address denoted by the stack
map. It implements that consistently with the comment.
MachineStackTracker::isGCPointer makes the same claim in a comment, but
actually implements the indexing in the opposite direction.
This patch:
* inverts the indexing direction of ::isGCPointer, making it consistent with
the comments and with ::setGCPointer
* changes the one-and-only use point of ::isGCPointer, in createStackMap(),
accordingly. Rather than change the argument to ::isGCPointer, the
iteration direction of the containing loop is inverted, since that fits
better with the surrounding code.
Differential Revision: https://phabricator.services.mozilla.com/D28594
--HG--
extra : rebase_source : 43d146d097fc44cda2e06e5ed30b6babe5d419eb
Gating that explicitly lists the architectures that are supported
is more resilient than one that lists architectures that are not.
Differential Revision: https://phabricator.services.mozilla.com/D28447
--HG--
extra : rebase_source : f80372c2c5ef1b6b31b69a493f3ea8e1426327ab
extra : amend_source : 5ff1ff04b0ad9bbfd175655c4bf007a34d0a755e
