Once networking starts tearing down, our attempts to use XHR to send pings
will fail. This might contibute to high intermittent send failures reported
in the wild. So let's not even try.
But, let's be sure to mention when we decide not to try so we can ensure the
numbers line up before and after.
MozReview-Commit-ID: 71QGM7Xk5oc
--HG--
extra : rebase_source : facce8fd8d8abda3566551cad3cd90abdb3b6c3d
This converts the majority of tests to the newer Async APIs. Some tests that are designed to only test the old APIs are moved to /legacy/,
these either have duplicate tests already existing, or no comparable test required.
MozReview-Commit-ID: HAjtK6hBhJJ
--HG--
rename : toolkit/components/places/tests/unit/test_418643_removeFolderChildren.js => toolkit/components/places/tests/legacy/test_418643_removeFolderChildren.js
rename : toolkit/components/places/tests/unit/test_bookmarks_setNullTitle.js => toolkit/components/places/tests/legacy/test_bookmarks_setNullTitle.js
rename : toolkit/components/places/tests/unit/test_placesTxn.js => toolkit/components/places/tests/legacy/test_placesTxn.js
extra : rebase_source : d0a4f80eaa211df9090027bd7838385b1c1eaed4
In order to optionally report the full hash back to Google, we need to keep it
around in the callback. While a prefix is not the same as a full hash (multiple
full hashes can map to the same prefix), in this case, the callback will only be
called when the full hash matches.
MozReview-Commit-ID: F4WSLZpYrXB
--HG--
extra : rebase_source : da3b16b00729d0aa6ff1765a135b751fcf44c012
This patch merges nsAtom into nsIAtom. For the moment, both names can be used
interchangeably due to a typedef. The patch also devirtualizes nsIAtom, by
making it not inherit from nsISupports, removing NS_DECL_NSIATOM, and dropping
the use of NS_IMETHOD_. It also removes nsIAtom's IIDs.
These changes trigger knock-on changes throughout the codebase, changing the
types of lots of things as follows.
- nsCOMPtr<nsIAtom> --> RefPtr<nsIAtom>
- nsCOMArray<nsIAtom> --> nsTArray<RefPtr<nsIAtom>>
- Count() --> Length()
- ObjectAt() --> ElementAt()
- AppendObject() --> AppendElement()
- RemoveObjectAt() --> RemoveElementAt()
- ns*Hashtable<nsISupportsHashKey, ...> -->
ns*Hashtable<nsRefPtrHashKey<nsIAtom>, ...>
- nsInterfaceHashtable<T, nsIAtom> --> nsRefPtrHashtable<T, nsIAtom>
- This requires adding a Get() method to nsRefPtrHashtable that it lacks but
nsInterfaceHashtable has.
- nsCOMPtr<nsIMutableArray> --> nsTArray<RefPtr<nsIAtom>>
- nsArrayBase::Create() --> nsTArray()
- GetLength() --> Length()
- do_QueryElementAt() --> operator[]
The patch also has some changes to Rust code that manipulates nsIAtom.
MozReview-Commit-ID: DykOl8aEnUJ
--HG--
extra : rebase_source : 254404e318e94b4c93ec8d4081ff0f0fda8aa7d1
The VIDEO_CAN_CREATE_{AAC,H264}_DECODER telemetry expired in 58, but is still
useful I think as a gauge of how support for proprietary formats is changing
over time, and how ubiquitous support is on Windows N and K/N variants. So I
think we should extend its life.
MozReview-Commit-ID: FnnLtcVdqaZ
--HG--
extra : rebase_source : 7cab61447931af6233a3c4c92662bdc54ebe0564
This lets us use 8-bit string literals for lots of filename extensions, and
also avoids two uses of NS_ConvertUTF16toUTF8.
--HG--
extra : rebase_source : 696469984d0b72be6b343713556d109fbcbbed26
This patch limits the amount of chars we hash and avoids some string copies.
MozReview-Commit-ID: AAcLtTzrYlb
--HG--
extra : rebase_source : 760c0899da9cd5bc5c640be030de20865a45ca98
Because nsAString is nicer to work with than char16_t*. The patch relatedly
changes nsIEmbeddingSiteWindow::title and nsIWindowMediator::updateWindowTitle
as well.
--HG--
extra : rebase_source : 0bf332dec3e09af6c39c676f8795b368768a6046
The NS_LITERAL_STRING macro creates a temporary nsLiteralString to encapsulate the char16_t string literal and its length, but AssignLiteral() can determine the char16_t string literal's length at compile-time without nsLiteralString.
MozReview-Commit-ID: L9UE3gXHG4Q
--HG--
extra : source : 37d74bf745b23542251cc6b021d6aabb5ffadea1
extra : intermediate-source : 0402b4bd34c293b44c76de22418899420c8e405b
The NS_LITERAL_STRING macro creates a temporary nsLiteralString to encapsulate the char16_t string literal and its length, but AssignLiteral() can determine the char16_t string literal's length at compile-time without nsLiteralString.
MozReview-Commit-ID: H9I6vNDMdIr
--HG--
extra : rebase_source : cf537a1f65af003c6c4f8919b925b0f305c1dd4d
extra : source : 13b89ce4e6a66c840f82a335c71f5a12938aba22
The NS_LITERAL_CSTRING macro creates a temporary nsLiteralCString to encapsulate the string literal and its length, but AssignLiteral() can determine the string literal's length at compile-time without nsLiteralCString.
MozReview-Commit-ID: B5Y8KyExPQ8
--HG--
extra : rebase_source : e27b266c145daa5acd887e998c6d5b408101e1db
extra : source : 33f49977a33cbdb1c7127871b940eefccc018f65
The NS_LITERAL_CSTRING macro creates a temporary nsLiteralCString to encapsulate the string literal and its length, but AssignLiteral() can determine the string literal's length at compile-time without nsLiteralCString.
MozReview-Commit-ID: F750v6NN81s
--HG--
extra : rebase_source : 714dd78df0f4c33e23e5b117615bd8fd561674c5
extra : source : 742bda9e6b1ddaf34d09894204ad18ce798b79b7
The NS_LITERAL_CSTRING macro creates a temporary nsLiteralCString to encapsulate the string literal and its length, but AssignLiteral() can determine the string literal's length at compile-time without nsLiteralCString.
MozReview-Commit-ID: KXJM13VRTB7
--HG--
extra : rebase_source : 3e50b1b3f23248d668d15310554559c39ff792f7
extra : source : 74f5e05877d50a79ec1e5330c227d2ce576a2d90
XPCOM's string API doesn't have the notion of a "null string". But it does have
the notion of a "void string" (or "voided string"), and that's what these
functions are returning. So the names should reflect that.
--HG--
extra : rebase_source : 4e3f982e0873877174a08a25413595ff66f7d20e
This includes minor shutdown fixes by :asuth as discussed on
https://bugzilla.mozilla.org/show_bug.cgi?id=1047098#c56 and c57.
--HG--
extra : rebase_source : d1a230cc005b2a6a71f16ef84a55851ee2f4f66e
extra : source : e89d2565799b4b02d5ee2c56da8d44dc0067f26a
This patch covers two cases when loading a favicon:
1. Get the request context ID of the document load group, when <link rel="icon"> is found in the page.
2. Use the top level document's request context ID when using the default favicon.
nsIHandleReportCallback, typedef of nsIMemoryReporterCallback, has been the
preferred name for a long time and is used in most places. This patch removes
nsIMemoryReporterCallback.
--HG--
extra : rebase_source : c675076b4f98d93d96235dad890e31e0b0e6c277
Vendor new dependency for compare-locales, python-fluent.
This is the 0.4.2 release of python-fluent.
Also, make mach command a bare minimum wrapper.
The compare-locales mach command used to own a couple of defaults
and opinions.
Now that those opinions and defaults are in the Makefiles, this
command can be much simpler. As a side effect, this should
make the thunderbird port easier, where none of the mach defaults
worked.
Update l10n.mk for compare-locales 2.x:
The command line interface is different now, with positional arguments.
Also, the l10n config file isn't a default anymore (that never worked
for thunderbird).
And the merge dir is now the parent of the locale dir, much like
we already anticipated in the code.
MozReview-Commit-ID: DxVVKyVSt5y
--HG--
extra : rebase_source : 7c591fea8c7d9ecef615fb56f9359d4f1bd4b340
The runtime type-checking rewrite of nsTextFormatter will not support
va_list uses. So, make these functions private and fix the sole user.
MozReview-Commit-ID: IBWALVzIcHC
--HG--
extra : rebase_source : a822697c81c1a054359fc2ecd894d51f95686548
* Remove transparency from the menu icons and labels in Normal state.
* Adding Firefox Support's hover state.
* Make the size of radio buttons as 20x20 px.
* Make minimum width of action buttons as 150px.
* Fix margin issues of When Nightly starts and Nightly Updates sections.
MozReview-Commit-ID: DHwdKTO1wxM
--HG--
extra : rebase_source : b5c93b8ef930dead9c6f194b14ed6dfcff39ecd6
TelemetrySession schedules some activities on idle, to avoid hogging resources.
Sometimes we're forced to handle these situations on a more rigid timeline than
"wait for idle". In those cases we should cancel the idle timeout so it doesn't
double-perform the operations.
Unfortunately idleDispatchToMainThread doesn't have a cancel mechanism, so we
need to bolt one over it.
MozReview-Commit-ID: JpUfb9rK2Od
--HG--
extra : rebase_source : 61489afa749e8b7fe038495ab5bc0d7d70bd6a0e
This patch makes sure |_updateSettings| carries over the attribution code,
if present. Without this patch the whole "environment.settings" section
is replaced and the attribution code disppears after the first environment
change/subsession split.
MozReview-Commit-ID: 8bxjVOl2mUp
--HG--
extra : rebase_source : c611d9148fc734ac5cb751fee8b86bad4550f11b
