Commit Graph

926 Commits

Author SHA1 Message Date
Kris Maglione
ef02b3cbd8 Bug 1568035: Part 1 - Skip tests which cause shutdown leaks under Fission. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D39459

--HG--
extra : rebase_source : 594e7c17a8aa81f9b212ff1fa492a8ab8f40d5ee
2019-07-19 15:31:16 -07:00
Nicholas Nethercote
18fae65f38 Bug 1563139 - Remove StaticPrefs.h. r=glandium
This requires replacing inclusions of it with inclusions of more specific prefs
files.

The exception is that StaticPrefsAll.h, which is equivalent to StaticPrefs.h,
and is used in `Codegen.py` because doing something smarter is tricky and
suitable for a follow-up. As a result, any change to StaticPrefList.yaml will
still trigger recompilation of all the generated DOM bindings files, but that's
still a big improvement over trigger recompilation of every file that uses
static prefs.

Most of the changes in this commit are very boring. The only changes that are
not boring are modules/libpref/*, Codegen.py, and ServoBindings.toml.

Differential Revision: https://phabricator.services.mozilla.com/D39138

--HG--
extra : moz-landing-system : lando
2019-07-26 01:10:23 +00:00
Kris Maglione
e40b418215 Bug 1566952: Part 2 - Update Fission failure annotations after skipping crashes. r=mccr8
When a test crashes, the harness skips all of the remaining tests in the
directory. That means that with crashes skipped, we now try to run a whole lot
more tests than we did before, and a lot of them fail under Fission.

This patch adds annotations to the new failures that show up after part 1.

Differential Revision: https://phabricator.services.mozilla.com/D38726

--HG--
extra : rebase_source : 292157039c88fc615f5de41679e96e72766ac4db
2019-07-19 12:30:10 -07:00
Kris Maglione
4bd4d680d4 Bug 1566952: Part 1 - Annotate mochitests that crash with Fission enabled. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D38725

--HG--
extra : rebase_source : 3e8b32b86b12b22d038baa770070a5c8095043c9
2019-07-17 13:37:48 -07:00
Kris Maglione
0962c2b731 Bug 1566182: Annotate mochitests that fail with Fission enabled. r=mccr8
My preference was to annotate most of the failing tests with `fail-if` so that
if they start passing, the `fail-if` needs to be removed and they need to keep
passing. That doesn't work for tests that timeout, or which trigger failures
from their cleanup functions, however, so those tests need skip-if. And tests
with fail in their cleanup functions likely leave the browser in an
inconsistent state for subsequent tests, anyway, so really should be skipped
regardless.

There are some remaining tests which still fail because of crashes. I chose
not to skip them here, but to fix the crashes in separate bugs instead.

Differential Revision: https://phabricator.services.mozilla.com/D38247

--HG--
extra : rebase_source : 39ba8fec2e882cfe577c5f2b58ab7e4b461f1178
2019-07-15 16:19:32 -07:00
Jonathan Kingston
31441f82ea Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D35504

--HG--
extra : moz-landing-system : lando
2019-07-08 16:37:45 +00:00
Victor Porof
2c53a5dcd9 Bug 1561435 - Format netwerk/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35919

--HG--
extra : source : afa5bd771feba466ba7670c58f3d93233a14e202
2019-07-05 10:55:23 +02:00
Andrea Marchesini
1cb27e6f3a Bug 1561210 - Pass samesite-none-secure WPTs, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D35762

--HG--
extra : moz-landing-system : lando
2019-07-03 18:18:27 +00:00
Masatoshi Kimura
ab5fd5b6f9 Bug 1410013 - Change aValue parameter of nsICookieManager.add to AUTF8String to align with nsICookie change. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D35150

--HG--
extra : moz-landing-system : lando
2019-06-17 20:48:30 +00:00
Andrea Marchesini
3b60357ed6 Bug 1551798 - nsICookie.sameSite should return rawSameSite if lax-by-default pref is set to false, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D33305

--HG--
extra : moz-landing-system : lando
2019-06-05 12:20:05 +00:00
Andrea Marchesini
0434ad7ecb Bug 1551798 - Test for cookie migration 10, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32483

--HG--
extra : moz-landing-system : lando
2019-06-05 12:19:56 +00:00
Andrea Marchesini
382a3aa030 Bug 1551798 - Store sameSite value as received from the wire in the database - migration 10, r=Ehsan,robwu
Differential Revision: https://phabricator.services.mozilla.com/D32482

--HG--
extra : moz-landing-system : lando
2019-06-05 12:19:54 +00:00
Andrea Marchesini
228b3afe31 Bug 1551798 - SameSite=lax by default and SameSite=none only if secure, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D31215

--HG--
extra : moz-landing-system : lando
2019-06-05 12:18:52 +00:00
Andrea Marchesini
176b3f8e39 Bug 1556419 - cookie path should not contain the last '/', r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D33500

--HG--
extra : moz-landing-system : lando
2019-06-04 02:42:57 +00:00
Andrea Marchesini
0a9fe4ff98 Bug 1553867 - Reduce the number of ClonePrincipalForPermission() call in CookieSettings, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32364

--HG--
extra : moz-landing-system : lando
2019-06-03 11:14:38 +00:00
Ehsan Akhgari
d74c1d4a0f Bug 1555846 - Block cookies from trackers with dynamic FPI; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D33227

--HG--
extra : moz-landing-system : lando
2019-05-31 14:33:36 +00:00
Dorel Luca
5a3296d55a Backed out changeset 910f7703f9f3 (bug 1555846) for Build bustages. CLOSED TREE 2019-05-31 17:24:43 +03:00
Ehsan Akhgari
62aa7c0ec3 Bug 1555846 - Block cookies from trackers with dynamic FPI; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D33227

--HG--
extra : moz-landing-system : lando
2019-05-31 06:14:14 +00:00
Andrea Marchesini
aa84d3c812 Bug 1436674 - nsICookieService.idl should use ACString XPIDL type in place of the string type, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32662

--HG--
extra : moz-landing-system : lando
2019-05-31 09:36:44 +00:00
Andrea Marchesini
b1b122fb20 Bug 1554464 - Merge nsICookie2 and nsICookie in 1 single interface, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D33031

--HG--
extra : moz-landing-system : lando
2019-05-31 09:36:44 +00:00
Andrea Marchesini
68fbe6f8ca Bug 1554377 - Cleanup nsCookie implementation - Removed mIPCOpen, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32616

--HG--
extra : moz-landing-system : lando
2019-05-31 09:32:51 +00:00
Andrea Marchesini
fd927a96aa Bug 1554377 - Cleanup nsCookie implementation - network_cookie_thirdparty_nonsecureSessionOnly to StaticPrefs, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32615

--HG--
extra : moz-landing-system : lando
2019-05-31 09:32:33 +00:00
Andrea Marchesini
1040f3de6a Bug 1554377 - Cleanup nsCookie implementation - network.cookie.thirdparty.sessionOnly to StaticPrefs, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32614

--HG--
extra : moz-landing-system : lando
2019-05-31 09:32:13 +00:00
Andrea Marchesini
ff8aaf2236 Bug 1554377 - Cleanup nsCookie implementation - simpler nsCookie, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32562

--HG--
extra : moz-landing-system : lando
2019-05-31 09:31:47 +00:00
Andrea Marchesini
8bcf905e12 Bug 1554377 - Cleanup nsCookie implementation - Get rid of nsCookieAttributes, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32561

--HG--
extra : moz-landing-system : lando
2019-05-31 09:31:30 +00:00
Andrea Marchesini
a1e12567f6 Bug 1554377 - Cleanup nsCookie implementation - Get rid of ConstCookie, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32560

--HG--
extra : moz-landing-system : lando
2019-05-31 09:31:12 +00:00
Csoregi Natalia
a51ae3670f Backed out 5 changesets (bug 1551798) for failures on test_rawSameSite.js. CLOSED TREE
Backed out changeset 11ddc433b632 (bug 1551798)
Backed out changeset f2ac8efb023d (bug 1551798)
Backed out changeset 0f6e797b434f (bug 1551798)
Backed out changeset eae7f88660c8 (bug 1551798)
Backed out changeset 2ba747afb3d0 (bug 1551798)
2019-05-30 10:17:01 +03:00
Andrea Marchesini
ef73f6105f Bug 1551798 - Add comments about the next removing patches, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D33037

--HG--
extra : moz-landing-system : lando
2019-05-29 16:34:27 +00:00
Andrea Marchesini
d513a67ed4 Bug 1551798 - Test for cookie migration 10, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32483

--HG--
extra : moz-landing-system : lando
2019-05-29 15:56:22 +00:00
Andrea Marchesini
84e139e50b Bug 1551798 - Store sameSite value as received from the wire in the database - migration 10, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32482

--HG--
extra : moz-landing-system : lando
2019-05-29 16:34:33 +00:00
Andrea Marchesini
ae8ab513d8 Bug 1551798 - SameSite=lax by default and SameSite=none only if secure, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D31215

--HG--
extra : moz-landing-system : lando
2019-05-30 00:48:41 +00:00
Andrea Marchesini
4c6ace6ac6 Bug 1551798 - Rename nsICookie2.SAMESITE_UNSET to nsICookie2.SAMESITE_NONE, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D31214

--HG--
extra : moz-landing-system : lando
2019-05-29 15:55:03 +00:00
arthur.iakab
944263f18a Backed out 5 changesets (bug 1551798) for multiple build bustages on StaticPrefList.h CLOSED TREE
Backed out changeset c89daff34d97 (bug 1551798)
Backed out changeset bbc3f88b8c03 (bug 1551798)
Backed out changeset b87996b8a411 (bug 1551798)
Backed out changeset d88b0002d736 (bug 1551798)
Backed out changeset 0fe740c90e2b (bug 1551798)
2019-05-29 18:07:26 +03:00
Andrea Marchesini
08c8aa4d6d Bug 1551798 - Test for cookie migration 10, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32483

--HG--
extra : moz-landing-system : lando
2019-05-27 01:46:11 +00:00
Andrea Marchesini
d5fdfc9e8c Bug 1551798 - Store sameSite value as received from the wire in the database - migration 10, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32482

--HG--
extra : moz-landing-system : lando
2019-05-27 05:11:54 +00:00
Andrea Marchesini
7a79f55da4 Bug 1551798 - SameSite=lax by default and SameSite=none only if secure, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D31215

--HG--
extra : moz-landing-system : lando
2019-05-24 15:44:00 +00:00
Andrea Marchesini
e9bbb85ed1 Bug 1551798 - Rename nsICookie2.SAMESITE_UNSET to nsICookie2.SAMESITE_NONE, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D31214

--HG--
extra : moz-landing-system : lando
2019-05-24 15:18:49 +00:00
Cosmin Sabou
482c1fdb41 Backed out 2 changesets (bug 1554527, bug 1553867) as requested by Sylvestre for causing huge perf regressions. a=backout
Backed out changeset 1e85291f97de (bug 1554527)
Backed out changeset daf113171d63 (bug 1553867)
2019-05-29 09:57:29 +03:00
Andrea Marchesini
4bbb03b93b Bug 1554527 - Clone the principal for permission checks in CookieSettings only if needed, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32660

--HG--
extra : moz-landing-system : lando
2019-05-27 13:45:42 +00:00
Andrea Marchesini
67e56bf7fb Bug 1191313 - Get rid of third-party-cookie-accepted and third-party-cookie-rejected notifications, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32665

--HG--
extra : moz-landing-system : lando
2019-05-27 13:27:47 +00:00
Andrea Marchesini
c355651b11 Bug 1416657 - Avoid calling IsThirdPartyChannel() with a nullptr channel in nsCookieService, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32672

--HG--
extra : moz-landing-system : lando
2019-05-27 13:25:12 +00:00
Andrea Marchesini
1f043863ca Bug 1554138 - nsCookie::Create should return an already_AddRef<> instead of a raw pointer, r=Ehsan
Depends on D32461

Differential Revision: https://phabricator.services.mozilla.com/D32462

--HG--
extra : moz-landing-system : lando
2019-05-25 01:32:24 +00:00
Ehsan Akhgari
a5fe850945 Bug 1547813 - Part 9: Ensure the cookie service does third-party checks when the cookie policy is set to nsICookieService::BEHAVIOR_REJECT_TRACKER_AND_PARTITION_FOREIGN; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D30118

--HG--
extra : moz-landing-system : lando
2019-05-25 01:25:46 +00:00
Ehsan Akhgari
70dba3be94 Bug 1547813 - Part 8: Introduce a CookieSettings API to query whether cookies from third-party trackers must be rejected and use it in Gecko; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D30117

--HG--
extra : moz-landing-system : lando
2019-05-25 01:25:43 +00:00
Ehsan Akhgari
ab20502fb9 Bug 1547813 - Part 7: Introduce a storage partitioning API; r=baku
This API abstracts away the details of the decision on what context should be
partitioned away from the consumers and centralizes the decision making into
the same location in the code base.

Differential Revision: https://phabricator.services.mozilla.com/D29742

--HG--
extra : moz-landing-system : lando
2019-05-25 01:25:41 +00:00
Ehsan Akhgari
e2a2c24b6e Bug 1547813 - Part 1: Introduce nsICookieService::BEHAVIOR_REJECT_TRACKER_AND_PARTITION_FOREIGN; r=baku
This new code designates our new cookie policy for blocking cookies and
storage access from third-party trackers and partitioning the cookie jar
of the rest of third-party resources.

Differential Revision: https://phabricator.services.mozilla.com/D29736

--HG--
extra : moz-landing-system : lando
2019-05-25 01:25:23 +00:00
Andrea Marchesini
c926d65d2f Bug 1553867 - Reduce the number of ClonePrincipalForPermission() call in CookieSettings, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32364

--HG--
extra : moz-landing-system : lando
2019-05-24 19:05:35 +00:00
Andrea Marchesini
52816e049d Bug 1554137 - nsICookie and nsICookie2 should be builtinclass interfaces, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32461

--HG--
extra : moz-landing-system : lando
2019-05-24 17:01:21 +00:00
Sylvestre Ledru
993c03acb1 Bug 1552795 - Remove all trailing whitespaces in idl files r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D31769

--HG--
extra : moz-landing-system : lando
2019-05-22 22:37:14 +00:00
Andrea Marchesini
7b8a38ee05 Bug 1551729 - Revert bug 1548432 - Re-introducing the support for cookies without values, r=mayhemer
This patch reverts the second part of bug 1548432.

Differential Revision: https://phabricator.services.mozilla.com/D31267

--HG--
extra : moz-landing-system : lando
2019-05-22 06:31:22 +00:00