Commit Graph

7991 Commits

Author SHA1 Message Date
Brendan Dahl
247b257cfa Bug 1470510 - Rename nsXULWindow and nsIXULWindow to AppWindow and nsIAppWindow. r=smaug
nsXULWindow is no longer XUL specific and is somewhat confusing name.

Differential Revision: https://phabricator.services.mozilla.com/D51486

--HG--
rename : xpfe/appshell/nsXULWindow.cpp => xpfe/appshell/AppWindow.cpp
rename : xpfe/appshell/nsXULWindow.h => xpfe/appshell/AppWindow.h
rename : xpfe/appshell/nsIXULWindow.idl => xpfe/appshell/nsIAppWindow.idl
extra : moz-landing-system : lando
2019-11-04 16:52:35 +00:00
James Teh
18ef8b89a3 Bug 1590929: a11y::TraversalRule::Match: Don't assume that all Accessibles have a frame. r=MarcoZ
I don't have a test case for this crash, but the stack suggests the frame is null.
This can certainly happen for display: contents.

Differential Revision: https://phabricator.services.mozilla.com/D51560

--HG--
extra : moz-landing-system : lando
2019-11-04 07:04:40 +00:00
Edgar Chen
acd2114113 Bug 1580491 - Use Element::HasNonEmptyAttr in various places; r=bzbarsky
This was done by reviewing the results of
https://searchfox.org/mozilla-central/search?q=%2F*GetAttr%5C(.%2B(%26%26%7C%5C%7C%5C%7C)&case=true&regexp=true
one by one and replacing them with Element::HasNonEmptyAttr if possible.

Differential Revision: https://phabricator.services.mozilla.com/D51241

--HG--
extra : moz-landing-system : lando
2019-11-01 15:24:25 +00:00
Yura Zenevich
7c914dd2e8 Bug 1543575 - add coverage for bounds b-c tests with fission enabled. r=Jamie
Depends on D51144

Differential Revision: https://phabricator.services.mozilla.com/D51152

--HG--
extra : moz-landing-system : lando
2019-10-31 00:10:03 +00:00
Yura Zenevich
4a00d94bad Bug 1543575 - add missing resources to browser.ini files to be able to run b-c a11y tests independently. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D51144

--HG--
extra : moz-landing-system : lando
2019-10-31 00:07:58 +00:00
Ehsan Akhgari
5b7ceaf11d Bug 1528115 - Remove support for the hidden private window; r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D51099

--HG--
extra : moz-landing-system : lando
2019-10-30 15:35:31 +00:00
James Teh
7d0494adc2 Bug 1585851: When processing a11y insertions, don't try to move an accessible if its new previous sibling hasn't been moved into its new container yet. r=MarcoZ
Sometimes, depending on how children were changed, children might be in the insertion list out of order; e.g. [child2, child1].
It's also possible that an earlier child (child1 in the above example) is being moved out of another container.
When processing the earlier insertion (child2), we'll determine we need to move it within its parent and will fetch its new previous sibling so we can move it into the right place.
However, in this case, the new previous sibling (child1) will be in the wrong container.
We can't move in that case; the new previous sibling's index in parent will obviously be wrong, since it's relative to the wrong container.
Therefore, we just skip the move.
Since the previous sibling (child1) is later in the insertion list, the ordering will be corrected when we process that insertion.

Differential Revision: https://phabricator.services.mozilla.com/D51037

--HG--
extra : moz-landing-system : lando
2019-10-30 06:32:50 +00:00
James Teh
7dfabe9989 Bug 1415667: Always use OuterDocAccessible for iframes, even if an ARIA table role is specified. r=yzen
OuterDocAccessible has some special behaviour.
We really shouldn't try to use some other class for iframes.
Anyway, making an iframe part of an ARIA table won't work for other reasons, plus I'm not sure it makes much sense.

Differential Revision: https://phabricator.services.mozilla.com/D50769

--HG--
extra : moz-landing-system : lando
2019-10-29 14:26:49 +00:00
Kirk Steuber
047d40ee73 Bug 1584283 - Stop using xul:wizard as a root element and migrate consumers to xul:window[role=dialog] with the wizard as the only child r=surkov. On a CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D48922

--HG--
extra : source : 01007f3333ea182c83bced4ff750c96b22925e80
extra : amend_source : 3b06af7be6009d6bd94798e14f30a2550f1c4c4f
extra : histedit_source : be50ba403a84dda5af1c902438c918c17a971578
2019-10-17 21:25:53 +00:00
Dorel Luca
659e2d2335 Backed out changeset 01007f3333ea (bug 1584283) for Browser-chrome failures in widget/tests/browser/browser_test_procinfo.js 2019-10-23 03:23:24 +03:00
Kirk Steuber
e937081418 Bug 1584283 - Stop using xul:wizard as a root element and migrate consumers to xul:window[role=dialog] with the wizard as the only child r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D48922

--HG--
extra : moz-landing-system : lando
2019-10-17 21:25:53 +00:00
Emilio Cobos Álvarez
602ba56e1f Bug 1590366 - Remove accessibility.heading-element-level-changes.enabled. r=MarcoZ
Well that was short :D

Differential Revision: https://phabricator.services.mozilla.com/D50047

--HG--
extra : moz-landing-system : lando
2019-10-22 13:51:41 +00:00
Sylvestre Ledru
7c309095ea Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
Please note that it is the first reformat with clang-format 9
I only saw a fix in the .mm file

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D49056

--HG--
extra : moz-landing-system : lando
2019-10-21 14:13:44 +00:00
Marco Bonardo
9105b2fe51 Bug 1587959 - The userSelectionBehavior property of the urlbar controller may get stale and confuse a11y. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D49725

--HG--
extra : moz-landing-system : lando
2019-10-18 15:55:54 +00:00
Harry Twyford
6c24ba64b2 Bug 1578445 - Add roles and aria attributes to tip elements. r=dao,fluent-reviewers,Gijs,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D47980

--HG--
extra : moz-landing-system : lando
2019-10-17 17:46:01 +00:00
Yura Zenevich
c8dd78f635 Bug 1543575 - add fission coverage for accessibility b-c e10s tree update tests. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D48552

--HG--
extra : rebase_source : d674efca44b5a6d11dbc371f3866d8dc87ab3ba4
extra : source : 2dbafadffbd9114592c927136992571d57b86bae
2019-10-17 15:15:18 +00:00
Yura Zenevich
fcf58d51e6 Bug 1543575 - add fission coverage for accessibility b-c e10s caching tests. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D48551

--HG--
extra : rebase_source : 581fb8be517742e482dca807a10ed483b2ff78db
extra : source : 8b92e98ee616c5a0e9d33d91d4bab5ea3209fe45
2019-10-17 15:15:09 +00:00
Yura Zenevich
ede444df5b Bug 1543575 - add fission coverage for accessibility b-c e10s event tests. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D48550

--HG--
extra : rebase_source : 99ab9d1b956a17dbd1d302ad9414885057bc4c90
extra : source : d7d27d08162d32b6b1c8fd048f918b50d40eabd6
2019-10-17 15:15:00 +00:00
Yura Zenevich
ac9730e94b Bug 1543575 - provide an option for running accessibility browser chrome e10s tests in fission process. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D48549

--HG--
extra : rebase_source : 3e1061d9a4d41b55421d56456ba08febc09cb445
extra : source : 5b54e1361ca15904a429cc0da84d886b2567b3a6
2019-10-17 15:14:50 +00:00
Yura Zenevich
de89df5cc3 Bug 1543575 - stop using ContentTask across accessible/ browser chrome tests. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D47387

--HG--
extra : rebase_source : bb1618e0b351f48da2750a93c9f46842d79f2cbd
extra : source : 5e5a6ce39829f7a176fa2de181db7cef60534522
2019-10-17 15:14:41 +00:00
Yura Zenevich
7ad8ffc6bb Bug 1543575 - stop using frame scripts across accessible/ browser chrome tests. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D47386

--HG--
extra : rebase_source : 2b8af3317a182b5710a7e7dd61241503f2958285
extra : source : 472cbb99f5ceb3b466c393c0c5a40753dcec79ff
2019-10-17 15:14:34 +00:00
Dorel Luca
d08ef1bec1 Backed out 6 changesets (bug 1543575) for Mochitest failures in toolkit/content/tests/chrome/test_popup_button.xul. CLOSED TREE
Backed out changeset 2dbafadffbd9 (bug 1543575)
Backed out changeset 8b92e98ee616 (bug 1543575)
Backed out changeset d7d27d08162d (bug 1543575)
Backed out changeset 5b54e1361ca1 (bug 1543575)
Backed out changeset 5e5a6ce39829 (bug 1543575)
Backed out changeset 472cbb99f5ce (bug 1543575)
2019-10-17 23:18:13 +03:00
Yura Zenevich
4418b7b6c7 Bug 1543575 - add fission coverage for accessibility b-c e10s tree update tests. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D48552

--HG--
extra : moz-landing-system : lando
2019-10-17 15:15:18 +00:00
Yura Zenevich
5ee679c147 Bug 1543575 - add fission coverage for accessibility b-c e10s caching tests. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D48551

--HG--
extra : moz-landing-system : lando
2019-10-17 15:15:09 +00:00
Yura Zenevich
f8c46981a4 Bug 1543575 - add fission coverage for accessibility b-c e10s event tests. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D48550

--HG--
extra : moz-landing-system : lando
2019-10-17 15:15:00 +00:00
Yura Zenevich
08b6f8ee1e Bug 1543575 - provide an option for running accessibility browser chrome e10s tests in fission process. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D48549

--HG--
extra : moz-landing-system : lando
2019-10-17 15:14:50 +00:00
Yura Zenevich
85544e7033 Bug 1543575 - stop using ContentTask across accessible/ browser chrome tests. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D47387

--HG--
extra : moz-landing-system : lando
2019-10-17 15:14:41 +00:00
Yura Zenevich
beb9aa4e5f Bug 1543575 - stop using frame scripts across accessible/ browser chrome tests. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D47386

--HG--
extra : moz-landing-system : lando
2019-10-17 15:14:34 +00:00
Coroiu Cristina
34a649cd21 Backed out changeset 8c0ed99d462c (bug 1578445) for browser-chrome failures at browser/modules/test/browser/browser_UsageTelemetry_urlbar_tip.js on a CLOSED TREE 2019-10-17 20:29:23 +03:00
Harry Twyford
8347b171c4 Bug 1578445 - Add roles and aria attributes to tip elements. r=dao,fluent-reviewers,Gijs,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D47980

--HG--
extra : moz-landing-system : lando
2019-10-17 16:49:38 +00:00
Morgan Reschenberg
1b8dfbb609 Bug 1579633: Update menu role, HTML spec tests. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D49314

--HG--
extra : moz-landing-system : lando
2019-10-17 15:45:27 +00:00
Oana Pop Rus
e0fb2f2a1e Backed out changeset 62d172103a78 (bug 1578445) for bc failures in browser/browser_ext_urlbar.js on a CLOSED TREE 2019-10-17 17:28:29 +03:00
Harry Twyford
07dd6769fb Bug 1578445 - Add roles and aria attributes to tip elements. r=dao,fluent-reviewers,Gijs,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D47980

--HG--
extra : moz-landing-system : lando
2019-10-17 10:48:26 +00:00
Emma Malysz
b806cbda1f Bug 1588918, rename .xul test files in accessible/ to .xhtml r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D49355

--HG--
rename : accessible/tests/browser/states/test_deck_has_out_of_process_iframe.xul => accessible/tests/browser/states/test_deck_has_out_of_process_iframe.xhtml
rename : accessible/tests/crashtests/471493.xul => accessible/tests/crashtests/471493.xhtml
rename : accessible/tests/crashtests/last_test_to_unload_testsuite.xul => accessible/tests/crashtests/last_test_to_unload_testsuite.xhtml
rename : accessible/tests/mochitest/actions/test_general.xul => accessible/tests/mochitest/actions/test_general.xhtml
rename : accessible/tests/mochitest/actions/test_keys_menu.xul => accessible/tests/mochitest/actions/test_keys_menu.xhtml
rename : accessible/tests/mochitest/actions/test_tree.xul => accessible/tests/mochitest/actions/test_tree.xhtml
rename : accessible/tests/mochitest/actions/test_treegrid.xul => accessible/tests/mochitest/actions/test_treegrid.xhtml
rename : accessible/tests/mochitest/attributes/test_obj_css.xul => accessible/tests/mochitest/attributes/test_obj_css.xhtml
rename : accessible/tests/mochitest/attributes/test_obj_group.xul => accessible/tests/mochitest/attributes/test_obj_group.xhtml
rename : accessible/tests/mochitest/attributes/test_obj_group_tree.xul => accessible/tests/mochitest/attributes/test_obj_group_tree.xhtml
rename : accessible/tests/mochitest/elm/test_listbox.xul => accessible/tests/mochitest/elm/test_listbox.xhtml
rename : accessible/tests/mochitest/events/test_focus_autocomplete.xul => accessible/tests/mochitest/events/test_focus_autocomplete.xhtml
rename : accessible/tests/mochitest/events/test_focus_contextmenu.xul => accessible/tests/mochitest/events/test_focus_contextmenu.xhtml
rename : accessible/tests/mochitest/events/test_focus_general.xul => accessible/tests/mochitest/events/test_focus_general.xhtml
rename : accessible/tests/mochitest/events/test_focus_listcontrols.xul => accessible/tests/mochitest/events/test_focus_listcontrols.xhtml
rename : accessible/tests/mochitest/events/test_focus_menu.xul => accessible/tests/mochitest/events/test_focus_menu.xhtml
rename : accessible/tests/mochitest/events/test_focus_tabbox.xul => accessible/tests/mochitest/events/test_focus_tabbox.xhtml
rename : accessible/tests/mochitest/events/test_focus_tree.xul => accessible/tests/mochitest/events/test_focus_tree.xhtml
rename : accessible/tests/mochitest/events/test_label.xul => accessible/tests/mochitest/events/test_label.xhtml
rename : accessible/tests/mochitest/events/test_menu.xul => accessible/tests/mochitest/events/test_menu.xhtml
rename : accessible/tests/mochitest/events/test_namechange.xul => accessible/tests/mochitest/events/test_namechange.xhtml
rename : accessible/tests/mochitest/events/test_scroll.xul => accessible/tests/mochitest/events/test_scroll.xhtml
rename : accessible/tests/mochitest/events/test_scroll_caret.xul => accessible/tests/mochitest/events/test_scroll_caret.xhtml
rename : accessible/tests/mochitest/events/test_selection.xul => accessible/tests/mochitest/events/test_selection.xhtml
rename : accessible/tests/mochitest/events/test_tree.xul => accessible/tests/mochitest/events/test_tree.xhtml
rename : accessible/tests/mochitest/focus/test_focus_radio.xul => accessible/tests/mochitest/focus/test_focus_radio.xhtml
rename : accessible/tests/mochitest/focus/test_takeFocus.xul => accessible/tests/mochitest/focus/test_takeFocus.xhtml
rename : accessible/tests/mochitest/hittest/test_menu.xul => accessible/tests/mochitest/hittest/test_menu.xhtml
rename : accessible/tests/mochitest/hittest/test_zoom_tree.xul => accessible/tests/mochitest/hittest/test_zoom_tree.xhtml
rename : accessible/tests/mochitest/hittest/zoom_tree.xul => accessible/tests/mochitest/hittest/zoom_tree.xhtml
rename : accessible/tests/mochitest/hyperlink/test_general.xul => accessible/tests/mochitest/hyperlink/test_general.xhtml
rename : accessible/tests/mochitest/name/test_browserui.xul => accessible/tests/mochitest/name/test_browserui.xhtml
rename : accessible/tests/mochitest/name/test_general.xul => accessible/tests/mochitest/name/test_general.xhtml
rename : accessible/tests/mochitest/name/test_tree.xul => accessible/tests/mochitest/name/test_tree.xhtml
rename : accessible/tests/mochitest/relations/test_embeds.xul => accessible/tests/mochitest/relations/test_embeds.xhtml
rename : accessible/tests/mochitest/relations/test_general.xul => accessible/tests/mochitest/relations/test_general.xhtml
rename : accessible/tests/mochitest/relations/test_tabbrowser.xul => accessible/tests/mochitest/relations/test_tabbrowser.xhtml
rename : accessible/tests/mochitest/relations/test_tree.xul => accessible/tests/mochitest/relations/test_tree.xhtml
rename : accessible/tests/mochitest/role/test_aria.xul => accessible/tests/mochitest/role/test_aria.xhtml
rename : accessible/tests/mochitest/role/test_general.xul => accessible/tests/mochitest/role/test_general.xhtml
rename : accessible/tests/mochitest/selectable/test_listbox.xul => accessible/tests/mochitest/selectable/test_listbox.xhtml
rename : accessible/tests/mochitest/selectable/test_menu.xul => accessible/tests/mochitest/selectable/test_menu.xhtml
rename : accessible/tests/mochitest/selectable/test_menulist.xul => accessible/tests/mochitest/selectable/test_menulist.xhtml
rename : accessible/tests/mochitest/selectable/test_tabs.xul => accessible/tests/mochitest/selectable/test_tabs.xhtml
rename : accessible/tests/mochitest/selectable/test_tree.xul => accessible/tests/mochitest/selectable/test_tree.xhtml
rename : accessible/tests/mochitest/states/test_aria.xul => accessible/tests/mochitest/states/test_aria.xhtml
rename : accessible/tests/mochitest/states/test_controls.xul => accessible/tests/mochitest/states/test_controls.xhtml
rename : accessible/tests/mochitest/states/test_expandable.xul => accessible/tests/mochitest/states/test_expandable.xhtml
rename : accessible/tests/mochitest/states/test_popup.xul => accessible/tests/mochitest/states/test_popup.xhtml
rename : accessible/tests/mochitest/states/test_tabs.xul => accessible/tests/mochitest/states/test_tabs.xhtml
rename : accessible/tests/mochitest/states/test_textbox.xul => accessible/tests/mochitest/states/test_textbox.xhtml
rename : accessible/tests/mochitest/states/test_tree.xul => accessible/tests/mochitest/states/test_tree.xhtml
rename : accessible/tests/mochitest/states/test_visibility.xul => accessible/tests/mochitest/states/test_visibility.xhtml
rename : accessible/tests/mochitest/table/test_headers_tree.xul => accessible/tests/mochitest/table/test_headers_tree.xhtml
rename : accessible/tests/mochitest/table/test_indexes_tree.xul => accessible/tests/mochitest/table/test_indexes_tree.xhtml
rename : accessible/tests/mochitest/table/test_sels_tree.xul => accessible/tests/mochitest/table/test_sels_tree.xhtml
rename : accessible/tests/mochitest/table/test_struct_tree.xul => accessible/tests/mochitest/table/test_struct_tree.xhtml
rename : accessible/tests/mochitest/text/test_general.xul => accessible/tests/mochitest/text/test_general.xhtml
rename : accessible/tests/mochitest/tree/test_applicationacc.xul => accessible/tests/mochitest/tree/test_applicationacc.xhtml
rename : accessible/tests/mochitest/tree/test_button.xul => accessible/tests/mochitest/tree/test_button.xhtml
rename : accessible/tests/mochitest/tree/test_combobox.xul => accessible/tests/mochitest/tree/test_combobox.xhtml
rename : accessible/tests/mochitest/tree/test_formctrl.xul => accessible/tests/mochitest/tree/test_formctrl.xhtml
rename : accessible/tests/mochitest/tree/test_groupbox.xul => accessible/tests/mochitest/tree/test_groupbox.xhtml
rename : accessible/tests/mochitest/tree/test_image.xul => accessible/tests/mochitest/tree/test_image.xhtml
rename : accessible/tests/mochitest/tree/test_tabbox.xul => accessible/tests/mochitest/tree/test_tabbox.xhtml
rename : accessible/tests/mochitest/tree/test_tabbrowser.xul => accessible/tests/mochitest/tree/test_tabbrowser.xhtml
rename : accessible/tests/mochitest/tree/test_tree.xul => accessible/tests/mochitest/tree/test_tree.xhtml
rename : accessible/tests/mochitest/tree/test_txtctrl.xul => accessible/tests/mochitest/tree/test_txtctrl.xhtml
rename : accessible/tests/mochitest/tree/wnd.xul => accessible/tests/mochitest/tree/wnd.xhtml
rename : accessible/tests/mochitest/treeupdate/test_contextmenu.xul => accessible/tests/mochitest/treeupdate/test_contextmenu.xhtml
rename : accessible/tests/mochitest/treeupdate/test_deck.xul => accessible/tests/mochitest/treeupdate/test_deck.xhtml
rename : accessible/tests/mochitest/treeupdate/test_listbox.xul => accessible/tests/mochitest/treeupdate/test_listbox.xhtml
rename : accessible/tests/mochitest/treeupdate/test_menu.xul => accessible/tests/mochitest/treeupdate/test_menu.xhtml
rename : accessible/tests/mochitest/treeupdate/test_menubutton.xul => accessible/tests/mochitest/treeupdate/test_menubutton.xhtml
rename : accessible/tests/mochitest/treeupdate/test_shutdown.xul => accessible/tests/mochitest/treeupdate/test_shutdown.xhtml
extra : moz-landing-system : lando
2019-10-16 16:59:02 +00:00
Emilio Cobos Álvarez
441f9a401b Bug 998590 - Prototype accessibility level changes for headings behind a pref. r=MarcoZ
I don't think these need invalidation of any sort since they only depend on
ancestors, and we recreate accessibles when the element's ancestor chain changes.

Differential Revision: https://phabricator.services.mozilla.com/D49408

--HG--
extra : moz-landing-system : lando
2019-10-16 12:31:21 +00:00
Emilio Cobos Álvarez
5ffa02e5a8 Bug 998590 - Factor out heading accessibility level into HTMLHeadingElement. r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D49407

--HG--
extra : moz-landing-system : lando
2019-10-16 12:32:10 +00:00
James Teh
cb2f077062 Bug 1577381: Correct accessibility exposure for optgroups in content select dropdowns. r=eeejay,NeilDeakin
For remote content documents, select dropdowns (for <select size="1">) are rendered in the parent process using a XUL menupopup.
This means that the accessibility code for HTML selects doesn't apply.

In the menupopup, the optgroup is a sibling of its contained options.
For accessibility, we want to preserve the hierarchy such that the options are inside the optgroup.
We do this using aria-owns on the optgroup item.

This required some tweaks to XULMenuitemAccessible, as it couldn't previously handle grouping Accessibles between the menupopup and its items.

Differential Revision: https://phabricator.services.mozilla.com/D43901

--HG--
extra : moz-landing-system : lando
2019-10-16 06:10:32 +00:00
Morgan Reschenberg
83d56de89c Bug 1579750: Consider aria role before landmark role for xlm-roles attribute. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D49178

--HG--
extra : moz-landing-system : lando
2019-10-14 21:54:35 +00:00
Morgan Reschenberg
c157ae77f0 Bug 822988: Create HyperTextAccessibleWrap for SVG text objects for correct role assignment. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D49202

--HG--
extra : moz-landing-system : lando
2019-10-14 21:51:58 +00:00
Alexander Surkov
5459de4426 Bug 1587512 - remove XBL dialog support bits; remove XBL support from TreeWalker; update XBL related comments and remove XBL mutation test r=MarcoZ,Jamie
Depends on D48964

Differential Revision: https://phabricator.services.mozilla.com/D48965

--HG--
extra : moz-landing-system : lando
2019-10-14 05:36:10 +00:00
Alexander Surkov
350c642a46 Bug 1587512 - remove nsIXBLAccessible interface r=MarcoZ,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D48964

--HG--
extra : moz-landing-system : lando
2019-10-14 05:40:05 +00:00
James Teh
76247694a7 Bug 1588416: Reinstate the label for the search one-offs container. r=Standard8
The previous code relied on the header label having a value property.
However, after the conversion to Fluent in bug 1563026, this is no longer the case.
Instead, use aria-labelledby, which avoids label duplication and will work irrespective of the label's implementation.

Differential Revision: https://phabricator.services.mozilla.com/D49125

--HG--
extra : moz-landing-system : lando
2019-10-14 12:27:49 +00:00
James Teh
af76f6473c Bug 1585907 part 2: Allow A11yUtils.announce to take a Fluent id. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D49096

--HG--
extra : moz-landing-system : lando
2019-10-14 10:31:26 +00:00
Tim Nguyen
79c7f01c56 Bug 1588066 - Remove remaining references to textbox. r=surkov,emilio,webdriver-reviewers,bgrins,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D48958

--HG--
extra : moz-landing-system : lando
2019-10-14 07:41:35 +00:00
Morgan Reschenberg
5f968ff73a Bug 1557849: Check if a MenuPopupAccessible belongs to a context menu to determine its role assignment. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D48394

--HG--
extra : moz-landing-system : lando
2019-10-10 20:33:29 +00:00
Alexander Surkov
ba43684bbe Bug 1587791 - remove XBL backed accessible relations support r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D48840

--HG--
extra : moz-landing-system : lando
2019-10-10 14:08:17 +00:00
Tim Nguyen
792b820aa5 Bug 1513325 - Remove some a11y tests that no longer apply in a post-XBL world. r=aryx
Differential Revision: https://phabricator.services.mozilla.com/D48701

--HG--
extra : moz-landing-system : lando
2019-10-09 12:45:03 +00:00
Tim Nguyen
822add064c Bug 1513325 - Remove textbox binding. r=emilio,dao
Differential Revision: https://phabricator.services.mozilla.com/D38955

--HG--
extra : moz-landing-system : lando
2019-10-09 09:27:28 +00:00
Brendan Dahl
c68cd30ef2 Bug 1510785 - Only build XBL related code when MOZ_XBL is defined. r=bzbarsky
When XBL is disabled, no code in dom/xbl will be built. Also, adds ifdefs
to remove any of the XBL related code elsewhere. There's definitely more
that can be done here, but I think it's better to wait to do the rest of
the cleanup when we actually remove the code.

Depends on D45612

Differential Revision: https://phabricator.services.mozilla.com/D45613

--HG--
extra : moz-landing-system : lando
2019-10-08 23:52:14 +00:00
Alexander Surkov
9dc56a5bf5 Bug 1587104 - do not pick up accessible name from containing XUL toolbaritem r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D48581

--HG--
extra : moz-landing-system : lando
2019-10-09 00:09:47 +00:00
Aaron Klotz
b256fc294a Bug 1586436: Ensure that mscom methods that accept variadic arguments use rvalue references in their arguments; r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D48435

--HG--
extra : moz-landing-system : lando
2019-10-08 20:43:38 +00:00
Alexander Surkov
7544bd8298 Bug 1586836 - remove <xul:textbox> from a11y tests r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D48576

--HG--
extra : moz-landing-system : lando
2019-10-08 17:29:16 +00:00
Andreea Pavel
ab8a9b521f Bug 1388256 - disabled browser_caching_name.js on debug mac and win, linux64 r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D48510

--HG--
extra : moz-landing-system : lando
2019-10-08 16:13:31 +00:00
Ricky Stewart
c010710916 Bug 1586358 - Replace existing instances of GENERATED_FILES with references to the GeneratedFile template r=firefox-build-system-reviewers,mshal
(Same content as bad revision https://phabricator.services.mozilla.com/D48230, but with a very small change to config/external/icu/data/moz.build to fix the build breakage.)

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=833f6a69fcac689488a640b43e8e0bdaa086a56c

Differential Revision: https://phabricator.services.mozilla.com/D48409

--HG--
extra : moz-landing-system : lando
2019-10-07 21:15:19 +00:00
Daniel Varga
052ef806b5 Backed out changeset 8d95f2c8867b (bug 1586358) for build bustage with FATAL ERROR PROCESSING MOZBUILD FILE. On a CLOSED TREE
--HG--
extra : rebase_source : 325fbad2455afc7f693087e75fa57dba79f4d86b
2019-10-07 20:22:08 +03:00
Ricky Stewart
940d91af38 Bug 1586358 - Replace existing instances of GENERATED_FILES with references to the GeneratedFile template r=nalexander
This patch doesn't remove all references to GENERATED_FILES, but does remove most of them, leaving only those which can't be trivially translated to the new template.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4a25230c3992b9c5519ceb351fb37f6b2bf605e

Differential Revision: https://phabricator.services.mozilla.com/D48230

--HG--
extra : moz-landing-system : lando
2019-10-07 15:31:05 +00:00
Sylvestre Ledru
f12b9fa5c3 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D47737

--HG--
extra : moz-landing-system : lando
2019-10-06 18:29:55 +00:00
Tim Nguyen
91976e6a66 Bug 1586018 - Remove a11y tree tests, reftests and crashtests only related to textbox. r=surkov,emilio
Differential Revision: https://phabricator.services.mozilla.com/D48080

--HG--
extra : moz-landing-system : lando
2019-10-03 18:01:08 +00:00
Alexander Surkov
e670b51391 Bug 1582590 - Clean up unused <textbox type='autocomplete'> platform code. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D46541

--HG--
extra : moz-landing-system : lando
2019-10-03 11:18:53 +00:00
Eitan Isaacson
cc288d94bb Bug 1582619 - Return DocAccessible if doc root element is passed to GetAccessibleOrDescendant. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D47365

--HG--
extra : moz-landing-system : lando
2019-10-03 00:31:13 +00:00
Eitan Isaacson
18deeb8110 Bug 1582561 - Don't access lazily created descendants in GetAccessibleOrDescendant. r=Jamie
Lazily creating children might cause us to make layout calls at unsafe times.

Differential Revision: https://phabricator.services.mozilla.com/D47361

--HG--
extra : moz-landing-system : lando
2019-10-03 00:30:06 +00:00
James Teh
d9d82b8278 Bug 1576509: Add a function to announce a message to screen reader users. r=Gijs,yzen
Differential Revision: https://phabricator.services.mozilla.com/D47717

--HG--
extra : moz-landing-system : lando
2019-10-02 05:53:52 +00:00
Morgan Reschenberg
a20612a878 Bug 1584465: Null check parent accessible before attribute check to cover root case. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D47488

--HG--
extra : moz-landing-system : lando
2019-09-30 16:23:30 +00:00
Eitan Isaacson
9b2ce1a83d Bug 1584297 - Simplify map element reflow whitespace test. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D47325

--HG--
extra : moz-landing-system : lando
2019-09-27 01:51:07 +00:00
Coroiu Cristina
c094fff9aa Backed out changeset ea2c69779571 (bug 1577381) for a11y failures at accessible/tests/mochitest/attributes/test_obj_group.xul on a CLOSED TREE 2019-09-27 08:00:39 +03:00
James Teh
1adf6ac726 Bug 1577381: Correct accessibility exposure for optgroups in content select dropdowns. r=eeejay,NeilDeakin
For remote content documents, select dropdowns (for <select size="1">) are rendered in the parent process using a XUL menupopup.
This means that the accessibility code for HTML selects doesn't apply.

In the menupopup, the optgroup is a sibling of its contained options.
For accessibility, we want to preserve the hierarchy such that the options are inside the optgroup.
We do this using aria-owns on the optgroup item.

This required some tweaks to XULMenuitemAccessible, as it couldn't previously handle grouping Accessibles between the menupopup and its items.

Differential Revision: https://phabricator.services.mozilla.com/D43901

--HG--
extra : moz-landing-system : lando
2019-09-27 02:50:59 +00:00
Sean Feng
660aac23aa Bug 1467970 - Unsupport cross docGroup adoption r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D43135

--HG--
extra : moz-landing-system : lando
2019-09-14 00:09:44 +00:00
Andreea Pavel
51cabe74d0 Bug 1582775 - disabled browser_deck_has_out_of_process_iframe.js on win qr r=hiro
Differential Revision: https://phabricator.services.mozilla.com/D47188

--HG--
extra : moz-landing-system : lando
2019-09-26 03:47:47 +00:00
Eitan Isaacson
b591abf5e0 Bug 1581589 - Return null in GetAccessibleOrContainer for text leafs of unrendered maps. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D47185

--HG--
extra : moz-landing-system : lando
2019-09-26 01:51:45 +00:00
Morgan Reschenberg
33381f2280 Bug 1177014: Modify TransformOffset to correctly report bullet offsets, despite incorrect return from PeekOffset. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D46490

--HG--
extra : moz-landing-system : lando
2019-09-25 02:10:08 +00:00
Hiroyuki Ikezoe
81918ac172 Bug 1582946 - Skip whole test cases in browser_deck_has_out_of_process_iframe.js if fission.autostart pref is locked. r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D47031

--HG--
extra : moz-landing-system : lando
2019-09-25 21:17:51 +00:00
Yura Zenevich
710d2ef14f Bug 1503084 - add additional event logging to e10s name tests. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D46972

--HG--
extra : moz-landing-system : lando
2019-09-25 18:24:59 +00:00
Tim Nguyen
b0d1ddb586 Bug 1581956 - Make search-textbox not use the <textbox> tag. r=surkov,MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D46219

--HG--
extra : moz-landing-system : lando
2019-09-25 19:12:48 +00:00
Eitan Isaacson
885a031613 Bug 1564549 - Remove AccessFu. r=geckoview-reviewers,yzen,snorp
Differential Revision: https://phabricator.services.mozilla.com/D45604

--HG--
extra : moz-landing-system : lando
2019-09-24 19:28:28 +00:00
Eitan Isaacson
cff449b020 Bug 1564549 - Implement clipboard actions natively. r=geckoview-reviewers,yzen,snorp
Differential Revision: https://phabricator.services.mozilla.com/D45602

--HG--
extra : moz-landing-system : lando
2019-09-23 23:42:38 +00:00
Eitan Isaacson
967793da25 Bug 1564549 - Implement set selection natively. r=geckoview-reviewers,yzen,snorp
Differential Revision: https://phabricator.services.mozilla.com/D45601

--HG--
extra : moz-landing-system : lando
2019-09-23 23:42:40 +00:00
Eitan Isaacson
1bce54c7cc Bug 1564549 - Implement text navigation natively. r=geckoview-reviewers,Jamie,snorp
Differential Revision: https://phabricator.services.mozilla.com/D45600

--HG--
extra : moz-landing-system : lando
2019-09-23 23:42:47 +00:00
Eitan Isaacson
0f147877cd Bug 1564549 - Implement move and explore by touch natively. r=geckoview-reviewers,yzen,snorp
Differential Revision: https://phabricator.services.mozilla.com/D45599

--HG--
extra : moz-landing-system : lando
2019-09-23 23:42:49 +00:00
Eitan Isaacson
c484dec9b9 Bug 1564549 - Introduce native traveral rule. r=yzen
The rule takes a granularity constant as an argument in the constructor.

Differential Revision: https://phabricator.services.mozilla.com/D45598

--HG--
extra : moz-landing-system : lando
2019-09-23 23:42:51 +00:00
Eitan Isaacson
f636c8855c Bug 1564549 - Add action forwarding macro. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D45597

--HG--
extra : moz-landing-system : lando
2019-09-23 23:42:53 +00:00
Andrew Halberstadt
898dfb96b4 Bug 1567642 - [lint.flake8] Fix misc flake8 under Python 3 lint issues r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D45417

--HG--
extra : moz-landing-system : lando
2019-09-24 14:44:01 +00:00
Noemi Erli
ecdbbb2a1f Backed out 8 changesets (bug 1564549) for causing failures in browser_all_files_referenced.js CLOSED TREE
Backed out changeset a6b83802832c (bug 1564549)
Backed out changeset 7f38c6ddd009 (bug 1564549)
Backed out changeset 15a754fb192e (bug 1564549)
Backed out changeset 34441585469f (bug 1564549)
Backed out changeset aada27f6ad6e (bug 1564549)
Backed out changeset 103dbf465704 (bug 1564549)
Backed out changeset c38e72058869 (bug 1564549)
Backed out changeset aca91e9add16 (bug 1564549)
2019-09-24 02:38:39 +03:00
Eitan Isaacson
b7427e24a9 Bug 1564549 - Remove AccessFu. r=geckoview-reviewers,yzen,snorp
Differential Revision: https://phabricator.services.mozilla.com/D45604

--HG--
extra : moz-landing-system : lando
2019-09-23 21:07:21 +00:00
Eitan Isaacson
11dd6681cd Bug 1564549 - Implement clipboard actions natively. r=geckoview-reviewers,yzen,snorp
Differential Revision: https://phabricator.services.mozilla.com/D45602

--HG--
extra : moz-landing-system : lando
2019-09-23 21:07:08 +00:00
Eitan Isaacson
ef8c8bacd2 Bug 1564549 - Implement set selection natively. r=geckoview-reviewers,yzen,snorp
Differential Revision: https://phabricator.services.mozilla.com/D45601

--HG--
extra : moz-landing-system : lando
2019-09-23 21:07:02 +00:00
Eitan Isaacson
ac01020042 Bug 1564549 - Implement text navigation natively. r=geckoview-reviewers,Jamie,snorp
Differential Revision: https://phabricator.services.mozilla.com/D45600

--HG--
extra : moz-landing-system : lando
2019-09-23 21:06:58 +00:00
Eitan Isaacson
85d6a5f093 Bug 1564549 - Implement move and explore by touch natively. r=geckoview-reviewers,yzen,snorp
Differential Revision: https://phabricator.services.mozilla.com/D45599

--HG--
extra : moz-landing-system : lando
2019-09-23 21:06:51 +00:00
Eitan Isaacson
37c232bfbf Bug 1564549 - Introduce native traveral rule. r=yzen
The rule takes a granularity constant as an argument in the constructor.

Differential Revision: https://phabricator.services.mozilla.com/D45598

--HG--
extra : moz-landing-system : lando
2019-09-23 21:06:49 +00:00
Eitan Isaacson
874de5845e Bug 1564549 - Add action forwarding macro. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D45597

--HG--
extra : moz-landing-system : lando
2019-09-23 21:06:40 +00:00
arthur.iakab
b6a627c094 Merge inbound to mozilla-central. a=merge
--HG--
extra : amend_source : 39c72a7f01f9afa5abf7587d732d1e63969cc9da
2019-09-21 13:00:40 +03:00
Dorel Luca
f5e74811ca Merge mozilla-central to mozilla-inbound 2019-09-21 00:58:45 +03:00
Kris Maglione
685d91c901 Bug 1553804: Part 6 - Fix chrome mochitests which open chrome windows with content openers. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D45828

MANUAL PUSH: Cannot update reopened Phabricator revisions.

--HG--
extra : source : 86b3d469b4ff9f22e5757f83450b956a4c769785
extra : histedit_source : 2bf945343632b15eb79cf6b2ddd3ce097ddf70de%2Caec93d9f11bc1c802b63793cd5818530b64e9b4b
2019-09-20 10:18:15 -07:00
Edgar Chen
5bc0854d2b Bug 1578355 - Part 1: Move user-activation code from EventStateManager to UserActivation; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D45168

--HG--
extra : moz-landing-system : lando
2019-09-20 20:51:25 +00:00
Hiroyuki Ikezoe
5399adbf3a Bug 1541256 - Tests for elements' accessibility states in out-of-process iframes in a deck. r=tnikkel,surkov
Differential Revision: https://phabricator.services.mozilla.com/D44951

--HG--
extra : source : 691c50b5729af881fff324bf68b739a3b8da5518
2019-09-20 11:33:00 +00:00
Andreea Pavel
1f18f66226 Backed out 2 changesets (bug 1541256) for failing browser_deck_has_out_of_process_iframe.js on a CLOSED TREE
Backed out changeset 691c50b5729a (bug 1541256)
Backed out changeset fc785139655e (bug 1541256)
2019-09-20 18:15:15 +03:00
Hiroyuki Ikezoe
d04cad22aa Bug 1541256 - Tests for elements' accessibility states in out-of-process iframes in a deck. r=tnikkel,surkov
Differential Revision: https://phabricator.services.mozilla.com/D44951

--HG--
extra : moz-landing-system : lando
2019-09-20 11:33:00 +00:00
Daniel Varga
bc19cdb06d Backed out 3 changesets (bug 1578355) for build bustage at build/src/dom/base/nsSyncLoadService.h:48:21. On a CLOSED TREE
Backed out changeset d50ad759f129 (bug 1578355)
Backed out changeset 339ab54ca471 (bug 1578355)
Backed out changeset 284299dac42c (bug 1578355)
2019-09-20 14:05:12 +03:00
Edgar Chen
5b6fe53148 Bug 1578355 - Part 1: Move user-activation code from EventStateManager to UserActivation; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D45168

--HG--
extra : moz-landing-system : lando
2019-09-20 10:31:55 +00:00
James Teh
79314daf0b Bug 1316965: Give file inputs an a11y role of GROUPING so screen readers report their label when focus enters them. r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D46375

--HG--
extra : moz-landing-system : lando
2019-09-19 04:39:21 +00:00
James Teh
90f724704e Bug 1582323: When a file input has DOM focus, focus the browse button inside it for a11y. r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D46386

--HG--
extra : moz-landing-system : lando
2019-09-19 04:34:29 +00:00