Commit Graph

821 Commits

Author SHA1 Message Date
James Teh
b992db08f1 Bug 1594623: Suppress focus events for OuterDocAccessibles to prevent incorrect reporting for OOP iframes. r=yzen
An OuterDoc shouldn't get accessibility focus itself.
Focus should always go to something inside it.
However, OOP iframes will get DOM focus because their content isn't in this process.
We now suppress the OuterDoc focus in this case.
The OOP browser will fire focus for the correct Accessible inside the embedded document.
Without suppression of the OuterDoc focus, the two focus events will race and the OuterDoc focus may override the correct embedded focus for accessibility clients.
Even if they fired in the correct order, clients may report extraneous focus information to the user before reporting the correct focus.

Differential Revision: https://phabricator.services.mozilla.com/D52126

--HG--
extra : moz-landing-system : lando
2019-11-07 20:32:46 +00:00
James Teh
7dfabe9989 Bug 1415667: Always use OuterDocAccessible for iframes, even if an ARIA table role is specified. r=yzen
OuterDocAccessible has some special behaviour.
We really shouldn't try to use some other class for iframes.
Anyway, making an iframe part of an ARIA table won't work for other reasons, plus I'm not sure it makes much sense.

Differential Revision: https://phabricator.services.mozilla.com/D50769

--HG--
extra : moz-landing-system : lando
2019-10-29 14:26:49 +00:00
Sylvestre Ledru
7c309095ea Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
Please note that it is the first reformat with clang-format 9
I only saw a fix in the .mm file

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D49056

--HG--
extra : moz-landing-system : lando
2019-10-21 14:13:44 +00:00
Morgan Reschenberg
1b8dfbb609 Bug 1579633: Update menu role, HTML spec tests. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D49314

--HG--
extra : moz-landing-system : lando
2019-10-17 15:45:27 +00:00
Morgan Reschenberg
c157ae77f0 Bug 822988: Create HyperTextAccessibleWrap for SVG text objects for correct role assignment. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D49202

--HG--
extra : moz-landing-system : lando
2019-10-14 21:51:58 +00:00
Alexander Surkov
5459de4426 Bug 1587512 - remove XBL dialog support bits; remove XBL support from TreeWalker; update XBL related comments and remove XBL mutation test r=MarcoZ,Jamie
Depends on D48964

Differential Revision: https://phabricator.services.mozilla.com/D48965

--HG--
extra : moz-landing-system : lando
2019-10-14 05:36:10 +00:00
Alexander Surkov
ba43684bbe Bug 1587791 - remove XBL backed accessible relations support r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D48840

--HG--
extra : moz-landing-system : lando
2019-10-10 14:08:17 +00:00
Tim Nguyen
822add064c Bug 1513325 - Remove textbox binding. r=emilio,dao
Differential Revision: https://phabricator.services.mozilla.com/D38955

--HG--
extra : moz-landing-system : lando
2019-10-09 09:27:28 +00:00
Brendan Dahl
c68cd30ef2 Bug 1510785 - Only build XBL related code when MOZ_XBL is defined. r=bzbarsky
When XBL is disabled, no code in dom/xbl will be built. Also, adds ifdefs
to remove any of the XBL related code elsewhere. There's definitely more
that can be done here, but I think it's better to wait to do the rest of
the cleanup when we actually remove the code.

Depends on D45612

Differential Revision: https://phabricator.services.mozilla.com/D45613

--HG--
extra : moz-landing-system : lando
2019-10-08 23:52:14 +00:00
Sylvestre Ledru
f12b9fa5c3 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D47737

--HG--
extra : moz-landing-system : lando
2019-10-06 18:29:55 +00:00
Alexander Surkov
e670b51391 Bug 1582590 - Clean up unused <textbox type='autocomplete'> platform code. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D46541

--HG--
extra : moz-landing-system : lando
2019-10-03 11:18:53 +00:00
Edgar Chen
5bc0854d2b Bug 1578355 - Part 1: Move user-activation code from EventStateManager to UserActivation; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D45168

--HG--
extra : moz-landing-system : lando
2019-09-20 20:51:25 +00:00
Daniel Varga
bc19cdb06d Backed out 3 changesets (bug 1578355) for build bustage at build/src/dom/base/nsSyncLoadService.h:48:21. On a CLOSED TREE
Backed out changeset d50ad759f129 (bug 1578355)
Backed out changeset 339ab54ca471 (bug 1578355)
Backed out changeset 284299dac42c (bug 1578355)
2019-09-20 14:05:12 +03:00
Edgar Chen
5b6fe53148 Bug 1578355 - Part 1: Move user-activation code from EventStateManager to UserActivation; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D45168

--HG--
extra : moz-landing-system : lando
2019-09-20 10:31:55 +00:00
Eitan Isaacson
f7856fcbe6 Bug 1580019 - Refactor nsIAccessiblePivot to a stateless Pivot class. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D45253

--HG--
extra : moz-landing-system : lando
2019-09-18 22:23:58 +00:00
Eitan Isaacson
0293722fcc Bug 1565728 - Introduce PDocAccessiblePlatformExt. r=Jamie
This is an extension protocol that can be used for platform specific
API (ie. AccessibleWrap methods).

I'm not thrilled with the seperate constructor for the sub-protocol.
This means that the parent won't have the actor upon DocAccessibleParent
construction, and some timing bugs can arise because of the extra round
trip. It would be cool if both actors could be co-created, but that
would require ManagedEndpoint, and for PBrowser to manage them both. I
don't want to expose this to PBrowser.

Differential Revision: https://phabricator.services.mozilla.com/D37955

--HG--
extra : moz-landing-system : lando
2019-09-13 16:55:01 +00:00
Morgan Reschenberg
0b76713b25 Bug 1563598: Display 'container-live' attribute on descendents of implicitly-live elements. r=Jamie
Depends on D45402

Differential Revision: https://phabricator.services.mozilla.com/D45609

--HG--
extra : moz-landing-system : lando
2019-09-13 16:43:58 +00:00
Morgan Reschenberg
8a64fb0963 Bug 1563598: Change output elements to have statusbar role instead of section role. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D45402

--HG--
extra : moz-landing-system : lando
2019-09-13 16:43:49 +00:00
Dorel Luca
c7aad775a7 Backed out 2 changesets (bug 1565728) for License failure. CLOSED TREE
Backed out changeset 6c30dad5259b (bug 1565728)
Backed out changeset 4369b7203266 (bug 1565728)
2019-09-13 03:16:23 +03:00
Eitan Isaacson
35496390cd Bug 1565728 - Introduce PDocAccessiblePlatformExt. r=Jamie
This is an extension protocol that can be used for platform specific
API (ie. AccessibleWrap methods).

I'm not thrilled with the seperate constructor for the sub-protocol.
This means that the parent won't have the actor upon DocAccessibleParent
construction, and some timing bugs can arise because of the extra round
trip. It would be cool if both actors could be co-created, but that
would require ManagedEndpoint, and for PBrowser to manage them both. I
don't want to expose this to PBrowser.

Differential Revision: https://phabricator.services.mozilla.com/D37955

--HG--
extra : moz-landing-system : lando
2019-09-12 23:01:59 +00:00
Dorel Luca
f6c45cc8c1 Backed out 2 changesets (bug 1563598) for Mochitest failures on accessible/tests/mochitest/tree/test_formctrl.html. CLOSED TREE
Backed out changeset 968ef845dc64 (bug 1563598)
Backed out changeset d647bd5b0b29 (bug 1563598)
2019-09-13 00:11:58 +03:00
Dorel Luca
7f5e96335e Backed out 2 changesets (bug 1565728) for License failure. CLOSED TREE
Backed out changeset 0d08e4b02c17 (bug 1565728)
Backed out changeset 4fe176e80602 (bug 1565728)
2019-09-12 23:48:50 +03:00
Morgan Reschenberg
5523b6c1ff Bug 1563598: Display 'container-live' attribute on descendents of implicitly-live elements. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D45609

--HG--
extra : moz-landing-system : lando
2019-09-12 20:01:50 +00:00
Morgan Reschenberg
dd9d61742f Bug 1563598: Change output elements to have statusbar role instead of section role. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D45402

--HG--
extra : moz-landing-system : lando
2019-09-12 16:13:19 +00:00
Eitan Isaacson
82aa8a18ca Bug 1565728 - Introduce PDocAccessiblePlatformExt. r=Jamie
This is an extension protocol that can be used for platform specific
API (ie. AccessibleWrap methods).

I'm not thrilled with the seperate constructor for the sub-protocol.
This means that the parent won't have the actor upon DocAccessibleParent
construction, and some timing bugs can arise because of the extra round
trip. It would be cool if both actors could be co-created, but that
would require ManagedEndpoint, and for PBrowser to manage them both. I
don't want to expose this to PBrowser.

Differential Revision: https://phabricator.services.mozilla.com/D37955

--HG--
extra : moz-landing-system : lando
2019-09-12 20:10:51 +00:00
Eitan Isaacson
8593d6d908 Bug 1576696 - Add a '0x' prefix to hex pointer values in logging nodes. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D43485

--HG--
extra : moz-landing-system : lando
2019-08-27 02:02:01 +00:00
Emilio Cobos Álvarez
f4fb9ab137 Bug 1576194 - Remove kDisplayKTable. r=mats
It doesn't represent anything useful anymore.

Differential Revision: https://phabricator.services.mozilla.com/D43262

--HG--
extra : moz-landing-system : lando
2019-08-23 15:52:05 +00:00
Eitan Isaacson
47656aa608 Bug 1572811 - Don't fire text change events if container accessible has no frame. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D42199

--HG--
extra : moz-landing-system : lando
2019-08-22 20:28:38 +00:00
Mike Hommey
66d7fe943e Bug 1575420 - Replace MOZ_WIDGET_TOOLKIT value of "gtk3" with "gtk". r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D42765

--HG--
extra : moz-landing-system : lando
2019-08-21 12:25:42 +00:00
Maliha Islam
f6e1118c76 Bug 1540813 - Support new ARIA roles insertion and deletion, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D42911

--HG--
extra : moz-landing-system : lando
2019-08-21 20:36:39 +00:00
Alexander Surkov
cfb8c8aef7 Bug 1573337 - remove XBL anon content filtering support from accessible tree traversal r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D42022

--HG--
extra : moz-landing-system : lando
2019-08-15 00:58:28 +00:00
Marco Zehe
de9c156fb7 Bug 1501182 - Expose WAI-ARIA landmarks as landmark roles through accessibility APIs, r=Jamie
This change will bring us on par with what Chrome does. However, if the author makes an error in applying a landmark role to an interactive element, or other element where the landmark role is illegal, as defined in the [WAI-ARIA in HTML specification section 2](https://www.w3.org/TR/html-aria/#document-conformance-requirements-for-use-of-aria-attributes-in-html), the accessible properties will now be that of the landmark role, no longer that of the native host language element. This might make some elements less accessible due to author error than before, but we currently do not know of examples in the wild that actually expose this problem. This could only be solved by applying the rules from said table also in the user agents, but that is not specified anywhere.

Differential Revision: https://phabricator.services.mozilla.com/D41923

--HG--
extra : moz-landing-system : lando
2019-08-15 01:25:56 +00:00
Eitan Isaacson
f76019cc9d Bug 1572519 - Log all element attributes in accessibility logging. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D41265

--HG--
extra : moz-landing-system : lando
2019-08-09 00:02:51 +00:00
Kannan Vijayan
e53a880b1c Bug 1569262 - Rename nsIDocShellTreeItem::GetRootTreeItem to GetInProcessRootTreeItem for Fission marking. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D41064

--HG--
extra : moz-landing-system : lando
2019-08-07 19:24:00 +00:00
Tom Schuster
0e913c22c4 Bug 1558915 - Use infallible nsIURI::SchemeIs in various places r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D40677

--HG--
extra : moz-landing-system : lando
2019-08-07 19:49:40 +00:00
Cosmin Sabou
c3430326e6 Backed out changeset ca88862d6b63 (bug 1558915) for causing build bustages on StartupCacheUtils. CLOSED TREE 2019-08-07 13:20:32 +03:00
Tom Schuster
8bc1f5ada8 Bug 1558915 - Use infallible nsIURI::SchemeIs in various places r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D40677

--HG--
extra : moz-landing-system : lando
2019-08-07 09:36:56 +00:00
Razvan Maries
eedbf1137f Backed out changeset b197ca57677a (bug 1558915) for build bustages. CLOSED TREE 2019-08-07 01:04:43 +03:00
Tom Schuster
03c7998ef2 Bug 1558915 - Use infallible nsIURI::SchemeIs in various places r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D40677

--HG--
extra : moz-landing-system : lando
2019-08-06 20:19:41 +00:00
James Teh
0ce8fb85c6 Bug 1571327: Process generic notifications after relocations to fix aria-activedescendant with simultaneous insertion and relocation. r=eeejay
Previously, if a hidden, aria-owned subtree was shown and aria-activedescendant was simultaneously targeted inside it, aria-activedescendant would fail.
This occurred because when we processed insertions, the presence of aria-owns meant we didn't create the subtree.
This meant that when we processed aria-activedescendant (which occurred before relocations), the active descendant didn't exist yet.
To fix this, we now process generic notifications (including aria-activedescendant) *after* relocations.

Differential Revision: https://phabricator.services.mozilla.com/D40579

--HG--
extra : moz-landing-system : lando
2019-08-06 03:07:51 +00:00
Eitan Isaacson
67c11960cc Bug 686400 - Delay accessible removal on frame reconstruction. r=Jamie,emilio
We naively remove and then recreate accessibles when their content's
frame is reconstructed. By delaying the removal until we are certain the
content does not have a new layout frame, we can cut down on redundant
recreations.

When reconstructed content is re-inserted we can check it and its
subtree for missing frames and prune those accessibles from the tree.

Differential Revision: https://phabricator.services.mozilla.com/D38380

--HG--
extra : moz-landing-system : lando
2019-08-02 22:13:28 +00:00
Eitan Isaacson
6d094c687d Bug 686400 - Filter content insertions in DocAccessible. r=Jamie
It seems a bit more sensible to me that if any filtering needs to happen
from content insertions, it should happen in the doc and not the
notification controller.

Differential Revision: https://phabricator.services.mozilla.com/D40132

--HG--
extra : moz-landing-system : lando
2019-08-01 16:19:15 +00:00
Eitan Isaacson
aeb736599d Bug 686400 - Add function to nsCoreUtils for display: contents. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D40131

--HG--
extra : moz-landing-system : lando
2019-08-01 16:19:06 +00:00
James Teh
b09e5ab2d6 Bug 1509234: Return early if accessible dies while processing a focus event to prevent crashes. r=eeejay
In FocusManager::ProcessFocusEvent, after firing the event, we get the anchor jump from the target Accessible's document.
However, it seems the Accessible can be shut down during the call to nsEventShell::FireEvent, resulting in a crash when we try to get the anchor jump.
Protect against this by checking whether the target is defunct after firing the event.

Differential Revision: https://phabricator.services.mozilla.com/D39450

--HG--
extra : moz-landing-system : lando
2019-08-01 03:00:16 +00:00
Kannan Vijayan
3fb6190ec6 Bug 1559414 - Rename unaudited pre-fission methods with SameProcess for future audit burndown. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D39378

--HG--
extra : moz-landing-system : lando
2019-07-26 16:48:31 +00:00
Marco Zehe
adce5a1e17 Bug 1568728 - Properly map thead to grouping if it is custom style, r=Jamie
This was an oversight in the checkin for bug 1461244. tfoot was duplicated due to a copy and paste error, thead was not mapped at all. It is now properly mapped, and the test adjusted accordingly.

Differential Revision: https://phabricator.services.mozilla.com/D39305

--HG--
extra : moz-landing-system : lando
2019-07-26 01:00:52 +00:00
James Teh
0eb35f6d14 Bug 1566324 part 1: Make a static version of IDRefsIterator::GetElem which can be called to get an id reference for any element. r=eeejay
IDRefsIterator::GetElem was previously an instance method which could only be used if you instantiated IDRefsIterator.
This is overkill for attributes which can only take a single id reference (rather than an id reference list).
Now, there is a static version of IDRefsIterator::GetElem which can be called with an arbitrary source element.
Any accessibility code should henceforth be using this instead of calling GetElementById directly, as this deals with shadow DOM, etc.

Differential Revision: https://phabricator.services.mozilla.com/D38832

--HG--
extra : moz-landing-system : lando
2019-07-25 20:44:18 +00:00
James Teh
b9e786af73 Bug 1509234: Add some assertions to help debug crashes. r=yzen
Differential Revision: https://phabricator.services.mozilla.com/D38967

--HG--
extra : moz-landing-system : lando
2019-07-24 00:08:01 +00:00
Mirko Brodesser
1669cc6770 Bug 1566046: rename GetParentOrHostNode to GetParentOrShadowHostNode. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D38078
2019-07-16 09:25:02 +02:00
Alexander Surkov
f09b8fa08d Bug 1563275 - make dynamically inserted slotted elements accessible r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D36919

--HG--
extra : moz-landing-system : lando
2019-07-05 12:28:51 +00:00