Commit Graph

27995 Commits

Author SHA1 Message Date
Agi Sferro
1b01ddf44b Bug 1512274 - [geckoview] Remove unused imports. r=geckoview-reviewers,snorp
Depends on D23690

Differential Revision: https://phabricator.services.mozilla.com/D23691

--HG--
extra : moz-landing-system : lando
2019-03-15 18:10:05 +00:00
Agi Sferro
c42ac4fa46 Bug 1512274 - [geckoview] Avoid star imports. r=geckoview-reviewers,snorp
Depends on D23689

Differential Revision: https://phabricator.services.mozilla.com/D23690

--HG--
extra : moz-landing-system : lando
2019-03-15 18:09:52 +00:00
Agi Sferro
2e05ec76a1 Bug 1512274 - [geckoview] Fix indentation. r=geckoview-reviewers,snorp
Depends on D23688

Differential Revision: https://phabricator.services.mozilla.com/D23689

--HG--
extra : moz-landing-system : lando
2019-03-15 18:09:14 +00:00
Agi Sferro
042e67c91f Bug 1512274 - [geckoview] LeftCurly checkstyle fixes r=geckoview-reviewers,snorp
Depends on D23687

Differential Revision: https://phabricator.services.mozilla.com/D23688

--HG--
extra : moz-landing-system : lando
2019-03-15 18:08:51 +00:00
Agi Sferro
bd18c381ab Bug 1512274 - [geckoview] Make all private member variable be mCamelCase. r=geckoview-reviewers,snorp
Depends on D23686

Differential Revision: https://phabricator.services.mozilla.com/D23687

--HG--
extra : moz-landing-system : lando
2019-03-15 18:08:49 +00:00
Agi Sferro
3317685af3 Bug 1512274 - [geckoview] Make all local variables be lowerCamelCase. r=geckoview-reviewers,snorp
Depends on D23685

Differential Revision: https://phabricator.services.mozilla.com/D23686

--HG--
extra : moz-landing-system : lando
2019-03-15 18:08:42 +00:00
Agi Sferro
b42d737270 Bug 1512274 - [geckoview] Make all constants actually final. r=geckoview-reviewers,snorp
Depends on D23684

Differential Revision: https://phabricator.services.mozilla.com/D23685

--HG--
extra : moz-landing-system : lando
2019-03-15 18:08:40 +00:00
Agi Sferro
176ef70e3b Bug 1512274 - [geckoview] Make all argument names be lowerCamelCase. r=geckoview-reviewers,snorp
Depends on D23683

Differential Revision: https://phabricator.services.mozilla.com/D23684

--HG--
extra : moz-landing-system : lando
2019-03-15 18:08:38 +00:00
Agi Sferro
287a835f12 Bug 1512274 - [geckoview] Add final to all methods in GeckoView. r=geckoview-reviewers,snorp
Depends on D23682

Differential Revision: https://phabricator.services.mozilla.com/D23683

--HG--
extra : moz-landing-system : lando
2019-03-15 18:08:36 +00:00
Agi Sferro
8a7237ff44 Bug 1512274 - [geckoview] Don't change value of method arguments. r=geckoview-reviewers,snorp
Differential Revision: https://phabricator.services.mozilla.com/D23682

--HG--
extra : moz-landing-system : lando
2019-03-15 18:08:34 +00:00
James Willcox
35c2a7e52a Bug 1534802 - Remove unused GeckoView delegate overrides in Fennec r=petru
Differential Revision: https://phabricator.services.mozilla.com/D23226

--HG--
extra : moz-landing-system : lando
2019-03-15 08:50:11 +00:00
James Willcox
6d80f1df21 Bug 1440601 - Disable TabSource on Android r=petru
Differential Revision: https://phabricator.services.mozilla.com/D23575

--HG--
extra : moz-landing-system : lando
2019-03-15 09:00:38 +00:00
Henrik Skupin
635199bb7b Bug 1530979 - Send custom "marionette-startup-requested" observer notification to start Marionette in Fennec. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D23488

--HG--
extra : moz-landing-system : lando
2019-03-15 12:51:07 +00:00
Vlad Baicu
acdf328bb6 Bug 1531047 - Part 2: Refactor TabQueue to a foreground service. r=JanH
Refactored the TabQueueService to be a foreground service from Android O
onwards. The service now uses a foreground notification that briefly informs
the user that a new tab is being added to the queue.

Depends on D23528

Differential Revision: https://phabricator.services.mozilla.com/D23529

--HG--
extra : moz-landing-system : lando
2019-03-15 11:21:29 +00:00
Vlad Baicu
02e4817753 Bug 1531047 - Part 1: Some code cleanup. r=petru
Differential Revision: https://phabricator.services.mozilla.com/D23528

--HG--
extra : moz-landing-system : lando
2019-03-15 11:21:02 +00:00
Razvan Maries
b5f0d05bc9 Merge mozilla-inbound to mozilla-central a=merge 2019-03-15 05:40:21 +02:00
Razvan Maries
1cfbd79a4e Merge mozilla-central to mozilla-inbound. a=merge on a CLOSED TREE 2019-03-14 23:50:44 +02:00
Agi Sferro
3960667956 Bug 1535013: [geckoview] Add default impls to all interfaces. r=snorp
This also upgrades apilint to 0.1.8 to enforce that all interfaces have default
impls.

Differential Revision: https://phabricator.services.mozilla.com/D23324

--HG--
extra : moz-landing-system : lando
2019-03-14 16:48:57 +00:00
Dorel Luca
2d22ab9308 Backed out 3 changesets (bug 1522451) for eslint failure
Backed out changeset bd7007ecd0db (bug 1522451)
Backed out changeset d291cd16ef76 (bug 1522451)
Backed out changeset 6fbcde5da1c1 (bug 1522451)
2019-03-14 18:07:15 +02:00
Andreea Pavel
d6a864b0c0 Backed out 4 changesets (bug 1533840, bug 1522451) for failing dom/manifest/test/test_ManifestProcessor_background_color.html on a CLOSED TREE
Backed out changeset 4fd7ce83efe1 (bug 1533840)
Backed out changeset 5a892aa56e37 (bug 1522451)
Backed out changeset 2ddf151f9535 (bug 1522451)
Backed out changeset 49ebb69e8893 (bug 1522451)
2019-03-14 23:02:15 +02:00
James Willcox
62668b86fc Bug 1533840 - Add convenience methods for dealing with WebRequest/WebResponse bodies r=geckoview-reviewers,agi,rbarker
Differential Revision: https://phabricator.services.mozilla.com/D22748

--HG--
extra : moz-landing-system : lando
2019-03-14 20:18:33 +00:00
Petru Lingurar
23317f68c0 Bug 1534875 - Remove SearchWidgetConfigurationActivity from search's appwidget-provider; r=VladBaicu
This was a leftover from an initial implementation which needed to track
certain events related to the user adding the search widget.
Otherwise it is not needed as we don't actually expose any widget settings to
be configured by the user before adding it.
Turns out this Activity would actually mess with our PendingIntents which would
not fire for when tapping search widget's elements.

Differential Revision: https://phabricator.services.mozilla.com/D23543

--HG--
extra : moz-landing-system : lando
2019-03-14 17:13:32 +00:00
James Willcox
98778b5ae2 Bug 1533425 - Look for architecture-specific greprefs.js files on Android r=njn
We want to publish a multi-architecture AAR for GeckoView which includes
a single omni.ja, but we archicture-specific changes in greprefs.js that
prevent this from working. This patch causes us to try to read an
architecture-specific greprefs.js first, which will be provided by the
packaging process for the fat AAR.

Differential Revision: https://phabricator.services.mozilla.com/D22526

--HG--
extra : moz-landing-system : lando
2019-03-14 19:37:03 +00:00
James Willcox
1b12f90b4e Bug 1522451 - Add ContentDelegate.onWebAppManifest() r=geckoview-reviewers,agi,droeh
This delivers a parsed and validated Web App Manifest to the
application, if present, during the page load process.

Differential Revision: https://phabricator.services.mozilla.com/D22612

--HG--
extra : moz-landing-system : lando
2019-03-14 19:18:01 +00:00
James Willcox
31161b8c36 Bug 1522451 - Add asset support to HttpBin r=geckoview-reviewers,agi
This lets us request, e.g. '/assets/www/hello.html'.

Differential Revision: https://phabricator.services.mozilla.com/D22611

--HG--
extra : moz-landing-system : lando
2019-03-14 16:45:04 +00:00
James Willcox
7f67f3cebb Bug 1522451 - Add ContentDelegate.onWebAppManifest() r=geckoview-reviewers,agi,droeh
This delivers a parsed and validated Web App Manifest to the
application, if present, during the page load process.

Differential Revision: https://phabricator.services.mozilla.com/D22612

--HG--
extra : moz-landing-system : lando
2019-03-13 15:32:57 +00:00
James Willcox
3ff87c0842 Bug 1522451 - Add asset support to HttpBin r=geckoview-reviewers,agi
This lets us request, e.g. '/assets/www/hello.html'.

Differential Revision: https://phabricator.services.mozilla.com/D22611

--HG--
extra : moz-landing-system : lando
2019-03-11 19:15:55 +00:00
Petru Lingurar
263b5fbffd Bug 1534488 - Optimize the imports related to the search widget functionality; r=VladBaicu
Depends on D23477

Differential Revision: https://phabricator.services.mozilla.com/D23478

--HG--
extra : moz-landing-system : lando
2019-03-14 12:48:22 +00:00
Petru Lingurar
505230c530 Bug 1534488 - Cleanup previous state before entering editing mode for search; r=VladBaicu
We need to ensure that nothing from the previous app state would prevent a
smooth flow for the search widget UX.
As such, in the event that they were left open, we will close the options menu
and the tabs tray before entering in tab editing mode for search.

Differential Revision: https://phabricator.services.mozilla.com/D23477

--HG--
extra : moz-landing-system : lando
2019-03-14 12:48:04 +00:00
Andrei Lazar
4e47ed126e Bug 1534207 Search Widget missing TELEMETRY probe for searches initiated r=petru
Added a telemetry probe (unique source value) to allow data science to measure percentage of searches initiated from the widget.

Differential Revision: https://phabricator.services.mozilla.com/D22956

--HG--
extra : moz-landing-system : lando
2019-03-13 16:10:41 +00:00
Nathan Froyd
6d4137ff36 Bug 1534159 - remove exceptions for Android and Darwin from libstdcxx checks; r=glandium
The only place we'd need the compat libraries would be for host
binaries, and those shouldn't be a problem given that our system images
are new enough.

Differential Revision: https://phabricator.services.mozilla.com/D22873

--HG--
extra : moz-landing-system : lando
2019-03-13 22:24:20 +00:00
Dustin J. Mitchell
aa3ebe8988 Bug 1535171 - fix missed uses of no-argument get_root_url r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D23416

--HG--
extra : moz-landing-system : lando
2019-03-13 23:10:16 +00:00
Botond Ballo
a986312833 Bug 1517895 - Wait for mozvisualscroll explicitly in the session store tests. r=JanH
SSTabScrollCaptured can sometimes be fired for other reasons, causing us to
query the visual scroll position before it has been updated.

Not explicitly waiting for SSTabScrollCaptured is also safe in this case
because we're only querying the session store's view of the scroll position
*after* closing the tab, which will flush any pending scroll position updates
in the session store.

Differential Revision: https://phabricator.services.mozilla.com/D19875

--HG--
extra : moz-landing-system : lando
2019-03-13 16:00:07 +00:00
Botond Ballo
fd96b481ac Bug 1517895 - Use scrollToVisual() in the session store tests. r=JanH
Differential Revision: https://phabricator.services.mozilla.com/D19874

--HG--
extra : moz-landing-system : lando
2019-03-13 16:00:07 +00:00
Gijs Kruitbosch
fba25eeb23 Bug 1534943 - also update android CSS for font-size changes, r=JanH
Differential Revision: https://phabricator.services.mozilla.com/D23325

--HG--
extra : moz-landing-system : lando
2019-03-13 19:40:26 +00:00
Geoff Brown
2390d7a2a4 Bug 1532435 - Skip junit inputConnection test on debug only, to save lots of time; r=snorp
Disabling inputConnection on debug saves about 15 minutes of time, which helps
us avoid the timeouts seen in this bug. It continues running on opt, where it
runs much faster.

Differential Revision: https://phabricator.services.mozilla.com/D23254

--HG--
extra : moz-landing-system : lando
2019-03-13 15:26:36 +00:00
Eitan Isaacson
50711a42d5 Bug 1531579 - Refresh viewport cache on tree mutations and fire android event. r=yzen
Differential Revision: https://phabricator.services.mozilla.com/D21610

--HG--
extra : moz-landing-system : lando
2019-03-12 21:58:37 +00:00
James Willcox
137efa1bc6 Bug 1498721 - Add default methods to GeckoView delegate interfaces r=geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D23016

--HG--
extra : moz-landing-system : lando
2019-03-12 14:19:45 +00:00
Andrei Lazar
69cf1e9a01 Bug 1533723 Missing variants resources for search widget preview r=petru
Added preview assets for search widget within all variants.

Differential Revision: https://phabricator.services.mozilla.com/D23136

--HG--
extra : moz-landing-system : lando
2019-03-12 14:38:26 +00:00
Dorel Luca
df51e27b6a Backed out changeset 583048926c12 (bug 1531579) for Geckoview failure. CLOSED TREE 2019-03-12 01:38:46 +02:00
Eitan Isaacson
adcc1ec434 Bug 1531579 - Refresh viewport cache on tree mutations and fire android event. r=yzen
Differential Revision: https://phabricator.services.mozilla.com/D21610

--HG--
extra : moz-landing-system : lando
2019-03-05 19:28:41 +00:00
Emily Toop
e349b447de Bug 1527716 - Update GVE and Documentation to reflect proper handling of Notification permissions. r=geckoview-reviewers,snorp
Differential Revision: https://phabricator.services.mozilla.com/D21947

--HG--
extra : moz-landing-system : lando
2019-03-11 15:35:42 +00:00
Petru Lingurar
1520e32465 Bug 1533361 - Force about:home startup tab if the app was opened from the search widget; r=AndreiLazar
If the app was started from the search widget we need to always load about:home
and not the homepage which the user may have set to be another address.

Differential Revision: https://phabricator.services.mozilla.com/D22948

--HG--
extra : moz-landing-system : lando
2019-03-11 13:18:06 +00:00
Andrei Lazar
823284d748 Bug 1534205 Search Widget wrong layout after updating period r=petru
Removed search widget update interval in order to prevent bad layout re-configuration.

Differential Revision: https://phabricator.services.mozilla.com/D22947

--HG--
extra : moz-landing-system : lando
2019-03-11 10:17:58 +00:00
Petru Lingurar
2be45cf249 Bug 1534074 - Use in place api check to prevent Lint ApiDetector errors; r=AndreiLazar
Previous code was using our own sugary feature26Plus check which Lint doesn't
properly follow.
As such even if the code was properly guarded and behaved correctly Lint would
show errors about improper usage of methods which require higher api levels.
Doing the api check in place ensures it will get picked up by Lint's
ApiDetector and so it will not report about such errors here.

Differential Revision: https://phabricator.services.mozilla.com/D22889

--HG--
extra : moz-landing-system : lando
2019-03-11 08:51:29 +00:00
Sylvestre Ledru
e34acc8d48 Bug 1531176 - Split the Google key management between gls and safe browsing r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D21459

--HG--
extra : moz-landing-system : lando
2019-03-10 15:29:41 +00:00
Petru Lingurar
38270c952c Bug 1532613 - Enter editing mode after new "about:home" tab was added; r=AndreiLazar
We'll delay entering editing mode until we are sure the process for adding a
new "about:home" tab completed.
This allows avoiding certain race conditions with the previous state or with
the tab counter animation.

Differential Revision: https://phabricator.services.mozilla.com/D22701

--HG--
extra : moz-landing-system : lando
2019-03-08 15:13:55 +00:00
Andrei Lazar
cf929b7617 Bug 1533645 Search widget can trigger the Tab Queue prompt r=petru
Added a flag on the search widget intent in order to skip the tab queue prompt.

Depends on D22314

Differential Revision: https://phabricator.services.mozilla.com/D22681

--HG--
extra : moz-landing-system : lando
2019-03-08 20:10:36 +00:00
Andrei Lazar
dd1cc20388 Bug 1526934 Search Widget for Fennec Part 4 - Polish UI using the UX's team layouts r=petru
Polished UI by adding a custom drawable with rounded corners.
Made layouts responsive by setting relative widths.
Handled edge case for 1x1 cell.
Removed unused resources.

Depends on D21685

Differential Revision: https://phabricator.services.mozilla.com/D22314

--HG--
rename : mobile/android/services/src/main/res/layout/widget_search_5_col_layout.xml => mobile/android/services/src/main/res/layout/widget_search_default_col_layout.xml
extra : moz-landing-system : lando
2019-03-08 15:05:42 +00:00
Andrei Lazar
e63ba51548 Bug 1531679 Search Widget for Fennec Part 3 - Make it discoverable through Leanplum r=petru
Provided a deep link for the add widget intent.

Differential Revision: https://phabricator.services.mozilla.com/D21685

--HG--
extra : moz-landing-system : lando
2019-03-08 15:05:02 +00:00