19 Commits

Author SHA1 Message Date
Sam Foster
1ce685a8c2 Bug 1334642 - Cache luminance values for each toolbar in ToolbarIconColor. r=dao,mconley
* Track window states: active, fullscreen and tabsintitlebar for each window
* Use toolbar.id and window state to store and retrieve values from cache
* Note: As each window has its own ToolbarIconColor object, the cache is not currently shared across windows
* inferFromText callers pass in a reason and associated value, which is used to update the state we track, and potentially clear out the cache
* Create new windows test directory for browser-window-specific tests like this
* Test for the ToolbarIconColor changes to avoid sync style flushes when windows activate/deactivate

MozReview-Commit-ID: JDJ3RtL4Lge

--HG--
extra : rebase_source : f944ccd1c2340a5d2973bf47480a6eb78b2aae3b
2017-04-06 10:50:09 -07:00
Sebastian Hengst
7d471b721c Backed out changeset abaa83873b88 (bug 1334642) for failing browser_toolbariconcolor_restyles.js. r=backout on a CLOSED TREE 2017-04-18 00:54:25 +02:00
Sam Foster
b29b823ee9 Bug 1334642 - Cache luminance values for each toolbar in ToolbarIconColor. r=dao,mconley
* Track window states: active, fullscreen and tabsintitlebar for each window
* Use toolbar.id and window state to store and retrieve values from cache
* Note: As each window has its own ToolbarIconColor object, the cache is not currently shared across windows
* inferFromText callers pass in a reason and associated value, which is used to update the state we track, and potentially clear out the cache
* Create new windows test directory for browser-window-specific tests like this
* Test for the ToolbarIconColor changes to avoid sync style flushes when windows activate/deactivate
* Skip test for windows 8, follow-up filed as bug 1356684

MozReview-Commit-ID: JDJ3RtL4Lge

--HG--
extra : rebase_source : e97bb5c09b2e6d7b264363ccba1b34bf666f31e9
2017-04-06 10:50:09 -07:00
Florian Queze
37ff4fc7cc Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
a07223d699 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
95d4d20c17 Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Jared Wein
ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Dave Townsend
8de07a19a0 Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz

--HG--
extra : rebase_source : db6482481b7338df491afd6f6fd376eccec84d7e
2016-11-11 08:10:51 -08:00
Dave Townsend
0a2c8f9b78 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
MozReview-Commit-ID: HBpjT2uHJaZ

--HG--
extra : rebase_source : 78fe71a1d673a1c698520a9c82c6f35959614f8f
2016-11-10 14:48:04 -08:00
Mark Banner
09ab00a94f Bug 1313998 - Turn on no-unused-vars for local variable scopes in browser/base/content. r=mossop
MozReview-Commit-ID: IyFGBotfd11

--HG--
extra : rebase_source : aa43e5aea9e7fd7223fc59e941ecdc067abdb48f
2016-10-31 10:33:38 +00:00
Jared Wein
d3e296107e Bug 1294621 - Enable the no-lonely-if rule for eslint. r=gijs
MozReview-Commit-ID: 8izEqc8IyCu
2016-08-12 11:50:35 -04:00
Gijs Kruitbosch
df7777aa11 Bug 1273094 - only trigger TabsInTitlebar.init() after the tabbrowser has updated the visibility of the tabs toolbar, r=mikedeboer
MozReview-Commit-ID: 2NOPYqbq4Zp

--HG--
extra : rebase_source : fcafa79a232d994ad56e73539134a2f01934a210
extra : amend_source : 42aad7336111e104b44c2286932bbbf409db5914
2016-05-17 17:18:55 +01:00
Gijs Kruitbosch
f2de33cf7d Bug 1269462 - fix race condition in TabsInTitlebar code where it was possible we'd only be called before init(), resulting in never updating the titlebar maths, r=MattN,mconley
MozReview-Commit-ID: KM274gGpiuR

--HG--
extra : rebase_source : 06cfc19ce026cfc033fff0a6b0c6a455c78e0cdf
2016-05-13 18:52:53 +01:00
Jonathan Kew
924d7f9458 Bug 1256731 - patch 3 - Don't pull the elements below the titlebar up so far they'll clash with the buttons, in the secondary lo-dpi case where the window controls are oversized. r=gijs 2016-03-17 16:05:42 +00:00
Jonathan Kew
08fa921c03 Bug 1256731 - patch 2 - Notify front-end code when screen resolution changes on Windows, so that TabsInTitlebar code can refresh its computations. r=gijs,emk 2016-03-17 12:53:31 +00:00
Gijs Kruitbosch
957e08a3bd Bug 1219215 - part 1: remove window-drag bindings and other callers of WindowDraggingUtils, replace with using window-dragging region everywhere, r=dao,felipe
--HG--
extra : commitid : 5eXAZOQmmPY
extra : rebase_source : ff9d7691e203697caddb3a9f2de6cb676a15a6b4
extra : histedit_source : 8c3f2681850b5dd6ee8f26e7b8d9e00f2e4122a8
2016-01-18 15:32:14 +00:00
Felipe Gomes
017ff6db0a Bug 1228655 - Move TabsInTitlebar to its own file to remove ifdefs. r=Gijs
TabsInTitlebar has various ifdefs to avoid shipping code that's not gonna be used on Linux. Instead of complicating the logic with AppConstants checks and shipping this extra code unecessarily on Linux, i've separated the code to a different file that can be replaced by a stub implementation.
2015-12-01 20:05:45 -02:00