Commit Graph

602062 Commits

Author SHA1 Message Date
Dorel Luca
f7aa7c9447 Backed out changeset 0ca9cade7725 (bug 1471614) for XPCshell failures on devtools/shared/tests/unit/test_css-properties-db.js 2018-06-27 18:42:30 +03:00
Emilio Cobos Álvarez
8aaca6bf90 Bug 1464782: Allow logical aliases in the property database. r=me
MozReview-Commit-ID: 68WqG0OViPQ
2018-06-27 17:35:46 +02:00
Nathan Froyd
9fd8289cf9 Bug 1471435 - part 2 - micro-optimize deferred MaybeOpen calls; r=valentin
We shouldn't need to QueryInterface from nsIFile to nsIFile!
2018-06-27 11:27:33 -04:00
Nathan Froyd
d65aee9de5 Bug 1471435 - part 1 - clean up nsFile{Input,Ouput}Stream::Create; r=valentin
We should be using smart pointers here, and there's no need to check for
allocation failure with our infallible new policy.
2018-06-27 11:27:33 -04:00
Jonathan Kew
899b2539d6 Bug 1471584 - Micro-optimize text shaping by avoiding an unnecessary virtual method call. r=lsalzman 2018-06-27 16:12:43 +01:00
Jonathan Kew
1e3aec53f9 Bug 1422530 - Don't initiate new font downloads for a fontGroup where we've already set mSkipDrawing because we're waiting on a resource to be available. r=heycam 2018-06-27 16:12:42 +01:00
Jonathan Kew
498696bbb5 Bug 1461573 - Mark various dynamicDirAuto-* tests as slightly fuzzy on Android due to painting inconsistency. r=mats 2018-06-27 16:12:41 +01:00
Nathan Froyd
1185b20068 Bug 1471614 - remove some dead code in CycleCollectedJSRuntime; r=mccr8
Not only is it dead code, but it's a significant amount of useless work!
2018-06-27 11:10:31 -04:00
Mike Hommey
75a6124d43 Bug 1469790 - Build for NEON by default when targetting Android arm. r=nalexander
The media/libpng/moz.build file overrides the C standard used via
-std=c89, per bug 1371266, which conflicts with the use of the
arm_neon.h header: compilation fails on the inline keyword, which didn't
exist in C89. We thus "bump" to the GNU89 standard, which is C89+GNU
extensions, including inline.

--HG--
extra : rebase_source : fe93a13e3bef8888e1874d2e94a6d8ef396aaf83
2018-06-27 08:07:27 +09:00
Mike Hommey
17bbe0155b Bug 1471491 - Add lld to the mac clang toolchain. r=froydnj
--HG--
extra : rebase_source : 3161081a464c1c7acae6dde6a010ed9f5a598bfa
2018-06-27 13:33:23 +09:00
Chris Manchester
cf39792d69 Bug 1471425 - Require rustc 1.28 in configure when building with Tup. r=mshal
MozReview-Commit-ID: 9FCs5FPcchC

--HG--
extra : rebase_source : 7a4e7afa7825f3c73b5cc3571d1531f26cc964b1
2018-06-26 20:32:16 -07:00
Chris Manchester
fd325c1c6f Bug 1471425 - Print output of cargo if it fails when run as a part of the Tup backend. r=mshal
MozReview-Commit-ID: BRVSLE83WMH

--HG--
extra : rebase_source : ce2b5b785a6487db09136882452d509c842c758f
2018-06-26 18:17:45 -07:00
Jacek Caban
29adb6362f Bug 1471293 - Support using llvm-objdump in dependentlibs.py r=glandium
MozReview-Commit-ID: 8b0o06EQh3n

--HG--
extra : rebase_source : e5a3296723d6a64db38427d4b30fb820d0516abd
2018-06-26 15:15:19 +02:00
Dorel Luca
4e1a98da16 Merge mozilla-central to autland. CLOSED TREE
--HG--
extra : amend_source : f27ba81f58e12b4cf5286650b6910404748e7f95
2018-06-27 14:07:04 +03:00
Dorel Luca
d296624690 Backed out 5 changesets (bug 1340498) for build bustage due to conflicts with bug 1470325. a=backout
Backed out changeset 28bedb658af4 (bug 1340498)
Backed out changeset f950a2310e26 (bug 1340498)
Backed out changeset 5fcd31c65fe0 (bug 1340498)
Backed out changeset 515bb5e24dd7 (bug 1340498)
Backed out changeset 79a8619bd3e2 (bug 1340498)
2018-06-27 14:05:20 +03:00
Dorel Luca
bc2fbd0648 Merge mozilla-central to autoland
--HG--
extra : rebase_source : 0f5c3c308ce6ddd6fb9fcb49b83d4450a24d67dc
2018-06-27 13:33:04 +03:00
Dorel Luca
f51c4fa5d9 Merge mozilla-inbound to mozilla-central. a=merge 2018-06-27 13:26:49 +03:00
Coroiu Cristina
614012f859 Backed out changeset a1db50f691f0 (bug 1442737) for frequent mochitest failures on e.g: dom/workers/test/browser_fileURL.js 2018-06-27 10:58:48 +03:00
Christoph Kerschbaumer
25caec9ca2 Bug 1463663 - Prefix exported functions of the RemotePageManager with RPM. r=mossop 2018-06-27 09:08:32 +02:00
Cameron McCormack
674e812659 Bug 1471499 - Part 3: Replace remaining "see nsStyleConsts.h" comments with more useful references. r=xidorn
MozReview-Commit-ID: kO8uT9JZgK

--HG--
extra : rebase_source : 119ce72ccb1f2b79ec0e827325ed4ea6897a9e87
2018-06-27 16:45:56 +10:00
Cameron McCormack
73de67e798 Bug 1471499 - Part 2: Remove "see nsStyleConsts.h" comments for style struct members that are enum classes. r=xidorn
MozReview-Commit-ID: ISkGZ7FU8xR

--HG--
extra : rebase_source : 74e8b99a38e9d9fd94d1a93c2385fb91d66c12f4
2018-06-27 15:51:33 +10:00
Cameron McCormack
d5ad9f4ec6 Bug 1471499 - Part 1: Remove [reset] and [inherited] comments on style struct members. r=xidorn
MozReview-Commit-ID: 9dL51J2KqPS

--HG--
extra : rebase_source : 28cb17a14052db90b55a75d09ac190b85051624e
2018-06-27 15:44:58 +10:00
Xidorn Quan
4b65f18d5a Bug 1471114 part 7 - Scripts used to generated the previous patches. r=emilio
MozReview-Commit-ID: E9dB5l9AmeS

--HG--
extra : source : 960b212b998e728f90bbf564f5899a92f65c9e0e
2018-06-27 15:34:29 +10:00
Xidorn Quan
882b6f2f03 Bug 1471114 part 6 - Remove unused CSS keywords. r=emilio
This is done with the following script:
```python
#!/usr/bin/env python3

import re
import subprocess

LIST_FILE = "layout/style/nsCSSKeywordList.h"

RE_KEYWORD = re.compile(r"\beCSSKeyword_(\w+)")
rg_result = subprocess.check_output(["rg", r"eCSSKeyword_\w+"], encoding="UTF-8")
to_keep = set()
for item in rg_result.splitlines():
    file, line = item.split(':', 1)
    for m in RE_KEYWORD.finditer(line):
        to_keep.add(m.group(1))

remaining_lines = []
RE_ITEM = re.compile(r"CSS_KEY\(.+, (\w+)\)")
with open(LIST_FILE, "r") as f:
    for line in f:
        m = RE_ITEM.search(line)
        if m is not None and m.group(1) not in to_keep:
            print("Removing " + m.group(1))
            continue
        remaining_lines.append(line)
with open(LIST_FILE, "w", newline="") as f:
    f.writelines(remaining_lines)
```

MozReview-Commit-ID: upyTPc8984

--HG--
extra : source : 65a744682fe99d8f0de4fa4b7a478e10aba0349e
2018-06-27 15:34:29 +10:00
Xidorn Quan
a18ad3b214 Bug 1471114 part 5 - Remove unused keyword tables. r=emilio
This is done with the following script:
```python
#!/usr/bin/env python3

import re
import subprocess

from pathlib import Path

HEADER = Path("layout/style/nsCSSProps.h")
SOURCE = Path("layout/style/nsCSSProps.cpp")

RE_TABLE = re.compile(r"\b(k\w+KTable)")
rg_result = subprocess.check_output(["rg", r"\bk\w+KTable"], encoding="UTF-8")
to_keep = set()
all = set()
for item in rg_result.splitlines():
    file, line = item.split(':', 1)
    name = RE_TABLE.search(line).group(1)
    path = Path(file)
    if path != HEADER and path != SOURCE:
        to_keep.add(name)
    else:
        all.add(name)

to_remove = all - to_keep
remaining_lines = []
with HEADER.open() as f:
    for line in f:
        m = RE_TABLE.search(line)
        if m is not None and m.group(1) in to_remove:
            print("Removing " + m.group(1))
            continue
        remaining_lines.append(line)
with HEADER.open("w", newline="") as f:
    f.writelines(remaining_lines)

remaining_lines = []
removing = False
RE_DEF = re.compile(r"KTableEntry nsCSSProps::(k\w+KTable)\[\]")
with SOURCE.open() as f:
    for line in f:
        if removing:
            if line == "};\n":
                removing = False
            continue
        m = RE_DEF.search(line)
        if m is not None and m.group(1) in to_remove:
            if remaining_lines[-1] == "\n":
                remaining_lines.pop()
            removing = True
            continue
        remaining_lines.append(line)
with SOURCE.open("w", newline="") as f:
    f.writelines(remaining_lines)
```

MozReview-Commit-ID: FeDZRcBceqV

--HG--
extra : source : fe9369e5cef11a6c6eaac641c185844eb45554b1
2018-06-27 15:34:29 +10:00
Xidorn Quan
a01792b85b Bug 1471114 part 4 - Remove unused getter functions from nsComputedDOMStyle. r=emilio
This is done with the following script:
```python
#!/usr/bin/env python3

import re
import sys

from pathlib import Path

if len(sys.argv) != 2:
    print("Usage: {} objdir".format(sys.argv[0]))
    exit(1)

generated = Path(sys.argv[1]) / "layout" / "style"
generated = generated / "nsComputedDOMStyleGenerated.cpp"
RE_GENERATED = re.compile(r"DoGet\w+")
keeping = set()
with generated.open() as f:
    for line in f:
        m = RE_GENERATED.search(line)
        if m is not None:
            keeping.add(m.group(0))

HEADER = "layout/style/nsComputedDOMStyle.h"
SOURCE = "layout/style/nsComputedDOMStyle.cpp"

# We need to keep functions invoked by others
RE_DEF = re.compile(r"nsComputedDOMStyle::(DoGet\w+)\(\)")
RE_SRC = re.compile(r"\b(DoGet\w+)\(\)")
with open(SOURCE, "r") as f:
    for line in f:
        m = RE_DEF.search(line)
        if m is not None:
            continue
        m = RE_SRC.search(line)
        if m is not None:
            keeping.add(m.group(1))

removing = set()
remaining_lines = []
with open(HEADER, "r") as f:
    for line in f:
        m = RE_SRC.search(line)
        if m is not None:
            name = m.group(1)
            if name not in keeping:
                print("Removing " + name)
                removing.add(name)
                continue
        remaining_lines.append(line)

with open(HEADER, "w", newline="") as f:
    f.writelines(remaining_lines)

remaining_lines = []
is_removing = False
with open(SOURCE, "r") as f:
    for line in f:
        if is_removing:
            if line == "}\n":
                is_removing = False
            continue
        m = RE_DEF.search(line)
        if m is not None:
            name = m.group(1)
            if name in removing:
                remaining_lines.pop()
                if remaining_lines[-1] == "\n":
                    remaining_lines.pop()
                is_removing = True
                continue
        remaining_lines.append(line)

with open(SOURCE, "w", newline="") as f:
    f.writelines(remaining_lines)
```

MozReview-Commit-ID: ACewvZ9ztWp

--HG--
extra : source : 7f167f9affd954da907d1da307ebc82be4b85911
2018-06-27 15:34:29 +10:00
Xidorn Quan
cd114ec151 Bug 1471114 part 3 - Drop the reference to getter functions we don't call. r=emilio
MozReview-Commit-ID: IbBayOwsjNX

--HG--
extra : source : 82ce1f7b7fd21c406cf61726c78de5f120028e35
2018-06-27 15:34:29 +10:00
Xidorn Quan
dca9867a8f Bug 1471114 part 2 - Generate ComputedStyleMap entry list from property data. r=emilio
This changes the order of properties returned from gCS. The old order
doesn't make much sense, and other browsers don't agree on an identical
order either, so it should be trivial to change it. Also the spec isn't
super clear / useful in this case.

Several -moz-prefixed properties are excluded from the list due to their
being internal. I suspect they are never accessible anyway, so probably
nothing gets changed by this.

MozReview-Commit-ID: 9LfangjpJ3P

--HG--
extra : source : 879a7265c35f51c5954d8a44ccd374a606ecba0e
2018-06-27 15:34:29 +10:00
Xidorn Quan
d1caa962ed Bug 1471114 part 1 - Move CSSPropFlags prefix generation into GenerateServoCSSPropList.py. r=emilio
MozReview-Commit-ID: E5dl9V2B2dq

--HG--
extra : source : 6e2448ce3f4d9965749298a575795dfab926b9cb
2018-06-27 15:34:29 +10:00
Xidorn Quan
46cae3d7aa Bug 1471104 followup - Upgrade cssparser and revendor.
MozReview-Commit-ID: 74rBgkJEcYd

--HG--
extra : rebase_source : a30d17b3d7e24f1a61c01d1dc442d6ce60c1dde3
extra : source : 8ff268ee87b7392391a6b6aa981f9180c45b27b6
2018-06-27 10:43:21 +10:00
Xidorn Quan
dadd7149ea Bug 1471104 - Remove location from preludes and take it from argument. r=emilio
MozReview-Commit-ID: HeJUQvkacaf

--HG--
extra : rebase_source : b63b2949249ddb6d8e063a98bfeaa7656e6183fe
extra : source : 6f32be6912db802563ad33ae1d70756f3b3dcd8a
2018-06-27 10:42:51 +10:00
Gurzau Raul
78f3442000 Backed out changeset 04352a50d097 (bug 1465950) for linting failure on /enterprisepolicies/tests/browser/browser_policies_getActivePolicies.js on a CLOSED TREE 2018-06-27 06:55:53 +03:00
Jean-Yves Avenard
f6a7d4ea1a Bug 1471214 - Ensure that DictionaryBase copy constructor is called. r=bzbarsky
Such that a call to dictionary.IsAnyMemberPresent() will return the correct value.

Differential Revision: https://phabricator.services.mozilla.com/D1829
2018-06-26 21:56:45 +00:00
Sam Foster
458a39e2cd Bug 1471263 - Unbork and un-skip the test_show_field_specific_error_on_addresschange test. r=jaws,MattN
MozReview-Commit-ID: BNvWDBF5HDH

--HG--
extra : rebase_source : 17ddaa6da49d74fedd2412cc601f63ba2f2050e8
2018-06-26 16:56:20 -07:00
Andrew Halberstadt
4984a86e83 Bug 1464419 - [tryselect] Ability to specify --query multiple times with |mach try fuzzy| r=jmaher
Currently it's possible to specify a single query and take the union of terms with the '|'
symbol. However if you want to craft anything more complicated (i.e linux mochitest and
xpcshell, but windows reftest), it becomes really difficult. This allows developers to union
the result of multiple queries.

For example:
./mach try fuzzy -q "'linux 'mochitest | 'xpschell" -q "'windows 'reftest"

Differential Revision: https://phabricator.services.mozilla.com/D1838
2018-06-26 22:08:07 +00:00
Bogdan Tara
ee8db3bbe1 Backed out 2 changesets (bug 1447116) for debug reftests failures CLOSED TREE
Backed out changeset 0c8c7b025aee (bug 1447116)
Backed out changeset 82dc9159f28d (bug 1447116)
2018-06-27 05:17:03 +03:00
Kartikaya Gupta
4b90819f59 Bug 1466950 - Fix test to work on Android. r=hiro
MozReview-Commit-ID: G2NTiGUiw5Y

--HG--
extra : rebase_source : 149e87e81d115cbb1a1b1684e0022fc24f7a7eb5
2018-06-26 09:20:21 -04:00
Kartikaya Gupta
b564a1c166 Bug 1471220 - Record the WR display list build time in the flb phase of content paint telemetry. r=mattwoodrow
MozReview-Commit-ID: 3nZxztEdXef

--HG--
extra : rebase_source : fe889adca13d21d857881e19fbffb3387afc18f4
2018-06-26 09:53:25 -04:00
Hiroyuki Ikezoe
5a526baa41 Bug 1471174 - Drop opacity value that was for preventing the animations run on the compositor and check the animation is NOT running on the compositor. r=birtles
Because now we don't try to send the animations on visibility:hidden element.

MozReview-Commit-ID: IFqIc8ewz5T

--HG--
extra : rebase_source : ed031b3a55fd89f74437b71812f90dfc1825e823
2018-06-27 09:40:55 +09:00
Hiroyuki Ikezoe
5bb979bdfb Bug 1471174 - Don't try to send invisible animations that we already throttled on the main thread. r=birtles
Even if we unthrottled the invisbile animations to update the overflow region,
we don't need to send the animations to the compositor since the scroll bar
updates caused by the overflow should have been finished before sending
animations to the compositor.

MozReview-Commit-ID: GtKdPfBSyRB

--HG--
extra : rebase_source : 3b15f4578ed60740c1409304fe35ecd4f53fbd5b
2018-06-27 09:40:52 +09:00
Hiroyuki Ikezoe
048a8ca37c Bug 1471174 - Constify nsIFrame::IsScrolledOutOfView. r=birtles
The reason why const_cast is used for nsLayoutUtils::GetNearestScrollableFrame
is that if we changed the function as well, it ends up scattering const_cast
in most call sites of the function.  That's because GetNearestScrollableFrame
has a do_QueryFrame call for the given nsIFrame* and returns the queried frame,
so it will be like this;

 const nsIScrollableFrame* GetNearestScrollableFrame(const nsIFrame*, ..)

Most call sites of this function are then calls do_QueryFrame for the returned
nsIScrollableFrame*.

MozReview-Commit-ID: EwccKUITL89

--HG--
extra : rebase_source : f3b915fc78c096ca18d0922c764d15d73d552910
2018-06-27 09:08:36 +09:00
Hiroyuki Ikezoe
7cf6c6e8ac Bug 1471241 - Set dom.animations-api.core.enabled for 1343139-1.html. r=birtles
Since the test relies on missing keyframes handling.

MozReview-Commit-ID: IfbMvRhIeOh

--HG--
extra : rebase_source : 447bec6c7bc8d8a79f00bb738182e0647ee68ec5
2018-06-27 06:04:21 +09:00
Xidorn Quan
cca2036556 Bug 1471116 - Use nsCSSProps::kPropertyPrefTable for pref callback register of nsComputedDOMStyle. r=emilio
MozReview-Commit-ID: 7VvFGYi12te

--HG--
extra : rebase_source : de146bf00f8902ba01278cc70ddf231272fc5cee
2018-06-26 14:06:46 +10:00
Alexandre Poirot
b18ae66a40 Bug 1471152 - Package all panel scripts under resource://devtools/ instead of chrome://devtools/. r=jdescottes
MozReview-Commit-ID: 72iggFSZswN

--HG--
extra : rebase_source : 9e6192682deb3c7ecd162515a2a5ac6b391f9674
2018-06-25 12:59:22 -07:00
Razvan Caliman
7d8cbdcea7 Bug 1467408 - (Part 2) Add test for keyword values in font editor UI. r=gl
MozReview-Commit-ID: 2ROABhBBjFU

--HG--
extra : rebase_source : f60c1483081131f15eeafea5b1cfdd3127cf9101
2018-06-26 17:58:35 +02:00
Razvan Caliman
d2a0bdfb8e Bug 1467408 - (Part 1) Skip keyword values and use computed styles when populating the font editor. r=gl
MozReview-Commit-ID: DpOjrfEudL6

--HG--
extra : rebase_source : a625d0822049e4fc2a1bc1293cb6fe86e7bf862c
2018-06-26 17:00:07 +02:00
rforbes
a9523d34ea Bug 1470079 - Add fuzzing coverage build to taskcluster r=marco
MozReview-Commit-ID: 5TyxY2KmLCs

--HG--
extra : rebase_source : ad480d344e428ffcb1c31ab5bca1f6c9a468d6e1
2018-06-24 18:48:52 -07:00
Johannes Willbold
5c6e8a5e28 Bug 1438574: Changed unknown group semantic handling, r=dminor
Unknown group semantics are no longer an error but a warning indicating that the lines was skipped.
Made rust unit test test_parse_attribute_group more explicit.

MozReview-Commit-ID: 7adMSzH195H

--HG--
extra : rebase_source : b5edcdd389d5435808cb4faed5b8bf816774d0e4
2018-06-25 16:16:18 -07:00
Morgan Rae Reschenberg
41f649ace3 Bug 1471267 - Update some baseline-querying utility functions to bail on frames that have 'contain:size'. r=dholbert
MozReview-Commit-ID: Bk2P73tlRqG

--HG--
extra : rebase_source : f20c751b9dd902f295a2a2181a13453451327e2c
2018-06-26 15:34:15 -07:00
Marco Castelluccio
37e7ee033d Bug 1470151 - Support resetting/dumping coverage counters in per-test mode for xpcshell on Linux. r=jmaher
--HG--
extra : rebase_source : f2d33c3f952a04c96a4ca02691e10ff5241522bf
extra : source : c73f394a4bef01cccd76d635bce9d67e4a48f721
2018-06-21 14:41:32 +01:00