Commit Graph

29941 Commits

Author SHA1 Message Date
Agi Sferro
a6bb2f24f2 Bug 1635564 - Implement ensureBuiltIn. r=droeh,aklotz
Verified locally that reading the manifest does not affect performance in Fenix
(which uses 5 different built-in extensions) for google.com.

79.0.20200617184425 - Don't parse manifest

fully-drawn : avg: 2030 ± 11 stddev: 112 n=101
about:blank : avg: 2775 ± 26 stddev: 265 n=101
page loaded : avg: 3922 ± 50 stddev: 503 n=101

79.0.20200617205116 - Parse manifest

fully-drawn : avg: 2025 ± 13 stddev: 130 n=89
about:blank : avg: 2761 ± 24 stddev: 232 n=89
page loaded : avg: 3866 ± 39 stddev: 377 n=89

Differential Revision: https://phabricator.services.mozilla.com/D80567
2020-06-23 19:03:50 +00:00
Makoto Kato
f823fd996a Bug 1645725 - Remove chatsetMenu.properties l10n resource from GeckoView. r=geckoview-reviewers,Pike,snorp
`charsetMenu.properies` was for "Text Encoding" menu in Fennec (bug 611580).
EN was off as default, but some language such JA turned on this menu.

Since Fennec is gone, it is unnecessary now, so let's remove this resource.

Differential Revision: https://phabricator.services.mozilla.com/D79634
2020-06-22 09:00:40 +00:00
Makoto Kato
8dbe6d9df4 Bug 1490661 - Part 6. Add geckoview-junit test for enterkeyhint. r=geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D79647
2020-06-23 06:38:18 +00:00
Makoto Kato
426de38712 Bug 1490661 - Part 5. Implement current spec of enterkeyhint on Android backend. r=geckoview-reviewers,agi
When using `enterkeyhint` attribute, key event must be be fired as enter key.
So by previous changeset, I change action type to `maybenext` if inferring
action type without `enterkeyhint`.

Also, `enterkeyhint` can have additional values (enter and previous), so Android
back end should support it.

Differential Revision: https://phabricator.services.mozilla.com/D79646
2020-06-23 06:38:10 +00:00
Butkovits Atila
6b3af0dbd0 Backed out changeset 0238d868b580 (bug 1645725) for build bustage at FuzzyLayer.cpp. CLOSED TREE 2020-06-23 08:48:30 +03:00
Makoto Kato
f1375a999d Bug 1645725 - Remove chatsetMenu.properties l10n resource from GeckoView. r=geckoview-reviewers,Pike,snorp
`charsetMenu.properies` was for "Text Encoding" menu in Fennec (bug 611580).
EN was off as default, but some language such JA turned on this menu.

Since Fennec is gone, it is unnecessary now, so let's remove this resource.

Differential Revision: https://phabricator.services.mozilla.com/D79634
2020-06-22 09:00:40 +00:00
Gijs Kruitbosch
d523471eac Bug 1644863 - fix trailing whitespace in browser/toolkit/devtools/mobile frontend code files, r=mossop,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D79201
2020-06-17 22:40:53 +00:00
Mitchell Hentges
58848678dc Bug 1644794: Improve "missing JDK" error message and docs r=rstewart,geckoview-reviewers,agi
Additionally, recommends the installation of AdoptOpenJDK instead of the Oracle JDK.
This required a different "JAVA_HOME" detection mechanism, which is implemented in this revision.

Differential Revision: https://phabricator.services.mozilla.com/D79547
2020-06-17 12:17:48 +00:00
Kris Maglione
3bda67deab Bug 1638153: Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp
Differential Revision: https://phabricator.services.mozilla.com/D75429
2020-06-17 17:17:16 +00:00
Alessio Placitelli
978c11c581 Bug 1620656 - Remove 'geckoview' telemetry support. r=chutten,geckoview-reviewers,aklotz
This removes the support for the 'geckoview' telemetry in
the core and in the JSM files. It also cleans up testing
and the configurations.

Differential Revision: https://phabricator.services.mozilla.com/D79521
2020-06-16 12:22:55 +00:00
dpk
214e706476 Bug 1637431 - Gives meaningful tabs.query error message. r=robwu,geckoview-reviewers,agi
***
Bug 1637431 - Gives meaningful tabs.query error message. r=robwu

Differential Revision: https://phabricator.services.mozilla.com/D78466
2020-06-16 11:47:14 +00:00
Simon Giesecke
3ada66891d Bug 1645339 - Use range-based for with nsTObserverArray in mobile/android. r=geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D79504
2020-06-16 10:16:43 +00:00
Butkovits Atila
29b9d8b25a Backed out 3 changesets (bug 1620656) for causing bustage at TestGeckoView. CLOSED TREE
Backed out changeset af6b36a497e8 (bug 1620656)
Backed out changeset f0b502580ef0 (bug 1620656)
Backed out changeset dd0ce5e4a1bf (bug 1620656)
2020-06-16 13:22:04 +03:00
Alessio Placitelli
96574abcf1 Bug 1620656 - Remove 'geckoview' telemetry support. r=chutten,geckoview-reviewers,aklotz
This removes the support for the 'geckoview' telemetry in
the core and in the JSM files. It also cleans up testing
and the configurations.

Differential Revision: https://phabricator.services.mozilla.com/D79521
2020-06-16 08:49:12 +00:00
Nika Layzell
cde53b3bec Bug 1508306 - Part 1: Migate the Large-Allocation handler to DocumentLoadListener, r=mattwoodrow,necko-reviewers,geckoview-reviewers,agi,valentin
This removes the diagnostic warnings which used to be logged when the
Large-Allocation header was present, but failed to switch into a
Large-Allocation process. Due to the low adoption of the header, this shouldn't
be too large of a problem, but we can look into re-adding the diagnostics if
needed in the future.

The new codepath no longer performs multiple network requests for
Large-Allocation resources, and now relies on the battle-tested
DocumentLoadListener codepath for process switching.

Differential Revision: https://phabricator.services.mozilla.com/D78998
2020-06-15 23:24:07 +00:00
Nicholas Nethercote
a15b81b965 Bug 1572508 - Convert ui.touch.* and ui.mouse.* VarCache prefs to static prefs. r=KrisWright,kats,geckoview-reviewers,agi.
This is a weird conversion because the existing VarCache mirror prefs are in a
two static structs, one for touch prefs and one for the equivalent mouse prefs,
and we dynamically select the appropriate struct in `GetPrefsFor()`.

(But note that `ui.mouse.radius.reposition` and
`ui.mouse.radius.inputSource.touchOnly` do not have corresponding `touch`
prefs! For touch events they are always considered to be false.)

The commit make the following changes.
- It makes the prefs into static prefs.
- It moves the code in `GetPrefsFor()` into a constructor for
  `EventRadiusPrefs`, and copies the pref values into a temporary object of
  that type. Those copied values are then used by the subsequent code.
- It removes the two static `EventRadiusPrefs` structs.
- It renames some fields in `EventRadiusPrefs` to make them more closely match
  the pref names.

Differential Revision: https://phabricator.services.mozilla.com/D79405
2020-06-15 06:23:48 +00:00
Narcis Beleuzu
a8dde16e58 Backed out 10 changesets (bug 1508306, bug 1640019) for bc failures on browser_autoOpen.js . CLOSED TREE
Backed out changeset 8844170ff408 (bug 1508306)
Backed out changeset b750f1d873cf (bug 1508306)
Backed out changeset c7170e76e676 (bug 1640019)
Backed out changeset 5905995e4815 (bug 1640019)
Backed out changeset 7bf86513348e (bug 1640019)
Backed out changeset f7d0605295f7 (bug 1640019)
Backed out changeset 521b4d5a9a89 (bug 1640019)
Backed out changeset 8542edc564bc (bug 1640019)
Backed out changeset 4f6a03152526 (bug 1640019)
Backed out changeset 30d2bf04719b (bug 1640019)
2020-06-12 22:47:50 +03:00
Nika Layzell
47c0aeb539 Bug 1508306 - Part 1: Migate the Large-Allocation handler to DocumentLoadListener, r=mattwoodrow,necko-reviewers,geckoview-reviewers,agi,valentin
This removes the diagnostic warnings which used to be logged when the
Large-Allocation header was present, but failed to switch into a
Large-Allocation process. Due to the low adoption of the header, this shouldn't
be too large of a problem, but we can look into re-adding the diagnostics if
needed in the future.

The new codepath no longer performs multiple network requests for
Large-Allocation resources, and now relies on the battle-tested
DocumentLoadListener codepath for process switching.

Differential Revision: https://phabricator.services.mozilla.com/D78998
2020-06-12 16:52:13 +00:00
Eugen Sawin
e047f641f7 Bug 1644447 - [1.0] Remove deprecated telemetry snapshot API. r=geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D78909
2020-06-12 12:02:11 +00:00
Eugen Sawin
e888fdae80 Bug 1643928 - [1.0] Assert for extension IDs instead of comparing instances. r=geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D79158
2020-06-10 18:06:23 +00:00
Bogdan Tara
2b80bfb16b Backed out changeset 61bdbb94ab7a (bug 1637431) for browser_ext_tabs_cookieStoreId.js failures CLOSED TREE 2020-06-11 07:36:35 +03:00
dpk
43998630ac Bug 1637431 - Gives meaningful tabs.query error message. r=robwu,geckoview-reviewers,agi
***
Bug 1637431 - Gives meaningful tabs.query error message. r=robwu

Differential Revision: https://phabricator.services.mozilla.com/D78466
2020-06-11 03:44:23 +00:00
Mihai Alexandru Michis
9167a29a3a Backed out changeset 436777b95e22 (bug 1637431) for causing bc failures in browser_ext_tabs_cookieStoreId.js
CLOSED TREE
2020-06-11 06:35:23 +03:00
dpk
21f99d2072 Bug 1637431 - Removed a comment line, rev approved. r=robwu,geckoview-reviewers,agi
***
Bug 1637431 - Gives meaningful tabs.query error message. r=robwu

Differential Revision: https://phabricator.services.mozilla.com/D78466
2020-06-11 02:33:11 +00:00
James Willcox
f48f8ed0ee Bug 1643129 - Add a reload to GV auth prompt test r=geckoview-reviewers,aklotz
This is needed in order to catch certain problems with LoginStorage.jsm.

Differential Revision: https://phabricator.services.mozilla.com/D78142
2020-06-10 05:44:48 +00:00
Eugen Sawin
3834bcff96 Bug 1638311 - [1.1] Ignore input type=hidden elements for autofill. r=geckoview-reviewers,MattN,agi
Differential Revision: https://phabricator.services.mozilla.com/D78557
2020-06-09 20:34:18 +00:00
Agi Sferro
f0ab43adb7 Bug 1644297 - Re enable old browser.storage.sync on Android. r=rpl,snorp
This also adds a smoke test which runs on all platforms to avoid regressions.

Differential Revision: https://phabricator.services.mozilla.com/D78987
2020-06-10 17:19:56 +00:00
Mitchell Hentges
b341f73995 Bug 1632874: Update docs since mozconfig file is automatically created r=agi,geckoview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D79002
2020-06-10 01:13:13 +00:00
Emilio Cobos Álvarez
4e88a12703 Bug 1643656 - Fix GeckoRuntimeSettings color scheme configuration. r=geckoview-reviewers,snorp
So as to not use a pref with an invalid value, which I would've changed
the behavior of with the previous patch.

Differential Revision: https://phabricator.services.mozilla.com/D78957
2020-06-09 22:40:22 +00:00
Grace Bramley-Simmons
4ab1c522b1 Bug 1618987 - Removed WebExtensionController#setTabDelegate and related methods r=agi,geckoview-reviewers
Updated API docs to reflect removed method

Removed incorrect line to fix some bugs

Updated changelog

Added listener registration back into WebExtension Listener constructor

Differential Revision: https://phabricator.services.mozilla.com/D78977
2020-06-09 21:49:56 +00:00
Alexis Beingessner
fc174e020d Bug 1642344 - convert HTMLInputElement VarCache prefs to StaticPrefs. r=geckoview-reviewers,agi.
converts:
* dom.experimental_forms
* dom.forms.datetime.others
* dom.forms.color

Differential Revision: https://phabricator.services.mozilla.com/D77850
2020-06-09 14:45:50 +00:00
James Willcox
ed11539ff5 Bug 1642345 - Add 'source' field to WebNotification r=geckoview-reviewers,agi,esawin
Differential Revision: https://phabricator.services.mozilla.com/D78168
2020-06-09 13:47:53 +00:00
Dorel Luca
d05df77874 Backed out changeset d52680bbda73 (bug 1642345) for Mochitest failures in toolkit/components/alerts/test/test_alerts_noobserve.html. CLOSED TREE 2020-06-08 23:50:35 +03:00
James Willcox
d9995bd658 Bug 1642345 - Add 'source' field to WebNotification r=geckoview-reviewers,agi,esawin
Differential Revision: https://phabricator.services.mozilla.com/D78168
2020-06-08 17:22:17 +00:00
James Willcox
dff6c8722d Bug 1641064 - Fail screenshot captures immediately if we pause the compositor r=geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D78373
2020-06-04 23:40:01 +00:00
Aaron Klotz
064411f491 Bug 1643458: Remove numUnbindFailures from ServiceAllocator.InstanceInfo.updateBindings; r=geckoview-reviewers,agi
`numUnbindFailures` can never be non-zero (since any unbind failures throw), so
we should just eliminate this variable.

Differential Revision: https://phabricator.services.mozilla.com/D78362
2020-06-04 21:56:50 +00:00
Eugen Sawin
884ca900af Bug 1619766 - [2.0] Add WebExtension openOptionsPage tests. r=geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D78398
2020-06-05 17:21:31 +00:00
Eugen Sawin
60b2d3d9e9 Bug 1619766 - [1.2] Add WebExtension openOptionsPage support. r=agi,geckoview-reviewers,robwu
Differential Revision: https://phabricator.services.mozilla.com/D77901
2020-06-05 17:21:24 +00:00
John Lin
b6a091d9dd Bug 1628792 - p2: update GeckoHls* for API changes in exoplayer. r=agi,geckoview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D78390
2020-06-05 02:06:14 +00:00
John Lin
68b7382249 Bug 1628792 - p1: merge exoplayer r2.11.4 codebase. r=agi,geckoview-reviewers
Reference bugs:
- bug 1341990 (original import)
- bug 1523544 (package renaming)
- bug 1457255 (warning fixes)
- bug 1459420 (Firefox ProxySelector support)

Differential Revision: https://phabricator.services.mozilla.com/D78389
2020-06-04 21:18:43 +00:00
Rob Wu
8162b376d4 Bug 1642671 - Add tests for falsey result from runtime.onMessage r=zombie,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D77895
2020-06-03 17:26:43 +00:00
Agi Sferro
570ba4b9d5 Bug 1642429 - Use checkstyle to enforce that all API methods have docs. r=esawin,snorp
Differential Revision: https://phabricator.services.mozilla.com/D77693
2020-06-02 15:05:13 +00:00
Makoto Kato
0917864e45 Bug 1593683 - Part 2. Handle arrow left/right key when having composition. r=geckoview-reviewers,esawin
Most IMEs handle arrow key, then set caret position by IME. But GBoard doesn't
handle it. GBoard will dispatch key event to application for arrow left/right
even if having IME composition.

Since Gecko doesn't dispatch key press during IME composition due to DOM UI
events spec, we have to emulate arrow key's behaviour.

And, `GeckoEditable` has a hack that composition text is committed when
dispatching key event. This hack is unnecessary after landing
bug 1613804 that `InputConnection.finishComposingText` is implemented.

Differential Revision: https://phabricator.services.mozilla.com/D76658
2020-06-01 08:36:29 +00:00
Razvan Maries
a36bb7751f Backed out 3 changesets (bug 1638153) for perma failures on cross-origin-objects.html. CLOSED TREE
Backed out changeset f7aedc92d396 (bug 1638153)
Backed out changeset 07ec713926c6 (bug 1638153)
Backed out changeset 5a656842e241 (bug 1638153)
2020-06-01 23:51:35 +03:00
Kris Maglione
b3fcd970ec Bug 1638153: Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp
Differential Revision: https://phabricator.services.mozilla.com/D75429
2020-06-01 17:59:01 +00:00
Agi Sferro
582feb1629 Bug 1575999 - Always run javadoc tasks during lint. r=nalexander,esawin
Differential Revision: https://phabricator.services.mozilla.com/D77489
2020-06-01 15:58:03 +00:00
Agi Sferro
bf1d097cb9 Bug 1641711 - Make javadoc output parsing more resilient. r=snorp
As it turns out, javadoc output is not stable across platforms / OSs / versions
(not a big suprise).

E.g. in try this is an example line:

```
/builds/worker/checkouts/gecko/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java:1124: warning - Tag @link: reference not found: Autocomplete.LoginStorageDelegate.onLoginFetch onLoginFetch
```

on my mac, this is the same error:

```
/Users/asferro/workspace/mozilla-central/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java:1118: error: reference not found
     * {@link Autocomplete.LoginStorageDelegate.onLoginFetch onLoginFetch}.
```

Notice the `-` character after `warning` in the first example and the `:`
character after the second example.

To be able to parse both this patch simiplifies the regex and also adds a
failsafe that will mark anything that contains the string "error" and "warning"
as such.

Differential Revision: https://phabricator.services.mozilla.com/D77545
2020-06-01 15:58:05 +00:00
Agi Sferro
519207a6a8 Bug 1641711 - Don't fail the build if javadoc fails. r=nalexander,snorp,esawin
`|mach lint -f treeherder|` expects lint to not fail ever, if a lint fails it's
just ignored. This means that when our javadoc errors out and fails the build
all lints are ignored.

To avoid that we add `failOnError = false` to the javadoc job so that we can
finish the build and actually report the errors.

This patch also adds gradle output `|mach lint|` to make it easier to
diagnose errors in the lint.

Differential Revision: https://phabricator.services.mozilla.com/D77373
2020-06-01 15:58:13 +00:00
Tomislav Jovanovic
8f0bdce123 Bug 1583484 - Move extension messaging off MessageChannel r=geckoview-reviewers,mixedpuppy,agi
Differential Revision: https://phabricator.services.mozilla.com/D74026
2020-05-22 22:50:46 +00:00
Mihai Alexandru Michis
7ac149a023 Backed out 2 changesets (bug 1593683) for causing failures in test_selectevents.html
Backed out changeset 05d7ad574df4 (bug 1593683)
Backed out changeset 16cc9284bc5f (bug 1593683)
2020-06-01 06:29:24 +03:00