Commit Graph

8930 Commits

Author SHA1 Message Date
Eitan Isaacson
6e8749d0da Bug 1693597 - P2: Rename ProxyAccessible to RemoteAccessible. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D105671
2021-02-19 23:14:33 +00:00
Eitan Isaacson
6e49732365 Bug 1693597 - P1: Rename Accessible to LocalAccessible. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D105670
2021-02-19 23:14:32 +00:00
Eitan Isaacson
f48f468cb7 Bug 1693607 - [Linux] Add braces around statements. r=morgan
This is a collaboration between clang-tidy and clang-format.

clang-tidy uses compiled code paths, so this patch is linux specific.

Differential Revision: https://phabricator.services.mozilla.com/D105669
2021-02-19 23:14:32 +00:00
Morgan Reschenberg
e71c1fa4ff Bug 1648813: Verify acc description when waiting for load/layout event r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D105373
2021-02-18 18:04:59 +00:00
Alexis Beingessner
07f2f659c6 Bug 1686616 - make StringBundle use Components instead of Services. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D105531
2021-02-18 13:26:32 +00:00
Alexis Beingessner
ade0725530 Bug 1686616 - make GfxInfo use Components instead of Services. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D105522
2021-02-18 13:26:29 +00:00
Emilio Cobos Álvarez
5d7295db79 Bug 1693429 - Fix some typos in a11y mochitests. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D105549
2021-02-18 04:23:40 +00:00
Morgan Reschenberg
9343b6370d Bug 1460378: Verify role, role description mapping for meter element on mac r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D104760
2021-02-17 15:58:31 +00:00
Morgan Reschenberg
588e12696e Bug 1460378: Introduce meter role and HTMLMeterAccessible class. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D104759
2021-02-17 15:58:31 +00:00
Markus Stange
355baf5b39 Bug 1692391 - Rename NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK macros, replacing ABORT with IGNORE. These macros just log the exception and move on, without aborting. r=haik
This patch was generated automatically, using the following commands:

```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK/NS_OBJC_BEGIN_TRY_IGNORE_BLOCK/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK/NS_OBJC_END_TRY_IGNORE_BLOCK/g'
```

Differential Revision: https://phabricator.services.mozilla.com/D104960
2021-02-16 22:55:21 +00:00
Markus Stange
9bc888af4a Bug 1692391 - Replace NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NIL with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(nil). r=haik
This patch was generated automatically, using the following commands:

```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NIL' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NIL/NS_OBJC_BEGIN_TRY_BLOCK_RETURN/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK_NIL' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK_NIL/NS_OBJC_END_TRY_BLOCK_RETURN(nil)/g'
```

Differential Revision: https://phabricator.services.mozilla.com/D104959
2021-02-16 22:55:21 +00:00
Markus Stange
56051da2d0 Bug 1692391 - Replace the NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NSRESULT macros with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(NS_ERROR_FAILURE). r=haik
This patch was generated with the commands:

```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT/NS_OBJC_BEGIN_TRY_BLOCK_RETURN/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK_NSRESULT' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK_NSRESULT/NS_OBJC_END_TRY_BLOCK_RETURN(NS_ERROR_FAILURE)/g'
```

Differential Revision: https://phabricator.services.mozilla.com/D104957
2021-02-16 22:55:20 +00:00
Markus Stange
5257db6695 Bug 1692391 - Remove the word ABORT from the NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_RETURN macros, because these macros don't abort. r=haik,necko-reviewers
This patch was generated automatically with the commands below:

```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_RETURN' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK_RETURN/NS_OBJC_BEGIN_TRY_BLOCK_RETURN/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK_RETURN' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK_RETURN/NS_OBJC_END_TRY_BLOCK_RETURN/g'
```

Differential Revision: https://phabricator.services.mozilla.com/D104955
2021-02-16 22:55:20 +00:00
Sylvestre Ledru
4fe9680965 no bug - Remove a pylint warning - variable 'text' is unused r=mstange DONTBUILD
Depends on D105299

Differential Revision: https://phabricator.services.mozilla.com/D105300
2021-02-16 21:10:33 +00:00
Eitan Isaacson
ff59e176e4 Bug 1692523 - P2: Prefix remote heirarchy functions with 'Remote'. r=Jamie
Parent -> RemoteParent
ChildAt -> RemoteChildAt
FirstChild -> RemoteFirstChild
LastChild -> RemoteLastChild
NextSibling -> RemoteNextSibling
PrevSibling -> RemotePrevSibling

Differential Revision: https://phabricator.services.mozilla.com/D105035
2021-02-16 20:05:11 +00:00
Eitan Isaacson
8c842a59e3 Bug 1692523 - P1: Prefix local heirarchy functions with 'Local'. r=Jamie
Parent -> LocalParent
GetChildAt -> LocalChildAt
FirstChild -> LocalFirstChild
LastChild -> LocalLastChild
NextSibling -> LocalNextSibling
PrevSibling -> LocalPrevSibling

Differential Revision: https://phabricator.services.mozilla.com/D105034
2021-02-16 20:05:10 +00:00
Simon Giesecke
338908171d Bug 1692846 - Remove redundant nullptr checks of return value of infallible new in accessible/. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D105174
2021-02-16 08:43:57 +00:00
Gerald Squelart
2416d881e2 Bug 1691589 - Reduce reliance on GeckoProfiler.h when only labels (and maybe markers) are needed - r=necko-reviewers,geckoview-reviewers,sg,agi,florian
There are no code changes, only #include changes.
It was a fairly mechanical process: Search for all "AUTO_PROFILER_LABEL", and in each file, if only labels are used, convert "GeckoProfiler.h" into "ProfilerLabels.h" (or just add that last one where needed).
In some files, there were also some marker calls but no other profiler-related calls, in these cases "GeckoProfiler.h" was replaced with both "ProfilerLabels.h" and "ProfilerMarkers.h", which still helps in reducing the use of the all-encompassing "GeckoProfiler.h".

Differential Revision: https://phabricator.services.mozilla.com/D104588
2021-02-16 04:44:19 +00:00
Simon Giesecke
780a1636a9 Bug 1691894 - Replace several suboptimal uses of Put after Get by GetOrInsertWith or WithEntryHandle. r=xpcom-reviewers,necko-reviewers,kmag,valentin,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D104849
2021-02-15 15:12:17 +00:00
smolnar
1afbbe67e1 Backed out 5 changesets (bug 1691894) for causing hazard failures in nsXULPrototypeCache. CLOSED TREE
Backed out changeset 22dc870ee609 (bug 1691894)
Backed out changeset 58c31e9d6ae3 (bug 1691894)
Backed out changeset 7483e84149d8 (bug 1691894)
Backed out changeset f977d6cfa973 (bug 1691894)
Backed out changeset db4503476f34 (bug 1691894)
2021-02-15 16:43:23 +02:00
Simon Giesecke
8973094ec1 Bug 1691894 - Replace several suboptimal uses of Put after Get by GetOrInsertWith or WithEntryHandle. r=xpcom-reviewers,necko-reviewers,kmag,valentin,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D104849
2021-02-15 10:04:45 +00:00
James Teh
a7a374a0cd Bug 1652192: Enable event logging for accessible/tests/browser/states/browser_test_visibility.js. r=yzen
I can't reproduce this on try, so I'm landing this so I can get (hopefully) useful info next time it fails.

Differential Revision: https://phabricator.services.mozilla.com/D104942
2021-02-14 22:14:03 +00:00
james
16060f0cc4 Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D104552
2021-02-13 23:33:51 +00:00
Narcis Beleuzu
ed6880e281 Backed out changeset b3fcb4fcea64 (bug 1691274) for bc failures on browser_pointerlock_warning.js . CLOSED TREE 2021-02-13 21:46:51 +02:00
james
8069ab6165 Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D104552
2021-02-13 18:11:18 +00:00
Mark Banner
263d555274 Bug 1608272 - Remove 'this' as the second argument to 'ChromeUtils.import', use object destructuring instead (test-only changes). r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D104683
2021-02-11 22:02:15 +00:00
Eitan Isaacson
5d2f41bc6e Bug 1691623 - Wait for text attr change event that precedes misspelled attribute. r=morgan.
Differential Revision: https://phabricator.services.mozilla.com/D104727
2021-02-10 20:04:41 +00:00
Morgan Reschenberg
1fe81c2358 Bug 1691502: Don't attempt to invalidate table cache on outlines r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D104432
2021-02-10 18:29:36 +00:00
Morgan Reschenberg
8a85843ede Bug 1648813: Wait for AXLoadComplete on spawned tab based on label r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D104553
2021-02-10 18:29:02 +00:00
Eitan Isaacson
b8ab9d0b57 Bug 1691345 - Check that focused child doc is a descendant of caller's doc. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D104546
2021-02-10 17:01:22 +00:00
Eitan Isaacson
49dfc2e434 Bug 1691831 - Clamp offsets to character count in HyperTextIterator. r=morgan
I tried to come up with a good test for this, that reproduces the issue in a demonstratable way, but couldn't.

Differential Revision: https://phabricator.services.mozilla.com/D104586
2021-02-10 06:58:40 +00:00
Morgan Reschenberg
f4a86a8e84 Bug 1690924: Wait for focus event instead of selected children changed r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D104264
2021-02-09 17:57:04 +00:00
Nika Layzell
661b4db5f0 Bug 1689147 - Part 4: Switch nested and prio to extended attributes, r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D103369
2021-02-09 16:50:22 +00:00
Yura Zenevich
c72349ac1a Bug 1689445 - revert EventUtils.sendMouseEvent back to being sync. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D104127
2021-02-09 01:30:08 +00:00
James Teh
f01ed6dea6 Bug 1646486: Move dom::Document::IsVisibleConsideringAncestors to a11y::nsCoreUtils::IsDocumentVisibleConsideringInProcessAncestors. r=emilio
Renaming the function makes it clear that it only deals with in-process ancestors, which is an important distinction for Fission.
A11y is the only consumer of this and it only cares about in-process ancestors in this case (OOP stuff is handled elsewhere), so the functionality doesn't need to change.
Since a11y is the only consumer, move this into the a11y code.

Differential Revision: https://phabricator.services.mozilla.com/D104341
2021-02-09 00:44:21 +00:00
Eitan Isaacson
0a92b9e380 Bug 1690342 - P5: Use AXTextArea for multiline aria text boxes. r=morgan DONTBUILD
Now that we have attribtued text we don't need to advertise rich text editables as AXTextField.

Differential Revision: https://phabricator.services.mozilla.com/D103803
2021-02-08 23:26:49 +00:00
Eitan Isaacson
cb03a1923c Bug 1690342 - P4: Implement IPC attributed text getter. r=morgan DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D103802
2021-02-08 23:26:47 +00:00
Eitan Isaacson
b9559d486e Bug 1690342 - P3: Add protocol stubs for mac attributed text. r=Jamie,mccr8,ipc-reviewers DONTBUILD
Created DocAccessibleTypes.ipdlh to put common types so they can be used in platform
extension protocols.

Differential Revision: https://phabricator.services.mozilla.com/D103801
2021-02-08 23:26:39 +00:00
Eitan Isaacson
e6912635e0 Bug 1690342 - P2: Populate NSAttributedText attributes with attributes. r=morgan DONTBUILD
A followup patch will make this work in e10s. This current implementation is non-ipc.

Differential Revision: https://phabricator.services.mozilla.com/D103800
2021-02-08 23:26:31 +00:00
Eitan Isaacson
84896a7a88 Bug 1690342 - P1: Introduce moxAncestorSearch for finding ancestors. r=morgan DONTBUILD
It looks like we need to do this often. Adding it to the protocol/base class allows
us to not have to worry each time about typing and traversing past MOX accessibles.

Differential Revision: https://phabricator.services.mozilla.com/D103799
2021-02-08 23:26:24 +00:00
Paul Zuehlcke
cbda00d7e1 Bug 1596897 - Updated tests for decoupled permissions panel. r=johannh,remote-protocol-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D99893
2021-02-05 13:40:42 +00:00
Tim Nguyen
864f262237 Bug 1691077 - Remove obsolete Fennec special case for nsDeckFrame a11y code. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D104240
2021-02-07 23:03:40 +00:00
Mihai Alexandru Michis
6da97a654e Backed out 2 changesets (bug 1689445) for causing bc failures in browser_search.js
Backed out changeset 2b1ec882c4c1 (bug 1689445)
Backed out changeset bcb4ba398ee0 (bug 1689445)
2021-02-06 05:33:02 +02:00
Yura Zenevich
d3beb62c1d Bug 1689445 - revert EventUtils.sendMouseEvent back to being sync. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D104127
2021-02-05 21:26:54 +00:00
James Teh
e81436a8a8 Bug 1689936: Move pending a11y content insertions into a temporary data structure before processing them. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D103977
2021-02-05 00:01:59 +00:00
Morgan Reschenberg
b6cdc22e2b Bug 1680840: Introduce table style changed event to mac platform, update caching r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D103698
2021-02-04 20:50:12 +00:00
Morgan Reschenberg
1f72fbb6eb Bug 1680840: Fire table styling changed event when style changes that may affect data/layout table classification r=emilio,eeejay
Differential Revision: https://phabricator.services.mozilla.com/D103254
2021-02-04 20:50:05 +00:00
Morgan Reschenberg
ced0045bea Bug 1688490: Make GetNativeFromGeckoAccessible null-safe r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D103813
2021-02-04 19:41:30 +00:00
Morgan Reschenberg
6b8df6efbe Bug 1686744: Fire AXMenuItemSelected notification when menu item is pressed r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D103954
2021-02-04 19:41:37 +00:00
James Teh
1b4d4c6a32 Bug 1690456: Don't allow nsAccessibilityService to be shut down while a parent document is still shutting down. r=yzen
DocAccessible::Shutdown calls DocManager::NotifyOfDocumentShutdown, which can shut down nsAccessibilityService if there are no more consumers.
Previously, this could happen even when shutting down child documents.
Since shutting down the service shuts down all documents, this resulted in shutting down the parent document within an outer call to shut down that same document.
Even if that reentry were prevented, the service would have been gone when returning to the outer Shutdown call, which still needs the service to complete its cleanup.

To fix this, DocManager::NotifyOfDocumentShutdown takes an argument specifying whether to allow service shutdown.
This is set to false when shutting down child documents.
The service is thus allowed to shut down when returning to the parent document Shutdown.

In addition, mPresShell is cleared before shutting down child documents to prevent reentry like this.
While this should no longer happen, this should safeguard against similar pain in future.

Differential Revision: https://phabricator.services.mozilla.com/D103966
2021-02-04 01:10:52 +00:00