Automatic update from web-platform-tests
[LayoutNG] Use BoxLayoutExtraInput when calculating overflow.
This will set temporary proper override sizes.
We already use this mechanism in NGBlockNode::RunLegacyLayout(), but
that one only has an effect for things that are done from within legacy
layout (LayoutObject::Layout()). Overflow calculation happens after
layout, and is done by the legacy engine, even for NG objects.
Bug: 908083
Change-Id: I2b4e88c096f138aa820856e3c79e1ddcef07a3da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801770
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696752}
--
wpt-commits: 149354218b0d2f62f1907d9fe8becfc94a8d138f
wpt-pr: 19043
Automatic update from web-platform-tests
[css-text] Adjust trailing space tests in response to https://github.com/w3c/csswg-drafts/issues/4180 (#18949)
--
wpt-commits: 0bfde9f6a8bfde0fde4dba73d7172a8eed6e946e
wpt-pr: 18949
Automatic update from web-platform-tests
[LayoutNG] Allow overflow-/word-wrap to work with keep-all
When `word-break: break-all` or `keep-all` is specified, this
patch fixes `overflow-/word-wrap: break-word` to be effective.
Before this patch, it was forced to be `normal`.
Bug: 1001378
Change-Id: I73f5956a6856f2cbd0944461a0aa7a2929e722cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806162
Commit-Queue: Koji Ishii <kojii@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696724}
--
wpt-commits: 5aaf335a29ebb5fde4b91f8e0032b03418b2a4be
wpt-pr: 19081
Automatic update from web-platform-tests
Remove tests for SVG transform with CSS syntax - part 1 (#11169)
Remove tests for SVG transform with CSS syntax - part 1
--
wpt-commits: 91985c1463b4a4abbeae3787e49c0e02c063bc2d
wpt-pr: 11169
Automatic update from web-platform-tests
Add smfr as reviewer for CSS Transforms (#19074)
Add smfr as reviewer for CSS Transforms
--
wpt-commits: c8845745bd2ee464977ffc4333b80c89d72bebd2
wpt-pr: 19074
Automatic update from web-platform-tests
MathML: Add per-element detection functions and avoid more false positive results. (#19068)
Note: For now detection of support for several elements rely on detection functions for other MathML elements.
--
wpt-commits: 2010c92cac5ee92ae1aef35240603c2e805261ac
wpt-pr: 19068
Automatic update from web-platform-tests
[css-writing-modes-3] Fix error in test reference; adjust test to be easier to interpret also. (#19059)
--
wpt-commits: c850921dd5b241913a97b99b05cecbbb1242755c
wpt-pr: 19059
Automatic update from web-platform-tests
[LayoutNG] Fix may_break_inside in NGLineBreaker
This patch fixes |may_break_inside| in |NGLineBreaker|.
Issue 1002442 revealed an error case in |ShapingLineBreaker|.
In that case, it returns a result whose size is larger than
the available space.
Before this patch, |NGLineBreaker| assumes that the line
overflows if the result size is larger than the available
size, and sets |may_break_inside| to |false|, which
prevents breaking in |HandleOverflow()|. This can cause
rather a large layout error.
crrev.com/c/1797954 tried to fix the error in
|ShapingLineBreaker|, but it looks like some tests is relying
on the behavior and it was reverted.
This patch instead makes |NGLineBreaker| more robust, by
using the actual overflow state from |ShapingLineBreaker| to
compute |may_break_inside|. The error in |ShapingLineBreaker|
is not fixed yet, but with this fix, the worst result is to
not able to fit a word that can fit by less than 1px or so.
Further work for better correctness will be tracked in
issue 1003742.
Bug: 1002442, 1003742
Change-Id: I13a3172abc8a0d2f5f78b2dd0b57b85de593fdff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803019
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696621}
--
wpt-commits: 8df929fdf1fe83d96cd85c8e0d3dfcef931e6270
wpt-pr: 19045
Automatic update from web-platform-tests
[motion-1] Drop a limit test of interpolation for offset shorthand (#19052)
The CSS spec says that any arbitrary limit is OK, so different browsers
may use different limits for `offset-distance`.
This was added because of a Chromium regression, and it'd be great to move
it into Chromium repo.
--
wpt-commits: eaf091c6d35126dc72abea1d1fe258c563286e52
wpt-pr: 19052
Automatic update from web-platform-tests
CSS: Serialize font shorthand with spaces around '/'
Each '/' is a CSS value should have a space before and after.
https://github.com/w3c/csswg-drafts/issues/4282
Omit 'normal' values from computed font serialization.
Change-Id: Iebbfe80ae0c7c3ebe0101b432c0d95a7d265154f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800894
Commit-Queue: Emil A Eklund <eae@chromium.org>
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696522}
--
wpt-commits: 5488ba49034a78c2fdfe7ca0d898ed3adb238f6b
wpt-pr: 19025
Automatic update from web-platform-tests
[Payments] Enable shipping and contact info delegation [3/5]
This cl includes paymentOptions and shippingOptions(when shipping is requested)
in PaymentRequestEvent and shipping(selected option id and address)/contact
information in PaymentHandlerResponse.
For overall flow please check
https://chromium-review.googlesource.com/c/chromium/src/+/1779003TBR=mek@chromium.org,chishtr@chromium.org
Bug: 984694
Change-Id: Ie9587c68c2a20c76efd94ee97b750cbbf300aff4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798571
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696519}
--
wpt-commits: 3029ad22406c9abec3366933bcbdc5f914c15f2f
wpt-pr: 18998
Automatic update from web-platform-tests
[css-flexbox] Test for definiteness where Blink disagrees with FF
See bug for discussion.
This CL contains only tests, no behavior changes.
Change-Id: I7a6377a6325d0cbc4657b005a824736a73be32f5
Bug: 1003506
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799884
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696503}
--
wpt-commits: 3164d2dc90a6dcabc0041179b978d8adcca74f4b
wpt-pr: 19036
Automatic update from web-platform-tests
Update wpt scroll-to-visible-areas tests
The original tests were based on an inaccurate understanding of
"visibility" for a snap area, where a snap area was considered to be
visible if it is in the viewport at the scroll location before the
snap. The definition of visibility per the specification is that a snap
area is visible if it would be in the viewport at its snap point.
See:
https://github.com/w3c/csswg-drafts/issues/2526#issuecomment-380371186
Also added tests for the consideration of scroll-margin when
calculating visibility as well.
Bug: 954851
Change-Id: Ic2ffef8d02fc5ea2439054b6ea5185bb66622d1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795308
Commit-Queue: Kaan Alsan <alsan@google.com>
Reviewed-by: Yi Gu <yigu@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696435}
--
wpt-commits: 224ecb27547a9b49b28b7ae06abc8bc09f4b91fc
wpt-pr: 19007
Automatic update from web-platform-tests
MathML fraction: Add a test for the default padding. (#19042)
--
wpt-commits: 97f5b89cb7a67720faf506c3014a17bb39502d25
wpt-pr: 19042
Automatic update from web-platform-tests
MathML fraction: Add a test to verify painting of fraction bar when m… (#19012)
* MathML fraction: Add a test to verify painting of fraction bar when margin/border/padding are involved.
* Remove reftest-wait, fix unfinished comment
--
wpt-commits: d1b80eeae9090ba05590694c84371e01a37538e9
wpt-pr: 19012
Automatic update from web-platform-tests
Revert "[LayoutNG] Fix incorrect rounding in ShapingLineBreaker"
This reverts commit a4d21f7f7faa39ce99f96b81996b6ece702f501e.
Reason for revert: This is likely breaking
- external/wpt/css/css-multicol/multicol-width-ch-001.xht
- css2.1/t1602-c546-txt-align-00-b.html
- external/wpt/css/css-text/white-space/trailing-space-align-start.tentative.html
Original change's description:
> [LayoutNG] Fix incorrect rounding in ShapingLineBreaker
>
> This patch fixes the rounding the end position to the same
> direction as the rounding the start position. Before this
> change, the end position was rounded to the line-end
> direction. This may have resulted in slightly larger
> available space than the given one.
>
> Although the error is slight, such an error can cause a large
> visual differences because of an optimization. |NGLineBreaker|
> determines the overflow by comparing the result width to the
> available width, and if overflow occurs, it assumes that it
> cannot break the result further when it tries to rewind.
>
> Bug: 1002442
> Change-Id: Iebee80117c9930eade029c45c561236b8916981a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797954
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Commit-Queue: Koji Ishii <kojii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#696262}
TBR=eae@chromium.org,kojii@chromium.org,drott@chromium.org
Change-Id: Ie9255f9bfc01427550d58d92135b4ce25db27583
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1002442
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801769
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696316}
--
wpt-commits: b4a87fc3ffc70aa6fcece741b71540333122ab7e
wpt-pr: 19041
Automatic update from web-platform-tests
Fix test case which relied on outdated Name/QName production
This test failed to get updated as the same time as #12202.
--
wpt-commits: 5a5d077527781678f6b32b71dd20241f363af9e2
wpt-pr: 19031
Automatic update from web-platform-tests
autofocus: Fix a crash with an autofocus element in a document without browsing context.
ShouldAutofocus() should check existence of the browsing context.
Otherwise, doc.TopFrameOrigin() returns null.
Before crrev.com/695830, ShouldAutofocus() was called only for
rendered elements. That is to say, the document always had
browsing context.
Bug: 1003228
Change-Id: I2a941c34e9707d44869a6d7585dc7fb9f06e3bf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800902
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696291}
--
wpt-commits: 46ebc162a20b9dec5a7007eeed94c1581dbeb8f9
wpt-pr: 19038
Automatic update from web-platform-tests
Element Reflection for FrozenArray
Followup CL to: https://crrev.com/c/1687013
Spec: https://whatpr.org/html/3917/common-dom-interfaces.html#reflecting-content-attributes-in-idl-attributes:element
This change:
- updates v8 bindings and IDL to reflect FrozenArray<Element>
- Implements (most) of the HTML spec for:
aria-controls
aria-describedby
aria-flowto
aria-labelledby
aria-owns
This change is part of the experimental AOM project, and allows attributes that
reflect ARIA relationships to return a array of element references
corresponding to the ID stored in the content attribute, rather than the
string of IDs. These attributes are exposed on the IDL interface AriaAttributes.
See https://rawgit.com/w3c/aria/master/#AriaAttributes for more information.
Note this change does not affect the underlying Accessibility Tree. This will be
done in a followup CL.
BUG=981423
Change-Id: Iabb43480fab116b0394154b47afd7938dc314850
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781917
Commit-Queue: Meredith Lane <meredithl@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696286}
--
wpt-commits: 9c83c5cad05104a9c14552550a0c5e53b28b00b3
wpt-pr: 18797
Automatic update from web-platform-tests
[LayoutNG] Fix incorrect rounding in ShapingLineBreaker
This patch fixes the rounding the end position to the same
direction as the rounding the start position. Before this
change, the end position was rounded to the line-end
direction. This may have resulted in slightly larger
available space than the given one.
Although the error is slight, such an error can cause a large
visual differences because of an optimization. |NGLineBreaker|
determines the overflow by comparing the result width to the
available width, and if overflow occurs, it assumes that it
cannot break the result further when it tries to rewind.
Bug: 1002442
Change-Id: Iebee80117c9930eade029c45c561236b8916981a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797954
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696262}
--
wpt-commits: 8893b1bcfc2ca0675f4e81cd8b2a694ab14418cf
wpt-pr: 19002
Automatic update from web-platform-tests
[LayoutNG] Auto block-size shouldn't prevent child margin propagation.
The block-end margin strut of a child can collapse with the block-end
margin strut of the parent if the computed block-size of the child is
auto. This includes unresolvable percentages (e.g. if the child has a
percentage block-size, but its containing block has auto block-size).
Update BlockLengthUnresolvable() to consider 'auto' as unresolvable.
Also include 'min-content', 'max-content', 'fit-content' and 'none'
(for max-block-size), since that seems correct, and also allows for
simplifying code at call-sites.
Bug: 1001663
Change-Id: I28decd41ca8f8340581fc68e0a4fe709d7389af8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796372
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696253}
--
wpt-commits: 908a7ed5a5d7f82eedeee4fef0b3505faf01308e
wpt-pr: 18993
Automatic update from web-platform-tests
Update webxr-test to support FakeXRFieldOfViewInit
In order to enable tests of the render depth, without requiring the test
implementations to perform this decomposition, the webxr-test-api was
updated to allow a fieldOfView parameter to be provided, which would
override any passed in projectionMatrix
Bug: 1003135
Change-Id: I54fce9832b72a36cf99130f626afc0c1c227e943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799318
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696210}
--
wpt-commits: 0bbb480b98b2b05772ee75e629eac4eab4960922
wpt-pr: 19014
Automatic update from web-platform-tests
[LayoutNG] Fix abspos replaced size with margins
NG was computing inline_size of replaced elements
with no intrinsic size (only aspect ratio) incorrectly.
Element's margin was not considered.
The fixes are:
- update code to use margin when computing inline_size
- update wpt exaustive replaced size test to include margins
- remove many stale expectations for position-absolute-replaced-minmax.html
With the updated test, Legacy still fails single test. I might
have to update expectations.
Bug: 1002748
Change-Id: I98b8595ce0e4dc0d19d1d8020e33fe17e125d41d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799422
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696101}
--
wpt-commits: dbf3183cf1e15b216c94aac238268efd84df57ca
wpt-pr: 19011
Automatic update from web-platform-tests
Capitalize a test error message for consistency (#19022)
Other messages are capitalized, including the one in `cleanup_done`
starting with "Test named".
--
wpt-commits: fac9e368d36b06c76ed82c198d5546da2e805b66
wpt-pr: 19022
Automatic update from web-platform-tests
Plumbing XRVisibilityState up from WMR
Bug: 987030
Change-Id: I4cf2ab2ed6455963b1f43f8717941e7a0368416a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790422
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696066}
--
wpt-commits: a848d185aa258513948c3fd0b3f7042e81e2c6ad
wpt-pr: 19010
